Skip to contentSkip to conversation

staging: rtl8723bs: Fix coding style issue in block comment

PATCH Superseded Kang Minchul 4 participants 5 messages Sep 17, 2022 – Sep 19, 2022 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 staging: rtl8723bs: Fix coding style issue in block comment

This patch removes the following warning generated by checkpatch.pl

WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)

WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +11 -11
index d8d394b67eeb..ad6fb6c3d1f0 100644
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
 }
 
 /*
-signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
-{
-	return rtw_free_recvframe(precvframe, queue);
-}
-*/
+ * signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
+ * {
+ * 	return rtw_free_recvframe(precvframe, queue);
+ * }
+ */
 
 
 
 
 /*
-caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
-pframequeue: defrag_queue : will be accessed in recv_thread  (passive)
-
-using spinlock to protect
-
-*/
+ * caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
+ * pframequeue: defrag_queue : will be accessed in recv_thread  (passive)
+ *
+ * using spinlock to protect
+ *
+ */
 
 void rtw_free_recvframe_queue(struct __queue *pframequeue,  struct __queue *pfree_recv_queue)
 {
Signature · 1 line
2.34.1
Reviewed-by on v1 1/2
#1 lore raw

Hi,

Quoted 7 lines · Kang Minchul

This patch removes the following warning generated by checkpatch.pl

WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)

Quoted 6 lines

WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)

Thanks, patch looks good to me:

Regards,

Hans

Quoted 42 lines
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +11 -11
index d8d394b67eeb..ad6fb6c3d1f0 100644
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
 }
 
 /*
-signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
-{
-	return rtw_free_recvframe(precvframe, queue);
-}
-*/
+ * signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
+ * {
+ * 	return rtw_free_recvframe(precvframe, queue);
+ * }
+ */
 
 
 
 
 /*
-caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
-pframequeue: defrag_queue : will be accessed in recv_thread  (passive)
-
-using spinlock to protect
-
-*/
+ * caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
+ * pframequeue: defrag_queue : will be accessed in recv_thread  (passive)
+ *
+ * using spinlock to protect
+ *
+ */
 
 void rtw_free_recvframe_queue(struct __queue *pframequeue,  struct __queue *pfree_recv_queue)
 {
#2 lore raw
In reply to Kang Minchul
Quoted 25 lines · Kang Minchul

This patch removes the following warning generated by checkpatch.pl

WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)

WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -0
index d8d394b67eeb..ad6fb6c3d1f0 100644
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
 }
 
 /*

drivers/staging/rtl8723bs/core/rtw_recv.c signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q · line 210

Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +5 -5
-signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
-{
-	return rtw_free_recvframe(precvframe, queue);
-}
-*/
+ * signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
+ * {
+ * 	return rtw_free_recvframe(precvframe, queue);
+ * }
+ */

Just delete this dead code.

regards,
dan carpenter

#3 lore raw
In reply to Kang Minchul
Quoted 25 lines · Kang Minchul

This patch removes the following warning generated by checkpatch.pl

WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)

WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -0
index d8d394b67eeb..ad6fb6c3d1f0 100644
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
 }
 
 /*

drivers/staging/rtl8723bs/core/rtw_recv.c signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q · line 210

Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +5 -5
-signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
-{
-	return rtw_free_recvframe(precvframe, queue);
-}
-*/
+ * signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
+ * {
+ * 	return rtw_free_recvframe(precvframe, queue);
+ * }
+ */

I agree with Dan, just remove these unused functions please.

thanks,

greg k-h

#4 lore raw

Thank you for your feedback!
I just amended and re-submitted the patch.

Thank you.
Kang

2022년 9월 19일 (월) 오후 6:09, Greg Kroah-Hartman <[email protected]>님이 작성:

Quoted 43 lines · Kang Minchul
Quoted 25 lines

This patch removes the following warning generated by checkpatch.pl

WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)

WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -0
index d8d394b67eeb..ad6fb6c3d1f0 100644
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
 }
 
 /*

drivers/staging/rtl8723bs/core/rtw_recv.c signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q · line 210

Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +5 -5
-signed int   rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
-{
-     return rtw_free_recvframe(precvframe, queue);
-}
-*/
+ * signed int        rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
+ * {
+ *   return rtw_free_recvframe(precvframe, queue);
+ * }
+ */

I agree with Dan, just remove these unused functions please.

thanks,

greg k-h