staging: rtl8723bs: Fix coding style issue in block comment
PATCH 1/2 staging: rtl8723bs: Fix coding style issue in block comment
This patch removes the following warning generated by checkpatch.pl
WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
--- drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +11 -11
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q }/* -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) -{ -return rtw_free_recvframe(precvframe, queue); -} -*/ +* signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) +* { +* return rtw_free_recvframe(precvframe, queue); +* } +*/ /* -caller : defrag ; recvframe_chk_defrag in recv_thread (passive) -pframequeue: defrag_queue : will be accessed in recv_thread (passive) - -using spinlock to protect - -*/ +* caller : defrag ; recvframe_chk_defrag in recv_thread (passive) +* pframequeue: defrag_queue : will be accessed in recv_thread (passive) +* +* using spinlock to protect +* +*/ void rtw_free_recvframe_queue (struct __queue *pframequeue,struct __queue *pfree_recv_queue) {
Signature · 1 line
2.34.1
Hi,
Quoted 7 lines · Kang Minchul
This patch removes the following warning generated by checkpatch.pl
WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed intrtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
Quoted 6 lines
WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ;recvframe_chk_defraginrecv_thread(passive)Signed-off-by Kang Minchul <[email protected]>
Thanks, patch looks good to me:
Regards,
Hans
Quoted 42 lines
--- drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)drivers/staging/rtl8723bs/core/rtw_recv.c +11
-11@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q }/* -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) -{ -return rtw_free_recvframe(precvframe, queue); -} -*/ +* signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) +* { +* return rtw_free_recvframe(precvframe, queue); +* } +*/ /* -caller : defrag ; recvframe_chk_defrag in recv_thread (passive) -pframequeue: defrag_queue : will be accessed in recv_thread (passive) - -using spinlock to protect - -*/ +* caller : defrag ; recvframe_chk_defrag in recv_thread (passive) +* pframequeue: defrag_queue : will be accessed in recv_thread (passive) +* +* using spinlock to protect +* +*/ void rtw_free_recvframe_queue (struct __queue *pframequeue,struct __queue *pfree_recv_queue) {
Quoted 25 lines · Kang Minchul
This patch removes the following warning generated by checkpatch.pl
WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed intrtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ;recvframe_chk_defraginrecv_thread(passive)Signed-off-by Kang Minchul <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)drivers/staging/rtl8723bs/core/rtw_recv.c +0
-0@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q }/*
drivers/staging/rtl8723bs/core/rtw_recv.c signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q · line 210
Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +5
-5-signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) -{ -return rtw_free_recvframe(precvframe, queue); -} -*/ +* signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) +* { +* return rtw_free_recvframe(precvframe, queue); +* } +*/
Just delete this dead code.
regards,
dan carpenter
Greg Kroah-Hartman
maintainerQuoted 25 lines · Kang Minchul
This patch removes the following warning generated by checkpatch.pl
WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed intrtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ;recvframe_chk_defraginrecv_thread(passive)Signed-off-by Kang Minchul <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)drivers/staging/rtl8723bs/core/rtw_recv.c +0
-0@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q }/*
drivers/staging/rtl8723bs/core/rtw_recv.c signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q · line 210
Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +5
-5-signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) -{ -return rtw_free_recvframe(precvframe, queue); -} -*/ +* signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) +* { +* return rtw_free_recvframe(precvframe, queue); +* } +*/
I agree with Dan, just remove these unused functions please.
thanks,
greg k-h
Thank you for your feedback!
I just amended and re-submitted the patch.
Thank you.
Kang
2022년 9월 19일 (월) 오후 6:09, Greg Kroah-Hartman <[email protected]>님이 작성:
Quoted 43 lines · Kang Minchul
Quoted 25 lines
This patch removes the following warning generated by checkpatch.pl
WARNING: Block comments use * on subsequent lines #206: FILE: rtw_recv.c:206:
+/*
+signed intrtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)WARNING: Block comments use * on subsequent lines #216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ;recvframe_chk_defraginrecv_thread(passive)Signed-off-by Kang Minchul <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)drivers/staging/rtl8723bs/core/rtw_recv.c +0
-0@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q }/* drivers/staging/rtl8723bs/core/rtw_recv.c signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q · line 210
Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +5
-5-signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) -{ -return rtw_free_recvframe(precvframe, queue); -} -*/ +* signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) +* { +* return rtw_free_recvframe(precvframe, queue); +* } +*/ I agree with Dan, just remove these unused functions please.
thanks,
greg k-h