arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
Subsystems (2)
PATCH 1/1 arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
When the imx8mm.dtsi file was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.
arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +4 -0
@@ -106,6 +106,10 @@ u-boot,off-on-delay-us = <20000>; }; +&spba1 { + u-boot,dm-spl; +}; + &uart2 { u-boot,dm-spl; };
Signature · 1 line
2.34.1
Hi Adam
Quoted 27 lines · Adam Ford
When the
imx8mm.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Adam Ford <[email protected]>arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +4
-1@@ -106,6 +106,10 @@ u-boot,off-on-delay-us = <20000>; }; +&spba1 { + u-boot,dm-spl; +}; + &uart2 { u-boot,dm-spl; }; --
Quoted 2 lines
2.34.1
Are you going to include it in imx8mn-u-boot.dtsi or do we need to patch every single board?
Michael
Quoted 23 lines · Michael Nazzareno Trimarchi
Hi Adam
Quoted 19 lines · Adam Ford
When the
imx8mm.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Adam Ford <[email protected]>arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +0
-0@@ -106,6 +106,10 @@ u-boot,off-on-delay-us = <20000>; };
Quoted 13 lines
Quoted 10 lines
arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +4
-1+&spba1 { + u-boot,dm-spl; +}; + &uart2 { u-boot,dm-spl; }; --2.34.1
Are you going to include it in
imx8mn-u-boot.dtsior do we need to patch every single board?
This is a temporary fix until I generate the common imx8mn-u-boot.dtsi which will include this.
Quoted 2 lines
Michael
Quoted 40 lines · Adam Ford
Quoted 23 lines · Michael Nazzareno Trimarchi
Hi Adam
Quoted 19 lines · Adam Ford
When the
imx8mm.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Adam Ford <[email protected]>arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +0
-0@@ -106,6 +106,10 @@ u-boot,off-on-delay-us = <20000>; };Quoted 13 lines
Quoted 10 lines
arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +4
-1+&spba1 { + u-boot,dm-spl; +}; + &uart2 { u-boot,dm-spl; }; --2.34.1
Are you going to include it in
imx8mn-u-boot.dtsior do we need to patch every single board?
Quoted 2 lines
This is a temporary fix until I generate the common
imx8mn-u-boot.dtsiwhich will include this.
I was hoping to finish this this afternoon, but a family emergency came up. I'm going to try to finish it later tonight or tomorrow. It's taking a bit longer because there are some boards with DDR4, LPDDR4 and DDR3. I don't have most of them, but I plan to at least generate a flash.bin file before posting it.
adam
Quoted 3 lines
Quoted 3 lines
Michael
PATCH 1/1 arm: dts: imx8mn-beacon-kit-u-boot: Fix broken booting
In reply to Adam FordQuoted 13 lines
When the
imx8mm.dtsifile was pulled in from Linux, the UARTs were moved into an spba sub-node which wasn't being included in the SPL device tree. This meant the references to the UART weren't being handled properly and when booting the system would constantly reboot. Fix this by adding the spba node to the spl device tree to restore normal booting.Fixes 4e5114daf9eb ("imx8mn: synchronise device tree with linux")Signed-off-by Adam Ford <[email protected]>arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +0
-0
arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi line 115
Quoted 10 lines
arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi +4
-0@@ -106,6 +106,10 @@ u-boot,off-on-delay-us = <20000>; }; +&spba1 { + u-boot,dm-spl; +}; + &uart2 { u-boot,dm-spl; };
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================