Skip to contentSkip to conversation

drm/panel: Add NewVision NV3051D Panels

PATCH Superseded Chris Morgan 4 participants 14 messages Sep 20, 2022 – Sep 24, 2022

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover drm/panel: Add NewVision NV3051D Panels

From: Chris Morgan <[email protected]>

Add the NewVision NV3051D panel as found on the Anbernic RG353P and RG353V. The underlying LCD panel itself is unknown (the NV3051D is the controller), so the device name is used for the panel with a fallback to the driver IC.

Changes from V1:
- Changed compatible string to the driver IC.
- Updated documentation to use new compatible string with board name.
- Refactored somewhat to make it easier to support other LCD panels with this kernel module.
- Added support for 60hz mode. Adjusted pixel clock to ensure proper 60hz and 120hz (previously was running at 124hz).
- Added vendor prefix for NewVision. Anbernic vendor prefix added in
https://lore.kernel.org/linux-devicetree/[email protected]

Chris Morgan (3):
dt-bindings: vendor-prefixes: add NewVision vendor prefix
dt-bindings: display: panel: Add NewVision NV3051D bindings drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

 .../display/panel/newvision,nv3051d.yaml      |  55 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 drivers/gpu/drm/panel/Kconfig                 |   9 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-newvision-nv3051d.c   | 513 ++++++++++++++++++
 5 files changed, 580 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3051d.c
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/3 dt-bindings: vendor-prefixes: add NewVision vendor prefix

From: Chris Morgan <[email protected]>

NewVision (also sometimes written as New Vision) is a company based in Shenzen that manufactures ICs for controlling LCD panels.

https://www.newvisiondisplay.com/

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 2f0151e9f6be..d9c38e214863 100644
@@ -873,6 +873,8 @@ patternProperties:
     description: Shenzhen Netxeon Technology CO., LTD
   "^neweast,.*":
     description: Guangdong Neweast Optoelectronics CO., LTD
+  "^newvision,.*":
+    description: New Vision Display (Shenzhen) Co., Ltd.
   "^nexbox,.*":
     description: Nexbox
   "^nextthing,.*":
Signature · 1 line
2.25.1
#3 lore raw

PATCH v2 2/3 dt-bindings: display: panel: Add NewVision NV3051D bindings

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p".

---
 .../display/panel/newvision,nv3051d.yaml      | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +55 -0
new file mode 100644
index 000000000000..d90bca4171c2
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NewVision NV3051D based LCD panel
+
+description: |
+  The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
+  this driver only supports the 640x480 panels found in the Anbernic RG353
+  based devices.
+
+maintainers:
+  - Chris Morgan <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel
+          - anbernic,rg353v-panel
+      - const: newvision,nv3051d
+  reg: true
+  backlight: true
+  port: true
+  reset-gpios: true
+  vdd-supply:
+    description: regulator that supplies the vdd voltage
+
+required:
+  - compatible
+  - reg
+  - backlight
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "anbernic,rg353p-panel";
+            reg = <0>;
+            backlight = <&backlight>;
+            vdd-supply = <&vcc3v3_lcd>;
+        };
+    };
+
+...
Signature · 1 line
2.25.1
#4 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 33 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p".

---
 .../display/panel/newvision,nv3051d.yaml      | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +14 -0
new file mode 100644
index 000000000000..d90bca4171c2
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NewVision NV3051D based LCD panel
+
+description: |
+  The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
+  this driver only supports the 640x480 panels found in the Anbernic RG353
+  based devices.
+
+maintainers:

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 24

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +10 -0
+  - Chris Morgan <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel

Are these vendor prefixs documented?

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 26

Quoted 2 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +2 -0
+          - anbernic,rg353v-panel
+      - const: newvision,nv3051d

Blank line.

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 32

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +6 -0
+  reg: true
+  backlight: true
+  port: true
+  reset-gpios: true
+  vdd-supply:
+    description: regulator that supplies the vdd voltage

Skip description and make it just "true". It's kind of obvious.

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 38

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +6 -0
+
+required:
+  - compatible
+  - reg
+  - backlight
+  - vdd-supply

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 38 lines · Krzysztof Kozlowski
Quoted 37 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p".

---
 .../display/panel/newvision,nv3051d.yaml      | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +18 -0
new file mode 100644
index 000000000000..d90bca4171c2
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fpanel%2Fnewvision%2Cnv3051d.yaml%23&amp;data=05%7C01%7C%7C844872fdf91b413aa65a08da9b9db9e7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637993398994635658%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=eTM2IFjR0TKPlQNYfoq3Poao8QYLSHRVaqiXtufJ7VA%3D&amp;reserved=0
+$schema: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7C%7C844872fdf91b413aa65a08da9b9db9e7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637993398994635658%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=sjb7x2Z2wKu1C8mMBW1epwuXipe8V26zxpHcCAuKLZY%3D&amp;reserved=0
+
+title: NewVision NV3051D based LCD panel
+
+description: |
+  The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
+  this driver only supports the 640x480 panels found in the Anbernic RG353
+  based devices.
+
+maintainers:
+  - Chris Morgan <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
Quoted 8 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 24

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +6 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel

Are these vendor prefixs documented?

Yes, they are in another patch series referenced in the cover letter. They were added for the Anbernic devicetrees and should (I believe) land in 6.1.

Quoted 6 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 26

Quoted 3 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +2 -0
+          - anbernic,rg353v-panel
+      - const: newvision,nv3051d

Blank line.

Ack.

Quoted 9 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 32

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +6 -0
+  reg: true
+  backlight: true
+  port: true
+  reset-gpios: true
+  vdd-supply:
+    description: regulator that supplies the vdd voltage

Skip description and make it just "true". It's kind of obvious.

Ack.

Quoted 9 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 38

Quoted 6 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +6 -0
+
+required:
+  - compatible
+  - reg
+  - backlight
+  - vdd-supply

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 10 lines · Chris Morgan
Quoted 6 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 24

Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +4 -0
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel

Are these vendor prefixs documented?

Yes, they are in another patch series referenced in the cover letter. They were added for the Anbernic devicetrees and should (I believe) land in 6.1.

OK... you still need to test your bindings. Your patch was clearly not tested before sending. :(

Best regards,
Krzysztof

#7 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Chris Morgan
Quoted 5 lines
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +4 -0
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Are these vendor prefixs documented?

Yes, they are in another patch series referenced in the cover letter. They were added for the Anbernic devicetrees and should (I believe) land in 6.1.

OK... you still need to test your bindings. Your patch was clearly not tested before sending. :(

I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and make dtbs_check (with DT_SCHEMA_FILES specified again). That's the proper testing flow correct? In this case it's the pre-requisite that's causing the issue as I see on a pristine master tree I'm warned about the missing vendor prefix for anbernic. Should I wait for that to go upstream before I submit this again?

I'll make the other change about the space and the description of the vdd-supply when I resubmit. Are we good with the panel compatibles? I'm still not entirely sure the best thing to name them as I have no part number whatsoever except the driver IC.

Thank you.

Quoted 4 lines

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 13 lines · Chris Morgan
Quoted 12 lines · Krzysztof Kozlowski
Quoted 10 lines · Chris Morgan
Quoted 6 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 24

Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +4 -0
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel

Are these vendor prefixs documented?

Yes, they are in another patch series referenced in the cover letter. They were added for the Anbernic devicetrees and should (I believe) land in 6.1.

Quoted 5 lines
Quoted 2 lines

OK... you still need to test your bindings. Your patch was clearly not tested before sending. :(

I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and make dtbs_check (with DT_SCHEMA_FILES specified again).

I have doubts. So if you say you did it, then you probably did not look at the results... or whatever other reason the test was not effective, because your binding cannot pass the dt_binding_check.

Quoted 5 lines

That's the proper
testing flow correct? In this case it's the pre-requisite that's causing the issue as I see on a pristine master tree I'm warned about the missing vendor prefix for anbernic. Should I wait for that to go upstream before I submit this again?

Not really. The testing fails on wrong compatible in example.

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 24 lines · Krzysztof Kozlowski
Quoted 13 lines · Chris Morgan
Quoted 12 lines · Krzysztof Kozlowski
Quoted 10 lines · Chris Morgan
Quoted 6 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 24

Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +4 -0
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel

Are these vendor prefixs documented?

Yes, they are in another patch series referenced in the cover letter. They were added for the Anbernic devicetrees and should (I believe) land in 6.1.

Quoted 5 lines
Quoted 2 lines

OK... you still need to test your bindings. Your patch was clearly not tested before sending. :(

I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and make dtbs_check (with DT_SCHEMA_FILES specified again).

I have doubts. So if you say you did it, then you probably did not look at the results... or whatever other reason the test was not effective, because your binding cannot pass the dt_binding_check.

Quoted 7 lines
Quoted 5 lines

That's the proper
testing flow correct? In this case it's the pre-requisite that's causing the issue as I see on a pristine master tree I'm warned about the missing vendor prefix for anbernic. Should I wait for that to go upstream before I submit this again?

Not really. The testing fails on wrong compatible in example.

My mistake, I see what I did wrong and apologize for the trouble. I misinterpreted the error I did get (I expected an issue with a missing vendor string, but as you correctly point out the received error is not for that). I'll correct and resend. Would you be so kind as to confirm if you're okay with the "anbernic,rg353-panel", "newvision,nv3051d" strings?

Thank you once again and I apologize for my mistake.

Quoted 4 lines

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

In reply to Chris Morgan
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p".

Quoted 6 lines
---
 .../display/panel/newvision,nv3051d.yaml      | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.example.dtb: panel@0: compatible: ['anbernic,rg353p-panel'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

maintainer
#11 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

In reply to Chris Morgan
Quoted 34 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p".

---
 .../display/panel/newvision,nv3051d.yaml      | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +15 -0
new file mode 100644
index 000000000000..d90bca4171c2
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NewVision NV3051D based LCD panel
+
+description: |
+  The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
+  this driver only supports the 640x480 panels found in the Anbernic RG353
+  based devices.
+
+maintainers:
+  - Chris Morgan <[email protected]>

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 25

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +10 -0
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel
+          - anbernic,rg353v-panel

Is 'panel' redundant? IOW, could 'rg353v' identify something else other than the panel?

Rob

#12 lore raw

Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Quoted 40 lines · Rob Herring
Quoted 39 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p".

---
 .../display/panel/newvision,nv3051d.yaml      | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +20 -0
new file mode 100644
index 000000000000..d90bca4171c2
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fpanel%2Fnewvision%2Cnv3051d.yaml%23&amp;data=05%7C01%7C%7C4f204345128d4cb827ca08da9e4f4d06%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637996360672620588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=9%2B66S0t1p9EqWBdmaLBj8pKte2fjzsmL%2FSbmmD8eNi0%3D&amp;reserved=0
+$schema: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7C%7C4f204345128d4cb827ca08da9e4f4d06%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637996360672620588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=r%2BzTHlte226t9fXktNC9k4NO%2FE2RomRIxuWBuRshIw0%3D&amp;reserved=0
+
+title: NewVision NV3051D based LCD panel
+
+description: |
+  The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
+  this driver only supports the 640x480 panels found in the Anbernic RG353
+  based devices.
+
+maintainers:
+  - Chris Morgan <[email protected]>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
Quoted 8 lines

Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml line 25

Quoted 5 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file +5 -0
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel
+          - anbernic,rg353v-panel

Is 'panel' redundant? IOW, could 'rg353v' identify something else other than the panel?

It is not redundant, the device itself is identified as "anbernic,rg353v". I don't have a part number for the LCD panel itself, only the controller IC.

Thank you.

Quoted 2 lines

Rob

#13 lore raw

PATCH v2 3/3 drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add NewVision NV3051D MIPI-DSI LCD panel

Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying LCD part number for the RG353x devices is unknown, so the device name and a fallback for the driver IC is used instead.

---
 drivers/gpu/drm/panel/Kconfig                 |   9 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-newvision-nv3051d.c   | 513 ++++++++++++++++++
 3 files changed, 523 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3051d.c
drivers/gpu/drm/panel/Kconfig +9 -0
index a9043eacce97..7258d28dda2f 100644
@@ -296,6 +296,15 @@ config DRM_PANEL_NEC_NL8048HL11
 	  panel (found on the Zoom2/3/3630 SDP boards). To compile this driver
 	  as a module, choose M here.
 
+config DRM_PANEL_NEWVISION_NV3051D
+	tristate "NewVision NV3051D DSI panel"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  This driver supports the NV3051D based panel found on the Anbernic
+	  RG353P and RG353V.
+
 config DRM_PANEL_NEWVISION_NV3052C
 	tristate "NewVision NV3052C RGB/SPI panel"
 	depends on OF && SPI
drivers/gpu/drm/panel/Makefile +1 -0
index 34e717382dbb..cb03b3a82738 100644
@@ -27,6 +27,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o
 obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o
 obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o
 obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o
+obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3051D) += panel-newvision-nv3051d.o
 obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o
 obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o
 obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o
drivers/gpu/drm/panel/panel-newvision-nv3051d.c new file +513 -0

513 lines not on this page · raw message

Signature · 1 line
2.25.1