Skip to contentSkip to conversation

lib/vdso: use "grep -E" instead of "egrep"

PATCH In review Greg Kroah-Hartman 3 participants 6 messages Sep 20, 2022 – Nov 21, 2022 Generic VDSO library

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/vdso: use "grep -E" instead of "egrep"

The latest version of grep claims the egrep is now obsolete so the build now contains warnings that look like:
egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the vdso Makefile to use "grep -E" instead.

Cc Andy Lutomirski <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vincenzo Frascino <[email protected]>
---
 lib/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/vdso/Makefile +1 -1
index c415a685d61b..e814061d6aa0 100644
@@ -17,6 +17,6 @@ $(error ARCH_REL_TYPE_ABS is not set)
 endif
 
 quiet_cmd_vdso_check = VDSOCHK $@
-      cmd_vdso_check = if $(OBJDUMP) -R $@ | egrep -h "$(ARCH_REL_TYPE_ABS)"; \
+      cmd_vdso_check = if $(OBJDUMP) -R $@ | grep -E -h "$(ARCH_REL_TYPE_ABS)"; \
 		       then (echo >&2 "$@: dynamic relocations are not supported"; \
 			     rm -f $@; /bin/false); fi
Signature · 1 line
2.37.3
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Greg Kroah-Hartman

The latest version of grep claims the egrep is now obsolete so the build now contains warnings that look like:
egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the vdso Makefile to use "grep -E" instead.

Cc Andy Lutomirski <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vincenzo Frascino <[email protected]>
Quoted 17 lines
---
 lib/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/vdso/Makefile +1 -1
index c415a685d61b..e814061d6aa0 100644
@@ -17,6 +17,6 @@ $(error ARCH_REL_TYPE_ABS is not set)
 endif
 
 quiet_cmd_vdso_check = VDSOCHK $@
-      cmd_vdso_check = if $(OBJDUMP) -R $@ | egrep -h "$(ARCH_REL_TYPE_ABS)"; \
+      cmd_vdso_check = if $(OBJDUMP) -R $@ | grep -E -h "$(ARCH_REL_TYPE_ABS)"; \
 		       then (echo >&2 "$@: dynamic relocations are not supported"; \
 			     rm -f $@; /bin/false); fi
Signature · 2 lines
Regards,
Vincenzo
#2 lore raw

Hi,

This patch can not be found in the torvalds/linux.git or next/linux-next.git tree, please take a look, thank you.

Thanks,
Tiezhu

author
#3 lore raw
Quoted 4 lines · Tiezhu Yang

Hi,

This patch can not be found in the torvalds/linux.git or next/linux-next.git tree, please take a look, thank you.

That is because no one has applied it to their trees :(

#4 lore raw

Cc Andrew Morton <[email protected]>

Quoted 8 lines · Greg KH
Quoted 4 lines · Tiezhu Yang

Hi,

This patch can not be found in the torvalds/linux.git or next/linux-next.git tree, please take a look, thank you.

That is because no one has applied it to their trees :(

Maybe Andrew can pick the following two patches sent by Greg.

[PATCH] lib/vdso: use "grep -E" instead of "egrep"
https://lore.kernel.org/lkml/[email protected]/

[PATCH] scripts: coccicheck: use "grep -E" instead of "egrep"
https://lore.kernel.org/lkml/[email protected]/

Thanks,
Tiezhu

#5 lore raw

Hi all,

Just FYI.

Quoted 9 lines · Tiezhu Yang

Cc Andrew Morton <[email protected]>

Quoted 6 lines · Greg KH
Quoted 4 lines · Tiezhu Yang

Hi,

This patch can not be found in the torvalds/linux.git or next/linux-next.git tree, please take a look, thank you.

Quoted 8 lines
Quoted 2 lines

That is because no one has applied it to their trees :(

Maybe Andrew can pick the following two patches sent by Greg.

[PATCH] lib/vdso: use "grep -E" instead of "egrep"
https://lore.kernel.org/lkml/[email protected]/

AFAIK, this patch is not in any tree now.

Quoted 4 lines

[PATCH] scripts: coccicheck: use "grep -E" instead of "egrep"
https://lore.kernel.org/lkml/[email protected]/

This patch is in the following tree, sorry for missing that.

https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git/commit/?h=for-6.1&id=2d63e6a3d971

Thanks,
Tiezhu