SDM670 RPMh Clocks
v2 cover SDM670 RPMh Clocks
Changes since v1:
- fix broken link
- accumulate ack tag
This patch series adds clocks controlled by RPMh for Snapdragon 670.
.../devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 + drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+)
PATCH v2 1/2 dt-bindings: clock: add rpmhcc bindings for sdm670
The Snapdragon 670 uses the RPMh mailbox for some clocks. Document its support.
--- Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml +1 -0
@@ -21,6 +21,7 @@ properties: - qcom,sc7280-rpmh-clk - qcom,sc8180x-rpmh-clk - qcom,sc8280xp-rpmh-clk + - qcom,sdm670-rpmh-clk - qcom,sdm845-rpmh-clk - qcom,sdx55-rpmh-clk - qcom,sdx65-rpmh-clk
Signature · 1 line
2.37.3
PATCH v2 2/2 clk: qcom: rpmhcc: add sdm670 clocks
In reply to Richard AcayanThe Snapdragon 670 uses the RPMh mailbox for most of the clocks used in SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail to resolve a clock.
--- drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
drivers/clk/qcom/clk-rpmh.c +21 -0
@@ -382,6 +382,26 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = { .num_clks = ARRAY_SIZE(sdm845_rpmh_clocks), }; +static struct clk_hw *sdm670_rpmh_clocks[] = { + [RPMH_CXO_CLK ] = &sdm845_bi_tcxo.hw, + [RPMH_CXO_CLK_A ] = &sdm845_bi_tcxo_ao.hw, + [RPMH_LN_BB_CLK2 ] = &sdm845_ln_bb_clk2.hw, + [RPMH_LN_BB_CLK2_A ] = &sdm845_ln_bb_clk2_ao.hw, + [RPMH_LN_BB_CLK3 ] = &sdm845_ln_bb_clk3.hw, + [RPMH_LN_BB_CLK3_A ] = &sdm845_ln_bb_clk3_ao.hw, + [RPMH_RF_CLK1 ] = &sdm845_rf_clk1.hw, + [RPMH_RF_CLK1_A ] = &sdm845_rf_clk1_ao.hw, + [RPMH_RF_CLK2 ] = &sdm845_rf_clk2.hw, + [RPMH_RF_CLK2_A ] = &sdm845_rf_clk2_ao.hw, + [RPMH_IPA_CLK ] = &sdm845_ipa.hw, + [RPMH_CE_CLK ] = &sdm845_ce.hw, +}; + +static const struct clk_rpmh_desc clk_rpmh_sdm670 = { + .clks = sdm670_rpmh_clocks, + .num_clks =ARRAY_SIZE (sdm670_rpmh_clocks), +}; +DEFINE_CLK_RPMH_VRM (sdx55, rf_clk1, rf_clk1_ao,"rfclkd1" ,1 );DEFINE_CLK_RPMH_VRM (sdx55, rf_clk2, rf_clk2_ao,"rfclkd2" ,1 );DEFINE_CLK_RPMH_BCM (sdx55, qpic_clk,"QP0" );
@@ -715,6 +735,7 @@ static const struct of_device_id clk_rpmh_match_table[] = { { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x}, { .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp}, { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, + { .compatible = "qcom,sdm670-rpmh-clk", .data = &clk_rpmh_sdm670}, { .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55}, { .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65}, { .compatible = "qcom,sm6350-rpmh-clk", .data = &clk_rpmh_sm6350},
Signature · 1 line
2.37.3
Re: [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks
Quoted 42 lines · Richard Acayan
The Snapdragon 670 uses the RPMh mailbox for most of the clocks used in SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail to resolve a clock.
Link https://android.googlesource.com/kernel/msm/+/443bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F7Signed-off-by Richard Acayan <[email protected]>--- drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)drivers/clk/qcom/clk-rpmh.c +20
-0@@ -382,6 +382,26 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = { .num_clks = ARRAY_SIZE(sdm845_rpmh_clocks), }; +static struct clk_hw *sdm670_rpmh_clocks[] = { + [RPMH_CXO_CLK ] = &sdm845_bi_tcxo.hw, + [RPMH_CXO_CLK_A ] = &sdm845_bi_tcxo_ao.hw, + [RPMH_LN_BB_CLK2 ] = &sdm845_ln_bb_clk2.hw, + [RPMH_LN_BB_CLK2_A ] = &sdm845_ln_bb_clk2_ao.hw, + [RPMH_LN_BB_CLK3 ] = &sdm845_ln_bb_clk3.hw, + [RPMH_LN_BB_CLK3_A ] = &sdm845_ln_bb_clk3_ao.hw, + [RPMH_RF_CLK1 ] = &sdm845_rf_clk1.hw, + [RPMH_RF_CLK1_A ] = &sdm845_rf_clk1_ao.hw, + [RPMH_RF_CLK2 ] = &sdm845_rf_clk2.hw, + [RPMH_RF_CLK2_A ] = &sdm845_rf_clk2_ao.hw, + [RPMH_IPA_CLK ] = &sdm845_ipa.hw, + [RPMH_CE_CLK ] = &sdm845_ce.hw, +}; + +static const struct clk_rpmh_desc clk_rpmh_sdm670 = { + .clks = sdm670_rpmh_clocks, + .num_clks =ARRAY_SIZE (sdm670_rpmh_clocks), +}; +DEFINE_CLK_RPMH_VRM (sdx55, rf_clk1, rf_clk1_ao,"rfclkd1" ,1 );DEFINE_CLK_RPMH_VRM (sdx55, rf_clk2, rf_clk2_ao,"rfclkd2" ,1 );DEFINE_CLK_RPMH_BCM (sdx55, qpic_clk,"QP0" );
drivers/clk/qcom/clk-rpmh.c static const struct of_device_id clk_rpmh_match_table[] = { · line 741
Quoted 7 lines
drivers/clk/qcom/clk-rpmh.c +1
-0@@ -715,6 +735,7 @@ static const struct of_device_id clk_rpmh_match_table[] = { { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x}, { .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp}, { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, + { .compatible = "qcom,sdm670-rpmh-clk", .data = &clk_rpmh_sdm670}, { .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55}, { .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65}, { .compatible = "qcom,sm6350-rpmh-clk", .data = &clk_rpmh_sm6350},
Quoted 11 lines · Richard Acayan
Changes since v1:
- fix broken link
- accumulate ack tagThis patch series adds clocks controlled by RPMh for Snapdragon 670.
.../devicetree/bindings/clock/qcom,rpmhcc.yaml| 1 +drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+)[...]
Applied, thanks!
[1/2] dt-bindings: clock: add rpmhcc bindings for sdm670
commit: c6648a402ced29ef826055583a96dcc85d9d3f55
[2/2] clk: qcom: rpmhcc: add sdm670 clocks
commit: 2ded040cedf830c698c04ee79d436bd23014811aBest regards,
Signature · 1 line
Bjorn Andersson <[email protected]>