Skip to contentSkip to conversation

scsi: ufs: Remove redundant dev_err call

PATCH Applied Shang XiaoJing 3 participants 3 messages Sep 23, 2022 – Oct 1, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: Remove redundant dev_err call

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

---
 drivers/ufs/host/ufs-qcom-ice.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ufs/host/ufs-qcom-ice.c +0 -1
index 745e48ec598f..62387ccd5b30 100644
@@ -118,7 +118,6 @@ int ufs_qcom_ice_init(struct ufs_qcom_host *host)
 	host->ice_mmio = devm_ioremap_resource(dev, res);
 	if (IS_ERR(host->ice_mmio)) {
 		err = PTR_ERR(host->ice_mmio);
-		dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
 		return err;
 	}
 
Signature · 1 line
2.17.1
#2 lore raw
In reply to Shang XiaoJing

Shang,

Quoted 2 lines

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

Applied to 6.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering