Skip to contentSkip to conversation

power: fan53555: Fix missing newline in error message

PATCH In review Michal Suchanek 3 participants 3 messages Sep 25, 2022 – Oct 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: fan53555: Fix missing newline in error message

Avoid concatenation with following message.

---

 drivers/power/pmic/fan53555.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/pmic/fan53555.c +1 -1
index 4d1e686d27..0d91628f57 100644
@@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg,
 			      u8 *buff, int len)
 {
 	if (dm_i2c_read(dev, reg, buff, len)) {
-		pr_err("%s: read error for register: %#x!", dev->name, reg);
+		pr_err("%s: read error for register: %#x!\n", dev->name, reg);
 		return -EIO;
 	}
 
Signature · 1 line
2.37.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Michal Suchanek

Avoid concatenation with following message.

Quoted 18 lines

---

  drivers/power/pmic/fan53555.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/pmic/fan53555.c +1 -1
index 4d1e686d27..0d91628f57 100644
@@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg,
  			      u8 *buff, int len)
  {
  	if (dm_i2c_read(dev, reg, buff, len)) {
-		pr_err("%s: read error for register: %#x!", dev->name, reg);
+		pr_err("%s: read error for register: %#x!\n", dev->name, reg);
  		return -EIO;
  	}
 
Reviewed-by on v1 1/1
#2 lore raw
In reply to Michal Suchanek
Quoted 3 lines · Michal Suchanek

Avoid concatenation with following message.

Best Regards,
Jaehoon Chung

Quoted 18 lines

---

 drivers/power/pmic/fan53555.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/pmic/fan53555.c +1 -1
index 4d1e686d27..0d91628f57 100644
@@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg,
 			      u8 *buff, int len)
 {
 	if (dm_i2c_read(dev, reg, buff, len)) {
-		pr_err("%s: read error for register: %#x!", dev->name, reg);
+		pr_err("%s: read error for register: %#x!\n", dev->name, reg);
 		return -EIO;
 	}