Skip to contentSkip to conversation

drm/display: Don't assume dual mode adaptors support i2c sub-addressing

PATCH RESEND Superseded Simon Rettberg 4 participants 8 messages Sep 26, 2022 – Sep 27, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/display: Don't assume dual mode adaptors support i2c sub-addressing

Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adaptors, the code failed to read the proper registers that would identify the device as a type 2 adaptor, and handled those as type 1, limiting the TMDS clock to 165MHz.
Fix this by always reading the ID buffer starting from offset 0, and discarding any bytes before the actual offset of interest.

---
(Resend because of no response, probably my fault since I ran get_maintainers on a shallow clone and missed a bunch of people)

We had problems with multiple different "4k ready" DP++ adaptors only resulting in 1080p resolution on Linux. While one of them turned out to actually just be a type1 adaptor, the others, according to the data retreived via i2cdump, were in fact proper type2 adaptors, advertising a TMDS clock of 300MHz. As it turned out, none of them supported sub-addressing when reading from the DP-HDMI adaptor ID buffer via i2c. The existing code suggested that this is known to happen with "broken" type1 adaptors, but evidently, type2 adaptors are also affected. We tried finding authoritative documentation on whether or not this is allowed behavior, but since all the official VESA docs are paywalled, the best we could come up with was the spec sheet for Texas Instruments' SNx5DP149 chip family.[1] It explicitly mentions that sub-adressing is supported for register writes, but *not* for reads (See NOTE in section 8.5.3). Unless TI blatantly and openly decided to violate the VESA spec, one could take that as a strong hint that sub-addressing is in fact not mandated by VESA.

[1] https://www.ti.com/lit/ds/symlink/sn75dp149.pdf

 .../gpu/drm/display/drm_dp_dual_mode_helper.c | 52 ++++++++++---------
 1 file changed, 28 insertions(+), 24 deletions(-)
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +28 -24
index 3ea53bb67..6147da983 100644
@@ -63,23 +63,42 @@
 ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter,
 			      u8 offset, void *buffer, size_t size)
 {
+	int ret;
+	u8 zero = 0;
+	char *tmpbuf;
+	/*
+	 * As sub-addressing is not supported by all adaptors,
+	 * always explicitly read from the start and discard
+	 * any bytes that come before the requested offset.
+	 * This way, no matter whether the adaptor supports it
+	 * or not, we'll end up reading the proper data.
+	 */
 	struct i2c_msg msgs[] = {
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = 0,
 			.len = 1,
-			.buf = &offset,
+			.buf = &zero,
 		},
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = I2C_M_RD,
-			.len = size,
-			.buf = buffer,
+			.len = size + offset,
+			.buf = NULL,
 		},
 	};
-	int ret;
 
+	tmpbuf = kmalloc(size + offset, GFP_KERNEL);
+	if (!tmpbuf)
+		return -ENOMEM;
+
+	msgs[1].buf = tmpbuf;
 	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
+	if (ret == ARRAY_SIZE(msgs))
+		memcpy(buffer, tmpbuf + offset, size);
+
+	kfree(tmpbuf);
+
 	if (ret < 0)
 		return ret;
 	if (ret != ARRAY_SIZE(msgs))
@@ -208,18 +227,6 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev,
 	if (ret)
 		return DRM_DP_DUAL_MODE_UNKNOWN;
 
-	/*
-	 * Sigh. Some (maybe all?) type 1 adaptors are broken and ack
-	 * the offset but ignore it, and instead they just always return
-	 * data from the start of the HDMI ID buffer. So for a broken
-	 * type 1 HDMI adaptor a single byte read will always give us
-	 * 0x44, and for a type 1 DVI adaptor it should give 0x00
-	 * (assuming it implements any registers). Fortunately neither
-	 * of those values will match the type 2 signature of the
-	 * DP_DUAL_MODE_ADAPTOR_ID register so we can proceed with
-	 * the type 2 adaptor detection safely even in the presence
-	 * of broken type 1 adaptors.
-	 */
 	ret = drm_dp_dual_mode_read(adapter, DP_DUAL_MODE_ADAPTOR_ID,
 				    &adaptor_id, sizeof(adaptor_id));
 	drm_dbg_kms(dev, "DP dual mode adaptor ID: %02x (err %zd)\n", adaptor_id, ret);
@@ -233,11 +240,10 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev,
 				return DRM_DP_DUAL_MODE_TYPE2_DVI;
 		}
 		/*
-		 * If neither a proper type 1 ID nor a broken type 1 adaptor
-		 * as described above, assume type 1, but let the user know
-		 * that we may have misdetected the type.
+		 * If not a proper type 1 ID, still assume type 1, but let
+		 * the user know that we may have misdetected the type.
 		 */
-		if (!is_type1_adaptor(adaptor_id) && adaptor_id != hdmi_id[0])
+		if (!is_type1_adaptor(adaptor_id))
 			drm_err(dev, "Unexpected DP dual mode adaptor ID %02x\n", adaptor_id);
 
 	}
@@ -343,10 +349,8 @@ EXPORT_SYMBOL(drm_dp_dual_mode_get_tmds_output);
  * @enable: enable (as opposed to disable) the TMDS output buffers
  *
  * Set the state of the TMDS output buffers in the adaptor. For
- * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register. As
- * some type 1 adaptors have problems with registers (see comments
- * in drm_dp_dual_mode_detect()) we avoid touching the register,
- * making this function a no-op on type 1 adaptors.
+ * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register.
+ * Type1 adaptors do not support any register writes.
  *
  * Returns:
  * 0 on success, negative error code on failure
Signature · 1 line
2.35.1
#1 lore raw
Quoted 33 lines · Simon Rettberg

Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adaptors, the code failed to read the proper registers that would identify the device as a type 2 adaptor, and handled those as type 1, limiting the TMDS clock to 165MHz.
Fix this by always reading the ID buffer starting from offset 0, and discarding any bytes before the actual offset of interest.

---
(Resend because of no response, probably my fault since I ran get_maintainers on a shallow clone and missed a bunch of people)

We had problems with multiple different "4k ready" DP++ adaptors only resulting in 1080p resolution on Linux. While one of them turned out to actually just be a type1 adaptor, the others, according to the data retreived via i2cdump, were in fact proper type2 adaptors, advertising a TMDS clock of 300MHz. As it turned out, none of them supported sub-addressing when reading from the DP-HDMI adaptor ID buffer via i2c. The existing code suggested that this is known to happen with "broken" type1 adaptors, but evidently, type2 adaptors are also affected. We tried finding authoritative documentation on whether or not this is allowed behavior, but since all the official VESA docs are paywalled, the best we could come up with was the spec sheet for Texas Instruments' SNx5DP149 chip family.[1] It explicitly mentions that sub-adressing is supported for register writes, but *not* for reads (See NOTE in section 8.5.3). Unless TI blatantly and openly decided to violate the VESA spec, one could take that as a strong hint that sub-addressing is in fact not mandated by VESA.

Quoted 1 line

[1] https://www.ti.com/lit/ds/symlink/sn75dp149.pdf

Cc Ville. Also bounced to intel-gfx list to get CI results.

We'll probably want to have the above details included in the commit message too.

BR,
Jani.

Quoted 102 lines
 .../gpu/drm/display/drm_dp_dual_mode_helper.c | 52 ++++++++++---------
 1 file changed, 28 insertions(+), 24 deletions(-)
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +28 -24
index 3ea53bb67..6147da983 100644
@@ -63,23 +63,42 @@
 ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter,
 			      u8 offset, void *buffer, size_t size)
 {
+	int ret;
+	u8 zero = 0;
+	char *tmpbuf;
+	/*
+	 * As sub-addressing is not supported by all adaptors,
+	 * always explicitly read from the start and discard
+	 * any bytes that come before the requested offset.
+	 * This way, no matter whether the adaptor supports it
+	 * or not, we'll end up reading the proper data.
+	 */
 	struct i2c_msg msgs[] = {
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = 0,
 			.len = 1,
-			.buf = &offset,
+			.buf = &zero,
 		},
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = I2C_M_RD,
-			.len = size,
-			.buf = buffer,
+			.len = size + offset,
+			.buf = NULL,
 		},
 	};
-	int ret;
 
+	tmpbuf = kmalloc(size + offset, GFP_KERNEL);
+	if (!tmpbuf)
+		return -ENOMEM;
+
+	msgs[1].buf = tmpbuf;
 	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
+	if (ret == ARRAY_SIZE(msgs))
+		memcpy(buffer, tmpbuf + offset, size);
+
+	kfree(tmpbuf);
+
 	if (ret < 0)
 		return ret;
 	if (ret != ARRAY_SIZE(msgs))
@@ -208,18 +227,6 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev,
 	if (ret)
 		return DRM_DP_DUAL_MODE_UNKNOWN;
 
-	/*
-	 * Sigh. Some (maybe all?) type 1 adaptors are broken and ack
-	 * the offset but ignore it, and instead they just always return
-	 * data from the start of the HDMI ID buffer. So for a broken
-	 * type 1 HDMI adaptor a single byte read will always give us
-	 * 0x44, and for a type 1 DVI adaptor it should give 0x00
-	 * (assuming it implements any registers). Fortunately neither
-	 * of those values will match the type 2 signature of the
-	 * DP_DUAL_MODE_ADAPTOR_ID register so we can proceed with
-	 * the type 2 adaptor detection safely even in the presence
-	 * of broken type 1 adaptors.
-	 */
 	ret = drm_dp_dual_mode_read(adapter, DP_DUAL_MODE_ADAPTOR_ID,
 				    &adaptor_id, sizeof(adaptor_id));
 	drm_dbg_kms(dev, "DP dual mode adaptor ID: %02x (err %zd)\n", adaptor_id, ret);
@@ -233,11 +240,10 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev,
 				return DRM_DP_DUAL_MODE_TYPE2_DVI;
 		}
 		/*
-		 * If neither a proper type 1 ID nor a broken type 1 adaptor
-		 * as described above, assume type 1, but let the user know
-		 * that we may have misdetected the type.
+		 * If not a proper type 1 ID, still assume type 1, but let
+		 * the user know that we may have misdetected the type.
 		 */
-		if (!is_type1_adaptor(adaptor_id) && adaptor_id != hdmi_id[0])
+		if (!is_type1_adaptor(adaptor_id))
 			drm_err(dev, "Unexpected DP dual mode adaptor ID %02x\n", adaptor_id);
 
 	}
@@ -343,10 +349,8 @@ EXPORT_SYMBOL(drm_dp_dual_mode_get_tmds_output);
  * @enable: enable (as opposed to disable) the TMDS output buffers
  *
  * Set the state of the TMDS output buffers in the adaptor. For
- * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register. As
- * some type 1 adaptors have problems with registers (see comments
- * in drm_dp_dual_mode_detect()) we avoid touching the register,
- * making this function a no-op on type 1 adaptors.
+ * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register.
+ * Type1 adaptors do not support any register writes.
  *
  * Returns:
  * 0 on success, negative error code on failure
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#2 lore raw
In reply to Simon Rettberg
Quoted 16 lines · Simon Rettberg

Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adaptors, the code failed to read the proper registers that would identify the device as a type 2 adaptor, and handled those as type 1, limiting the TMDS clock to 165MHz.
Fix this by always reading the ID buffer starting from offset 0, and discarding any bytes before the actual offset of interest.

---
(Resend because of no response, probably my fault since I ran get_maintainers on a shallow clone and missed a bunch of people)

Quoted 16 lines

We had problems with multiple different "4k ready" DP++ adaptors only resulting in 1080p resolution on Linux. While one of them turned out to actually just be a type1 adaptor, the others, according to the data retreived via i2cdump, were in fact proper type2 adaptors, advertising a TMDS clock of 300MHz. As it turned out, none of them supported sub-addressing when reading from the DP-HDMI adaptor ID buffer via i2c. The existing code suggested that this is known to happen with "broken" type1 adaptors, but evidently, type2 adaptors are also affected. We tried finding authoritative documentation on whether or not this is allowed behavior, but since all the official VESA docs are paywalled, the best we could come up with was the spec sheet for Texas Instruments' SNx5DP149 chip family.[1] It explicitly mentions that sub-adressing is supported for register writes, but *not* for reads (See NOTE in section 8.5.3). Unless TI blatantly and openly decided to violate the VESA spec, one could take that as a strong hint that sub-addressing is in fact not mandated by VESA.

I don't think that would pass the dual mode CTS for type2 adaptors since it explicitly calls for reading individual bytes from various offsets.

The actual dual mode spec specifies things rather poorly. Technically it doesn't even specify the write protocol, and the read protocol is only specified in the form of an example read of the HDMI ID buffer. There it says the offset write is optional for the master, but mandatory for the slave to ack. It neither explicitly allows nor disallows the ack+ignore behaviour, but IIRC there is some text in there that suggests that type1 adaptors might ignore it.

Quoted 43 lines

[1] https://www.ti.com/lit/ds/symlink/sn75dp149.pdf

 .../gpu/drm/display/drm_dp_dual_mode_helper.c | 52 ++++++++++---------
 1 file changed, 28 insertions(+), 24 deletions(-)
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +13 -4
index 3ea53bb67..6147da983 100644
@@ -63,23 +63,42 @@
 ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter,
 			      u8 offset, void *buffer, size_t size)
 {
+	int ret;
+	u8 zero = 0;
+	char *tmpbuf;
+	/*
+	 * As sub-addressing is not supported by all adaptors,
+	 * always explicitly read from the start and discard
+	 * any bytes that come before the requested offset.
+	 * This way, no matter whether the adaptor supports it
+	 * or not, we'll end up reading the proper data.
+	 */
 	struct i2c_msg msgs[] = {
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = 0,
 			.len = 1,
-			.buf = &offset,
+			.buf = &zero,
 		},
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = I2C_M_RD,
-			.len = size,
-			.buf = buffer,
+			.len = size + offset,
+			.buf = NULL,
 		},
 	};
-	int ret;
 

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c line 100

Quoted 10 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +9 -0
+	tmpbuf = kmalloc(size + offset, GFP_KERNEL);
+	if (!tmpbuf)
+		return -ENOMEM;
+
+	msgs[1].buf = tmpbuf;
 	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
+	if (ret == ARRAY_SIZE(msgs))
+		memcpy(buffer, tmpbuf + offset, size);
+
+	kfree(tmpbuf);

Could optimize a bit here and avoid the temp buffer when the original offset is 0.

Quoted 12 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +1 -4
+
 	if (ret < 0)
 		return ret;
 	if (ret != ARRAY_SIZE(msgs))
@@ -208,18 +227,6 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev,
 	if (ret)
 		return DRM_DP_DUAL_MODE_UNKNOWN;
 
-	/*
-	 * Sigh. Some (maybe all?) type 1 adaptors are broken and ack
-	 * the offset but ignore it, and instead they just always return
-	 * data from the start of the HDMI ID buffer. So for a broken

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev, · line 231

Quoted 10 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +0 -8
-	 * type 1 HDMI adaptor a single byte read will always give us
-	 * 0x44, and for a type 1 DVI adaptor it should give 0x00
-	 * (assuming it implements any registers). Fortunately neither
-	 * of those values will match the type 2 signature of the
-	 * DP_DUAL_MODE_ADAPTOR_ID register so we can proceed with
-	 * the type 2 adaptor detection safely even in the presence
-	 * of broken type 1 adaptors.
-	 */
 	ret = drm_dp_dual_mode_read(adapter, DP_DUAL_MODE_ADAPTOR_ID,
 				    &adaptor_id, sizeof(adaptor_id));

Another optimization opportunity here to maybe combine the HDMI ID buffer read with this one. Could perhaps just read the full 32 bytes static capabilities section. But this one should probably be left for a separate patch. Ideally I guess we'd also combine the max TMDS clock read with this one. But for that we'd need to return more than the single enum drm_dp_dual_mode_type from this function.

Quoted 31 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +5 -8
 	drm_dbg_kms(dev, "DP dual mode adaptor ID: %02x (err %zd)\n", adaptor_id, ret);
@@ -233,11 +240,10 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev,
 				return DRM_DP_DUAL_MODE_TYPE2_DVI;
 		}
 		/*
-		 * If neither a proper type 1 ID nor a broken type 1 adaptor
-		 * as described above, assume type 1, but let the user know
-		 * that we may have misdetected the type.
+		 * If not a proper type 1 ID, still assume type 1, but let
+		 * the user know that we may have misdetected the type.
 		 */
-		if (!is_type1_adaptor(adaptor_id) && adaptor_id != hdmi_id[0])
+		if (!is_type1_adaptor(adaptor_id))
 			drm_err(dev, "Unexpected DP dual mode adaptor ID %02x\n", adaptor_id);
 
 	}
@@ -343,10 +349,8 @@ EXPORT_SYMBOL(drm_dp_dual_mode_get_tmds_output);
  * @enable: enable (as opposed to disable) the TMDS output buffers
  *
  * Set the state of the TMDS output buffers in the adaptor. For
- * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register. As
- * some type 1 adaptors have problems with registers (see comments
- * in drm_dp_dual_mode_detect()) we avoid touching the register,
- * making this function a no-op on type 1 adaptors.
+ * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register.
+ * Type1 adaptors do not support any register writes.
  *
  * Returns:
  * 0 on success, negative error code on failure
Signature · 1 line
2.35.1
Signature · 2 lines
Ville Syrjälä
Intel
#3 lore raw
Quoted 40 lines · On Mon, 26 Sep 2022 15:38:43 +0300 Ville Syrjälä…
Quoted 26 lines · Simon Rettberg

Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adaptors, the code failed to read the proper registers that would identify the device as a type 2 adaptor, and handled those as type 1, limiting the TMDS clock to 165MHz. Fix this by always reading the ID buffer starting from offset 0, and discarding any bytes before the actual offset of interest.

---
(Resend because of no response, probably my fault since I ran get_maintainers on a shallow clone and missed a bunch of people)

We had problems with multiple different "4k ready" DP++ adaptors only resulting in 1080p resolution on Linux. While one of them turned out to actually just be a type1 adaptor, the others, according to the data retreived via i2cdump, were in fact proper type2 adaptors, advertising a TMDS clock of 300MHz. As it turned out, none of them supported sub-addressing when reading from the DP-HDMI adaptor ID buffer via i2c. The existing code suggested that this is known to happen with "broken" type1 adaptors, but evidently, type2 adaptors are also affected. We tried finding

Quoted 8 lines

authoritative documentation on whether or not this is allowed behavior, but since all the official VESA docs are paywalled, the best we could come up with was the spec sheet for Texas Instruments' SNx5DP149 chip family.[1] It explicitly mentions that sub-adressing is supported for register writes, but *not* for reads (See NOTE in section 8.5.3). Unless TI blatantly and openly decided to violate the VESA spec, one could take that as a strong hint that sub-addressing is in fact not mandated by VESA.

I don't think that would pass the dual mode CTS for type2 adaptors since it explicitly calls for reading individual bytes from various offsets.

Quoted 7 lines

The actual dual mode spec specifies things rather poorly. Technically it doesn't even specify the write protocol, and the read protocol is only specified in the form of an example read of the HDMI ID buffer. There it says the offset write is optional for the master, but mandatory for the slave to ack. It neither explicitly allows nor disallows the ack+ignore behaviour, but IIRC there is some text in there that suggests that type1 adaptors might ignore it.

Interesting, but poor spec would explain why it's not implemented by at least three such chips. That's the TI one (we don't actually have it, but the data sheet above seems quite clear), and the two we confirmed it with: the PS8409(A), and the LT8611.
So either way it might make sense to handle this. Since the first submission of this patch I also took the time to check it on Windows 10, and both adaptors make Windows list 4k resolutions with both the intel iGPU and an nvidia card.

Here are the two dumps for completeness:

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 44 50 2d 48 44 4d 49 20 41 44 41 50 54 4f 52 04    DP-HDMI ADAPTOR?
10: a0 00 1c f8 50 53 38 34 30 39 a2 00 00 78 08 ff    ?.??PS8409?..x?.
     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 44 50 2d 48 44 4d 49 20 41 44 41 50 54 4f 52 04    DP-HDMI ADAPTOR?
10: a0 ff ff ff 4c 54 38 36 31 31 a2 00 00 78 0f 00    ?...LT8611?..x?.
Quoted 45 lines
Quoted 45 lines

[1] https://www.ti.com/lit/ds/symlink/sn75dp149.pdf

 .../gpu/drm/display/drm_dp_dual_mode_helper.c | 52

++++++++++--------- 1 file changed, 28 insertions(+), 24 deletions(-)

(quoted diff) +0 -0

b/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c index 3ea53bb67..6147da983 100644 --- a/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +++ b/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c @@ -63,23 +63,42 @@ ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter,

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +13 -4
 			      u8 offset, void *buffer, size_t size)
 {
+	int ret;
+	u8 zero = 0;
+	char *tmpbuf;
+	/*
+	 * As sub-addressing is not supported by all adaptors,
+	 * always explicitly read from the start and discard
+	 * any bytes that come before the requested offset.
+	 * This way, no matter whether the adaptor supports it
+	 * or not, we'll end up reading the proper data.
+	 */
 	struct i2c_msg msgs[] = {
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = 0,
 			.len = 1,
-			.buf = &offset,
+			.buf = &zero,
 		},
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = I2C_M_RD,
-			.len = size,
-			.buf = buffer,
+			.len = size + offset,
+			.buf = NULL,
 		},
 	};
-	int ret;
Quoted 13 lines

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c line 100

Quoted 10 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +9 -0
+	tmpbuf = kmalloc(size + offset, GFP_KERNEL);
+	if (!tmpbuf)
+		return -ENOMEM;
+
+	msgs[1].buf = tmpbuf;
 	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
+	if (ret == ARRAY_SIZE(msgs))
+		memcpy(buffer, tmpbuf + offset, size);
+
+	kfree(tmpbuf);  

Could optimize a bit here and avoid the temp buffer when the original offset is 0.

Was thinking about that too while writing the patch, but decided to keep it as straight forward as possible for the initial submission; it's also not really performance critical, should be called a few times when the adaptor is plugged in, and probably just once with offset 0.
It also didn't feel nice to have the "if (ret == ARRAY_SIZE(msgs))" check duplicated for the memcpy, to avoid copying potentially uninitialised memory into the output buffer. I didn't see how this would lead to an information leak to user space with the current code base, but better safe than sorry? :)
The alternative is to move the memcpy down and merge it with the other if-block, but then we'd need a cleanup label at the bottom to do the kfree in the error case that comes before that... But I'll happily refine that further and submit a v2 if desired.

Quoted 27 lines
Quoted 27 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +1 -2
+
 	if (ret < 0)
 		return ret;
 	if (ret != ARRAY_SIZE(msgs))
@@ -208,18 +227,6 @@ enum drm_dp_dual_mode_type
 drm_dp_dual_mode_detect(const struct drm_device *dev, if (ret)
 		return DRM_DP_DUAL_MODE_UNKNOWN;
 
-	/*
-	 * Sigh. Some (maybe all?) type 1 adaptors are broken and

ack

(quoted diff) +0 -1
-	 * the offset but ignore it, and instead they just always

return

(quoted diff) +0 -1
-	 * data from the start of the HDMI ID buffer. So for a

broken

(quoted diff) +0 -1
-	 * type 1 HDMI adaptor a single byte read will always give

us

(quoted diff) +0 -2
-	 * 0x44, and for a type 1 DVI adaptor it should give 0x00
-	 * (assuming it implements any registers). Fortunately

neither

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +0 -5
-	 * of those values will match the type 2 signature of the
-	 * DP_DUAL_MODE_ADAPTOR_ID register so we can proceed with
-	 * the type 2 adaptor detection safely even in the presence
-	 * of broken type 1 adaptors.
-	 */
 	ret = drm_dp_dual_mode_read(adapter,
Quoted 8 lines
Quoted 1 line

DP_DUAL_MODE_ADAPTOR_ID, &adaptor_id, sizeof(adaptor_id));

Another optimization opportunity here to maybe combine the HDMI ID buffer read with this one. Could perhaps just read the full 32 bytes static capabilities section. But this one should probably be left for a separate patch. Ideally I guess we'd also combine the max TMDS clock read with this one. But for that we'd need to return more than the single enum drm_dp_dual_mode_type from this function.

Pretty much same as above, keep v1 simple, but I noticed that too. If that's going to be another patch anyways, it might make sense if that's done by someone more familiar with that code in general (basically had to research all this DP++/i2c stuff from scratch). But I could give it a spin.

Quoted 38 lines
Quoted 37 lines

drm_dbg_kms(dev, "DP dual mode adaptor ID: %02x (err
%zd)\n", adaptor_id, ret); @@ -233,11 +240,10 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev, return DRM_DP_DUAL_MODE_TYPE2_DVI; }

(quoted diff) +0 -1
 		/*
-		 * If neither a proper type 1 ID nor a broken type

1 adaptor

(quoted diff) +0 -1
-		 * as described above, assume type 1, but let the

user know

(quoted diff) +1 -1
-		 * that we may have misdetected the type.
+		 * If not a proper type 1 ID, still assume type 1,

but let

(quoted diff) +1 -0
+		 * the user know that we may have misdetected the

type. */

(quoted diff) +0 -1
-		if (!is_type1_adaptor(adaptor_id) && adaptor_id !=

hdmi_id[0])

(quoted diff) +1 -0
+		if (!is_type1_adaptor(adaptor_id))
 			drm_err(dev, "Unexpected DP dual mode

adaptor ID %02x\n", adaptor_id);

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +2 -4
 	}
@@ -343,10 +349,8 @@
 EXPORT_SYMBOL(drm_dp_dual_mode_get_tmds_output);
  * @enable: enable (as opposed to disable) the TMDS output buffers
  *
  * Set the state of the TMDS output buffers in the adaptor. For
- * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register. As
- * some type 1 adaptors have problems with registers (see comments
- * in drm_dp_dual_mode_detect()) we avoid touching the register,
- * making this function a no-op on type 1 adaptors.
+ * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register.
+ * Type1 adaptors do not support any register writes.
  *
  * Returns:

* 0 on success, negative error code on failure

Signature · 1 line
2.35.1  
#4 lore raw
Quoted 129 lines · Simon Rettberg
Quoted 40 lines · On Mon, 26 Sep 2022 15:38:43 +0300 Ville Syrjälä…
Quoted 26 lines · Simon Rettberg

Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adaptors, the code failed to read the proper registers that would identify the device as a type 2 adaptor, and handled those as type 1, limiting the TMDS clock to 165MHz. Fix this by always reading the ID buffer starting from offset 0, and discarding any bytes before the actual offset of interest.

---
(Resend because of no response, probably my fault since I ran get_maintainers on a shallow clone and missed a bunch of people)

We had problems with multiple different "4k ready" DP++ adaptors only resulting in 1080p resolution on Linux. While one of them turned out to actually just be a type1 adaptor, the others, according to the data retreived via i2cdump, were in fact proper type2 adaptors, advertising a TMDS clock of 300MHz. As it turned out, none of them supported sub-addressing when reading from the DP-HDMI adaptor ID buffer via i2c. The existing code suggested that this is known to happen with "broken" type1 adaptors, but evidently, type2 adaptors are also affected. We tried finding

Quoted 8 lines

authoritative documentation on whether or not this is allowed behavior, but since all the official VESA docs are paywalled, the best we could come up with was the spec sheet for Texas Instruments' SNx5DP149 chip family.[1] It explicitly mentions that sub-adressing is supported for register writes, but *not* for reads (See NOTE in section 8.5.3). Unless TI blatantly and openly decided to violate the VESA spec, one could take that as a strong hint that sub-addressing is in fact not mandated by VESA.

I don't think that would pass the dual mode CTS for type2 adaptors since it explicitly calls for reading individual bytes from various offsets.

Quoted 7 lines

The actual dual mode spec specifies things rather poorly. Technically it doesn't even specify the write protocol, and the read protocol is only specified in the form of an example read of the HDMI ID buffer. There it says the offset write is optional for the master, but mandatory for the slave to ack. It neither explicitly allows nor disallows the ack+ignore behaviour, but IIRC there is some text in there that suggests that type1 adaptors might ignore it.

Interesting, but poor spec would explain why it's not implemented by at least three such chips. That's the TI one (we don't actually have it, but the data sheet above seems quite clear), and the two we confirmed it with: the PS8409(A), and the LT8611.
So either way it might make sense to handle this. Since the first submission of this patch I also took the time to check it on Windows 10, and both adaptors make Windows list 4k resolutions with both the intel iGPU and an nvidia card.

Here are the two dumps for completeness:

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 44 50 2d 48 44 4d 49 20 41 44 41 50 54 4f 52 04    DP-HDMI ADAPTOR?
10: a0 00 1c f8 50 53 38 34 30 39 a2 00 00 78 08 ff    ?.??PS8409?..x?.
     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 44 50 2d 48 44 4d 49 20 41 44 41 50 54 4f 52 04    DP-HDMI ADAPTOR?
10: a0 ff ff ff 4c 54 38 36 31 31 a2 00 00 78 0f 00    ?...LT8611?..x?.
Quoted 45 lines
Quoted 45 lines

[1] https://www.ti.com/lit/ds/symlink/sn75dp149.pdf

 .../gpu/drm/display/drm_dp_dual_mode_helper.c | 52

++++++++++--------- 1 file changed, 28 insertions(+), 24 deletions(-)

(quoted diff) +0 -0

b/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c index 3ea53bb67..6147da983 100644 --- a/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +++ b/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c @@ -63,23 +63,42 @@ ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter,

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +13 -4
 			      u8 offset, void *buffer, size_t size)
 {
+	int ret;
+	u8 zero = 0;
+	char *tmpbuf;
+	/*
+	 * As sub-addressing is not supported by all adaptors,
+	 * always explicitly read from the start and discard
+	 * any bytes that come before the requested offset.
+	 * This way, no matter whether the adaptor supports it
+	 * or not, we'll end up reading the proper data.
+	 */
 	struct i2c_msg msgs[] = {
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = 0,
 			.len = 1,
-			.buf = &offset,
+			.buf = &zero,
 		},
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = I2C_M_RD,
-			.len = size,
-			.buf = buffer,
+			.len = size + offset,
+			.buf = NULL,
 		},
 	};
-	int ret;
Quoted 13 lines

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c line 100

Quoted 10 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +9 -0
+	tmpbuf = kmalloc(size + offset, GFP_KERNEL);
+	if (!tmpbuf)
+		return -ENOMEM;
+
+	msgs[1].buf = tmpbuf;
 	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
+	if (ret == ARRAY_SIZE(msgs))
+		memcpy(buffer, tmpbuf + offset, size);
+
+	kfree(tmpbuf);  

Could optimize a bit here and avoid the temp buffer when the original offset is 0.

Quoted 5 lines

Was thinking about that too while writing the patch, but decided to keep it as straight forward as possible for the initial submission; it's also not really performance critical, should be called a few times when the adaptor is plugged in, and probably just once with offset 0.

Would avoid the extra failure point.

Looks like all you really need to do is make the tmpbuf allocation (+ msg mangling) conditional, and check that tmpbuf was allocated before calling memcpy().

Quoted 8 lines

It also didn't feel nice to have the "if (ret == ARRAY_SIZE(msgs))" check duplicated for the memcpy, to avoid copying potentially uninitialised memory into the output buffer. I didn't see how this would lead to an information leak to user space with the current code base, but better safe than sorry? :)
The alternative is to move the memcpy down and merge it with the other if-block, but then we'd need a cleanup label at the bottom to do the kfree in the error case that comes before that...

kfree(NULL) is perfectly legal.

Quoted 38 lines

But I'll happily refine that further and submit a v2 if desired.

Quoted 27 lines
Quoted 27 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +1 -2
+
 	if (ret < 0)
 		return ret;
 	if (ret != ARRAY_SIZE(msgs))
@@ -208,18 +227,6 @@ enum drm_dp_dual_mode_type
 drm_dp_dual_mode_detect(const struct drm_device *dev, if (ret)
 		return DRM_DP_DUAL_MODE_UNKNOWN;
 
-	/*
-	 * Sigh. Some (maybe all?) type 1 adaptors are broken and

ack

(quoted diff) +0 -1
-	 * the offset but ignore it, and instead they just always

return

(quoted diff) +0 -1
-	 * data from the start of the HDMI ID buffer. So for a

broken

(quoted diff) +0 -1
-	 * type 1 HDMI adaptor a single byte read will always give

us

(quoted diff) +0 -2
-	 * 0x44, and for a type 1 DVI adaptor it should give 0x00
-	 * (assuming it implements any registers). Fortunately

neither

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +0 -5
-	 * of those values will match the type 2 signature of the
-	 * DP_DUAL_MODE_ADAPTOR_ID register so we can proceed with
-	 * the type 2 adaptor detection safely even in the presence
-	 * of broken type 1 adaptors.
-	 */
 	ret = drm_dp_dual_mode_read(adapter,
Quoted 8 lines
Quoted 1 line

DP_DUAL_MODE_ADAPTOR_ID, &adaptor_id, sizeof(adaptor_id));

Another optimization opportunity here to maybe combine the HDMI ID buffer read with this one. Could perhaps just read the full 32 bytes static capabilities section. But this one should probably be left for a separate patch. Ideally I guess we'd also combine the max TMDS clock read with this one. But for that we'd need to return more than the single enum drm_dp_dual_mode_type from this function.

Quoted 5 lines

Pretty much same as above, keep v1 simple, but I noticed that too. If that's going to be another patch anyways, it might make sense if that's done by someone more familiar with that code in general (basically had to research all this DP++/i2c stuff from scratch). But I could give it a spin.

I think this one will need a bit more restructuing so better done as a separate patch. Might not really be worth the hassle unless we go all in and try to do just a single 32byte read for everything including the max TMDS clock.

Quoted 39 lines
Quoted 39 lines
Quoted 38 lines

drm_dbg_kms(dev, "DP dual mode adaptor ID: %02x (err
%zd)\n", adaptor_id, ret); @@ -233,11 +240,10 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev, return DRM_DP_DUAL_MODE_TYPE2_DVI; }

(quoted diff) +0 -1
 		/*
-		 * If neither a proper type 1 ID nor a broken type

1 adaptor

(quoted diff) +0 -1
-		 * as described above, assume type 1, but let the

user know

(quoted diff) +1 -1
-		 * that we may have misdetected the type.
+		 * If not a proper type 1 ID, still assume type 1,

but let

(quoted diff) +1 -0
+		 * the user know that we may have misdetected the

type. */

(quoted diff) +0 -1
-		if (!is_type1_adaptor(adaptor_id) && adaptor_id !=

hdmi_id[0])

(quoted diff) +1 -0
+		if (!is_type1_adaptor(adaptor_id))
 			drm_err(dev, "Unexpected DP dual mode

adaptor ID %02x\n", adaptor_id);

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +2 -4
 	}
@@ -343,10 +349,8 @@
 EXPORT_SYMBOL(drm_dp_dual_mode_get_tmds_output);
  * @enable: enable (as opposed to disable) the TMDS output buffers
  *
  * Set the state of the TMDS output buffers in the adaptor. For
- * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register. As
- * some type 1 adaptors have problems with registers (see comments
- * in drm_dp_dual_mode_detect()) we avoid touching the register,
- * making this function a no-op on type 1 adaptors.
+ * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register.
+ * Type1 adaptors do not support any register writes.
  *
  * Returns:

* 0 on success, negative error code on failure

Signature · 1 line
2.35.1  
Signature · 2 lines
Ville Syrjälä
Intel
#5 lore raw

Am Mon, 26 Sep 2022 17:57:47 +0300
schrieb Ville Syrjälä <[email protected]>:

Quoted 139 lines · Simon Rettberg
Quoted 132 lines
Quoted 41 lines · On Mon, 26 Sep 2022 15:38:43 +0300 Ville Syrjälä…
Quoted 27 lines · Simon Rettberg

Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected adaptors, the code failed to read the proper registers that would identify the device as a type 2 adaptor, and handled those as type 1, limiting the TMDS clock to 165MHz. Fix this by always reading the ID buffer starting from offset 0, and discarding any bytes before the actual offset of interest.

Signed-off-by: Simon Rettberg <[email protected]> Reviewed-by: Rafael Gieschke <[email protected]> --- (Resend because of no response, probably my fault since I ran get_maintainers on a shallow clone and missed a bunch of people)

We had problems with multiple different "4k ready" DP++ adaptors only resulting in 1080p resolution on Linux. While one of them turned out to actually just be a type1 adaptor, the others, according to the data retreived via i2cdump, were in fact proper type2 adaptors, advertising a TMDS clock of 300MHz. As it turned out, none of them supported sub-addressing when reading from the DP-HDMI adaptor ID buffer via i2c. The existing code suggested that this is known to happen with "broken" type1 adaptors, but evidently, type2 adaptors are also affected. We tried finding authoritative documentation on whether or not this is allowed

Quoted 8 lines

behavior, but since all the official VESA docs are paywalled, the best we could come up with was the spec sheet for Texas Instruments' SNx5DP149 chip family.[1] It explicitly mentions that sub-adressing is supported for register writes, but *not* for reads (See NOTE in section 8.5.3). Unless TI blatantly and openly decided to violate the VESA spec, one could take that as a strong hint that sub-addressing is in fact not mandated by VESA.

I don't think that would pass the dual mode CTS for type2 adaptors since it explicitly calls for reading individual bytes from various offsets.

Quoted 8 lines

The actual dual mode spec specifies things rather poorly. Technically it doesn't even specify the write protocol, and the read protocol is only specified in the form of an example read of the HDMI ID buffer. There it says the offset write is optional for the master, but mandatory for the slave to ack. It neither explicitly allows nor disallows the ack+ignore behaviour, but IIRC there is some text in there that suggests that type1 adaptors might ignore it.

Interesting, but poor spec would explain why it's not implemented by at least three such chips. That's the TI one (we don't actually have it, but the data sheet above seems quite clear), and the two we confirmed it with: the PS8409(A), and the LT8611.
So either way it might make sense to handle this. Since the first submission of this patch I also took the time to check it on Windows 10, and both adaptors make Windows list 4k resolutions with both the intel iGPU and an nvidia card.

Here are the two dumps for completeness:

0 1 2 3 4 5 6 7 8 9 a b c d e f
0123456789abcdef 00: 44 50 2d 48 44 4d 49 20 41 44 41 50 54 4f 52
04 DP-HDMI ADAPTOR? 10: a0 00 1c f8 50 53 38 34 30 39 a2 00 00
78 08 ff ?.??PS8409?..x?.

0 1 2 3 4 5 6 7 8 9 a b c d e f
0123456789abcdef 00: 44 50 2d 48 44 4d 49 20 41 44 41 50 54 4f 52
04 DP-HDMI ADAPTOR? 10: a0 ff ff ff 4c 54 38 36 31 31 a2 00 00
78 0f 00 ?...LT8611?..x?.

Quoted 45 lines
Quoted 45 lines

[1] https://www.ti.com/lit/ds/symlink/sn75dp149.pdf

 .../gpu/drm/display/drm_dp_dual_mode_helper.c | 52

++++++++++--------- 1 file changed, 28 insertions(+), 24 deletions(-)

(quoted diff) +0 -0

b/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c index 3ea53bb67..6147da983 100644 --- a/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +++ b/drivers/gpu/drm/display/drm_dp_dual_mode_helper.c @@ -63,23 +63,42 @@ ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter, u8 offset, void *buffer, size_t size)
{

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +13 -4
+	int ret;
+	u8 zero = 0;
+	char *tmpbuf;
+	/*
+	 * As sub-addressing is not supported by all adaptors,
+	 * always explicitly read from the start and discard
+	 * any bytes that come before the requested offset.
+	 * This way, no matter whether the adaptor supports it
+	 * or not, we'll end up reading the proper data.
+	 */
 	struct i2c_msg msgs[] = {
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = 0,
 			.len = 1,
-			.buf = &offset,
+			.buf = &zero,
 		},
 		{
 			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
 			.flags = I2C_M_RD,
-			.len = size,
-			.buf = buffer,
+			.len = size + offset,
+			.buf = NULL,
 		},
 	};
-	int ret;
Quoted 13 lines

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c line 100

Quoted 10 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +9 -0
+	tmpbuf = kmalloc(size + offset, GFP_KERNEL);
+	if (!tmpbuf)
+		return -ENOMEM;
+
+	msgs[1].buf = tmpbuf;
 	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
+	if (ret == ARRAY_SIZE(msgs))
+		memcpy(buffer, tmpbuf + offset, size);
+
+	kfree(tmpbuf);    

Could optimize a bit here and avoid the temp buffer when the original offset is 0.

Quoted 5 lines

Was thinking about that too while writing the patch, but decided to keep it as straight forward as possible for the initial submission; it's also not really performance critical, should be called a few times when the adaptor is plugged in, and probably just once with offset 0.

Quoted 5 lines

Would avoid the extra failure point.

Looks like all you really need to do is make the tmpbuf allocation (+ msg mangling) conditional, and check that tmpbuf was allocated before calling memcpy().

Right, that sounds good.

Quoted 11 lines
Quoted 9 lines

It also didn't feel nice to have the "if (ret == ARRAY_SIZE(msgs))" check duplicated for the memcpy, to avoid copying potentially uninitialised memory into the output buffer. I didn't see how this would lead to an information leak to user space with the current code base, but better safe than sorry? :)
The alternative is to move the memcpy down and merge it with the other if-block, but then we'd need a cleanup label at the bottom to do the kfree in the error case that comes before that...

kfree(NULL) is perfectly legal.

This was regarding the conditional for the memcpy(). In the current patch, it's not copying anything from tmpbuf into the output buffer if the i2c_transfer() call fails, because maybe there is some sensitive information in tmpbuf from a previous allocation. But it's not strictly necessary for correctness, as drm_dp_dual_mode_read() would return nonzero in this case and the output buffer is ignored at all current call sites. This was along the lines of "what if later on, someone adds a sysfs interface that calls drm_dp_dual_mode_read() and returns the data without checking the return value". Or maybe just make it a kzalloc instead? I'm probably overthinking this.

So, a rough prototype:

	char *tmpbuf = NULL;
	struct i2c_msg msgs[] = {
		{
			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
			.flags = 0,
			.len = 1,
			.buf = &zero,
		},
		{
			.addr = DP_DUAL_MODE_SLAVE_ADDRESS,
			.flags = I2C_M_RD,
			.len = size + offset,
			.buf = buffer,
		},
	};

	if (offset) {
		tmpbuf = kzalloc(size + offset, GFP_KERNEL);
		if (!tmpbuf)
			return -ENOMEM;
		msgs[1].buf = tmpbuf;
	}

	ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs));
	if (tmpbuf)
		memcpy(buffer, tmpbuf + offset, size);
	kfree(tmpbuf);

	if (ret < 0)
		return ret;
	if (ret != ARRAY_SIZE(msgs))
		return -EPROTO;
	return 0;
Quoted 50 lines
Quoted 44 lines

But I'll happily refine that further and submit a v2 if desired.

Quoted 33 lines
Quoted 31 lines
drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +1 -2
+
 	if (ret < 0)
 		return ret;
 	if (ret != ARRAY_SIZE(msgs))
@@ -208,18 +227,6 @@ enum drm_dp_dual_mode_type
 drm_dp_dual_mode_detect(const struct drm_device *dev, if (ret)
 		return DRM_DP_DUAL_MODE_UNKNOWN;
 
-	/*
-	 * Sigh. Some (maybe all?) type 1 adaptors are broken

and ack

(quoted diff) +0 -1
-	 * the offset but ignore it, and instead they just

always return

(quoted diff) +0 -1
-	 * data from the start of the HDMI ID buffer. So for a

broken

(quoted diff) +0 -1
-	 * type 1 HDMI adaptor a single byte read will always

give us

(quoted diff) +0 -1
-	 * 0x44, and for a type 1 DVI adaptor it should give

0x00

(quoted diff) +0 -1
-	 * (assuming it implements any registers). Fortunately

neither

(quoted diff) +0 -1
-	 * of those values will match the type 2 signature of

the

(quoted diff) +0 -1
-	 * DP_DUAL_MODE_ADAPTOR_ID register so we can proceed

with

(quoted diff) +0 -1
-	 * the type 2 adaptor detection safely even in the

presence

drivers/gpu/drm/display/drm_dp_dual_mode_helper.c +0 -2
-	 * of broken type 1 adaptors.
-	 */
 	ret = drm_dp_dual_mode_read(adapter,
Quoted 1 line

DP_DUAL_MODE_ADAPTOR_ID, &adaptor_id, sizeof(adaptor_id));

Quoted 7 lines

Another optimization opportunity here to maybe combine the HDMI ID buffer read with this one. Could perhaps just read the full 32 bytes static capabilities section. But this one should probably be left for a separate patch. Ideally I guess we'd also combine the max TMDS clock read with this one. But for that we'd need to return more than the single enum drm_dp_dual_mode_type from this function.

Quoted 5 lines

Pretty much same as above, keep v1 simple, but I noticed that too. If that's going to be another patch anyways, it might make sense if that's done by someone more familiar with that code in general (basically had to research all this DP++/i2c stuff from scratch). But I could give it a spin.

Quoted 4 lines

I think this one will need a bit more restructuing so better done as a separate patch. Might not really be worth the hassle unless we go all in and try to do just a single 32byte read for everything including the max TMDS clock.

ack!

Quoted 43 lines
Quoted 42 lines
Quoted 42 lines
Quoted 41 lines

drm_dbg_kms(dev, "DP dual mode adaptor ID: %02x (err
%zd)\n", adaptor_id, ret); @@ -233,11 +240,10 @@ enum drm_dp_dual_mode_type drm_dp_dual_mode_detect(const struct drm_device *dev, return DRM_DP_DUAL_MODE_TYPE2_DVI; }

(quoted diff) +0 -1
 		/*
-		 * If neither a proper type 1 ID nor a broken

type 1 adaptor

(quoted diff) +0 -1
-		 * as described above, assume type 1, but let

the user know

(quoted diff) +1 -1
-		 * that we may have misdetected the type.
+		 * If not a proper type 1 ID, still assume

type 1, but let

(quoted diff) +1 -0
+		 * the user know that we may have misdetected

the type. */

(quoted diff) +0 -1
-		if (!is_type1_adaptor(adaptor_id) &&

adaptor_id != hdmi_id[0])

(quoted diff) +1 -0
+		if (!is_type1_adaptor(adaptor_id))
 			drm_err(dev, "Unexpected DP dual mode

adaptor ID %02x\n", adaptor_id);

(quoted diff) +0 -0
 	}
@@ -343,10 +349,8 @@
 EXPORT_SYMBOL(drm_dp_dual_mode_get_tmds_output);
  * @enable: enable (as opposed to disable) the TMDS output

buffers *
* Set the state of the TMDS output buffers in the adaptor. For
- * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register. As
- * some type 1 adaptors have problems with registers (see comments
- * in drm_dp_dual_mode_detect()) we avoid touching the register,
- * making this function a no-op on type 1 adaptors.
+ * type2 this is set via the DP_DUAL_MODE_TMDS_OEN register.
+ * Type1 adaptors do not support any register writes. *
* Returns:
* 0 on success, negative error code on failure

Signature · 1 line
2.35.1    
#6 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display: Don't assume dual mode adaptors support i2c sub-addressing

In reply to Simon Rettberg
== Series Details ==

== Series Details ==

Series: drm/display: Don't assume dual mode adaptors support i2c sub-addressing
URL : https://patchwork.freedesktop.org/series/109049/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109049v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/index.html

Participating hosts (46 -> 45)
------------------------------

Additional (1): fi-rkl-11600
Missing (2): fi-bxt-dsi fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_109049v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [PASS][1] -> [INCOMPLETE][2] ([i915#146])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#3282])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html

* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#3012])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [PASS][7] -> [INCOMPLETE][8] ([i915#4983])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][9] ([i915#5982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([fdo#111827]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#4103])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([fdo#109285] / [i915#4098])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#1072]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html

* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#3555] / [i915#4098])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3301] / [i915#3708])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-rkl-11600/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][17] ([i915#2867]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]

* igt@gem_ringfill@basic-all:
- {bat-dg2-9}: [FAIL][19] ([i915#5886]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-dg2-9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/bat-dg2-9/igt@[email protected]

* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [DMESG-WARN][21] ([i915#5904]) -> [PASS][22] +30 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html

* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][23] ([i915#4983] / [i915#6257] / [i915#6380]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-rpls-1/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- {bat-rplp-1}: [DMESG-FAIL][25] -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-rplp-1/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/bat-rplp-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [DMESG-WARN][27] ([i915#5904] / [i915#62]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-cfl-8109u/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][29] ([i915#62]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-cfl-8109u/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- fi-cfl-8109u: [DMESG-WARN][31] ([i915#62]) -> [PASS][32] +10 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@kms_pipe_crc_basic@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2:
- {bat-dg2-11}: [FAIL][33] ([i915#6818]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818

Build changes
-------------

* Linux: CI_DRM_12185 -> Patchwork_109049v1

CI-20190529: 20190529
CI_DRM_12185: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109049v1: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

0bc0a5e9aae5 drm/display: Don't assume dual mode adaptors support i2c sub-addressing

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/index.html

#7 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/display: Don't assume dual mode adaptors support i2c sub-addressing

In reply to Simon Rettberg
== Series Details ==

== Series Details ==

Series: drm/display: Don't assume dual mode adaptors support i2c sub-addressing
URL : https://patchwork.freedesktop.org/series/109049/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12185_full -> Patchwork_109049v1_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (12 -> 11)
------------------------------

Missing (1): shard-dg1

Known issues
------------

Here are the changes found in Patchwork_109049v1_full that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- shard-glk: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [FAIL][48], [PASS][49], [PASS][50]) ([i915#4392])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk9/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk9/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk9/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk8/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk1/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk9/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk9/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk9/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk9/boot.html

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@display-3x:
- shard-iclb: NOTRUN -> [SKIP][51] ([i915#1839])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][52] -> [SKIP][53] ([i915#4525])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb1/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb6/igt@[email protected]

* igt@gem_exec_capture@capture-recoverable:
- shard-iclb: NOTRUN -> [SKIP][54] ([i915#6344])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][55] -> [FAIL][56] ([i915#2842])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl6/igt@gem_exec_fair@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][57] ([i915#2842]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][58] -> [FAIL][59] ([i915#2842])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb4/igt@gem_exec_fair@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb7/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-iclb: NOTRUN -> [SKIP][60] ([i915#2190])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@gem_lmem_swapping@verify-ccs:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#4613])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl6/igt@[email protected]

* igt@gem_pxp@create-regular-context-2:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271]) +11 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl6/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-on:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#4270])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@gem_render_copy@yf-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#768])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@gen3_render_tiledy_blits:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109289])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@gen3_render_tiledy_blits.html

* igt@gen9_exec_parse@bb-start-out:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#2856])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#658])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl6/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][68] -> [FAIL][69] ([i915#3989] / [i915#454]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb7/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][70] -> [FAIL][71] ([i915#6537])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl6/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl3/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#5286])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#110723])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109278] / [i915#3886]) +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278]) +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html

* igt@kms_color_chamelium@ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109284] / [fdo#111827]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109279] / [i915#3359])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#3359])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions:
- shard-iclb: [PASS][79] -> [FAIL][80] ([i915#5072])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb1/igt@kms_cursor_legacy@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb7/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@2x-busy-flip:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109274])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][82] -> [FAIL][83] ([i915#79])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk1/igt@kms_flip@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-apl: [PASS][84] -> [FAIL][85] ([i915#79]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl6/igt@kms_flip@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][86] ([i915#2587] / [i915#2672]) +4 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#2672]) +4 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#3555]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109280]) +8 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1:
- shard-iclb: NOTRUN -> [SKIP][90] ([i915#5176]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#5235]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1.html

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][92] -> [SKIP][93] ([i915#5235]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [PASS][94] -> [SKIP][95] ([fdo#109642] / [fdo#111068] / [i915#658])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb4/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][96] -> [SKIP][97] ([fdo#109441])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][98] -> [SKIP][99] ([i915#5519])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-tglb2/igt@[email protected]

* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#112283])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@perf_pmu@[email protected]

#### Possible fixes ####

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][101] ([i915#6268]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb7/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-tglb1/igt@[email protected]

* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][103] ([i915#4525]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb3/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][105] ([i915#2842]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb7/igt@gem_exec_fair@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk6/igt@gem_exec_fair@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [DMESG-WARN][109] ([i915#180]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl1/igt@gem_exec_suspend@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl6/igt@gem_exec_suspend@[email protected]

* igt@gem_exec_whisper@basic-contexts-forked:
- shard-iclb: [INCOMPLETE][111] ([i915#6453]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][113] ([i915#2190]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb7/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-tglb1/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][115] ([i915#4281]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb3/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb1/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][117] ([i915#3555]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][119] ([i915#5176]) -> [PASS][120] +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_plane_scaling@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][121] ([i915#5235]) -> [PASS][122] +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_plane_scaling@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@kms_plane_scaling@[email protected]

* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][123] ([fdo#109441]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb6/igt@kms_psr@psr2_primary_blt.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb2/igt@kms_psr@psr2_primary_blt.html

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][125] ([i915#6117]) -> [SKIP][126] ([i915#4525])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb4/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb6/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][127] ([i915#588]) -> [SKIP][128] ([i915#658])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb3/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][129] ([fdo#111068] / [i915#658]) -> [SKIP][130] ([i915#2920])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb5/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][131] ([i915#2920]) -> [SKIP][132] ([i915#658])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb4/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][133] ([i915#2920]) -> [SKIP][134] ([fdo#111068] / [i915#658]) +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb4/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][135] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][136] ([i915#5939])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [FAIL][137] ([i915#5939]) -> [SKIP][138] ([fdo#109642] / [fdo#111068] / [i915#658])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-iclb4/igt@kms_psr2_su@page_flip-p010.html

* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140], [FAIL][141]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][142], [FAIL][143]) ([i915#3002] / [i915#4312])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl8/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl1/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl2/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl1/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/shard-apl6/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12185 -> Patchwork_109049v1

CI-20190529: 20190529
CI_DRM_12185: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109049v1: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109049v1/index.html