Add Support for Dell 5811e with usb-id 0x413c:0x81c2

PATCH In review Frank Wunderlich 5 participants 8 messages Sep 26, 2022 – Sep 27, 2022

Subsystems (7)

Networking Network drivers Stable branch USB +3 more subsystems

lore

Share & tools

lore

Frank Wunderlich

author

2022-09-26 16:27 UTC #0 lore raw

cover Add Support for Dell 5811e with usb-id 0x413c:0x81c2

From: Frank Wunderlich <[email protected]>

Add new USB-id for dell branded EM7455 with this usb-id in qcserial and qmi driver.
MBIM-mode works out of the box with 6.0-rc6.

Frank Wunderlich (2):
USB: serial: qcserial: add new usb-id for Dell branded EM7455
net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455

 drivers/net/usb/qmi_wwan.c    | 1 +
 drivers/usb/serial/qcserial.c | 1 +
 2 files changed, 2 insertions(+)

Signature · 1 line

2.34.1

Frank Wunderlich

author

2022-09-26 16:37 UTC #1 lore raw

PATCH 1/2 USB: serial: qcserial: add new usb-id for Dell branded EM7455

From: Frank Wunderlich <[email protected]>

Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.

Signed-off-by Frank Wunderlich <[email protected]>

Cc [email protected]

---
 drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/serial/qcserial.c +1 -0

index 586ef5551e76..7897609916a6 100644
@@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x413c, 0x81b3)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
 	{DEVICE_SWI(0x413c, 0x81b5)},	/* Dell Wireless 5811e QDL */
 	{DEVICE_SWI(0x413c, 0x81b6)},	/* Dell Wireless 5811e QDL */
+	{DEVICE_SWI(0x413c, 0x81c2)},	/* Dell Wireless 5811e QDL */
 	{DEVICE_SWI(0x413c, 0x81cb)},	/* Dell Wireless 5816e QDL */
 	{DEVICE_SWI(0x413c, 0x81cc)},	/* Dell Wireless 5816e */
 	{DEVICE_SWI(0x413c, 0x81cf)},   /* Dell Wireless 5819 */

Signature · 1 line

2.34.1

Frank Wunderlich

2022-09-27 06:48 UTC #3 lore raw

Aw: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455

Quoted 9 lines

Gesendet: Dienstag, 27. September 2022 um 08:31 Uhr
Von: "Johan Hovold" <[email protected]>
An: "Frank Wunderlich" <[email protected]>
Cc: [email protected], "Frank Wunderlich" <[email protected]>, "Bjørn Mork" <[email protected]>, "David S. Miller" <[email protected]>, "Eric Dumazet" <[email protected]>, "Jakub Kicinski" <[email protected]>, "Paolo Abeni" <[email protected]>, "Greg Kroah-Hartman" <[email protected]>, [email protected], [email protected], [email protected]
Betreff: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455
Quoted 1 line · Frank Wunderlich
From: Frank Wunderlich <[email protected]>

Quoted 8 lines

drivers/usb/serial/qcserial.c static const struct usb_device_id id_table[] = { · line 180
Quoted 6 lines
+++ b/drivers/usb/serial/qcserial.c
drivers/usb/serial/qcserial.c +1 -0
@@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x413c, 0x81b3)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
 	{DEVICE_SWI(0x413c, 0x81b5)},	/* Dell Wireless 5811e QDL */
 	{DEVICE_SWI(0x413c, 0x81b6)},	/* Dell Wireless 5811e QDL */
+	{DEVICE_SWI(0x413c, 0x81c2)},	/* Dell Wireless 5811e QDL */
I assume this is not just for QDL mode as the comment indicates.

to be honest, have not found out yet what QDL means and assumed that it's like the other dw5811e, so not changed comment :)

Quoted 1 line

Could you post the output of usb-devices for this device?

Bus 001 Device 004: ID 413c:81c2 Sierra Wireless, Incorporated DW5811e Snapdragon™ X7 LTE

/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-mtk/2p, 480M
ID 1d6b:0002 Linux Foundation 2.0 root hub
|__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M
ID 1a40:0101 Terminus Technology Inc. Hub
|__ Port 1: Dev 6, If 0, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 2, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 3, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 8, Class=Vendor Specific Class, Driver=qmi_wwan, 480M
ID 413c:81c2 Dell Computer Corp.

Quoted 5 lines

drivers/usb/serial/qcserial.c static const struct usb_device_id id_table[] = { · line 183
Quoted 3 lines
drivers/usb/serial/qcserial.c +0 -0
 	{DEVICE_SWI(0x413c, 0x81cb)},	/* Dell Wireless 5816e QDL */
 	{DEVICE_SWI(0x413c, 0x81cc)},	/* Dell Wireless 5816e */
 	{DEVICE_SWI(0x413c, 0x81cf)},   /* Dell Wireless 5819 */
Johan

regards Frank

Johan Hovold

maintainer

2022-09-27 07:04 UTC #4 lore raw

Re: Aw: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455

Quoted 17 lines · Frank Wunderlich

Hi
Quoted 6 lines
Gesendet: Dienstag, 27. September 2022 um 08:31 Uhr
Von: "Johan Hovold" <[email protected]>
Quoted 1 line · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
Quoted 8 lines
drivers/usb/serial/qcserial.c static const struct usb_device_id id_table[] = { · line 180
Quoted 6 lines
+++ b/drivers/usb/serial/qcserial.c
drivers/usb/serial/qcserial.c +1 -0
@@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x413c, 0x81b3)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
 	{DEVICE_SWI(0x413c, 0x81b5)},	/* Dell Wireless 5811e QDL */
 	{DEVICE_SWI(0x413c, 0x81b6)},	/* Dell Wireless 5811e QDL */
+	{DEVICE_SWI(0x413c, 0x81c2)},	/* Dell Wireless 5811e QDL */
I assume this is not just for QDL mode as the comment indicates.

Quoted 2 lines

to be honest, have not found out yet what QDL means and assumed that it's like the other dw5811e, so not changed comment :)

I believe that's Qualcomm Download mode or similar, for flashing the device (cf. 5816e which has two entries, one for QDL mode).

Quoted 5 lines

Quoted 1 line
Could you post the output of usb-devices for this device?
Bus 001 Device 004: ID 413c:81c2 Sierra Wireless, Incorporated DW5811e Snapdragon™ X7 LTE

Quoted 12 lines

/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-mtk/2p, 480M
ID 1d6b:0002 Linux Foundation 2.0 root hub
|__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M
ID 1a40:0101 Terminus Technology Inc. Hub
|__ Port 1: Dev 6, If 0, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 2, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 3, Class=Vendor Specific Class, Driver=qcserial, 480M
ID 413c:81c2 Dell Computer Corp.
|__ Port 1: Dev 6, If 8, Class=Vendor Specific Class, Driver=qmi_wwan, 480M
ID 413c:81c2 Dell Computer Corp.

Thanks. The above doesn't include all the details that usb-devices (or lsusb -v) would but still confirms the basic bits so I've applied the patch now after amending the comment.

Johan

Frank Wunderlich

author

2022-09-26 16:27 UTC #5 lore raw

PATCH 2/2 net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455

In reply to Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.

Signed-off-by Frank Wunderlich <[email protected]>

Cc [email protected]

---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

drivers/net/usb/qmi_wwan.c +1 -0

index 0cb187def5bc..26c34a7c21bd 100644
@@ -1402,6 +1402,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x413c, 0x81b3, 8)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
 	{QMI_FIXED_INTF(0x413c, 0x81b6, 8)},	/* Dell Wireless 5811e */
 	{QMI_FIXED_INTF(0x413c, 0x81b6, 10)},	/* Dell Wireless 5811e */
+	{QMI_FIXED_INTF(0x413c, 0x81c2, 8)},	/* Dell Wireless 5811e */
 	{QMI_FIXED_INTF(0x413c, 0x81cc, 8)},	/* Dell Wireless 5816e */
 	{QMI_FIXED_INTF(0x413c, 0x81d7, 0)},	/* Dell Wireless 5821e */
 	{QMI_FIXED_INTF(0x413c, 0x81d7, 1)},	/* Dell Wireless 5821e preproduction config */

Signature · 1 line

2.34.1

Bjørn Mork

maintainer Acked-by on v1 2/2

2022-09-26 17:46 UTC #6 lore raw

Re: [PATCH 2/2] net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455

Quoted 15 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>
Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2.
Signed-off-by Frank Wunderlich <[email protected]>
Cc [email protected]
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/usb/qmi_wwan.c +0 -0
index 0cb187def5bc..26c34a7c21bd 100644

drivers/net/usb/qmi_wwan.c static const struct usb_device_id products[] = { · line 1408

Quoted 7 lines

drivers/net/usb/qmi_wwan.c +1 -0

@@ -1402,6 +1402,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x413c, 0x81b3, 8)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
 	{QMI_FIXED_INTF(0x413c, 0x81b6, 8)},	/* Dell Wireless 5811e */
 	{QMI_FIXED_INTF(0x413c, 0x81b6, 10)},	/* Dell Wireless 5811e */
+	{QMI_FIXED_INTF(0x413c, 0x81c2, 8)},	/* Dell Wireless 5811e */
 	{QMI_FIXED_INTF(0x413c, 0x81cc, 8)},	/* Dell Wireless 5816e */
 	{QMI_FIXED_INTF(0x413c, 0x81d7, 0)},	/* Dell Wireless 5821e */
 	{QMI_FIXED_INTF(0x413c, 0x81d7, 1)},	/* Dell Wireless 5821e preproduction config */

Acked-by Bjørn Mork <[email protected]>

[email protected]

2022-09-27 14:51 UTC #7 lore raw

In reply to Frank Wunderlich

This series was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Mon, 26 Sep 2022 17:07:38 +0200 you wrote:

From: Frank Wunderlich <[email protected]>
Add new USB-id for dell branded EM7455 with this usb-id in qcserial and qmi driver.
MBIM-mode works out of the box with 6.0-rc6.
Frank Wunderlich (2):
USB: serial: qcserial: add new usb-id for Dell branded EM7455
net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455
[...]

Here is the summary with links:
- [1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455 (no matching commit)
- [2/2] net: usb: qmi_wwan: Add new usb-id for Dell branded EM7455

    https://git.kernel.org/netdev/net/c/797666cd5af0

You are awesome, thank you!

Signature · 2 lines

Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html