mm: fix BUG splat with kvmalloc + GFP_ATOMIC
Subsystems (2)
PATCH v2 1/1 mm: fix BUG splat with kvmalloc + GFP_ATOMIC
Martin Zaharinov reports BUG with 5.19.10 kernel:
kernel BUG at mm/vmalloc.c:2437!
invalid opcode: 0000 [#1] SMP
CPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 #1 [..] RIP: 0010:__get_vm_area_node+0x120/0x130 __vmalloc_node_range+0x96/0x1e0 kvmalloc_node+0x92/0xb0 bucket_table_alloc.isra.0+0x47/0x140 rhashtable_try_insert+0x3a4/0x440 rhashtable_insert_slow+0x1b/0x30 [..]
bucket_table_alloc uses kvzalloc(GPF_ATOMIC). If kmalloc fails, this now falls through to vmalloc and hits code paths that assume GFP_KERNEL.
--- mm/util.c | 4 ++++ 1 file changed, 4 insertions(+)
mm/util.c +4 -0
@@ -619,6 +619,10 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node)if (ret || size <=PAGE_SIZE )return ret; +/* non-sleeping allocations are not supported by vmalloc */ +if (!gfpflags_allow_blocking (flags)) +return NULL ; +/* Don't even allow crazy sizes */ if (unlikely (size >INT_MAX )) {WARN_ON_ONCE (!(flags & __GFP_NOWARN));
Signature · 1 line
2.35.1
Quoted 13 lines · Florian Westphal
Martin Zaharinov reports BUG with 5.19.10 kernel:
kernel BUG atmm/vmalloc.c:2437!
invalid opcode: 0000 [#1] SMPCPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 #1 [..] RIP: 0010:__get_vm_area_node+0x120/0x130 __vmalloc_node_range+0x96/0x1e0 kvmalloc_node+0x92/0xb0 bucket_table_alloc.isra.0+0x47/0x140 rhashtable_try_insert+0x3a4/0x440 rhashtable_insert_slow+0x1b/0x30 [..]
Quoted 8 lines
bucket_table_allocuseskvzalloc(GPF_ATOMIC). If kmalloc fails, this now falls through to vmalloc and hits code paths that assumeGFP_KERNEL.Reported-by Martin Zaharinov <[email protected]>Fixes a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc")Suggested-by Michal Hocko <[email protected]>Signed-off-by Florian Westphal <[email protected]>
Maybe we can extend this to GFP_NOWAIT capable vmalloc call but I am not sure this exists or whether this is something vmalloc maintainers want to commit to.
This is a clear and trivial fixup of the above commit. I would add this to the stable tree as well.
Thanks!
Quoted 21 lines
--- mm/util.c | 4 ++++ 1 file changed, 4 insertions(+)mm/util.c +4
-0@@ -619,6 +619,10 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node)if (ret || size <=PAGE_SIZE )return ret; +/* non-sleeping allocations are not supported by vmalloc */ +if (!gfpflags_allow_blocking (flags)) +return NULL ; +/* Don't even allow crazy sizes */ if (unlikely (size >INT_MAX )) {WARN_ON_ONCE (!(flags & __GFP_NOWARN));Signature · 1 line
2.35.1
Signature · 2 lines
Michal Hocko SUSE Labs