Skip to contentSkip to conversation

linux-next: build failure after merge of the leds tree

DISCUSSION [email protected] 2 participants 2 messages Sep 26, 2022 Linux-next tree

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

Hi all,

After merging the leds tree, today's linux-next build (x86 allmodconfig) failed like this:

/tmp/next/build/drivers/leds/leds-pca963x.c: In function 'pca963x_register_leds':
/tmp/next/build/drivers/leds/leds-pca963x.c:355:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]

  355 |   if (hw_blink)
      |   ^~
/tmp/next/build/drivers/leds/leds-pca963x.c:357:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  357 |    led->blinking = false;
      |    ^~~

cc1: all warnings being treated as errors

Caused by commit

fd6dd9584ed3ee6deb ("leds: pca963x: fix blink with hw acceleration")

I am continuing to use the version from 20220921.

#1 lore raw

Hi!

Quoted 10 lines

After merging the leds tree, today's linux-next build (x86 allmodconfig) failed like this:

/tmp/next/build/drivers/leds/leds-pca963x.c: In function 'pca963x_register_leds':
/tmp/next/build/drivers/leds/leds-pca963x.c:355:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]

  355 |   if (hw_blink)
      |   ^~
/tmp/next/build/drivers/leds/leds-pca963x.c:357:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  357 |    led->blinking = false;
      |    ^~~
Quoted 5 lines

cc1: all warnings being treated as errors

Caused by commit

fd6dd9584ed3ee6deb ("leds: pca963x: fix blink with hw acceleration")

Thanks, fixed and pushed out. Someone please check my fix is right.

Best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.