Skip to contentSkip to conversation

x86: Fix i8259 ifdef include guard

PATCH In review Alistair Delva 3 participants 3 messages Sep 26, 2022 – Dec 14, 2022 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Fix i8259 ifdef include guard

When building U-Boot with clang, it notices that the i8259.h include guard does not work correctly due to a typo. Fix it.

Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Nick Desaulniers <[email protected]>
---
 arch/x86/include/asm/i8259.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/i8259.h +2 -2
index b73052a6d2..90f2d3866c 100644
@@ -7,7 +7,7 @@
 /* i8259.h i8259 PIC Registers */
 
 #ifndef _ASMI386_I8259_H_
-#define _ASMI386_I8959_H_
+#define _ASMI386_I8259_H_
 
 /* PIC I/O mapped registers */
 #define IRR		0x0	/* Interrupt Request Register */
@@ -73,4 +73,4 @@
 
 int i8259_init(void);
 
-#endif /* _ASMI386_I8959_H_ */
+#endif /* _ASMI386_I8259_H_ */
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Alistair Delva

When building U-Boot with clang, it notices that the i8259.h include guard does not work correctly due to a typo. Fix it.

Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Nick Desaulniers <[email protected]>
---
 arch/x86/include/asm/i8259.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
#2 lore raw
In reply to Alistair Delva
Quoted 4 lines · Alistair Delva

When building U-Boot with clang, it notices that the i8259.h include guard does not work correctly due to a typo. Fix it.

Quoted 8 lines
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Nick Desaulniers <[email protected]>
---
 arch/x86/include/asm/i8259.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

applied to u-boot-x86, thanks!