Skip to contentSkip to conversation

arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon

PATCH Superseded Macpaul Lin 2 participants 6 messages Sep 22, 2022 – Oct 24, 2022

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon

The size of device tree node secmon (bl31_secmon_reserved) was incorrect. It should be increased to 2MiB (0x200000).

The origin setting will cause some abnormal behavior due to trusted-firmware-a and related firmware didn't load correctly. The incorrect behavior may vary because of different software stacks. For example, it will cause build error in some Yocto project because it will check if there was enough memory to load trusted-firmware-a to the reserved memory.

Fixes 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")
---
 arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt8195-demo.dts +2 -2
index 4fbd99eb496a..dec85d254838 100644
@@ -56,10 +56,10 @@
 		#size-cells = <2>;
 		ranges;
 
-		/* 192 KiB reserved for ARM Trusted Firmware (BL31) */
+		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
 		bl31_secmon_reserved: secmon@54600000 {
 			no-map;
-			reg = <0 0x54600000 0x0 0x30000>;
+			reg = <0 0x54600000 0x0 0x200000>;
 		};
 
 		/* 12 MiB reserved for OP-TEE (BL32)
Signature · 1 line
2.18.0
#1 lore raw

Hi Macpaul,

Quoted 2 lines

The size of device tree node secmon (bl31_secmon_reserved) was incorrect. It should be increased to 2MiB (0x200000).

192K should work when the patch(6147314aeedc) was accepted. Does the trusted-firmware-a get larger now, so we need to increase the size to 2MiB?

thanks,
Miles

Quoted 11 lines

The origin setting will cause some abnormal behavior due to trusted-firmware-a and related firmware didn't load correctly. The incorrect behavior may vary because of different software stacks. For example, it will cause build error in some Yocto project because it will check if there was enough memory to load trusted-firmware-a to the reserved memory.

Fixes 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")
#2 lore raw
Quoted 11 lines · Miles Chen

Hi Macpaul,

Quoted 2 lines

The size of device tree node secmon (bl31_secmon_reserved) was incorrect. It should be increased to 2MiB (0x200000).

192K should work when the patch(6147314aeedc) was accepted. Does the trusted-firmware-a get larger now, so we need to increase the size to 2MiB?

thanks,
Miles

When mt8195-demo.dts sent to the upstream, at that time the size of
BL31 was small. Because supported functions and modules in BL31 are basic sets when the board was under early development stage.

Now BL31 includes more firmwares of coprocessors and maturer functions
so the size has grown bigger in real applications. According to the value reported by customers, we think reserved 2MiB for BL31 might be enough for maybe the following 2 or 3 years.

Quoted 11 lines
Quoted 11 lines

The origin setting will cause some abnormal behavior due to trusted-firmware-a and related firmware didn't load correctly. The incorrect behavior may vary because of different software stacks. For example, it will cause build error in some Yocto project because it will check if there was enough memory to load trusted-firmware-a to the reserved memory.

Fixes 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")

Thanks
Macpaul Lin

Reviewed-by
#3 lore raw

Re: [PATCH] arm64: dts: mediatek: mt8195-demo: fix the memory size of

Quoted 13 lines · Miles Chen
Quoted 11 lines

Hi Macpaul,

Quoted 2 lines

The size of device tree node secmon (bl31_secmon_reserved) was incorrect. It should be increased to 2MiB (0x200000).

192K should work when the patch(6147314aeedc) was accepted. Does the trusted-firmware-a get larger now, so we need to increase the size to 2MiB?

thanks,
Miles

Quoted 8 lines

When mt8195-demo.dts sent to the upstream, at that time the size of BL31 was small. Because supported functions and modules in BL31 are basic sets when the board was under early development stage.

Now BL31 includes more firmwares of coprocessors and maturer functions so the size has grown bigger in real applications. According to the value reported by customers, we think reserved 2MiB for BL31 might be enough for maybe the following 2 or 3 years.

Thanks for your explanation,
please add this to the commit message and submit next version.

With that, feel free to add:

thanks,
Miles

#4 lore raw

PATCH v2 1/1 arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon

In reply to Macpaul Lin

The size of device tree node secmon (bl31_secmon_reserved) was incorrect. It should be increased to 2MiB (0x200000).

The origin setting will cause some abnormal behavior due to trusted-firmware-a and related firmware didn't load correctly. The incorrect behavior may vary because of different software stacks. For example, it will cause build error in some Yocto project because it will check if there was enough memory to load trusted-firmware-a to the reserved memory.

When mt8195-demo.dts sent to the upstream, at that time the size of BL31 was small. Because supported functions and modules in BL31 are basic sets when the board was under early development stage.

Now BL31 includes more firmwares of coprocessors and maturer functions so the size has grown bigger in real applications. According to the value reported by customers, we think reserved 2MiB for BL31 might be enough for maybe the following 2 or 3 years.

Fixes 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")

---
Changes for v2
- Add more information about the size difference for BL31 in commit message. Thanks for Miles's review.

 arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt8195-demo.dts +2 -2
index 4fbd99eb496a..dec85d254838 100644
@@ -56,10 +56,10 @@
 		#size-cells = <2>;
 		ranges;
 
-		/* 192 KiB reserved for ARM Trusted Firmware (BL31) */
+		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
 		bl31_secmon_reserved: secmon@54600000 {
 			no-map;
-			reg = <0 0x54600000 0x0 0x30000>;
+			reg = <0 0x54600000 0x0 0x200000>;
 		};
 
 		/* 12 MiB reserved for OP-TEE (BL32)
Signature · 1 line
2.18.0
#5 lore raw
Quoted 10 lines · Macpaul Lin

The size of device tree node secmon (bl31_secmon_reserved) was incorrect. It should be increased to 2MiB (0x200000).

The origin setting will cause some abnormal behavior due to trusted-firmware-a and related firmware didn't load correctly. The incorrect behavior may vary because of different software stacks. For example, it will cause build error in some Yocto project because it will check if there was enough memory to load trusted-firmware-a to the reserved memory.

Quoted 8 lines

When mt8195-demo.dts sent to the upstream, at that time the size of BL31 was small. Because supported functions and modules in BL31 are basic sets when the board was under early development stage.

Now BL31 includes more firmwares of coprocessors and maturer functions so the size has grown bigger in real applications. According to the value reported by customers, we think reserved 2MiB for BL31 might be enough for maybe the following 2 or 3 years.

Dear Matthias, sorry for a gentle reminder. MediaTek hope this simple fix could be applied to 6.1-rc and be picked-up to current stable tree after v5.19. Thanks a lot.

Quoted 19 lines
Fixes 6147314aeedc ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")

---
Changes for v2
- Add more information about the size difference for BL31 in commit message. Thanks for Miles's review.

  arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt8195-demo.dts +0 -0
index 4fbd99eb496a..dec85d254838 100644
@@ -56,10 +56,10 @@
  		#size-cells = <2>;
  		ranges;

arch/arm64/boot/dts/mediatek/mt8195-demo.dts line 65

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8195-demo.dts +2 -2
 
-		/* 192 KiB reserved for ARM Trusted Firmware (BL31) */
+		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
  		bl31_secmon_reserved: secmon@54600000 {
  			no-map;
-			reg = <0 0x54600000 0x0 0x30000>;
+			reg = <0 0x54600000 0x0 0x200000>;
  		};
 
  		/* 12 MiB reserved for OP-TEE (BL32)

Regards,
Macpaul Lin