Skip to contentSkip to conversation

perf tools: Fix bison object compilation with clang 15

PATCH Applied Jiri Olsa 4 participants 7 messages Sep 29, 2022 perf events

lore
Share & tools
lore

Jiri Olsa

author reviewer
#0 lore raw

PATCH 1/2 perf tools: Fix bison object compilation with clang 15

Arnaldo reported compilation fail with clang 15:

CC util/parse-events-bison.o
util/parse-events-bison.c:1401:9: error: variable 'parse_events_nerrs' set but not used [-Werror,-Wunused-but-set-variable]

      int yynerrs = 0;
        ^
  util/parse-events-bison.c:72:25: note: expanded from macro 'yynerrs'
  #define yynerrs         parse_events_nerrs
                        ^

1 error generated.

Disabling -Wunused-but-set-variable check for bison object compilation.

---
 tools/perf/util/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/Build +1 -1
index 8fd6dc8de521..d559c80559e3 100644
@@ -270,7 +270,7 @@ CFLAGS_expr-flex.o          += $(flex_flags)
 bison_flags := -DYYENABLE_NLS=0
 BISON_GE_35 := $(shell expr $(shell $(BISON) --version | grep bison | sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\= 35)
 ifeq ($(BISON_GE_35),1)
-  bison_flags += -Wno-unused-parameter -Wno-nested-externs -Wno-implicit-function-declaration -Wno-switch-enum
+  bison_flags += -Wno-unused-parameter -Wno-nested-externs -Wno-implicit-function-declaration -Wno-switch-enum -Wno-unused-but-set-variable
 else
   bison_flags += -w
 endif
Signature · 1 line
2.37.3
author reviewer
#1 lore raw

PATCH 2/2 perf tools: Remove unused variable in tests/test-basic.c

The clang 15 build reveal several unused-but-set variables, removing the 'foo' variable in tests/mmap-basic.o object.

---
 tools/perf/tests/mmap-basic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/tests/mmap-basic.c +1 -2
index 21b5e68179d7..8322fc2295fa 100644
@@ -112,8 +112,7 @@ static int test__basic_mmap(struct test_suite *test __maybe_unused, int subtest
 
 	for (i = 0; i < nsyscalls; ++i)
 		for (j = 0; j < expected_nr_events[i]; ++j) {
-			int foo = syscalls[i]();
-			++foo;
+			syscalls[i]();
 		}
 
 	md = &evlist->mmap[0];
Signature · 1 line
2.37.3
maintainer Applied
#2 lore raw

Re: [PATCH 2/2] perf tools: Remove unused variable in tests/test-basic.c

Em Thu, Sep 29, 2022 at 04:05:14PM +0200, Jiri Olsa escreveu:

Quoted 2 lines

The clang 15 build reveal several unused-but-set variables, removing the 'foo' variable in tests/mmap-basic.o object.

Thanks, applied.

- Arnaldo

Quoted 21 lines
---
 tools/perf/tests/mmap-basic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/tests/mmap-basic.c +1 -2
index 21b5e68179d7..8322fc2295fa 100644
@@ -112,8 +112,7 @@ static int test__basic_mmap(struct test_suite *test __maybe_unused, int subtest
 
 	for (i = 0; i < nsyscalls; ++i)
 		for (j = 0; j < expected_nr_events[i]; ++j) {
-			int foo = syscalls[i]();
-			++foo;
+			syscalls[i]();
 		}
 
 	md = &evlist->mmap[0];
Signature · 1 line
2.37.3
Signature · 1 line
- Arnaldo
#3 lore raw
In reply to Jiri Olsa

Em Thu, Sep 29, 2022 at 04:05:13PM +0200, Jiri Olsa escreveu:

Quoted 5 lines

Arnaldo reported compilation fail with clang 15:

CC util/parse-events-bison.o
util/parse-events-bison.c:1401:9: error: variable 'parse_events_nerrs' set but not used [-Werror,-Wunused-but-set-variable]

Quoted 8 lines
      int yynerrs = 0;
        ^
  util/parse-events-bison.c:72:25: note: expanded from macro 'yynerrs'
  #define yynerrs         parse_events_nerrs
                        ^

1 error generated.

Disabling -Wunused-but-set-variable check for bison object compilation.

So we have to disable something else:

37 44.92 fedora:32 : FAIL clang version 10.0.1 (Fedora 10.0.1-3.fc32)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
38 61.77 fedora:33 : FAIL clang version 11.0.0 (Fedora 11.0.0-3.fc33)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
39 66.59 fedora:34 : FAIL clang version 12.0.1 (Fedora 12.0.1-1.fc34)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2

I'll try yours + -Wno-unknown-warning-option

;-)

- Arnaldo

Quoted 20 lines
---
 tools/perf/util/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/Build +1 -1
index 8fd6dc8de521..d559c80559e3 100644
@@ -270,7 +270,7 @@ CFLAGS_expr-flex.o          += $(flex_flags)
 bison_flags := -DYYENABLE_NLS=0
 BISON_GE_35 := $(shell expr $(shell $(BISON) --version | grep bison | sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\= 35)
 ifeq ($(BISON_GE_35),1)
-  bison_flags += -Wno-unused-parameter -Wno-nested-externs -Wno-implicit-function-declaration -Wno-switch-enum
+  bison_flags += -Wno-unused-parameter -Wno-nested-externs -Wno-implicit-function-declaration -Wno-switch-enum -Wno-unused-but-set-variable
 else
   bison_flags += -w
 endif
Signature · 1 line
2.37.3
Signature · 1 line
- Arnaldo
maintainer
#4 lore raw
Quoted 29 lines · Arnaldo Carvalho de Melo

Em Thu, Sep 29, 2022 at 04:05:13PM +0200, Jiri Olsa escreveu:

Quoted 5 lines

Arnaldo reported compilation fail with clang 15:

CC util/parse-events-bison.o
util/parse-events-bison.c:1401:9: error: variable 'parse_events_nerrs' set but not used [-Werror,-Wunused-but-set-variable]

Quoted 8 lines
      int yynerrs = 0;
        ^
  util/parse-events-bison.c:72:25: note: expanded from macro 'yynerrs'
  #define yynerrs         parse_events_nerrs
                        ^

1 error generated.

Disabling -Wunused-but-set-variable check for bison object compilation.

So we have to disable something else:

37 44.92 fedora:32 : FAIL clang version 10.0.1 (Fedora 10.0.1-3.fc32)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
38 61.77 fedora:33 : FAIL clang version 11.0.0 (Fedora 11.0.0-3.fc33)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
39 66.59 fedora:34 : FAIL clang version 12.0.1 (Fedora 12.0.1-1.fc34)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2

Quoted 1 line

I'll try yours + -Wno-unknown-warning-option

Is -Wno-unknown-warning-option known to older versions? ;-)

Thanks,
Namhyung

#5 lore raw

Em Thu, Sep 29, 2022 at 11:22:41AM -0700, Namhyung Kim escreveu:

Quoted 31 lines
Quoted 29 lines · Arnaldo Carvalho de Melo

Em Thu, Sep 29, 2022 at 04:05:13PM +0200, Jiri Olsa escreveu:

Quoted 5 lines

Arnaldo reported compilation fail with clang 15:

CC util/parse-events-bison.o
util/parse-events-bison.c:1401:9: error: variable 'parse_events_nerrs' set but not used [-Werror,-Wunused-but-set-variable]

Quoted 8 lines
      int yynerrs = 0;
        ^
  util/parse-events-bison.c:72:25: note: expanded from macro 'yynerrs'
  #define yynerrs         parse_events_nerrs
                        ^

1 error generated.

Disabling -Wunused-but-set-variable check for bison object compilation.

So we have to disable something else:

37 44.92 fedora:32 : FAIL clang version 10.0.1 (Fedora 10.0.1-3.fc32)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
38 61.77 fedora:33 : FAIL clang version 11.0.0 (Fedora 11.0.0-3.fc33)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
39 66.59 fedora:34 : FAIL clang version 12.0.1 (Fedora 12.0.1-1.fc34)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2

Quoted 3 lines
Quoted 1 line

I'll try yours + -Wno-unknown-warning-option

Is -Wno-unknown-warning-option known to older versions? ;-)

Excellent question! ;-)

And one we should learn something from, so that we
can prep tools/perf/ (and other projects we contribute to) for the future:

So far, so good:

[perfbuilder@five ~]$ echo grep FAIL dm.log/summary | cut -c15- | cut -d: -f1,2
alpine:3.12 alpine:3.13 alpine:3.14 alpine:3.15 alt:p10 amazonlinux:devel debian:11 fedora:32 fedora:33 fedora:34 fedora:37 fedora:38 fedora:rawhide ubuntu:21.04 [perfbuilder@five ~]$ export BUILD_TARBALL=http://192.168.86.14/perf/perf-6.0.0-rc7.tar.xz
[perfbuilder@five ~]$ time dm debian:experimental alpine:3.12 alpine:3.13 alpine:3.14 alpine:3.15 alt:p10 amazonlinux:devel debian:11 fedora:32 fedora:33 fedora:34 fedora:37 fedora:38 fedora:rawhide ubuntu:21.04

   1   140.66 debian:experimental           : Ok   gcc (Debian 12.2.0-3) 12.2.0 , Debian clang version 14.0.6-2
   2   132.82 alpine:3.12                   : Ok   gcc (Alpine 9.3.0) 9.3.0 , Alpine clang version 10.0.0 (https://gitlab.alpinelinux.org/alpine/aports.git 7445adce501f8473efdb93b17b5eaf2f1445ed4c)
   3   140.40 alpine:3.13                   : Ok   gcc (Alpine 10.2.1_pre1) 10.2.1 20201203 , Alpine clang version 10.0.1
   4   143.75 alpine:3.14                   : Ok   gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424 , Alpine clang version 11.1.0
   5   147.77 alpine:3.15                   : Ok   gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027 , Alpine clang version 12.0.1
   6    98.79 alt:p10                       : Ok   x86_64-alt-linux-gcc (GCC) 10.3.1 20210703 (ALT Sisyphus 10.3.1-alt2) , clang version 11.0.1

7: amazonlinux:devel

- Arnaldo

#6 lore raw
In reply to Arnaldo Carvalho de Melo
Quoted 28 lines · Arnaldo Carvalho de Melo

Em Thu, Sep 29, 2022 at 04:05:13PM +0200, Jiri Olsa escreveu:

Quoted 5 lines

Arnaldo reported compilation fail with clang 15:

CC util/parse-events-bison.o
util/parse-events-bison.c:1401:9: error: variable 'parse_events_nerrs' set but not used [-Werror,-Wunused-but-set-variable]

Quoted 8 lines
      int yynerrs = 0;
        ^
  util/parse-events-bison.c:72:25: note: expanded from macro 'yynerrs'
  #define yynerrs         parse_events_nerrs
                        ^

1 error generated.

Disabling -Wunused-but-set-variable check for bison object compilation.

So we have to disable something else:

37 44.92 fedora:32 : FAIL clang version 10.0.1 (Fedora 10.0.1-3.fc32)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
38 61.77 fedora:33 : FAIL clang version 11.0.0 (Fedora 11.0.0-3.fc33)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2
39 66.59 fedora:34 : FAIL clang version 12.0.1 (Fedora 12.0.1-1.fc34)
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option] make[3]: *** [/git/perf-6.0.0-rc7/tools/build/Makefile.build:139: util] Error 2

Quoted 1 line

I'll try yours + -Wno-unknown-warning-option

ugh, of course... thanks ;-)

jirka

Quoted 29 lines

;-)

- Arnaldo

Quoted 20 lines
---
 tools/perf/util/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/Build +1 -1
index 8fd6dc8de521..d559c80559e3 100644
@@ -270,7 +270,7 @@ CFLAGS_expr-flex.o          += $(flex_flags)
 bison_flags := -DYYENABLE_NLS=0
 BISON_GE_35 := $(shell expr $(shell $(BISON) --version | grep bison | sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\= 35)
 ifeq ($(BISON_GE_35),1)
-  bison_flags += -Wno-unused-parameter -Wno-nested-externs -Wno-implicit-function-declaration -Wno-switch-enum
+  bison_flags += -Wno-unused-parameter -Wno-nested-externs -Wno-implicit-function-declaration -Wno-switch-enum -Wno-unused-but-set-variable
 else
   bison_flags += -w
 endif
Signature · 1 line
2.37.3
Signature · 1 line
- Arnaldo