phy: qcom-qmp-usb: correct registers layout for IPQ8074 USB3 PHY
Subsystems (2)
PATCH 1/1 phy: qcom-qmp-usb: correct registers layout for IPQ8074 USB3 PHY
According to the kernel 4.4 sources from NHSS.QSDK.9.0.2 and according to hardware docs, the PHY registers layout used for IPQ8074 USB3 PHY is incorrect. This platform uses offset 0x174 for the PCS_STATUS register, 0xd8 for PCS_AUTONOMOUS_MODE_CTRL, etc.
Correct the PHY registers layout.
--- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-qmp-usb.c +1 -1
@@ -1616,7 +1616,7 @@ static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = { .num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), - .regs = usb3phy_regs_layout, + .regs = qmp_v3_usb3phy_regs_layout, .start_ctrl = SERDES_START | PCS_START, .pwrdn_ctrl = SW_PWRDN,
Signature · 7 lines
2.35.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 19 lines · Dmitry Baryshkov
According to the kernel 4.4 sources from NHSS.QSDK.9.0.2 and according to hardware docs, the PHY registers layout used for IPQ8074 USB3 PHY is incorrect. This platform uses offset
0x174for thePCS_STATUSregister,0xd8forPCS_AUTONOMOUS_MODE_CTRL, etc.Correct the PHY registers layout.
Fixes 94a407cc17a4 ("phy: qcom-qmp: create copies of QMP PHY driver")Fixes 507156f5a99f ("phy: qcom-qmp: Add USB QMP PHY support for IPQ8074")Signed-off-by Dmitry Baryshkov <[email protected]>--- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/phy/qualcomm/phy-qcom-qmp-usb.c +0
-0
drivers/phy/qualcomm/phy-qcom-qmp-usb.c static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = { · line 1622
Quoted 8 lines
drivers/phy/qualcomm/phy-qcom-qmp-usb.c +1
-1@@ -1616,7 +1616,7 @@ static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = { .num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), - .regs = usb3phy_regs_layout, + .regs = qmp_v3_usb3phy_regs_layout, .start_ctrl = SERDES_START | PCS_START, .pwrdn_ctrl = SW_PWRDN,
Reviewed the docs, changes looks good to me.
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 4 lines · Dmitry Baryshkov
According to the kernel 4.4 sources from NHSS.QSDK.9.0.2 and according to hardware docs, the PHY registers layout used for IPQ8074 USB3 PHY is incorrect. This platform uses offset
0x174for thePCS_STATUSregister,0xd8forPCS_AUTONOMOUS_MODE_CTRL, etc.
Applied, thanks
Signature · 1 line
~Vinod