binfmt: remove taso from linux_binprm struct
Subsystems (3)
PATCH 1/1 binfmt: remove taso from linux_binprm struct
With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the use of the special taso flag for alpha architectures in the linux_binprm struct is gone.
Remove the definition of taso in the linux_binprm struct.
No functional change.
---
Kees, please pick this patch on top of the commit above.
include/linux/binfmts.h | 3 --- 1 file changed, 3 deletions(-)
include/linux/binfmts.h +0 -3
@@ -43,9 +43,6 @@ struct linux_binprm {* original userspace. */ point_of_no_return:1 ; -#ifdef __alpha__ - unsigned int taso:1; -#endif struct file *executable;/* Executable to pass to the interpreter */ struct file *interpreter;struct file *file;
Signature · 1 line
2.17.1
Quoted 7 lines · Lukas Bulwahn
With commit
987f20a9dcce("a.out: Remove the a.out implementation"), the use of the special taso flag for alpha architectures in thelinux_binprmstruct is gone.Remove the definition of taso in the
linux_binprmstruct.No functional change.
Alphas binfmt_loader is the only use I can find of that variable so let's kill it as well.
Quoted 21 lines
Signed-off-by Lukas Bulwahn <[email protected]>---
Kees, please pick this patch on top of the commit above.include/linux/binfmts.h | 3 --- 1 file changed, 3 deletions(-)include/linux/binfmts.h +0
-3@@ -43,9 +43,6 @@ struct linux_binprm {* original userspace. */ point_of_no_return:1 ; -#ifdef __alpha__ - unsigned int taso:1; -#endif struct file *executable;/* Executable to pass to the interpreter */ struct file *interpreter;struct file *file;
Quoted 6 lines · Eric W. Biederman
Quoted 4 lines · Lukas Bulwahn
With commit
987f20a9dcce("a.out: Remove the a.out implementation"), the use of the special taso flag for alpha architectures in thelinux_binprmstruct is gone.
Quoted 8 lines
Quoted 3 lines
Remove the definition of taso in the
linux_binprmstruct.No functional change.
Reviewed-by "Eric W. Biederman" <[email protected]>Alphas
binfmt_loaderis the only use I can find of that variable so let's kill it as well.
I can't find anything using "taso". Where are you looking?
Signature · 1 line
Kees Cook
Quoted 6 lines · Eric W. Biederman
Quoted 4 lines · Lukas Bulwahn
With commit
987f20a9dcce("a.out: Remove the a.out implementation"), the use of the special taso flag for alpha architectures in thelinux_binprmstruct is gone.
Quoted 8 lines
Quoted 3 lines
Remove the definition of taso in the
linux_binprmstruct.No functional change.
Reviewed-by "Eric W. Biederman" <[email protected]>Alphas
binfmt_loaderis the only use I can find of that variable so let's kill it as well.
Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the only place it was accessed. Agreed. :)
Signature · 1 line
Kees Cook
Quoted 11 lines · Kees Cook
Quoted 10 lines · Eric W. Biederman
Quoted 7 lines · Lukas Bulwahn
With commit
987f20a9dcce("a.out: Remove the a.out implementation"), the use of the special taso flag for alpha architectures in thelinux_binprmstruct is gone.Remove the definition of taso in the
linux_binprmstruct.No functional change.
Quoted 7 lines
Quoted 4 lines
Reviewed-by "Eric W. Biederman" <[email protected]>Alphas
binfmt_loaderis the only use I can find of that variable so let's kill it as well.Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the only place it was accessed. Agreed. :)
Yes. I was looking in a tree without my previous change merged.
The code in binfmt_loader (which is removed in the my change) was the only user of that variable I could find.
Eric
Kees Cook
AppliedQuoted 9 lines · Lukas Bulwahn
With commit
987f20a9dcce("a.out: Remove the a.out implementation"), the use of the special taso flag for alpha architectures in thelinux_binprmstruct is gone.Remove the definition of taso in the
linux_binprmstruct.No functional change.
[...]
Applied to for-next/execve, thanks!
[1/1] binfmt: remove taso from linux_binprm struct
https://git.kernel.org/kees/c/9f4beead610c
Signature · 1 line
Kees Cook