Skip to contentSkip to conversation

iomap: add a tracepoint for mappings returned by map_blocks

PATCH In review Darrick J. Wong 2 participants 2 messages Sep 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iomap: add a tracepoint for mappings returned by map_blocks

From: Darrick J. Wong <[email protected]>

Add a new tracepoint so we can see what mapping the filesystem returns to writeback a dirty page.

---
 fs/iomap/buffered-io.c |    1 +
 fs/iomap/trace.h       |    1 +
 2 files changed, 2 insertions(+)
fs/iomap/buffered-io.c +1 -0
index 77d59c159248..91ee0b308e13 100644
@@ -1360,6 +1360,7 @@ iomap_writepage_map(struct iomap_writepage_ctx *wpc,
 		error = wpc->ops->map_blocks(wpc, inode, pos);
 		if (error)
 			break;
+		trace_iomap_writepage_map(inode, &wpc->iomap);
 		if (WARN_ON_ONCE(wpc->iomap.type == IOMAP_INLINE))
 			continue;
 		if (wpc->iomap.type == IOMAP_HOLE)
fs/iomap/trace.h +1 -0
index d48868fc40d7..f6ea9540d082 100644
@@ -148,6 +148,7 @@ DEFINE_EVENT(iomap_class, name,	\
 	TP_ARGS(inode, iomap))
 DEFINE_IOMAP_EVENT(iomap_iter_dstmap);
 DEFINE_IOMAP_EVENT(iomap_iter_srcmap);
+DEFINE_IOMAP_EVENT(iomap_writepage_map);
 
 TRACE_EVENT(iomap_iter,
 	TP_PROTO(struct iomap_iter *iter, const void *ops,
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Add a new tracepoint so we can see what mapping the filesystem returns to writeback a dirty page.

---
 fs/iomap/buffered-io.c |    1 +
 fs/iomap/trace.h       |    1 +
 2 files changed, 2 insertions(+)
fs/iomap/buffered-io.c +1 -0
index 77d59c159248..91ee0b308e13 100644
@@ -1360,6 +1360,7 @@ iomap_writepage_map(struct iomap_writepage_ctx *wpc,
 		error = wpc->ops->map_blocks(wpc, inode, pos);
 		if (error)
 			break;
+		trace_iomap_writepage_map(inode, &wpc->iomap);
 		if (WARN_ON_ONCE(wpc->iomap.type == IOMAP_INLINE))
 			continue;
 		if (wpc->iomap.type == IOMAP_HOLE)
fs/iomap/trace.h +0 -0
index d48868fc40d7..f6ea9540d082 100644

fs/iomap/trace.h DEFINE_EVENT(iomap_class, name, \ · line 154

Quoted 7 lines
fs/iomap/trace.h +1 -0
@@ -148,6 +148,7 @@ DEFINE_EVENT(iomap_class, name,	\
 	TP_ARGS(inode, iomap))
 DEFINE_IOMAP_EVENT(iomap_iter_dstmap);
 DEFINE_IOMAP_EVENT(iomap_iter_srcmap);
+DEFINE_IOMAP_EVENT(iomap_writepage_map);
 
 TRACE_EVENT(iomap_iter,
 	TP_PROTO(struct iomap_iter *iter, const void *ops,

Looks fine.

Signature · 2 lines
Dave Chinner
[email protected]