Fix __clzsi2 logic
PATCH 1/1 Fix __clzsi2 logic
Fix the incorrect return value of __clzsi2 function.
--- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/kern/compiler-rt.c +1 -1
@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)for (; j; j >>=1 ) { -if ((temp = val) >> j) +if ((temp = (val >> j))) {if (j ==1 ) {
Signature · 1 line
2.25.1
Quoted 4 lines · Tuan Phan
Fix the incorrect return value of
__clzsi2function.Fixes e795b90 ("RISC-V: Add libgcc helpers for clz")Signed-off-by Tuan Phan <[email protected]>
Quoted 9 lines
--- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)grub-core/kern/compiler-rt.c +0
-0
grub-core/kern/compiler-rt.c __clzsi2 (grub_uint32_t val) · line 434
Quoted 5 lines
grub-core/kern/compiler-rt.c +1
-1@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)for (; j; j >>=1 ) { -if ((temp = val) >> j) +if ((temp = (val >> j)))
... I will drop redundant brackets from here to be in line with things in the libgcc...
Daniel
Quoted 26 lines · Daniel Kiper
Quoted 4 lines · Tuan Phan
Fix the incorrect return value of
__clzsi2function.Fixes e795b90 ("RISC-V: Add libgcc helpers for clz")Signed-off-by Tuan Phan <[email protected]>Reviewed-by Daniel Kiper <[email protected]> but...Quoted 9 lines
--- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)grub-core/kern/compiler-rt.c +0
-0grub-core/kern/compiler-rt.c __clzsi2 (grub_uint32_t val) · line 434
Quoted 5 lines
grub-core/kern/compiler-rt.c +1
-1@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)for (; j; j >>=1 ) { -if ((temp = val) >> j) +if ((temp = (val >> j)))... I will drop redundant brackets from here to be in line with things in the libgcc...
Quoted 2 lines
Daniel
Thanks for the review, I will drop the redundant brackets.
PATCH v2 1/1 Fix __clzsi2 logic
In reply to Daniel KiperFix the incorrect return value of __clzsi2 function.
---
V2: Drop redundant brackets
--- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/kern/compiler-rt.c +1 -1
@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)for (; j; j >>=1 ) { -if ((temp = val) >> j) +if (temp = (val >> j)) {if (j ==1 ) {
Signature · 1 line
2.25.1
Quoted 26 lines · Tuan Phan
Fix the incorrect return value of
__clzsi2function.Fixes e795b90 ("RISC-V: Add libgcc helpers for clz")Signed-off-by Tuan Phan <[email protected]>Reviewed-by Daniel Kiper <[email protected]>---
V2: Drop redundant bracketsSigned-off-by Tuan Phan <[email protected]>--- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)grub-core/kern/compiler-rt.c +1
-2@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)for (; j; j >>=1 ) { -if ((temp = val) >> j) +if (temp = (val >> j)) {if (j ==1 ) { --
Quoted 3 lines
2.25.1
Hi Daniel,
Any chances that this patch will be merged soon?
Thanks,
Quoted 30 lines · Tuan Phan
On Mon, Oct 3, 2022 at 11:30 AM Tuan Phan <[email protected]> wrote:
Fix the incorrect return value of __clzsi2 function. Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz") Signed-off-by: Tuan Phan <[email protected]> Reviewed-by: Daniel Kiper <[email protected]> --- V2: Drop redundant brackets Signed-off-by: Tuan Phan <[email protected]> --- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler- rt.c index 2057c2e0c..738bb8420 100644 --- a/grub-core/kern/compiler-rt.c +++ b/grub-core/kern/compiler-rt.c @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val) for (; j; j >>= 1) { - if ((temp = val) >> j) + if (temp = (val >> j)) { if (j == 1) { -- 2.25.1
Quoted 2 lines
Hi Daniel,
Any chances that this patch will be merged soon?
It has been merged together with other patches last week.
Daniel
Quoted 32 lines · Daniel Kiper
Quoted 1 line · Tuan Phan
On Mon, Oct 3, 2022 at 11:30 AM Tuan Phan <[email protected]>
Quoted 29 lines · wrote:
Fix the incorrect return value of __clzsi2 function. Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz") Signed-off-by: Tuan Phan <[email protected]> Reviewed-by: Daniel Kiper <[email protected]> --- V2: Drop redundant brackets Signed-off-by: Tuan Phan <[email protected]> --- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler- rt.c index 2057c2e0c..738bb8420 100644 --- a/grub-core/kern/compiler-rt.c +++ b/grub-core/kern/compiler-rt.c @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val) for (; j; j >>= 1) { - if ((temp = val) >> j) + if (temp = (val >> j)) { if (j == 1) { -- 2.25.1
Quoted 7 lines
Quoted 2 lines
Hi Daniel,
Any chances that this patch will be merged soon?It has been merged together with other patches last week.
Daniel
Awesome, thanks!