Skip to contentSkip to conversation

Add ums512 clocks and relative bindings file

PATCH RESEND Applied Cixi Geng 5 participants 8 messages Sep 9, 2022 – Sep 30, 2022

Subsystems (4)
lore
Share & tools
lore

Cixi Geng

author
#0 lore raw

v8 cover Add ums512 clocks and relative bindings file

From: Cixi Geng <[email protected]>

This patchset is add the UMS512 clocks support

v2 changes:
adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd" compatibles to fix match failed logs in the dt_binding_check. add the property license and copyright notice.

v3 changes:
fix wrong indentation and hint: "maxItems" is not needed with an "items" list when use the latest dtschema.

v4 changes:
move the syscon bindins from clk to glbreg yaml file by pickup chunyan's patch for global registers bindings
fix the comments from Krzysztof in v3 patchset
add the Acked-by: Krzysztof in patch v4 3/4
fix the warning Prefer "GPL" over "GPL v2"

v5 changes:
Add review tags.
fix the comments in ums512-glbreg.yaml.

v6 changes:
No more send the patch 1/4 and 3/4 in V5 for applied by Stephen change GPL to GPL v2 license
fix the lack of space in some "{" and "}"
add check error for sprd_clk_regmap_init.

v7 changes:
Resend the patchset after the cross-tree patch merged use the absolute path for the mfd refs of patternProperties

v8 changes:
add the const property for address-cells and size-cells.

Chunyan Zhang (1):
dt-bindings: mfd: sprd: Add bindings for ums512 global registers

Cixi Geng (1):
clk: sprd: Add clocks support for UMS512

 .../bindings/mfd/sprd,ums512-glbreg.yaml      |   71 +
 drivers/clk/sprd/Kconfig                      |    6 +
 drivers/clk/sprd/Makefile                     |    1 +
 drivers/clk/sprd/ums512-clk.c                 | 2202 +++++++++++++++++
 4 files changed, 2280 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml
 create mode 100644 drivers/clk/sprd/ums512-clk.c
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH RESEND v8 1/2 dt-bindings: mfd: sprd: Add bindings for ums512 global registers

From: Chunyan Zhang <[email protected]>

Add bindings for Unisoc system global register which provide register map for clocks.

---
 .../bindings/mfd/sprd,ums512-glbreg.yaml      | 71 +++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml
Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml new file +71 -0
new file mode 100644
index 000000000000..996bd4a17ca3
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright 2022 Unisoc Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/sprd,ums512-glbreg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Unisoc System Global Register
+
+maintainers:
+  - Orson Zhai <[email protected]>
+  - Baolin Wang <[email protected]>
+  - Chunyan Zhang <[email protected]>
+
+description:
+  Unisoc system global registers provide register map
+  for clocks and some multimedia modules of the SoC.
+
+properties:
+  compatible:
+    items:
+      - const: sprd,ums512-glbregs
+      - const: syscon
+      - const: simple-mfd
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  ranges:
+    maxItems: 1
+
+  reg:
+    maxItems: 1
+
+patternProperties:
+  "^clock-controller@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/clock/sprd,ums512-clk.yaml#
+    description:
+      Clock controller for the SoC clocks.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    ap_apb_regs: syscon@71000000 {
+      compatible = "sprd,ums512-glbregs", "syscon", "simple-mfd";
+      reg = <0x71000000 0x3000>;
+      #address-cells = <1>;
+      #size-cells = <1>;
+      ranges = <0 0x71000000 0x3000>;
+
+      clock-controller@0 {
+        compatible = "sprd,ums512-apahb-gate";
+        reg = <0x0 0x2000>;
+        #clock-cells = <1>;
+      };
+    };
+
+  - |
+    ap_intc5_regs: syscon@32360000 {
+      compatible = "sprd,ums512-glbregs", "syscon", "simple-mfd";
+      reg = <0x32360000 0x1000>;
+    };
Signature · 1 line
2.34.1
Reviewed-by on v8 1/2
#2 lore raw

Re: [RESEND][PATCH V8 1/2] dt-bindings: mfd: sprd: Add bindings for ums512 global registers

Quoted 8 lines · Cixi Geng

From: Chunyan Zhang <[email protected]>

Add bindings for Unisoc system global register which provide register map for clocks.

Best regards,
Krzysztof

maintainer Applied
#3 lore raw

Re: [RESEND][PATCH V8 1/2] dt-bindings: mfd: sprd: Add bindings for ums512 global registers

In reply to Cixi Geng
Quoted 5 lines · Cixi Geng

From: Chunyan Zhang <[email protected]>

Add bindings for Unisoc system global register which provide register map for clocks.

Quoted 7 lines
---
 .../bindings/mfd/sprd,ums512-glbreg.yaml      | 71 +++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml

Applied, thanks.

Signature · 1 line
Lee Jones [李琼斯]
author
#4 lore raw

PATCH RESEND v8 2/2 clk: sprd: Add clocks support for UMS512

In reply to Cixi Geng

From: Cixi Geng <[email protected]>

Add the list of clocks for the Unisoc UMS512, along with clock initialization.

---
 drivers/clk/sprd/Kconfig      |    6 +
 drivers/clk/sprd/Makefile     |    1 +
 drivers/clk/sprd/ums512-clk.c | 2202 +++++++++++++++++++++++++++++++++
 3 files changed, 2209 insertions(+)
 create mode 100644 drivers/clk/sprd/ums512-clk.c
drivers/clk/sprd/Kconfig +6 -0
index e18c80fbe804..c744bd9d2f96 100644
@@ -21,4 +21,10 @@ config SPRD_SC9863A_CLK
 	help
 	  Support for the global clock controller on sc9863a devices.
 	  Say Y if you want to use peripheral devices on sc9863a SoC.
+
+config SPRD_UMS512_CLK
+	tristate "Support for the Spreadtrum UMS512 clocks"
+	help
+	  Support for the global clock controller on ums512 devices.
+	  Say Y if you want to use peripheral devices on ums512 SoC.
 endif
drivers/clk/sprd/Makefile +1 -0
index 41d90e0d7863..f25b2c3904fb 100644
@@ -11,3 +11,4 @@ clk-sprd-y	+= pll.o
 ## SoC support
 obj-$(CONFIG_SPRD_SC9860_CLK)	+= sc9860-clk.o
 obj-$(CONFIG_SPRD_SC9863A_CLK)	+= sc9863a-clk.o
+obj-$(CONFIG_SPRD_UMS512_CLK)	+= ums512-clk.o
drivers/clk/sprd/ums512-clk.c new file +2202 -0

2,202 lines not on this page · raw message

Signature · 1 line
2.34.1
author
#7 lore raw
In reply to Cixi Geng
Quoted 31 lines · Cixi Geng <[email protected]> 于2022年9月9日周五 23:24写道:

From: Cixi Geng <[email protected]>

This patchset is add the UMS512 clocks support

v2 changes:
adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd" compatibles to fix match failed logs in the dt_binding_check. add the property license and copyright notice.

v3 changes:
fix wrong indentation and hint: "maxItems" is not needed with an "items" list when use the latest dtschema.

v4 changes:
move the syscon bindins from clk to glbreg yaml file by pickup chunyan's patch for global registers bindings
fix the comments from Krzysztof in v3 patchset
add the Acked-by: Krzysztof in patch v4 3/4
fix the warning Prefer "GPL" over "GPL v2"

v5 changes:
Add review tags.
fix the comments in ums512-glbreg.yaml.

v6 changes:
No more send the patch 1/4 and 3/4 in V5 for applied by Stephen change GPL to GPL v2 license
fix the lack of space in some "{" and "}"
add check error for sprd_clk_regmap_init.

Quoted 6 lines

v7 changes:
Resend the patchset after the cross-tree patch merged use the absolute path for the mfd refs of patternProperties

v8 changes:
add the const property for address-cells and size-cells.

Sorry, I have no idea why the v8 patchset cover-letter append this email I have double-check the subject is v8 version.

Subject: [RESEND][PATCH V8 0/2] Add ums512 clocks and relative bindings file
Date: Fri, 9 Sep 2022 23:24:19 +0800
Message-Id: <[email protected]>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Quoted 18 lines

Chunyan Zhang (1):
dt-bindings: mfd: sprd: Add bindings for ums512 global registers

Cixi Geng (1):
clk: sprd: Add clocks support for UMS512

 .../bindings/mfd/sprd,ums512-glbreg.yaml      |   71 +
 drivers/clk/sprd/Kconfig                      |    6 +
 drivers/clk/sprd/Makefile                     |    1 +
 drivers/clk/sprd/ums512-clk.c                 | 2202 +++++++++++++++++
 4 files changed, 2280 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml
 create mode 100644 drivers/clk/sprd/ums512-clk.c

--
2.34.1