Skip to contentSkip to conversation

clk: bcm: rpi: Add support for three more clocks

PATCH RESEND Applied Ivan T. Ivanov 2 participants 7 messages Aug 29, 2022 – Sep 30, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v4 cover clk: bcm: rpi: Add support for three more clocks

Add missing clock required by RPiVid video decoder and provide more reliable and accurate source for HDMI pixel and video encoder clocks.

Changes since v3
- Put back support for VEC clock, which was actually one of reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.

[1] https://bugzilla.suse.com/show_bug.cgi?id=1198942

Changes since v2
- Added Acks from Maxime Ripard and Dave Stevenson

Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.

Dom Cobley (1):
clk: bcm: rpi: Add support for VEC clock

Ivan T. Ivanov (2):
clk: bcm: rpi: Add support HEVC clock
clk: bcm: rpi: Handle pixel clock in firmware

 drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
Signature · 1 line
2.35.3
#1 lore raw

PATCH RESEND v4 1/3 clk: bcm: rpi: Add support HEVC clock

Export clock required for RPiVid video decoder hardware.

---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -0
index 73518009a0f2..8f560c6b602d 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_HEVC_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
Signature · 1 line
2.35.3
maintainer Applied
#2 lore raw

Re: [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock

Quoting Ivan T. Ivanov (2022-08-29 08:21:52)

Quoted 6 lines

Export clock required for RPiVid video decoder hardware.

---

Applied to clk-next

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

PATCH RESEND v4 2/3 clk: bcm: rpi: Handle pixel clock in firmware

In reply to Ivan T. Ivanov

The clk-bcm2835 handling of the pixel clock does not function correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the firmware clock driver.

---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -0
index 8f560c6b602d..1248c0d64eae 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_PIXEL_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_HEVC_CLK_ID] = {
 		.export = true,
 	},
Signature · 1 line
2.35.3
maintainer Applied
#4 lore raw

Re: [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware

Quoting Ivan T. Ivanov (2022-08-29 08:21:53)

Quoted 10 lines

The clk-bcm2835 handling of the pixel clock does not function correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the firmware clock driver.

---

Applied to clk-next

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

PATCH RESEND v4 3/3 clk: bcm: rpi: Add support for VEC clock

In reply to Ivan T. Ivanov

From: Dom Cobley <[email protected]>

Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz). Export VEC clock trough clk-raspberrypi which uses the right PLL to get an accurate 108MHz.

[iivanov: Adapted on top of v5.17-rc6]
---
 drivers/clk/bcm/clk-raspberrypi.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +5 -0
index 1248c0d64eae..d70bb9283af7 100644
@@ -33,6 +33,7 @@ enum rpi_firmware_clk_id {
 	RPI_FIRMWARE_EMMC2_CLK_ID,
 	RPI_FIRMWARE_M2MC_CLK_ID,
 	RPI_FIRMWARE_PIXEL_BVB_CLK_ID,
+	RPI_FIRMWARE_VEC_CLK_ID,
 	RPI_FIRMWARE_NUM_CLK_ID,
 };
 
@@ -51,6 +52,7 @@ static char *rpi_firmware_clk_names[] = {
 	[RPI_FIRMWARE_EMMC2_CLK_ID]	= "emmc2",
 	[RPI_FIRMWARE_M2MC_CLK_ID]	= "m2mc",
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID]	= "pixel-bvb",
+	[RPI_FIRMWARE_VEC_CLK_ID]	= "vec",
 };
 
 #define RPI_FIRMWARE_STATE_ENABLE_BIT	BIT(0)
@@ -138,6 +140,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_VEC_CLK_ID] = {
+		.export = true,
+	},
 };
 
 /*
Signature · 1 line
2.35.3
maintainer Applied
#6 lore raw

Re: [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock

Quoting Ivan T. Ivanov (2022-08-29 08:21:54)

Quoted 10 lines

From: Dom Cobley <[email protected]>

Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz). Export VEC clock trough clk-raspberrypi which uses the right PLL to get an accurate 108MHz.

[iivanov: Adapted on top of v5.17-rc6]

---

Applied to clk-next

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel