clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe
Subsystems (2)
PATCH 1/1 clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe
pm_runtime_get_sync() will increment pm usage counter. Forgetting to putting operation will result in reference leak. Add missing pm_runtime_put_sync in some error paths.
Fixes 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/clk/ti/clk-dra7-atl.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/clk/ti/clk-dra7-atl.c +6 -3
@@ -253,14 +253,16 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)if (rc) {pr_err ("%s: failed to lookup atl clock %d\n" , __func__, i); -return -EINVAL ; + ret = -EINVAL ; + goto pm_put; } clk =of_clk_get_from_provider (&clkspec);if (IS_ERR (clk)) {pr_err ("%s: failed to get atl clock %d from provider\n" , __func__, i); -return PTR_ERR (clk); + ret =PTR_ERR (clk); + goto pm_put; } cdesc =to_atl_desc (__clk_get_hw (clk));
@@ -293,8 +295,9 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)if (cdesc->enabled)atl_clk_enable (__clk_get_hw (clk)); } -pm_runtime_put_sync (cinfo->dev); +pm_put: +pm_runtime_put_sync (cinfo->dev);return ret; }
Signature · 1 line
2.25.1
Quoted 6 lines · Miaoqian Lin
pm_runtime_get_sync()will increment pm usage counter. Forgetting to putting operation will result in reference leak. Add missingpm_runtime_put_syncin some error paths.Fixes 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")Signed-off-by Miaoqian Lin <[email protected]>
Reviewed-by Tony Lindgren <[email protected]>
Quoting Miaoqian Lin (2022-06-01 20:08:36)
Quoted 7 lines
pm_runtime_get_sync()will increment pm usage counter. Forgetting to putting operation will result in reference leak. Add missingpm_runtime_put_syncin some error paths.Fixes 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")Signed-off-by Miaoqian Lin <[email protected]>---
Applied to clk-next