drm/i915/guc: Fix revocation of non-persistent contexts
Subsystems (3)
PATCH 1/1 drm/i915/guc: Fix revocation of non-persistent contexts
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of intel_context_is_banned in the GuC backend needed replacing with newly introduced intel_context_is_schedulable.
Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing intel_context_is_banned with intel_context_is_schedulable, which should always be safe since latter is a superset of the former.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 14 +++++++--- drivers/gpu/drm/i915/gt/intel_context.h | 8 +----- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 26 +++++++++---------- 4 files changed, 25 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.c +1 -7
@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines, bool exit, bool persistent)*/ for_each_gem_engine (ce, engines, it) {struct intel_engine_cs *engine; -bool skip = false; -if (exit) - skip =intel_context_set_exiting (ce); -else if (!persistent) - skip =intel_context_exit_nonpersistent (ce,NULL ); - -if (skip) +if ((exit || !persistent) &&intel_context_revoke (ce))continue ;/* Already marked. */ /*
drivers/gpu/drm/i915/gt/intel_context.c +10 -4
@@ -614,13 +614,19 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq)return ret; } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq) +bool intel_context_revoke (struct intel_context *ce) {bool ret =intel_context_set_exiting (ce); -if (ce->ops->revoke) - ce->ops->revoke (ce, rq, ce->engine->props.preempt_timeout_ms); +if (!ret &&intel_engine_uses_guc (ce->engine)) { +/* +* With GuC backend we have to notify it of revocation as soon +* as the exiting flag is set. +*/ +if (ce->ops->revoke) + ce->ops->revoke (ce,NULL , + ce->engine->props.preempt_timeout_ms); + }return ret; }
drivers/gpu/drm/i915/gt/intel_context.h +1 -7
@@ -319,18 +319,12 @@ static inline bool intel_context_is_schedulable(const struct intel_context *ce) !test_bit (CONTEXT_BANNED , &ce->flags); } -static inline bool intel_context_is_exiting (const struct intel_context *ce) -{ -return test_bit (CONTEXT_EXITING , &ce->flags); -} -static inline bool intel_context_set_exiting (struct intel_context *ce) {return test_and_set_bit (CONTEXT_EXITING , &ce->flags); } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq); +bool intel_context_revoke (struct intel_context *ce);static inline bool intel_context_force_single_submission (const struct intel_context *ce)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +13 -13
@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc *guc, struct i915_request *rq)* Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ -if (unlikely (intel_context_is_banned (ce))) { +if (unlikely (!intel_context_is_schedulable (ce))) {i915_request_put (i915_request_mark_eio (rq));intel_engine_signal_breadcrumbs (ce->engine);return 0 ;
@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) {struct intel_context *ce =request_to_scheduling_context (rq); -int ret =0 ; +int ret; -if (likely (!intel_context_is_banned (ce))) { - ret =__guc_wq_item_append (rq); +if (unlikely (!intel_context_is_schedulable (ce))) +return 0 ; -if (unlikely (ret == -EBUSY )) { - guc->stalled_request = rq; - guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; - } + ret =__guc_wq_item_append (rq); +if (unlikely (ret == -EBUSY )) { + guc->stalled_request = rq; + guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; }return ret;
@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request *rq)* submitting all the requests generated in parallel. */ return test_bit (I915_FENCE_FLAG_SUBMIT_PARALLEL , &rq->fence.flags) || -intel_context_is_banned (ce); + !intel_context_is_schedulable (ce); }static int guc_dequeue_one_context (struct intel_guc *guc)
@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc)struct intel_context *ce =request_to_scheduling_context (last);if (unlikely (!ctx_id_mapped (guc, ce->guc_id.id) && - !intel_context_is_banned (ce))) { +intel_context_is_schedulable (ce))) { ret =try_context_registration (ce, false);if (unlikely (ret == -EPIPE )) { goto deadlk;
@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) {struct intel_engine_cs *engine =__context_to_physical_engine (ce); -if (intel_context_is_banned (ce)) +if (!intel_context_is_schedulable (ce))return ;GEM_BUG_ON (!intel_context_is_pinned (ce));
@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(struct intel_guc *guc, {trace_intel_context_reset (ce); -if (likely (!intel_context_is_banned (ce))) { +if (likely (intel_context_is_schedulable (ce))) {capture_error_state (guc, ce);guc_context_replay (ce); }else {drm_info (&guc_to_gt (guc)->i915->drm, -"Ignoring context reset notification of banned context 0x%04X on %s" , +"Ignoring context reset notification of exiting context 0x%04X on %s" , ce->guc_id.id, ce->engine->name); } }
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix revocation of non-persistent contexts
== Series Details ==
== Series Details ==
Series: drm/i915/guc: Fix revocation of non-persistent contexts
URL : https://patchwork.freedesktop.org/series/109299/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12202 -> Patchwork_109299v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/index.html
Participating hosts (47 -> 48)
------------------------------
Additional (4): bat-dg2-8 bat-adlp-4 fi-tgl-dsi bat-dg1-5
Missing (3): fi-ctg-p8600 fi-bdw-samus fi-hsw-4200u
Known issues
------------
Here are the changes found in Patchwork_109299v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@nullptr:
- bat-dg1-5: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@fbdev@read:
- bat-adlp-4: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([i915#4083])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4079]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-adlp-4: NOTRUN -> [SKIP][8] ([i915#1155])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#1155])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-adlp-4: NOTRUN -> [SKIP][10] ([i915#6621])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#6621])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][12] ([i915#4418])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][13] -> [INCOMPLETE][14] ([i915#4785])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/fi-hsw-4770/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/fi-hsw-4770/igt@i915_selftest@[email protected]
- fi-snb-2600: [PASS][15] -> [INCOMPLETE][16] ([i915#6992])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/fi-snb-2600/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/fi-snb-2600/igt@i915_selftest@[email protected]
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#4212]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4215])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([i915#1845] / [i915#4303])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][20] ([fdo#111827])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][21] ([fdo#111827]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][22] ([fdo#111827]) +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-adlp-4: NOTRUN -> [SKIP][23] ([i915#3637]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][24] ([i915#4093]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][25] ([fdo#109285])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-4: NOTRUN -> [SKIP][26] ([i915#4342])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-dg1-5: NOTRUN -> [SKIP][27] ([i915#4078]) +13 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-adlp-4: NOTRUN -> [SKIP][28] ([i915#3546]) +10 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][29] ([i915#1072] / [i915#4078]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-adlp-4: NOTRUN -> [SKIP][30] ([i915#1072]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][31] ([i915#3555])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][32] ([i915#3555] / [i915#4579])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- bat-adlp-4: NOTRUN -> [SKIP][33] ([fdo#109295] / [i915#3546] / [i915#3708])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][34] ([i915#1845] / [i915#3708])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][35] ([i915#3708]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][36] ([i915#3708] / [i915#4077]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][37] ([fdo#109295] / [i915#3301] / [i915#3708])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][38] ([i915#3708] / [i915#4873])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][39] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlp-4/igt@[email protected]
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][40] ([fdo#109271] / [i915#4312] / [i915#5594])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/fi-hsw-4770/igt@[email protected]
- bat-dg1-5: NOTRUN -> [FAIL][41] ([i915#4312])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg1-5/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][42] ([i915#2867]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@lmem0:
- {bat-dg2-11}: [DMESG-WARN][44] ([i915#6816]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/bat-dg2-11/igt@gem_exec_suspend@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/bat-dg2-11/igt@gem_exec_suspend@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][46] ([i915#5982]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/fi-rkl-11600/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/fi-rkl-11600/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
[i915#6992]: https://gitlab.freedesktop.org/drm/intel/issues/6992
Build changes
-------------
* Linux: CI_DRM_12202 -> Patchwork_109299v1
CI-20190529: 20190529
CI_DRM_12202: 0b9f0501c9541cf79fdfb43a7760360a81453d88 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6670: d618e9865fe5cbaf511ca43503abad442605d0a5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109299v1: 0b9f0501c9541cf79fdfb43a7760360a81453d88 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
1617afbec369 drm/i915/guc: Fix revocation of non-persistent contexts
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/index.html
Quoted 11 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of
intel_context_is_bannedin the GuC backend needed replacing with newly introducedintel_context_is_schedulable.
Quoted 4 lines
Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing
intel_context_is_bannedwithintel_context_is_schedulable, which should always be safe since latter is a superset of the former.
negation of the latter is a ...?
Quoted 47 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 45c64ecf97ee ("drm/i915: Improve user experience and driver robustness under SIGINT or similar")Cc Andrzej Hajda <[email protected]>Cc John Harrison <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 14 +++++++--- drivers/gpu/drm/i915/gt/intel_context.h | 8 +----- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 26 +++++++++---------- 4 files changed, 25 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-6@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines, bool exit, bool persistent)*/ for_each_gem_engine (ce, engines, it) {struct intel_engine_cs *engine; -bool skip = false; -if (exit) - skip =intel_context_set_exiting (ce); -else if (!persistent) - skip = intel_context_exit_nonpersistent(ce, NULL); > - - if (skip) +if ((exit || !persistent) &&intel_context_revoke (ce))continue ;/* Already marked. */ /* drivers/gpu/drm/i915/gt/intel_context.c +1
-3@@ -614,13 +614,19 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq)return ret; } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq) +bool intel_context_revoke (struct intel_context *ce) {bool ret =intel_context_set_exiting (ce); -if (ce->ops->revoke)
drivers/gpu/drm/i915/gt/intel_context.c bool intel_context_ban(struct intel_context *ce, struct i915_request *rq) · line 629
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_context.c +9
-1- ce->ops->revoke (ce, rq, ce->engine->props.preempt_timeout_ms); +if (!ret &&intel_engine_uses_guc (ce->engine)) { +/* +* With GuC backend we have to notify it of revocation as soon +* as the exiting flag is set. +*/ +if (ce->ops->revoke) + ce->ops->revoke (ce,NULL , + ce->engine->props.preempt_timeout_ms); + }
Now revoke is called only with GuC, previously it was called also for other backends in case non-exiting/non-persistent, is it OK?
Quoted 92 lines
drivers/gpu/drm/i915/gt/intel_context.c +0
-0return ret; }drivers/gpu/drm/i915/gt/intel_context.h +1
-7@@ -319,18 +319,12 @@ static inline bool intel_context_is_schedulable(const struct intel_context *ce) !test_bit (CONTEXT_BANNED , &ce->flags); } -static inline bool intel_context_is_exiting (const struct intel_context *ce) -{ -return test_bit (CONTEXT_EXITING , &ce->flags); -} -static inline bool intel_context_set_exiting (struct intel_context *ce) {return test_and_set_bit (CONTEXT_EXITING , &ce->flags); } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq); +bool intel_context_revoke (struct intel_context *ce);static inline bool intel_context_force_single_submission (const struct intel_context *ce)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +11
-11@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc *guc, struct i915_request *rq)* Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ -if (unlikely (intel_context_is_banned (ce))) { +if (unlikely (!intel_context_is_schedulable (ce))) {i915_request_put (i915_request_mark_eio (rq));intel_engine_signal_breadcrumbs (ce->engine);return 0 ;@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) {struct intel_context *ce =request_to_scheduling_context (rq); -int ret =0 ; +int ret; -if (likely (!intel_context_is_banned (ce))) { - ret =__guc_wq_item_append (rq); +if (unlikely (!intel_context_is_schedulable (ce))) +return 0 ; -if (unlikely (ret == -EBUSY )) { - guc->stalled_request = rq; - guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; - } + ret =__guc_wq_item_append (rq); +if (unlikely (ret == -EBUSY )) { + guc->stalled_request = rq; + guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; }return ret;@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request *rq)* submitting all the requests generated in parallel. */ return test_bit (I915_FENCE_FLAG_SUBMIT_PARALLEL , &rq->fence.flags) || -intel_context_is_banned (ce); + !intel_context_is_schedulable (ce); }static int guc_dequeue_one_context (struct intel_guc *guc)@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc)struct intel_context *ce =request_to_scheduling_context (last);if (unlikely (!ctx_id_mapped (guc, ce->guc_id.id) && - !intel_context_is_banned (ce))) { +intel_context_is_schedulable (ce))) { ret =try_context_registration (ce, false);if (unlikely (ret == -EPIPE )) { goto deadlk;@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) {struct intel_engine_cs *engine =__context_to_physical_engine (ce); -if (intel_context_is_banned (ce)) +if (!intel_context_is_schedulable (ce))return ;GEM_BUG_ON (!intel_context_is_pinned (ce));@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(struct intel_guc *guc, {
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_handle_context_reset(struct intel_guc *guc, · line 4526
Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2
-2trace_intel_context_reset (ce); -if (likely (!intel_context_is_banned (ce))) { +if (likely (intel_context_is_schedulable (ce))) {capture_error_state (guc, ce);guc_context_replay (ce); }else { drm_info(&guc_to_gt(guc)->i915->drm, - "Ignoring context reset notification of banned context 0x%04X on %s", + "Ignoring context reset notification of exiting context 0x%04X on %s",
With small clarifications:
Regards
Andrzej
Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0ce->guc_id.id, ce->engine->name); } }
Quoted 12 lines · Andrzej Hajda
Quoted 11 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of
intel_context_is_bannedin the GuC backend needed replacing with newly introducedintel_context_is_schedulable.
Quoted 6 lines
Quoted 4 lines
Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing
intel_context_is_bannedwithintel_context_is_schedulable, which should always be safe since latter is a superset of the former.negation of the latter is a ...?
I did not get what you meant here.
Quoted 48 lines
Quoted 48 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 45c64ecf97ee ("drm/i915: Improve user experience and driver robustness under SIGINT or similar")Cc Andrzej Hajda <[email protected]>Cc John Harrison <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 14 +++++++--- drivers/gpu/drm/i915/gt/intel_context.h | 8 +-----.../gpu/drm/i915/gt/uc/intel_guc_submission.c| 26 +++++++++----------4 files changed, 25 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-6@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines,bool exit, bool persistent) */ for_each_gem_engine(ce, engines, it) { struct intel_engine_cs *engine; - bool skip = false; - if (exit) - skip = intel_context_set_exiting(ce); - else if (!persistent) - skip = intel_context_exit_nonpersistent(ce, NULL); > - - if (skip) + if ((exit || !persistent) && intel_context_revoke(ce))continue; /* Already marked. */
/*drivers/gpu/drm/i915/gt/intel_context.c +4
-4@@ -614,13 +614,19 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq) return ret; } -bool intel_context_exit_nonpersistent (struct intel_context *ce, - struct i915_request *rq) +bool intel_context_revoke (struct intel_context *ce) { bool ret = intel_context_set_exiting(ce); - if (ce->ops->revoke) - ce->ops->revoke(ce, rq, ce->engine->props.preempt_timeout_ms); + if (!ret && intel_engine_uses_guc(ce->engine)) { + /* +* With GuC backend we have to notify it of revocation as soon
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_context.c bool intel_context_ban(struct intel_context *ce, struct i915_request *rq) · line 629
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_context.c +6
-0+* as the exiting flag is set. +*/ + if (ce->ops->revoke) + ce->ops->revoke(ce, NULL, + ce->engine->props.preempt_timeout_ms); + }Now revoke is called only with GuC, previously it was called also for other backends in case non-exiting/non-persistent, is it OK?
It is okay (execlists has no revoke vfunc, ringbuffer has it but only works if target request is known), but agreed it is a bit ugly. I was in two minds which way to go. Perhaps it would indeed be cleaner to go unconditional. I will resend with that change, copying stable this time round (since 6.0 is out), and can keep your r-b?
Regards,
Tvrtko
Quoted 113 lines
Quoted 90 lines
drivers/gpu/drm/i915/gt/intel_context.c +0
-0return ret; }drivers/gpu/drm/i915/gt/intel_context.h +1
-7@@ -319,18 +319,12 @@ static inline bool intel_context_is_schedulable(const struct intel_context *ce) !test_bit(CONTEXT_BANNED, &ce->flags); } -static inline bool intel_context_is_exiting (const struct intel_context *ce) -{ - return test_bit(CONTEXT_EXITING, &ce->flags); -} - static inline bool intel_context_set_exiting(struct intel_context *ce) { return test_and_set_bit(CONTEXT_EXITING, &ce->flags); } -bool intel_context_exit_nonpersistent (struct intel_context *ce, - struct i915_request *rq); +bool intel_context_revoke (struct intel_context *ce);static inline bool
intel_context_force_single_submission(const struct intel_context *ce)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1
-1@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc*guc, struct i915_request *rq) * Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ - if (unlikely(intel_context_is_banned(ce))) { + if (unlikely(!intel_context_is_schedulable(ce))) { i915_request_put(i915_request_mark_eio(rq)); intel_engine_signal_breadcrumbs(ce->engine);return 0;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +7
-7@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) { struct intel_context *ce = request_to_scheduling_context(rq); - int ret = 0; + int ret; - if (likely(!intel_context_is_banned(ce))) { - ret = __guc_wq_item_append(rq); + if (unlikely(!intel_context_is_schedulable(ce))) + return 0; - if (unlikely(ret == -EBUSY)) { - guc->stalled_request = rq; - guc->submission_stall_reason = STALL_MOVE_LRC_TAIL; - } + ret = __guc_wq_item_append(rq); + if (unlikely(ret == -EBUSY)) { + guc->stalled_request = rq; + guc->submission_stall_reason = STALL_MOVE_LRC_TAIL; } return ret;@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request *rq)* submitting all the requests generated in parallel. */ return
test_bit(I915_FENCE_FLAG_SUBMIT_PARALLEL, &rq->fence.flags)|| -intel_context_is_banned(ce);
+ !intel_context_is_schedulable(ce);
}
static intguc_dequeue_one_context(struct intel_guc *guc)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc) struct intel_context *ce = request_to_scheduling_context(last);if (unlikely(!ctx_id_mapped(guc,
ce->guc_id.id) && - !intel_context_is_banned(ce))) { +intel_context_is_schedulable(ce))) { ret =try_context_registration(ce, false); if (unlikely(ret ==-EPIPE)) {
goto deadlk;drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1
-1@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) { struct intel_engine_cs *engine = __context_to_physical_engine(ce); - if (intel_context_is_banned(ce)) + if (!intel_context_is_schedulable(ce)) return; GEM_BUG_ON(!intel_context_is_pinned(ce));@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(structintel_guc *guc, { trace_intel_context_reset(ce);drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_handle_context_reset(struct · line 4528
Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2
-2- if (likely(!intel_context_is_banned(ce))) { + if (likely(intel_context_is_schedulable(ce))) { capture_error_state(guc, ce); guc_context_replay(ce); } else { drm_info(&guc_to_gt(guc)->i915->drm, - "Ignoring context reset notification of banned context 0x%04X on %s", + "Ignoring context reset notification of exiting context 0x%04X on %s",With small clarifications:
Reviewed-by Andrzej Hajda <[email protected]>Regards
AndrzejQuoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0ce->guc_id.id, ce->engine->name);}
}
Quoted 80 lines · Tvrtko Ursulin
Quoted 12 lines · Andrzej Hajda
Quoted 11 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of
intel_context_is_bannedin the GuC backend needed replacing with newly introducedintel_context_is_schedulable.Quoted 6 lines
Quoted 4 lines
Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing
intel_context_is_bannedwithintel_context_is_schedulable, which should always be safe since latter is a superset of the former.negation of the latter is a ...?
I did not get what you meant here.
Quoted 48 lines
Quoted 48 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 45c64ecf97ee ("drm/i915: Improve user experience and driver robustness under SIGINT or similar")Cc Andrzej Hajda <[email protected]>Cc John Harrison <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 14 +++++++--- drivers/gpu/drm/i915/gt/intel_context.h | 8 +-----.../gpu/drm/i915/gt/uc/intel_guc_submission.c| 26 +++++++++----------4 files changed, 25 insertions(+), 31 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-6@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines,bool exit, bool persistent) */ for_each_gem_engine(ce, engines, it) { struct intel_engine_cs *engine; - bool skip = false; - if (exit) - skip = intel_context_set_exiting(ce); - else if (!persistent) - skip = intel_context_exit_nonpersistent(ce, NULL); > - - if (skip) + if ((exit || !persistent) && intel_context_revoke(ce))continue; /* Already marked. */
/*drivers/gpu/drm/i915/gt/intel_context.c +4
-4@@ -614,13 +614,19 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq) return ret; } -bool intel_context_exit_nonpersistent (struct intel_context *ce, - struct i915_request *rq) +bool intel_context_revoke (struct intel_context *ce) { bool ret = intel_context_set_exiting(ce); - if (ce->ops->revoke) - ce->ops->revoke(ce, rq, ce->engine->props.preempt_timeout_ms); + if (!ret && intel_engine_uses_guc(ce->engine)) { + /* +* With GuC backend we have to notify it of revocation as soon Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_context.c bool intel_context_ban(struct intel_context *ce, struct i915_request *rq) · line 629
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_context.c +6
-0+* as the exiting flag is set. +*/ + if (ce->ops->revoke) + ce->ops->revoke(ce, NULL, + ce->engine->props.preempt_timeout_ms); + }Now revoke is called only with GuC, previously it was called also for other backends in case non-exiting/non-persistent, is it OK?
Quoted 1 line
It is okay (execlists has no revoke vfunc, ringbuffer has it but only works if target request is known), but agreed it is a bit ugly. I was in two minds which way to go. Perhaps it would indeed be cleaner to go unconditional. I will resend with that change, copying stable this time round (since 6.0 is out), and can keep your r-b?
Yes, please keep r-b.
Regards
Andrzej
Quoted 119 lines
Regards,
Tvrtko
Quoted 114 lines
Quoted 91 lines
drivers/gpu/drm/i915/gt/intel_context.c +0
-0return ret; }drivers/gpu/drm/i915/gt/intel_context.h +1
-7@@ -319,18 +319,12 @@ static inline bool intel_context_is_schedulable(const struct intel_context *ce) !test_bit(CONTEXT_BANNED, &ce->flags); } -static inline bool intel_context_is_exiting (const struct intel_context *ce) -{ - return test_bit(CONTEXT_EXITING, &ce->flags); -} - static inline bool intel_context_set_exiting(struct intel_context *ce) { return test_and_set_bit(CONTEXT_EXITING, &ce->flags); } -bool intel_context_exit_nonpersistent (struct intel_context *ce, - struct i915_request *rq); +bool intel_context_revoke (struct intel_context *ce);static inline bool
intel_context_force_single_submission(const struct intel_context *ce)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1
-1@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc*guc, struct i915_request *rq) * Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ - if (unlikely(intel_context_is_banned(ce))) { + if (unlikely(!intel_context_is_schedulable(ce))) { i915_request_put(i915_request_mark_eio(rq)); intel_engine_signal_breadcrumbs(ce->engine);return 0;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +7
-7@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) { struct intel_context *ce = request_to_scheduling_context(rq); - int ret = 0; + int ret; - if (likely(!intel_context_is_banned(ce))) { - ret = __guc_wq_item_append(rq); + if (unlikely(!intel_context_is_schedulable(ce))) + return 0; - if (unlikely(ret == -EBUSY)) { - guc->stalled_request = rq; - guc->submission_stall_reason = STALL_MOVE_LRC_TAIL; - } + ret = __guc_wq_item_append(rq); + if (unlikely(ret == -EBUSY)) { + guc->stalled_request = rq; + guc->submission_stall_reason = STALL_MOVE_LRC_TAIL; } return ret;@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request*rq) * submitting all the requests generated in parallel. */ return
test_bit(I915_FENCE_FLAG_SUBMIT_PARALLEL, &rq->fence.flags)|| -intel_context_is_banned(ce);
+ !intel_context_is_schedulable(ce);
}
static intguc_dequeue_one_context(struct intel_guc *guc)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc) struct intel_context *ce = request_to_scheduling_context(last);if (unlikely(!ctx_id_mapped(guc,
ce->guc_id.id) && - !intel_context_is_banned(ce))) { +intel_context_is_schedulable(ce))) { ret =try_context_registration(ce, false); if (unlikely(ret ==-EPIPE)) {
goto deadlk;drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1
-1@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) { struct intel_engine_cs *engine = __context_to_physical_engine(ce); - if (intel_context_is_banned(ce)) + if (!intel_context_is_schedulable(ce)) return; GEM_BUG_ON(!intel_context_is_pinned(ce));@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(structintel_guc *guc, { trace_intel_context_reset(ce);drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_handle_context_reset(struct · line 4528
Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2
-2- if (likely(!intel_context_is_banned(ce))) { + if (likely(intel_context_is_schedulable(ce))) { capture_error_state(guc, ce); guc_context_replay(ce); } else { drm_info(&guc_to_gt(guc)->i915->drm, - "Ignoring context reset notification of banned context 0x%04X on %s", + "Ignoring context reset notification of exiting context 0x%04X on %s",With small clarifications:
Reviewed-by Andrzej Hajda <[email protected]>Regards
AndrzejQuoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0ce->guc_id.id, ce->engine->name);}
}
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Fix revocation of non-persistent contexts
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/guc: Fix revocation of non-persistent contexts
URL : https://patchwork.freedesktop.org/series/109299/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12202_full -> Patchwork_109299v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_109299v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [FAIL][50]) ([i915#4392])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk9/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk9/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk8/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk5/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk7/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk7/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk8/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk9/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk9/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-4x:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#1839])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@gem_eio@kms:
- shard-tglb: [PASS][52] -> [FAIL][53] ([i915#5784])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-tglb5/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb3/igt@[email protected]
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][54] -> [SKIP][55] ([i915#4525])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb7/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][56] -> [FAIL][57] ([i915#2842])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-tglb8/igt@gem_exec_fair@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@bcs0:
- shard-tglb: NOTRUN -> [FAIL][58] ([i915#2842]) +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][59] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][60] -> [FAIL][61] ([i915#2842]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@parallel-random:
- shard-glk: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#4613])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk7/igt@[email protected]
* igt@gem_vm_create@invalid-create:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271]) +25 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-snb5/igt@[email protected]
* igt@gen7_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109289])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][65] -> [DMESG-WARN][66] ([i915#5591])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-tglb5/igt@i915_selftest@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb3/igt@i915_selftest@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#5286]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: [PASS][68] -> [FAIL][69] ([i915#3743])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#111615])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk7/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#3689])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@kms_ccs@pipe-d-crc-primary-rotation-180-y_tiled_ccs.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-apl3/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109284] / [fdo#111827]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_content_protection@dp-mst-type-1:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#3116] / [i915#3299])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@cursor-rapid-movement-32x32:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3555])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1:
- shard-apl: [PASS][77] -> [DMESG-WARN][78] ([i915#180]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-apl7/igt@kms_cursor_crc@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-apl8/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][79] -> [FAIL][80] ([i915#2346])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk5/igt@kms_cursor_legacy@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk2/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109274] / [fdo#111825] / [i915#3637])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][82] -> [FAIL][83] ([i915#79])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk5/igt@kms_flip@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-hdmi-a1:
- shard-glk: [PASS][84] -> [FAIL][85] ([i915#2122])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk1/igt@kms_flip@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#2587] / [i915#2672])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#2587] / [i915#2672])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#2672]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][89] -> [SKIP][90] ([i915#3555])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109280] / [fdo#111825]) +5 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#6497])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#109274] / [fdo#111825])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-a-dp-1:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271]) +19 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-apl3/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#2920])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][96] -> [SKIP][97] ([fdo#109441]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@kms_psr@psr2_primary_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][98] -> [SKIP][99] ([i915#5519])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-tglb3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb8/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [DMESG-WARN][100] ([i915#180]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-apl6/igt@gem_ctx_isolation@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-apl3/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][102] ([i915#4525]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb3/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][104] ([i915#5566] / [i915#716]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk7/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk7/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1:
- shard-snb: [SKIP][106] ([fdo#109271]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-snb6/igt@kms_cursor_crc@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-snb2/igt@kms_cursor_crc@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][108] ([i915#4767]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-apl6/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-apl8/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][110] ([i915#3555]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][112] ([i915#5176]) -> [PASS][113] +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@kms_plane_scaling@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [SKIP][114] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb6/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][116] ([fdo#109441]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][118] ([i915#5519]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb7/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb7/igt@[email protected]
* igt@kms_rotation_crc@sprite-rotation-180:
- shard-tglb: [INCOMPLETE][120] -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-tglb8/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-tglb7/igt@[email protected]
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: [FAIL][122] ([i915#43]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-glk5/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-glk2/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-apl: [FAIL][124] ([i915#5639]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-apl6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-apl3/igt@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][126] ([i915#6117]) -> [SKIP][127] ([i915#4525])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][128] ([i915#658]) -> [SKIP][129] ([i915#2920])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb6/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][130] ([i915#2920]) -> [SKIP][131] ([i915#658])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][132] ([i915#2920]) -> [SKIP][133] ([fdo#111068] / [i915#658]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12202/shard-iclb2/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/shard-iclb3/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12202 -> Patchwork_109299v1
CI-20190529: 20190529
CI_DRM_12202: 0b9f0501c9541cf79fdfb43a7760360a81453d88 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6670: d618e9865fe5cbaf511ca43503abad442605d0a5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109299v1: 0b9f0501c9541cf79fdfb43a7760360a81453d88 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v1/index.html
PATCH v2 1/1 drm/i915/guc: Fix revocation of non-persistent contexts
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of intel_context_is_banned in the GuC backend needed replacing with newly introduced intel_context_is_schedulable.
Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing intel_context_is_banned with intel_context_is_schedulable, which should always be safe since latter is a superset of the former.
v2:
* Just call ce->ops->revoke unconditionally. (Andrzej)
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 5 ++-- drivers/gpu/drm/i915/gt/intel_context.h | 3 +-- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 26 +++++++++---------- 4 files changed, 17 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.c +1 -7
@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines, bool exit, bool persistent)*/ for_each_gem_engine (ce, engines, it) {struct intel_engine_cs *engine; -bool skip = false; -if (exit) - skip =intel_context_set_exiting (ce); -else if (!persistent) - skip =intel_context_exit_nonpersistent (ce,NULL ); - -if (skip) +if ((exit || !persistent) &&intel_context_revoke (ce))continue ;/* Already marked. */ /*
drivers/gpu/drm/i915/gt/intel_context.c +2 -3
@@ -614,13 +614,12 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq)return ret; } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq) +bool intel_context_revoke (struct intel_context *ce) {bool ret =intel_context_set_exiting (ce);if (ce->ops->revoke) - ce->ops->revoke (ce, rq, ce->engine->props.preempt_timeout_ms); + ce->ops->revoke (ce,NULL , ce->engine->props.preempt_timeout_ms);return ret; }
drivers/gpu/drm/i915/gt/intel_context.h +1 -2
@@ -329,8 +329,7 @@ static inline bool intel_context_set_exiting(struct intel_context *ce)return test_and_set_bit (CONTEXT_EXITING , &ce->flags); } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq); +bool intel_context_revoke (struct intel_context *ce);static inline bool intel_context_force_single_submission (const struct intel_context *ce)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +13 -13
@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc *guc, struct i915_request *rq)* Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ -if (unlikely (intel_context_is_banned (ce))) { +if (unlikely (!intel_context_is_schedulable (ce))) {i915_request_put (i915_request_mark_eio (rq));intel_engine_signal_breadcrumbs (ce->engine);return 0 ;
@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) {struct intel_context *ce =request_to_scheduling_context (rq); -int ret =0 ; +int ret; -if (likely (!intel_context_is_banned (ce))) { - ret =__guc_wq_item_append (rq); +if (unlikely (!intel_context_is_schedulable (ce))) +return 0 ; -if (unlikely (ret == -EBUSY )) { - guc->stalled_request = rq; - guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; - } + ret =__guc_wq_item_append (rq); +if (unlikely (ret == -EBUSY )) { + guc->stalled_request = rq; + guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; }return ret;
@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request *rq)* submitting all the requests generated in parallel. */ return test_bit (I915_FENCE_FLAG_SUBMIT_PARALLEL , &rq->fence.flags) || -intel_context_is_banned (ce); + !intel_context_is_schedulable (ce); }static int guc_dequeue_one_context (struct intel_guc *guc)
@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc)struct intel_context *ce =request_to_scheduling_context (last);if (unlikely (!ctx_id_mapped (guc, ce->guc_id.id) && - !intel_context_is_banned (ce))) { +intel_context_is_schedulable (ce))) { ret =try_context_registration (ce, false);if (unlikely (ret == -EPIPE )) { goto deadlk;
@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) {struct intel_engine_cs *engine =__context_to_physical_engine (ce); -if (intel_context_is_banned (ce)) +if (!intel_context_is_schedulable (ce))return ;GEM_BUG_ON (!intel_context_is_pinned (ce));
@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(struct intel_guc *guc, {trace_intel_context_reset (ce); -if (likely (!intel_context_is_banned (ce))) { +if (likely (intel_context_is_schedulable (ce))) {capture_error_state (guc, ce);guc_context_replay (ce); }else {drm_info (&guc_to_gt (guc)->i915->drm, -"Ignoring context reset notification of banned context 0x%04X on %s" , +"Ignoring context reset notification of exiting context 0x%04X on %s" , ce->guc_id.id, ce->engine->name); } }
Signature · 1 line
2.34.1
Quoted 11 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of
intel_context_is_bannedin the GuC backend needed replacing with newly introducedintel_context_is_schedulable.
Quoted 7 lines
Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing
intel_context_is_bannedwithintel_context_is_schedulable, which should always be safe since latter is a superset of the former.v2:
* Just callce->ops->revokeunconditionally. (Andrzej)
CI is happy - could I get some acks for the GuC backend changes please?
Regards,
Tvrtko
Quoted 146 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 45c64ecf97ee ("drm/i915: Improve user experience and driver robustness under SIGINT or similar")Cc Andrzej Hajda <[email protected]>Cc John Harrison <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc <[email protected]> # v6.0+Reviewed-by Andrzej Hajda <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 5 ++-- drivers/gpu/drm/i915/gt/intel_context.h | 3 +-- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 26 +++++++++---------- 4 files changed, 17 insertions(+), 25 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-7@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines, bool exit, bool persistent)*/ for_each_gem_engine (ce, engines, it) {struct intel_engine_cs *engine; -bool skip = false; -if (exit) - skip =intel_context_set_exiting (ce); -else if (!persistent) - skip =intel_context_exit_nonpersistent (ce,NULL ); - -if (skip) +if ((exit || !persistent) &&intel_context_revoke (ce))continue ;/* Already marked. */ /* drivers/gpu/drm/i915/gt/intel_context.c +2
-3@@ -614,13 +614,12 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq)return ret; } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq) +bool intel_context_revoke (struct intel_context *ce) {bool ret =intel_context_set_exiting (ce);if (ce->ops->revoke) - ce->ops->revoke (ce, rq, ce->engine->props.preempt_timeout_ms); + ce->ops->revoke (ce,NULL , ce->engine->props.preempt_timeout_ms);return ret; }drivers/gpu/drm/i915/gt/intel_context.h +1
-2@@ -329,8 +329,7 @@ static inline bool intel_context_set_exiting(struct intel_context *ce)return test_and_set_bit (CONTEXT_EXITING , &ce->flags); } -bool intel_context_exit_nonpersistent (struct intel_context *ce, -struct i915_request *rq); +bool intel_context_revoke (struct intel_context *ce);static inline bool intel_context_force_single_submission (const struct intel_context *ce)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +13
-13@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc *guc, struct i915_request *rq)* Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ -if (unlikely (intel_context_is_banned (ce))) { +if (unlikely (!intel_context_is_schedulable (ce))) {i915_request_put (i915_request_mark_eio (rq));intel_engine_signal_breadcrumbs (ce->engine);return 0 ;@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) {struct intel_context *ce =request_to_scheduling_context (rq); -int ret =0 ; +int ret; -if (likely (!intel_context_is_banned (ce))) { - ret =__guc_wq_item_append (rq); +if (unlikely (!intel_context_is_schedulable (ce))) +return 0 ; -if (unlikely (ret == -EBUSY )) { - guc->stalled_request = rq; - guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; - } + ret =__guc_wq_item_append (rq); +if (unlikely (ret == -EBUSY )) { + guc->stalled_request = rq; + guc->submission_stall_reason =STALL_MOVE_LRC_TAIL ; }return ret;@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request *rq)* submitting all the requests generated in parallel. */ return test_bit (I915_FENCE_FLAG_SUBMIT_PARALLEL , &rq->fence.flags) || -intel_context_is_banned (ce); + !intel_context_is_schedulable (ce); }static int guc_dequeue_one_context (struct intel_guc *guc)@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc)struct intel_context *ce =request_to_scheduling_context (last);if (unlikely (!ctx_id_mapped (guc, ce->guc_id.id) && - !intel_context_is_banned (ce))) { +intel_context_is_schedulable (ce))) { ret =try_context_registration (ce, false);if (unlikely (ret == -EPIPE )) { goto deadlk;@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) {struct intel_engine_cs *engine =__context_to_physical_engine (ce); -if (intel_context_is_banned (ce)) +if (!intel_context_is_schedulable (ce))return ;GEM_BUG_ON (!intel_context_is_pinned (ce));@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(struct intel_guc *guc, {trace_intel_context_reset (ce); -if (likely (!intel_context_is_banned (ce))) { +if (likely (intel_context_is_schedulable (ce))) {capture_error_state (guc, ce);guc_context_replay (ce); }else {drm_info (&guc_to_gt (guc)->i915->drm, -"Ignoring context reset notification of banned context 0x%04X on %s" , +"Ignoring context reset notification of exiting context 0x%04X on %s" , ce->guc_id.id, ce->engine->name); } }
Ceraolo Spurio, Daniele
Acked-byQuoted 18 lines · Tvrtko Ursulin
Quoted 16 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of
intel_context_is_bannedin the GuC backend needed replacing with newly introducedintel_context_is_schedulable.Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing
intel_context_is_bannedwithintel_context_is_schedulable, which should always be safe since latter is a superset of the former.
Quoted 4 lines
Quoted 2 lines
v2:
* Just callce->ops->revokeunconditionally. (Andrzej)CI is happy - could I get some acks for the GuC backend changes please?
I think we still need to have a longer conversation on the revoking times, but in the meantime this fixes the immediate concerns, so:
Daniele
Quoted 148 lines
Regards,
Tvrtko
Quoted 143 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Fixes 45c64ecf97ee ("drm/i915: Improve user experience and driver robustness under SIGINT or similar")Cc Andrzej Hajda <[email protected]>Cc John Harrison <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc <[email protected]> # v6.0+Reviewed-by Andrzej Hajda <[email protected]>---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +----- drivers/gpu/drm/i915/gt/intel_context.c | 5 ++-- drivers/gpu/drm/i915/gt/intel_context.h | 3 +--.../gpu/drm/i915/gt/uc/intel_guc_submission.c| 26 +++++++++----------4 files changed, 17 insertions(+), 25 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-6@@ -1387,14 +1387,8 @@ kill_engines(struct i915_gem_engines *engines,bool exit, bool persistent) */ for_each_gem_engine(ce, engines, it) { struct intel_engine_cs *engine; - bool skip = false; - if (exit) - skip = intel_context_set_exiting(ce); - else if (!persistent) - skip = intel_context_exit_nonpersistent(ce, NULL); - - if (skip) + if ((exit || !persistent) && intel_context_revoke(ce))continue; /* Already marked. */
/*drivers/gpu/drm/i915/gt/intel_context.c +2
-2@@ -614,13 +614,12 @@ bool intel_context_ban(struct intel_context *ce, struct i915_request *rq) return ret; } -bool intel_context_exit_nonpersistent(struct intel_context *ce, - struct i915_request *rq) +bool intel_context_revoke(struct intel_context *ce) { bool ret = intel_context_set_exiting(ce); if (ce->ops->revoke) - ce->ops->revoke(ce, rq, ce->engine->props.preempt_timeout_ms); + ce->ops->revoke(ce, NULL, ce->engine->props.preempt_timeout_ms); return ret; }drivers/gpu/drm/i915/gt/intel_context.h +1
-1@@ -329,8 +329,7 @@ static inline bool intel_context_set_exiting(struct intel_context *ce) return test_and_set_bit(CONTEXT_EXITING, &ce->flags); } -bool intel_context_exit_nonpersistent(struct intel_context *ce, - struct i915_request *rq); +bool intel_context_revoke(struct intel_context *ce);static inline bool
intel_context_force_single_submission(const struct intel_context *ce)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1
-1@@ -685,7 +685,7 @@ static int __guc_add_request(struct intel_guc*guc, struct i915_request *rq) * Corner case where requests were sitting in the priority list or a * request resubmitted after the context was banned. */ - if (unlikely(intel_context_is_banned(ce))) { + if (unlikely(!intel_context_is_schedulable(ce))) { i915_request_put(i915_request_mark_eio(rq)); intel_engine_signal_breadcrumbs(ce->engine);return 0;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +7
-5@@ -871,15 +871,15 @@ static int guc_wq_item_append(struct intel_guc *guc, struct i915_request *rq) { struct intel_context *ce = request_to_scheduling_context(rq); - int ret = 0; + int ret; - if (likely(!intel_context_is_banned(ce))) { - ret = __guc_wq_item_append(rq); + if (unlikely(!intel_context_is_schedulable(ce))) + return 0; - if (unlikely(ret == -EBUSY)) { - guc->stalled_request = rq; - guc->submission_stall_reason = STALL_MOVE_LRC_TAIL; - } + ret = __guc_wq_item_append(rq); + if (unlikely(ret == -EBUSY)) { + guc->stalled_request = rq; + guc->submission_stall_reason = STALL_MOVE_LRC_TAIL; } return ret;@@ -898,7 +898,7 @@ static bool multi_lrc_submit(struct i915_request*rq) * submitting all the requests generated in parallel. */ return
test_bit(I915_FENCE_FLAG_SUBMIT_PARALLEL, &rq->fence.flags)|| -intel_context_is_banned(ce);
+ !intel_context_is_schedulable(ce);
}
static intguc_dequeue_one_context(struct intel_guc *guc)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0@@ -967,7 +967,7 @@ static int guc_dequeue_one_context(struct intel_guc *guc) struct intel_context *ce = request_to_scheduling_context(last);if (unlikely(!ctx_id_mapped(guc,
ce->guc_id.id) && - !intel_context_is_banned(ce))) {
+intel_context_is_schedulable(ce))) { ret =try_context_registration(ce, false); if (unlikely(ret ==-EPIPE)) {
goto deadlk;drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +3
-1@@ -1577,7 +1577,7 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub) { struct intel_engine_cs *engine = __context_to_physical_engine(ce); - if (intel_context_is_banned(ce)) + if (!intel_context_is_schedulable(ce)) return; GEM_BUG_ON(!intel_context_is_pinned(ce));@@ -4518,12 +4518,12 @@ static void guc_handle_context_reset(struct intel_guc *guc, { trace_intel_context_reset(ce); - if (likely(!intel_context_is_banned(ce))) { + if (likely(intel_context_is_schedulable(ce))) { capture_error_state(guc, ce); guc_context_replay(ce); } else { drm_info(&guc_to_gt(guc)->i915->drm, - "Ignoring context reset notification of banned context 0x%04X on %s", + "Ignoring context reset notification of exiting context 0x%04X on %s",
ce->guc_id.id,ce->engine->name);
}
}
Quoted 19 lines · Daniele
Quoted 18 lines · Tvrtko Ursulin
Quoted 16 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Patch which added graceful exit for non-persistent contexts missed the fact it is not enough to set the exiting flag on a context and let the backend handle it from there.
GuC backend cannot handle it because it runs independently in the firmware and driver might not see the requests ever again. Patch also missed the fact some usages of
intel_context_is_bannedin the GuC backend needed replacing with newly introducedintel_context_is_schedulable.Fix the first issue by calling into backend revoke when we know this is the last chance to do it. Fix the second issue by replacing
intel_context_is_bannedwithintel_context_is_schedulable, which should always be safe since latter is a superset of the former.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
v2:
* Just callce->ops->revokeunconditionally. (Andrzej)CI is happy - could I get some acks for the GuC backend changes please?
I think we still need to have a longer conversation on the revoking times, but in the meantime this fixes the immediate concerns, so:
Thanks, I've pushed it so should unbreak 6.0 via stable.
For follow up work I am okay either with a fixes 20ms timeout (this was enough for users which originally reported it), or go with fully configurable? Latter feels a bit over the top since it would then me a kconfig and sysfs to align with the normal preempt timeout.
Regards,
Tvrtko
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix revocation of non-persistent contexts (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/guc: Fix revocation of non-persistent contexts (rev2)
URL : https://patchwork.freedesktop.org/series/109299/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12204 -> Patchwork_109299v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/index.html
Participating hosts (48 -> 42)
------------------------------
Additional (2): bat-dg2-11 fi-rkl-11600
Missing (8): fi-tgl-u2 fi-hsw-4200u fi-glk-dsi fi-ctg-p8600 fi-hsw-4770 fi-pnv-d510 fi-bsw-nick fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_109299v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][2] ([fdo#109271]) +19 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-bdw-gvtdvm/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#3012])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][6] ([i915#4817])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-bdw-gvtdvm/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][7] ([i915#5982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([fdo#111827]) +7 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][9] ([i915#4103])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][10] -> [FAIL][11] ([i915#6298])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([fdo#109285] / [i915#4098])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#1072]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#3555] / [i915#4098])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3301] / [i915#3708])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-11600/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@load:
- fi-bdw-gvtdvm: [DMESG-WARN][17] ([i915#6540]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/fi-bdw-gvtdvm/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-bdw-gvtdvm/igt@[email protected]
* igt@i915_selftest@live@mman:
- fi-rkl-guc: [INCOMPLETE][19] ([i915#6794]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/fi-rkl-guc/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-rkl-guc/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][21] ([i915#4983]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/bat-rpls-1/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_force_connector_basic@force-connector-state:
- fi-bdw-gvtdvm: [DMESG-WARN][23] ([i915#5922]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/fi-bdw-gvtdvm/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/fi-bdw-gvtdvm/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5922]: https://gitlab.freedesktop.org/drm/intel/issues/5922
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6540]: https://gitlab.freedesktop.org/drm/intel/issues/6540
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
Build changes
-------------
* Linux: CI_DRM_12204 -> Patchwork_109299v2
CI-20190529: 20190529
CI_DRM_12204: fd2f9b9a4178e667adad268a662eb8a9c0ddc8f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6670: d618e9865fe5cbaf511ca43503abad442605d0a5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109299v2: fd2f9b9a4178e667adad268a662eb8a9c0ddc8f8 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a4a05514e769 drm/i915/guc: Fix revocation of non-persistent contexts
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Fix revocation of non-persistent contexts (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/guc: Fix revocation of non-persistent contexts (rev2)
URL : https://patchwork.freedesktop.org/series/109299/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12204_full -> Patchwork_109299v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_109299v2_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-apl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [FAIL][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#4386]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl3/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl8/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl8/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl1/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl1/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl3/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl3/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl3/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl8/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl3/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl3/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl3/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl8/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl8/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl7/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl8/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl1/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl1/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][51] ([i915#4991])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl6/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#1099])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-snb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][53] -> [SKIP][54] ([i915#4525]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb5/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][55] -> [DMESG-WARN][56] ([i915#5566] / [i915#716])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-glk5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-glk1/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][57] -> [FAIL][58] ([i915#3989] / [i915#454])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#1937])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/igt@i915_pm_lpsp@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#3886]) +3 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@vga-frame-dump:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +5 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [PASS][62] -> [DMESG-WARN][63] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl8/igt@kms_cursor_crc@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl3/igt@kms_cursor_crc@[email protected]
* igt@kms_flip@2x-nonexisting-fb:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271]) +64 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][65] -> [FAIL][66] ([i915#2122])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-glk2/igt@kms_flip@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [PASS][67] -> [FAIL][68] ([i915#79])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-glk2/igt@kms_flip@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#2587] / [i915#2672]) +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#3555])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][71] -> [SKIP][72] ([i915#3555])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#2672]) +6 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271]) +37 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-snb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][75] -> [SKIP][76] ([i915#5176]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb5/igt@kms_plane_scaling@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][77] -> [SKIP][78] ([fdo#109441]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2994])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [DMESG-WARN][80] ([i915#180]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/igt@gem_ctx_isolation@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl1/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][82] ([i915#4525]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb3/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][84] ([i915#2842]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-glk1/igt@gem_exec_fair@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][86] ([i915#2842]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-tglb1/igt@gem_exec_fair@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][88] ([i915#2190]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-tglb7/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-tglb8/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][90] ([i915#5566] / [i915#716]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl7/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl2/igt@[email protected]
* igt@gen9_exec_parse@bb-large:
- shard-apl: [TIMEOUT][92] ([i915#4639]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-apl2/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-apl7/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][94] ([i915#6992]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-snb4/igt@i915_selftest@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-snb7/igt@i915_selftest@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][96] ([i915#5235]) -> [PASS][97] +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][98] ([fdo#109441]) -> [PASS][99] +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb5/igt@kms_psr@psr2_primary_blt.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][100] ([i915#5639]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-tglb7/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-tglb8/igt@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][102] ([i915#4525]) -> [FAIL][103] ([i915#6117])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb5/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][104] ([i915#588]) -> [SKIP][105] ([i915#658])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb8/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][106] ([i915#658]) -> [SKIP][107] ([i915#2920])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb5/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][108] ([fdo#111068] / [i915#658]) -> [SKIP][109] ([i915#2920])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb5/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][110] ([i915#2920]) -> [SKIP][111] ([i915#658])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12204/shard-iclb2/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/shard-iclb5/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4639]: https://gitlab.freedesktop.org/drm/intel/issues/4639
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6992]: https://gitlab.freedesktop.org/drm/intel/issues/6992
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12204 -> Patchwork_109299v2
CI-20190529: 20190529
CI_DRM_12204: fd2f9b9a4178e667adad268a662eb8a9c0ddc8f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6670: d618e9865fe5cbaf511ca43503abad442605d0a5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109299v2: fd2f9b9a4178e667adad268a662eb8a9c0ddc8f8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109299v2/index.html