Skip to contentSkip to conversation

mm: /proc/pid/smaps_rollup: fix no vma's null-deref

PATCH In review FirstName LastName 3 participants 4 messages Oct 3, 2022 – Oct 4, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: /proc/pid/smaps_rollup: fix no vma's null-deref

From: Seth Jenkins <[email protected]>

Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file") introduced a null-deref if there are no vma's in the task in show_smaps_rollup.

Fixes 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file")
---
 fs/proc/task_mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/proc/task_mmu.c +1 -1
index 4e0023643f8b..1e7bbc0873a4 100644
@@ -969,7 +969,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v)
 		vma = vma->vm_next;
 	}
 
-	show_vma_header_prefix(m, priv->mm->mmap->vm_start,
+	show_vma_header_prefix(m, priv->mm->mmap ? priv->mm->mmap->vm_start : 0,
 			       last_vma_end, 0, 0, 0, 0);
 	seq_pad(m, ' ');
 	seq_puts(m, "[rollup]\n");
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 13 lines · FirstName LastName

From: Seth Jenkins <[email protected]>

Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file") introduced a null-deref if there are no vma's in the task in show_smaps_rollup.

Fixes 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file")

fs/proc/task_mmu.c static int show_smaps_rollup(struct seq_file *m, void *v) · line 975

Quoted 8 lines
fs/proc/task_mmu.c +1 -1
@@ -969,7 +969,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v)
 		vma = vma->vm_next;
 	}
 
-	show_vma_header_prefix(m, priv->mm->mmap->vm_start,
+	show_vma_header_prefix(m, priv->mm->mmap ? priv->mm->mmap->vm_start : 0,
 			       last_vma_end, 0, 0, 0, 0);
 	seq_pad(m, ' ');
 	seq_puts(m, "[rollup]\n");

Now I know how to create stable process without address space.

maintainer
#2 lore raw
In reply to FirstName LastName
Quoted 9 lines · On Mon, 3 Oct 2022 18:45:31 -0400 FirstName LastName <[email protected]>…

From: Seth Jenkins <[email protected]>

Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file") introduced a null-deref if there are no vma's in the task in show_smaps_rollup.

fs/proc/task_mmu.c static int show_smaps_rollup(struct seq_file *m, void *v) · line 975

Quoted 8 lines
fs/proc/task_mmu.c +1 -1
@@ -969,7 +969,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v)
 		vma = vma->vm_next;
 	}
 
-	show_vma_header_prefix(m, priv->mm->mmap->vm_start,
+	show_vma_header_prefix(m, priv->mm->mmap ? priv->mm->mmap->vm_start : 0,
 			       last_vma_end, 0, 0, 0, 0);
 	seq_pad(m, ' ');
 	seq_puts(m, "[rollup]\n");

The current mm tree is very different here. In fact the bug might not exist any more. Please take a look at the mm-stable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm?

If no fixes are needed in mm-stable then I guess the process is to propose this patch to the stable tree maintainers.

#3 lore raw

I concur, mm-stable looks fine to me as well.

Jann and I conversed today and the tentative decision since this isn't considered a high-priority security bug is to wait for maple tree to merge into Linus's branch before submitting this patch to stable.

Quoted 28 lines · Andrew Morton
Quoted 9 lines · On Mon, 3 Oct 2022 18:45:31 -0400 FirstName LastName <[email protected]>…

From: Seth Jenkins <[email protected]>

Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file") introduced a null-deref if there are no vma's in the task in show_smaps_rollup.

fs/proc/task_mmu.c static int show_smaps_rollup(struct seq_file *m, void *v) · line 975

Quoted 8 lines
fs/proc/task_mmu.c +1 -1
@@ -969,7 +969,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v)
              vma = vma->vm_next;
      }
 
-     show_vma_header_prefix(m, priv->mm->mmap->vm_start,
+     show_vma_header_prefix(m, priv->mm->mmap ? priv->mm->mmap->vm_start : 0,
                             last_vma_end, 0, 0, 0, 0);
      seq_pad(m, ' ');
      seq_puts(m, "[rollup]\n");

The current mm tree is very different here. In fact the bug might not exist any more. Please take a look at the mm-stable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm?

If no fixes are needed in mm-stable then I guess the process is to propose this patch to the stable tree maintainers.