Input: atmel_captouch - drop obsolete dependency on COMPILE_TEST
Subsystems (3)
PATCH 1/1 Input: atmel_captouch - drop obsolete dependency on COMPILE_TEST
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.
As a matter of fact, dropping the alternative dependency on COMPILE_TEST allows removing preprocessor directives, which will speed up the build.
--- drivers/input/misc/Kconfig | 2 +- drivers/input/misc/atmel_captouch.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/input/misc/Kconfig +1 -1
@@ -107,7 +107,7 @@ config INPUT_ATC260X_ONKEY config INPUT_ATMEL_CAPTOUCH tristate "Atmel Capacitive Touch Button Driver" - depends on OF || COMPILE_TEST + depends on OF depends on I2C help Say Y here if an Atmel Capacitive Touch Button device which
drivers/input/misc/atmel_captouch.c +1 -3
@@ -249,7 +249,6 @@ static int atmel_captouch_probe(struct ireturn 0 ; } -#ifdef CONFIG_OFstatic const struct of_device_id atmel_captouch_of_id[] = { { .compatible ="atmel,captouch" ,
@@ -257,7 +256,6 @@ static const struct of_device_id atmel_c {/* sentinel */ } };MODULE_DEVICE_TABLE (of, atmel_captouch_of_id); -#endif static const struct i2c_device_id atmel_captouch_id[] = { {"atmel_captouch" ,0 },
@@ -270,7 +268,7 @@ static struct i2c_driver atmel_captouch_ .id_table = atmel_captouch_id, .driver = { .name = "atmel_captouch", - .of_match_table = of_match_ptr(atmel_captouch_of_id), + .of_match_table = atmel_captouch_of_id, }, };module_i2c_driver (atmel_captouch_driver);
Signature · 2 lines
Jean Delvare SUSE L3 Support