Configure default wifi through kconfig

Configure a default basic wifi setup able to automatically connect to the selected access point.

Signed-off-by Angelo Compagnucci <[email protected]>

---
  package/wpa_supplicant/wpa_supplicant.mk | 10 ++++++++++
  system/Config.in                         |  1 +
  2 files changed, 11 insertions(+)

package/wpa_supplicant/wpa_supplicant.mk +0 -0

index 60ae290e26..8611fc6577 100644

package/wpa_supplicant/wpa_supplicant.mk +3 -0

+endef
+SYSTEMD_ROOTFS_PRE_CMD_HOOKS += WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD_PRESET
  endif
 
  define WPA_SUPPLICANT_INSTALL_TARGET_CMDS

@@ -304,6 +313,7 @@ define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
  		$(TARGET_DIR)/usr/lib/systemd/system/[email protected]
  	$(INSTALL) -D -m 644 $(WPA_SUPPLICANT_PKGDIR)/50-wpa_supplicant.preset \
  		$(TARGET_DIR)/usr/lib/systemd/system-preset/50-wpa_supplicant.preset
+	$(WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD)
  endef
 
  $(eval $(generic-package))

system/Config.in +0 -0

index 647072b965..761a5a95c2 100644

Quoted 2 lines · Angelo Compagnucci

Configure a default basic wifi setup able to automatically connect to the selected access point.

I think this feature is indeed useful. IIUC, currently wpa_supplicant actually
isn't started, even though we do install a service file.

Quoted 13 lines

Signed-off-by Angelo Compagnucci <[email protected]>

---
  package/wpa_supplicant/wpa_supplicant.mk | 10 ++++++++++
  system/Config.in                         |  1 +
  2 files changed, 11 insertions(+)

package/wpa_supplicant/wpa_supplicant.mk +0 -0

index 60ae290e26..8611fc6577 100644

package/wpa_supplicant/wpa_supplicant.mk define WPA_SUPPLICANT_ENABLE_WIFI · line 283

Quoted 7 lines

package/wpa_supplicant/wpa_supplicant.mk +4 -0

@@ -277,6 +277,15 @@ define WPA_SUPPLICANT_ENABLE_WIFI
              echo "}"; \
      ) >> $(TARGET_DIR)/etc/wpa_supplicant.conf
  endef
+define WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD
+     $(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/wpa_supplicant/
+     ln -sf ../wpa_supplicant.conf \
+             $(TARGET_DIR)/etc/wpa_supplicant/wpa_supplicant-$(BR2_SYSTEM_DHCP).conf

If the interface-specific service is used rather than the global one, I think
the idea is to be able to use separate conf files for them. So I think it makes more sense to copy than symlink.

That said, I'm not sure if it's really useful to use the per-interface
service. The global one should work as well, no? I think the only thing we're missing is to enable it for the wifi interface.

Also, I don't think it's a good idea to reuse BR2_SYSTEM_DHCP for this. There
are quite a few boards that have both ethernet and wifi and ideally we want both to come up. So I think it's worth adding a BR2_SYSTEM_WLAN to specify the wifi interface - and perhaps automatically select wpa_supplicant if that option is set (although we could just as well use iwd instead of supplicant, of course).

package/wpa_supplicant/wpa_supplicant.mk define WPA_SUPPLICANT_ENABLE_WIFI · line 286

Quoted 3 lines

package/wpa_supplicant/wpa_supplicant.mk +3 -0

+endef
+define WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD_PRESET
+     $(HOST_DIR)/bin/systemctl --root=$(TARGET_DIR) preset wpa_supplicant\@$(BR2_SYSTEM_DHCP).service

I'm not sure what this is supposed to do. Doesn't it just undo the disable we
do in 50-wpa_supplicant.preset? Wouldn't it be better to just remove that preset somehow?

Quoted 18 lines

package/wpa_supplicant/wpa_supplicant.mk +3 -0

+endef
+SYSTEMD_ROOTFS_PRE_CMD_HOOKS += WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD_PRESET
  endif
 
  define WPA_SUPPLICANT_INSTALL_TARGET_CMDS

@@ -304,6 +313,7 @@ define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
              $(TARGET_DIR)/usr/lib/systemd/system/[email protected]
      $(INSTALL) -D -m 644 $(WPA_SUPPLICANT_PKGDIR)/50-wpa_supplicant.preset \
              $(TARGET_DIR)/usr/lib/systemd/system-preset/50-wpa_supplicant.preset
+     $(WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD)
  endef
 
  $(eval $(generic-package))

system/Config.in +0 -0

index 647072b965..761a5a95c2 100644

system/Config.in comment "automatic network configuration via DHCP needs ifupdown or busybox or n · line 424

Quoted 4 lines

system/Config.in +1 -0

@@ -421,6 +421,7 @@ comment "automatic network configuration via DHCP needs ifupdown or busybox or n
  config BR2_SYSTEM_CONNECT_WIFI
      bool "Connect to a default wifi access point"
      depends on BR2_SYSTEM_DHCP != "" && BR2_PACKAGE_WPA_SUPPLICANT
+     select BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE if BR2_PACKAGE_SYSTEMD

This needs some explanation. I don't see the service files requiring this
anywhere.

On the other hand, the global service file does start wpa_supplicant with the
-u option so it would need dbus.

Regards,
Arnout

Quoted 3 lines

system/Config.in +0 -0

  config BR2_SYSTEM_CONNECT_WIFI_SSID
      string "Access point SSID"

Add a proper wpa-conf line to the interfaces files to let the system bring up the wifi interface and the related wpa supplicant.

Signed-off-by Angelo Compagnucci <[email protected]>

---
Changes:
v3:
* add "|| true" lo let the command exit without error when BR2_SYSTEM_CONNECT_WIFI is empty (me)

  package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++
  1 file changed, 2 insertions(+)

package/ifupdown-scripts/ifupdown-scripts.mk +0 -0

index 5ef032142c..ebaf234143 100644

In cases where no hotplug is available (by choice or by the lack of a proper hotplug method for a device), this service can be used to load kernel module drivers by reading the /etc/modules-load.d/*.conf files. The modules files matches the one used by systemd, which in turn has a builtin mechanism to load a module at boot, therefore making systemv init on par with systemd features.

Signed-off-by Angelo Compagnucci <[email protected]>

---
v2:
* Moved script to initscripts (Arnout)
* Moved script to S11modules, after S10[mu]dev (Andreas)
* Use /etc/modules-load.d/ to share the same setup with systemd (me) v4:
* Select only .conf file (Peter)
* Better ouput: printing module name only when loaded successfully, print a FAIL when at least one module fails (Peter)

  package/initscripts/init.d/S11modules | 59 +++++++++++++++++++++++++++
  1 file changed, 59 insertions(+)

create mode 100644 package/initscripts/init.d/S11modules

package/initscripts/init.d/S11modules new file +0 -0

new file mode 100644
index 0000000000..dcc2e79135

package/initscripts/init.d/S11modules new file +41 -0

+		while read module args; do
+
+			case "$module" in
+				""|"#"*) continue ;;
+			esac
+
+			if [ "$1" = "load" ]; then
+				modprobe -q ${module} ${args} >/dev/null && \
+					printf '%s ' "$module" || RET='FAIL'
+			else
+				rmmod ${module} >/dev/null
+			fi
+
+		done < ${module_file}
+	done
+
+	RET='OK'
+}
+
+start() {
+	printf 'Starting modules: '
+
+	load_unload load
+
+	echo $RET
+}
+
+stop() {
+	printf 'Stopping modules: '
+
+	load_unload unload
+
+	echo $RET
+}
+
+restart() {
+	stop
+	sleep 1
+	start
+}
+

This series was born while adding support for a board and feeling the necessity to have the networking options available in .config. I understand that something like that could be done by adding an overlay, but it requires a lot of boilerplate only to be able to connect to a wifi network.

Angelo Compagnucci (5):
system: adding options for configuring wifi package/wpa_supplicant: configure wifi on systemv when enabled package/wpa_supplicant: configure wifi on systemd when enabled package/ifupdown-scripts: add wifi configuration when enabled package/initscripts: add service to load kernel modules at boot

  package/ifupdown-scripts/ifupdown-scripts.mk |  2 +
  package/initscripts/init.d/S11modules        | 59 ++++++++++++++++++++
  package/wpa_supplicant/wpa_supplicant.mk     | 24 ++++++++
  system/Config.in                             | 15 +++++
  4 files changed, 100 insertions(+)

create mode 100644 package/initscripts/init.d/S11modules

Quoted 5 lines · Angelo Compagnucci

This series was born while adding support for a board and feeling the necessity to have the networking options available in .config. I understand that something like that could be done by adding an overlay, but it requires a lot of boilerplate only to be able to connect to a wifi network.

 As you say, it's something that can easily be added in an overlay. In addition, it's something that is only useful in a very specific, very small use case: when you're demonstrating a board of which you use only in a single place and aren't planning to move anywhere else, and when you don't want ot spend time preparing a proper overlay for it.

 So, I'm going to mark this series as rejected.

 That said, there are some useful bits in it, which I'll comment on individually.

 Regards,
 Arnout

Quoted 15 lines

Angelo Compagnucci (5):
   system: adding options for configuring wifi package/wpa_supplicant: configure wifi on systemv when enabled package/wpa_supplicant: configure wifi on systemd when enabled package/ifupdown-scripts: add wifi configuration when enabled package/initscripts: add service to load kernel modules at boot

  package/ifupdown-scripts/ifupdown-scripts.mk |  2 + package/initscripts/init.d/S11modules        | 59 ++++++++++++++++++++ package/wpa_supplicant/wpa_supplicant.mk     | 24 ++++++++ system/Config.in                             | 15 +++++

  4 files changed, 100 insertions(+)

  create mode 100644 package/initscripts/init.d/S11modules