Skip to contentSkip to conversation

ext4: remove unused string "deprecated_msg"

PATCH In review Colin Ian King 2 participants 2 messages Oct 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: remove unused string "deprecated_msg"

The string deprecated_msg is no longer being used, remove it.

---
 fs/ext4/super.c | 4 ----
 1 file changed, 4 deletions(-)
fs/ext4/super.c +0 -4
index 2335452efed0..981563c8245e 100644
@@ -1740,10 +1740,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {
 
 #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
 
-static const char deprecated_msg[] =
-	"Mount option \"%s\" will be removed by %s\n"
-	"Contact [email protected] if you think we should keep it.\n";
-
 #define MOPT_SET	0x0001
 #define MOPT_CLEAR	0x0002
 #define MOPT_NOSUPPORT	0x0004
Signature · 1 line
2.37.1
reviewer
#1 lore raw
Quoted 1 line · Colin Ian King

The string deprecated_msg is no longer being used, remove it.

So if IIUC we use this string as a standard message whenever we use any mount options about to be deprecated. We don't seem to have any deprecated mount options right now but we might want to keep the string around for future?

Quoted 24 lines
---
 fs/ext4/super.c | 4 ----
 1 file changed, 4 deletions(-)
fs/ext4/super.c +0 -4
index 2335452efed0..981563c8245e 100644
@@ -1740,10 +1740,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {
 
 #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
 
-static const char deprecated_msg[] =
-	"Mount option \"%s\" will be removed by %s\n"
-	"Contact [email protected] if you think we should keep it.\n";
-
 #define MOPT_SET	0x0001
 #define MOPT_CLEAR	0x0002
 #define MOPT_NOSUPPORT	0x0004
Signature · 1 line
2.37.1