Skip to contentSkip to conversation

staging: rtl8192u: Fix spelling mistake athros -> Atheros and fix grammer

PATCH In review Colin Ian King 2 participants 2 messages Oct 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192u: Fix spelling mistake athros -> Atheros and fix grammer

There is a spellig mistake, correct it and fix capital letter on the proper noun. Also fix the grammar.

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +1 -1
index b58e75932ecd..f142d0986990 100644
@@ -1806,7 +1806,7 @@ int ieee80211_parse_info_param(struct ieee80211_device *ieee,
 				info_element->data[0] == 0x00 &&
 				info_element->data[1] == 0x13 &&
 				info_element->data[2] == 0x74)) {
-				netdev_dbg(ieee->dev, "========> athros AP is exist\n");
+				netdev_dbg(ieee->dev, "========> Atheros AP exists\n");
 				network->atheros_cap_exist = true;
 			} else
 				network->atheros_cap_exist = false;
Signature · 1 line
2.37.1
#1 lore raw
Quoted 13 lines · Colin Ian King

There is a spellig mistake, correct it and fix capital letter on the proper noun. Also fix the grammar.

---
  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +0 -0
index b58e75932ecd..f142d0986990 100644

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c int ieee80211_parse_info_param(struct ieee80211_device *ieee, · line 1812

Quoted 8 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +1 -1
@@ -1806,7 +1806,7 @@ int ieee80211_parse_info_param(struct ieee80211_device *ieee,
  				info_element->data[0] == 0x00 &&
  				info_element->data[1] == 0x13 &&
  				info_element->data[2] == 0x74)) {
-				netdev_dbg(ieee->dev, "========> athros AP is exist\n");
+				netdev_dbg(ieee->dev, "========> Atheros AP exists\n");
  				network->atheros_cap_exist = true;
  			} else
  				network->atheros_cap_exist = false;

Hi Colin,

often this type of debug messages get removed instead of being fixed.

I do not know what the maintainer will decide in this case. I tend to remove.

But for more patches you may want to use:
./scripts/checkpatch.pl --file drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c

Here just a small output of what checkpatch does not like:

WARNING: quoted string split across lines
#2079: FILE: drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2079:
+ IEEE80211_DEBUG_SCAN("Filtered out '%s (%pM)' "
+ "network.\n",

CHECK: Avoid CamelCase: <SignalStrength>
#2095: FILE: drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2095:
+ stats->signal = 30 + (stats->SignalStrength * 70) / 100;

WARNING: Block comments use a trailing */ on a separate line #2110: FILE: drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2110:
+ * as one network */

Please also have a look at:
https://lore.kernel.org/linux-staging/
For inspiration.

https://www.mail-archive.com/[email protected]/

For further questions:
https://www.mail-archive.com/[email protected]/msg22219.html

Bye Philipp