irqchip: irq-imx-mu-msi: fixed wrong register offset for 8ulp
Subsystems (2)
Frank Li
maintainerPATCH 1/1 irqchip: irq-imx-mu-msi: fixed wrong register offset for 8ulp
Offset 0x124 should be IMX_MU_TSR, not IMX_MU_GSR
Signed-off-by Frank Li <[email protected]>
--- drivers/irqchip/irq-imx-mu-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-imx-mu-msi.c +1 -1
@@ -292,7 +292,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = { .xSR = { [IMX_MU_SR] = 0xC, [IMX_MU_GSR] = 0x118, - [IMX_MU_GSR] = 0x124, + [IMX_MU_TSR] = 0x124, [IMX_MU_RSR] = 0x12C, }, .xCR = {
Signature · 1 line
2.35.1
Fabio Estevam
reviewerHi Frank,
Quoted 4 lines · Frank Li
Offset
0x124should beIMX_MU_TSR, notIMX_MU_GSRSigned-off-by Frank Li <[email protected]>
You missed passing Reported-by and Fixes tag.
Quoted 10 lines · Fabio Estevam
Hi Frank,
Quoted 4 lines · Frank Li
Offset
0x124should beIMX_MU_TSR, notIMX_MU_GSRSigned-off-by Frank Li <[email protected]>You missed passing Reported-by and Fixes tag.
I fixed that locally. Thanks for CC'ing Colin though.
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
[irqchip: irq/irqchip-fixes] irqchip/imx-mu-msi: Fix wrong register offset for 8ulp
In reply to Frank LiThe following commit has been merged into the irq/irqchip-fixes branch of irqchip:
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: e4a7e67a08ac409f1485c82a2190636d5c81b932 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/e4a7e67a08ac409f1485c82a2190636d5c81b932 Author: Frank Li <[email protected]> AuthorDate: Tue, 04 Oct 2022 15:24:14 -05:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Tue, 04 Oct 2022 23:35:36 +01:00
irqchip/imx-mu-msi: Fix wrong register offset for 8ulp
Offset 0x124 should be for IMX_MU_TSR, not IMX_MU_GSR.
Fixes 70afdab904d2 ("irqchip: Add IMX MU MSI controller driver")
Reported-by Colin King <[email protected]>
Signed-off-by Frank Li <[email protected]>
[maz: updated commit message, tags]
Signed-off-by Marc Zyngier <[email protected]>
--- drivers/irqchip/irq-imx-mu-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-imx-mu-msi.c +1 -1
@@ -292,7 +292,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = { .xSR = { [IMX_MU_SR] = 0xC, [IMX_MU_GSR] = 0x118, - [IMX_MU_GSR] = 0x124, + [IMX_MU_TSR] = 0x124, [IMX_MU_RSR] = 0x12C, }, .xCR = {