Skip to contentSkip to conversation

chrony: add pkgconfig class as pkg-config is explicitly searched for

PATCH In review Federico Pellegrin 2 participants 2 messages Oct 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 chrony: add pkgconfig class as pkg-config is explicitly searched for

The configure script present in chrony will explicitly look for pkg-config and without the pkgconfig class it will fail:

Checking for pkg-config : No

This then affects the possibility (via image features or bbappend) to use features based on nettle/gnutls/nss which strictly require pkgconfig to be present and working.

---
 meta-networking/recipes-support/chrony/chrony_4.3.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-networking/recipes-support/chrony/chrony_4.3.bb +3 -0
index 083d2cbc0..dfdb7864a 100644
@@ -47,6 +47,9 @@ DEPENDS = "pps-tools"
 #       chrony does not use GNU Autotools.
 inherit update-rc.d systemd
 
+# The configure scripts explicitly check for pkgconfig and needs it for gnutls/neetle/nss
+inherit pkgconfig
+
 # Add chronyd user if privdrop packageconfig is selected
 inherit ${@bb.utils.contains('PACKAGECONFIG', 'privdrop', 'useradd', '', d)}
 USERADD_PACKAGES = "${@bb.utils.contains('PACKAGECONFIG', 'privdrop', '${PN}', '', d)}"
Signature · 1 line
2.37.3
#1 lore raw

This should go to openembedded-devel@, not -core@.

Also, there’s no need for a comment in the recipe explaining what the pkgconfig inherit is for, just put it on the same line as the other inherits.

Ross

Quoted 42 lines · Federico Pellegrin via lists.openembedded.org

The configure script present in chrony will explicitly look for pkg-config and without the pkgconfig class it will fail:

Checking for pkg-config : No

This then affects the possibility (via image features or bbappend) to use features based on nettle/gnutls/nss which strictly require pkgconfig to be present and working.

---
meta-networking/recipes-support/chrony/chrony_4.3.bb | 3 +++

1 file changed, 3 insertions(+)
meta-networking/recipes-support/chrony/chrony_4.3.bb +0 -0
index 083d2cbc0..dfdb7864a 100644
@@ -47,6 +47,9 @@ DEPENDS = "pps-tools"
 #       chrony does not use GNU Autotools.

inherit update-rc.d systemd

meta-networking/recipes-support/chrony/chrony_4.3.bb +3 -0
+# The configure scripts explicitly check for pkgconfig and needs it for gnutls/neetle/nss
+inherit pkgconfig
+

# Add chronyd user if privdrop packageconfig is selected
inherit ${@bb.utils.contains('PACKAGECONFIG', 'privdrop', 'useradd', '', d)} USERADD_PACKAGES = "${@bb.utils.contains('PACKAGECONFIG', 'privdrop', '${PN}', '', d)}"

Signature · 10 lines
2.37.3


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171479): https://lists.openembedded.org/g/openembedded-core/message/171479
Mute This Topic: https://lists.openembedded.org/mt/94151504/6875888
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-