Skip to contentSkip to conversation

mtd: spi-nor: winbond: add support for w25q01jv-im

PATCH In review Delphine CC Chiu 3 participants 5 messages Oct 6, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: winbond: add support for w25q01jv-im

Add support for winbond w25q01jv-im chip.

---
 drivers/mtd/spi-nor/winbond.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi-nor/winbond.c +3 -0
index ffaa24055259..2b02b05ceb0a 100644
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] = {
 	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
+	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+			      SPI_NOR_QUAD_READ) },
 };
 
 /**
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Am 2022-10-06 09:08, schrieb Delphine CC Chiu:

Quoted 12 lines

Add support for winbond w25q01jv-im chip.

---
 drivers/mtd/spi-nor/winbond.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi-nor/winbond.c +0 -0
index ffaa24055259..2b02b05ceb0a 100644

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] · line 143

Quoted 5 lines
drivers/mtd/spi-nor/winbond.c +1 -0
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] 
 = {
 	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
+	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)

The name should be w25q01jvm.

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] = { · line 144

Quoted 2 lines
drivers/mtd/spi-nor/winbond.c +2 -0
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+			      SPI_NOR_QUAD_READ) },

That flash should support SFDP, so please try the following:
+ { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },

Also, we require an SFDP dump for new flash submissions, see [1].

-michael

[1] https://lore.kernel.org/linux-mtd/[email protected]/

#2 lore raw
Quoted 30 lines · Michael Walle

Hi,

Am 2022-10-06 09:08, schrieb Delphine CC Chiu:

Quoted 13 lines

Add support for winbond w25q01jv-im chip.

---
 drivers/mtd/spi-nor/winbond.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi-nor/winbond.c +0 -0
index ffaa24055259..2b02b05ceb0a 100644

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] · line 143

Quoted 5 lines
drivers/mtd/spi-nor/winbond.c +1 -0
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] 
 = {
 	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
+	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)

The name should be w25q01jvm.

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] = { · line 144

Quoted 2 lines
drivers/mtd/spi-nor/winbond.c +2 -0
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+			      SPI_NOR_QUAD_READ) },

That flash should support SFDP, so please try the following:

(quoted diff) +1 -0
+	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
Quoted 6 lines

Also, we require an SFDP dump for new flash submissions, see [1].

-michael

[1]
https://lore.kernel.org/linux-mtd/[email protected]/

It looks like this was already attempted to be added:

https://lore.kernel.org/all/[email protected]/

Potin, do you have an update?

Signature · 1 line
Patrick Williams
#3 lore raw
In reply to Michael Walle
Quoted 28 lines · Michael Walle

Hi,

Am 2022-10-06 09:08, schrieb Delphine CC Chiu:

Quoted 13 lines

Add support for winbond w25q01jv-im chip.

---
 drivers/mtd/spi-nor/winbond.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi-nor/winbond.c +0 -0
index ffaa24055259..2b02b05ceb0a 100644

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] · line 143

Quoted 5 lines
drivers/mtd/spi-nor/winbond.c +1 -0
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] 
 = {
 	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
+	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)

The name should be w25q01jvm.

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] = { · line 144

Quoted 2 lines
drivers/mtd/spi-nor/winbond.c +2 -0
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+			      SPI_NOR_QUAD_READ) },

That flash should support SFDP, so please try the following:

Review

Quoted 1 line
(quoted diff) +1 -0
+	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },

It seems like QEMU doesn't support SFDP yet. Is using PARSE_SFDP a hard requirement or can we delay until the QEMU support can be written?

Signature · 1 line
Patrick Williams

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#4 lore raw
Quoted 25 lines · Patrick Williams
Quoted 24 lines · Michael Walle

Hi,

Am 2022-10-06 09:08, schrieb Delphine CC Chiu:

Quoted 13 lines

Add support for winbond w25q01jv-im chip.

---
 drivers/mtd/spi-nor/winbond.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi-nor/winbond.c +0 -0
index ffaa24055259..2b02b05ceb0a 100644

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] · line 143

Quoted 5 lines
drivers/mtd/spi-nor/winbond.c +1 -0
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] 
 = {
 	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
+	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)

The name should be w25q01jvm.

Quoted 8 lines

Review

Quoted 5 lines

drivers/mtd/spi-nor/winbond.c static const struct flash_info winbond_nor_parts[] = { · line 144

Quoted 2 lines
drivers/mtd/spi-nor/winbond.c +2 -0
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+			      SPI_NOR_QUAD_READ) },

That flash should support SFDP, so please try the following:

(quoted diff) +1 -0
+	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },

It seems like QEMU doesn't support SFDP yet. Is using PARSE_SFDP a hard requirement or can we delay until the QEMU support can be written?

It turns out that there is some tentative support in QEMU for giving SFDP information now. I've sent a patch building on top of that for the w25q01jvq chip and updated Potin's patch-set to v4 that I mentioned elsewhere in this thread.

It looks like the w25q01jvq I pointed to in Potin's patch-set and the w25q01jvm being proposed here are slightly different chips.

Signature · 1 line
Patrick Williams