Skip to contentSkip to conversation

arm64: dts: qcom: sc8280xp: correct ref clock for ufs_mem_phy

PATCH Applied Brian Masney 2 participants 2 messages Oct 6, 2022 – Oct 18, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 arm64: dts: qcom: sc8280xp: correct ref clock for ufs_mem_phy

The first UFS host controller fails to start on the SA8540P automotive board (QDrive3) due to the following errors:

ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag_retry: query attribute, opcode 5, idn 18, failed
with error 253 after 3 retries

The system eventually fails to boot with the warning:

gcc_ufs_phy_axi_clk status stuck at 'off'

This issue can be worked around by adding clk_ignore_unused to the kernel command line since the system firmware sets up this clock for us.

Let's fix this issue by updating the ref clock on ufs_mem_phy. Note that the downstream MSM 5.4 sources list this as ref_clk_parent. With this patch, the SA8540P is able to be booted without clk_ignore_unused.

Fixes 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")

---
Changes since v3:
- Renamed ref_aux to ref in patch subject. Added Johan's R-b and T-b.

v3 of this patch can be found at
https://lore.kernel.org/lkml/[email protected]/

v2 of this patch can be found at
https://lore.kernel.org/lkml/[email protected]/T/#u

v1 of this patch can be found at
https://lore.kernel.org/lkml/[email protected]/T/#u

 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +1 -1
index c32bcded2aef..006b9a13bc2f 100644
@@ -891,7 +891,7 @@ ufs_mem_phy: phy@1d87000 {
 			ranges;
 			clock-names = "ref",
 				      "ref_aux";
-			clocks = <&rpmhcc RPMH_CXO_CLK>,
+			clocks = <&gcc GCC_UFS_REF_CLKREF_CLK>,
 				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
 
 			resets = <&ufs_mem_hc 0>;
Signature · 1 line
2.37.3
maintainer Applied
#1 lore raw
Quoted 10 lines · Brian Masney

The first UFS host controller fails to start on the SA8540P automotive board (QDrive3) due to the following errors:

ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag_retry: query attribute, opcode 5, idn 18, failed
with error 253 after 3 retries

[...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp: correct ref clock for ufs_mem_phy

      commit: f3aa975e230e060c07dcfdf3fe92b59809422c13

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>