mailbox: qcom-ipcc: flag IRQ NO_THREAD
Subsystems (3)
PATCH v2 1/1 mailbox: qcom-ipcc: flag IRQ NO_THREAD
PREEMPT_RT forces qcom-ipcc's handler to be threaded with interrupts enabled, which triggers a warning in __handle_irq_event_percpu():
irq 173 handler irq_default_primary_handler+0x0/0x10 enabled interrupts
WARNING: CPU: 0 PID: 77 at kernel/irq/handle.c:161 __handle_irq_event_percpu+0x4c4/0x4d0Mark it IRQF_NO_THREAD. This is an IRQ-multiplexer and as such it should not be threaded, otherwise its child-interrupts would be invoked from the thread handler which is not desired.
This is noticed by PREEMPT_RT, but also on a non-PREEMPT_RT kernel where `threadirqs' has been used.
Signed-off-by Eric Chanudet <[email protected]>
---
Changes since v1:
- Reformulate the patch description using Sebastian's response.
v1 can be found at
https://lore.kernel.org/linux-arm-msm/[email protected]/
drivers/mailbox/qcom-ipcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mailbox/qcom-ipcc.c +2 -1
@@ -308,7 +308,8 @@ static int qcom_ipcc_probe(struct platform_device *pdev) goto err_mbox; ret =devm_request_irq (&pdev->dev, ipcc->irq, qcom_ipcc_irq_fn, -IRQF_TRIGGER_HIGH |IRQF_NO_SUSPEND , name, ipcc); +IRQF_TRIGGER_HIGH |IRQF_NO_SUSPEND | +IRQF_NO_THREAD , name, ipcc);if (ret <0 ) {dev_err (&pdev->dev,"Failed to register the irq: %d\n" , ret); goto err_req_irq;
Signature · 1 line
2.37.3