Skip to contentSkip to conversation

drm/edid/firmware: stop using throwaway platform device

PATCH Superseded Jani Nikula 3 participants 13 messages Oct 6, 2022 – Nov 13, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/edid/firmware: stop using throwaway platform device

We've used a temporary platform device for firmware EDID loading since it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as firmware to override broken monitor"), but there's no explanation why.

Do we need to?

Maybe this fixes the suspend/resume issue?

(Yes, I'll rewrite the commit message if this is the way to go ;)

References: https://lore.kernel.org/r/[email protected]

Cc Matthieu CHARETTE <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/drm_edid_load.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpu/drm/drm_edid_load.c +1 -10
index 37d8ba3ddb46..fbae12130234 100644
@@ -182,18 +182,9 @@ static void *edid_load(struct drm_connector *connector, const char *name,
 		fwdata = generic_edid[builtin];
 		fwsize = sizeof(generic_edid[builtin]);
 	} else {
-		struct platform_device *pdev;
 		int err;
 
-		pdev = platform_device_register_simple(connector_name, -1, NULL, 0);
-		if (IS_ERR(pdev)) {
-			DRM_ERROR("Failed to register EDID firmware platform device "
-				  "for connector \"%s\"\n", connector_name);
-			return ERR_CAST(pdev);
-		}
-
-		err = request_firmware(&fw, name, &pdev->dev);
-		platform_device_unregister(pdev);
+		err = request_firmware(&fw, name, connector->dev->dev);
 		if (err) {
 			DRM_ERROR("Requesting EDID firmware \"%s\" failed (err=%d)\n",
 				  name, err);
Signature · 1 line
2.34.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid/firmware: stop using throwaway platform device

== Series Details ==

== Series Details ==

Series: drm/edid/firmware: stop using throwaway platform device
URL : https://patchwork.freedesktop.org/series/109464/
State : warning

== Summary ==

Error: dim checkpatch failed
88cfbbf5d352 drm/edid/firmware: stop using throwaway platform device
-:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #19:
References: https://lore.kernel.org/r/[email protected]

total: 0 errors, 1 warnings, 0 checks, 19 lines checked

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid/firmware: stop using throwaway platform device

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/edid/firmware: stop using throwaway platform device
URL : https://patchwork.freedesktop.org/series/109464/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12223 -> Patchwork_109464v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/index.html

Participating hosts (42 -> 40)
------------------------------

Missing (2): fi-ctg-p8600 fi-hsw-4200u

Known issues
------------

Here are the changes found in Patchwork_109464v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
- fi-bxt-dsi: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/fi-hsw-4770/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][6] ([fdo#111827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-dg1-5/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4078])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-dg1-5/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][8] ([i915#2867]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-rplp-1/igt@gem_exec_suspend@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][10] ([i915#2867]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [INCOMPLETE][12] ([i915#4418]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-dg1-5/igt@i915_selftest@live@gt_engines.html

* igt@i915_selftest@live@gt_pm:
- {bat-adln-1}: [DMESG-FAIL][14] ([i915#4258]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/bat-adln-1/igt@i915_selftest@live@gt_pm.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-adln-1/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][16] ([i915#4785]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/fi-hsw-4770/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][18] ([i915#4983] / [i915#6257]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/bat-rpls-1/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- {bat-rpls-2}: [FAIL][20] ([i915#6559]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/bat-rpls-2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/bat-rpls-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559

Build changes
-------------

* Linux: CI_DRM_12223 -> Patchwork_109464v1

CI-20190529: 20190529
CI_DRM_12223: c53a5e48e0405a63cda64682304cd8b391025be3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7002: 523844c74e7da6b39d856596c28a92f04172035f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109464v1: c53a5e48e0405a63cda64682304cd8b391025be3 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

ec41649d276a drm/edid/firmware: stop using throwaway platform device

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/index.html

#3 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid/firmware: stop using throwaway platform device

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/edid/firmware: stop using throwaway platform device
URL : https://patchwork.freedesktop.org/series/109464/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12223_full -> Patchwork_109464v1_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (12 -> 12)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_109464v1_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_eio@suspend:
- {shard-rkl}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]
- {shard-dg1}: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-dg1-18/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-dg1-15/igt@[email protected]

* igt@kms_color_chamelium@degamma:
- {shard-rkl}: [SKIP][5] ([fdo#111827]) -> [SKIP][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_109464v1_full that come from known issues:

### CI changes ###

#### Possible fixes ####

* boot:
- shard-apl: ([PASS][7], [PASS][8], [PASS][9], [FAIL][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31]) ([i915#4386]) -> ([PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl2/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl2/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl2/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl3/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl3/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl3/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl7/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl8/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl8/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl8/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl1/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl1/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl2/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl2/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl2/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl2/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl7/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl7/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl7/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl7/boot.html
- shard-snb: ([PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [FAIL][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79], [PASS][80], [PASS][81]) ([i915#4338]) -> ([PASS][82], [PASS][83], [PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [PASS][90], [PASS][91], [PASS][92], [PASS][93], [PASS][94], [PASS][95], [PASS][96], [PASS][97], [PASS][98], [PASS][99], [PASS][100], [PASS][101], [PASS][102], [PASS][103], [PASS][104], [PASS][105], [PASS][106])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb6/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb6/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb6/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb5/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb5/boot.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb5/boot.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb5/boot.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb5/boot.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb4/boot.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb4/boot.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb4/boot.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb4/boot.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb4/boot.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb2/boot.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb2/boot.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb2/boot.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb2/boot.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb2/boot.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb7/boot.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb7/boot.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb7/boot.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb7/boot.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb7/boot.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb6/boot.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-snb6/boot.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb7/boot.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb7/boot.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb7/boot.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb7/boot.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb7/boot.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/boot.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/boot.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/boot.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/boot.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/boot.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb5/boot.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb5/boot.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb5/boot.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb5/boot.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb2/boot.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb2/boot.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb2/boot.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb2/boot.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb2/boot.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb4/boot.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb4/boot.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb4/boot.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb4/boot.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb4/boot.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb5/boot.html

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#1099])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-glk: [PASS][108] -> [TIMEOUT][109] ([i915#3063])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-glk1/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk6/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][110] -> [SKIP][111] ([i915#4525]) +3 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb4/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb8/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][112] -> [FAIL][113] ([i915#2842])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-tglb2/igt@gem_exec_fair@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][114] -> [FAIL][115] ([i915#2842]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-glk7/igt@gem_exec_fair@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][116] -> [FAIL][117] ([i915#2842])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb7/igt@gem_exec_fair@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][118] ([i915#2842])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#4613])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#4613])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk5/igt@[email protected]

* igt@gem_softpin@allocator-evict@rcs0:
- shard-skl: NOTRUN -> [SKIP][121] ([fdo#109271]) +19 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl9/igt@gem_softpin@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-glk: NOTRUN -> [SKIP][122] ([fdo#109271]) +21 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk5/igt@[email protected]

* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-skl: NOTRUN -> [FAIL][123] ([i915#7036])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl9/igt@[email protected]

* igt@kms_addfb_basic@legacy-format:
- shard-tglb: [PASS][124] -> [INCOMPLETE][125] ([i915#6987])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-tglb5/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-tglb5/igt@[email protected]

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#3886])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][127] ([fdo#109271] / [i915#3886])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs:
- shard-apl: NOTRUN -> [SKIP][128] ([fdo#109271]) +49 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs.html

* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#3886])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl6/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-snb: NOTRUN -> [SKIP][130] ([fdo#109271] / [fdo#111827]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/igt@[email protected]

* igt@kms_color_chamelium@degamma:
- shard-apl: NOTRUN -> [SKIP][131] ([fdo#109271] / [fdo#111827]) +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][132] ([fdo#109271] / [fdo#111827])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk5/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][133] ([i915#1319])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][134] -> [FAIL][135] ([i915#4767])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl7/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][136] -> [FAIL][137] ([i915#2122])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-glk1/igt@kms_flip@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk5/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: NOTRUN -> [FAIL][138] ([i915#79]) +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][139] -> [FAIL][140] ([i915#79])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl1/igt@kms_flip@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [PASS][141] -> [INCOMPLETE][142] ([i915#4839] / [i915#4939])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl6/igt@kms_flip@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][143] ([i915#2587] / [i915#2672]) +4 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][144] ([i915#3555])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][145] ([i915#2672]) +6 similar issues
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][146] ([i915#2672] / [i915#3555])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][147] ([fdo#109271] / [i915#658]) +1 similar issue
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][148] -> [SKIP][149] ([fdo#109441]) +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb5/igt@kms_psr@psr2_no_drrs.html

* igt@kms_psr@suspend:
- shard-skl: [PASS][150] -> [INCOMPLETE][151] ([i915#4939])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl9/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl4/igt@[email protected]

* igt@kms_tv_load_detect@load-detect:
- shard-snb: NOTRUN -> [SKIP][152] ([fdo#109271]) +71 similar issues
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-snb6/igt@[email protected]

* igt@sysfs_clients@recycle-many:
- shard-apl: NOTRUN -> [SKIP][153] ([fdo#109271] / [i915#2994])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl8/igt@[email protected]

#### Possible fixes ####

* igt@gem_bad_reloc@negative-reloc-lut:
- {shard-rkl}: [SKIP][154] ([i915#3281]) -> [PASS][155] +12 similar issues
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]

* igt@gem_busy@close-race:
- {shard-rkl}: [TIMEOUT][156] ([i915#5748]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-5/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-3/igt@[email protected]

* igt@gem_create@create-clear@smem0:
- {shard-rkl}: [INCOMPLETE][158] -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-3/igt@gem_create@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-4/igt@gem_create@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][160] ([i915#6268]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]
- shard-tglb: [FAIL][162] ([i915#6268]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-tglb2/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-tglb7/igt@[email protected]
- {shard-tglu}: [FAIL][164] ([i915#6268]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-tglu-3/igt@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-tglu-5/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-skl: [INCOMPLETE][166] ([i915#4793]) -> [PASS][167]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl1/igt@gem_ctx_isolation@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl6/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@smoketest:
- shard-tglb: [FAIL][168] ([i915#5099]) -> [PASS][169]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-tglb2/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-tglb2/igt@[email protected]

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][170] ([i915#4525]) -> [PASS][171]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb7/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- {shard-rkl}: [FAIL][172] ([i915#2842]) -> [PASS][173]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@gem_exec_fair@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][174] ([i915#2842]) -> [PASS][175]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-glk5/igt@gem_exec_fair@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][176] ([i915#2842]) -> [PASS][177]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl7/igt@gem_exec_fair@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][178] ([i915#2842]) -> [PASS][179]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb6/igt@gem_exec_fair@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [DMESG-WARN][180] ([i915#4936]) -> [PASS][181]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-dg1-13/igt@gem_lmem_swapping@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-dg1-13/igt@gem_lmem_swapping@[email protected]

* igt@gem_mmap_gtt@coherency:
- {shard-rkl}: [SKIP][182] ([fdo#111656]) -> [PASS][183]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-6/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]

* igt@gem_pread@snoop:
- {shard-rkl}: [SKIP][184] ([i915#3282]) -> [PASS][185] +6 similar issues
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-6/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][186] ([i915#5566] / [i915#716]) -> [PASS][187]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-glk1/igt@[email protected]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk5/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][188] ([i915#2527]) -> [PASS][189] +4 similar issues
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]

* igt@i915_hangman@engine-engine-error@bcs0:
- {shard-rkl}: [SKIP][190] ([i915#6258]) -> [PASS][191]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-5/igt@i915_hangman@[email protected]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-1/igt@i915_hangman@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][192] ([i915#1397]) -> [PASS][193]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-3/igt@[email protected]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- {shard-rkl}: [FAIL][194] ([i915#4016]) -> [PASS][195]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-6/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [DMESG-FAIL][196] ([i915#5334]) -> [PASS][197]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl1/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][198] ([i915#1845] / [i915#4098]) -> [PASS][199] +22 similar issues
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-3/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][200] ([i915#2346]) -> [PASS][201]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-glk2/igt@kms_cursor_legacy@[email protected]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-glk9/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-iclb: [FAIL][202] ([i915#2346]) -> [PASS][203] +1 similar issue
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb2/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][204] ([i915#2122]) -> [PASS][205]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl1/igt@kms_flip@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- {shard-rkl}: [SKIP][206] ([i915#1849] / [i915#4098]) -> [PASS][207] +8 similar issues
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-6/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][208] ([i915#3558]) -> [PASS][209] +1 similar issue
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@kms_plane@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-6/igt@kms_plane@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][210] ([i915#5235]) -> [PASS][211] +2 similar issues
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb2/igt@kms_plane_scaling@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb5/igt@kms_plane_scaling@[email protected]

* igt@kms_psr@cursor_plane_onoff:
- {shard-rkl}: [SKIP][212] ([i915#1072]) -> [PASS][213] +1 similar issue
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-1/igt@kms_psr@cursor_plane_onoff.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-6/igt@kms_psr@cursor_plane_onoff.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][214] ([fdo#109441]) -> [PASS][215] +1 similar issue
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

* igt@kms_rotation_crc@primary-rotation-90:
- shard-skl: [DMESG-WARN][216] ([i915#1982]) -> [PASS][217]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-skl4/igt@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-skl9/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-apl: [FAIL][218] ([i915#5639]) -> [PASS][219]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-apl7/igt@[email protected]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-apl6/igt@[email protected]

* igt@perf_pmu@busy-double-start@rcs0:
- {shard-dg1}: [FAIL][220] ([i915#4349]) -> [PASS][221]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-dg1-17/igt@perf_pmu@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-dg1-15/igt@perf_pmu@[email protected]

* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][222] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][223]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-rkl-6/igt@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-rkl-5/igt@[email protected]

#### Warnings ####

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][224] ([i915#658]) -> [SKIP][225] ([i915#2920])
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb7/igt@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][226] ([i915#2920]) -> [SKIP][227] ([i915#658]) +2 similar issues
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb2/igt@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb1/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][228] ([i915#2920]) -> [SKIP][229] ([fdo#111068] / [i915#658])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12223/shard-iclb2/igt@[email protected]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/shard-iclb1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
[i915#4793]: https://gitlab.freedesktop.org/drm/intel/issues/4793
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4998]: https://gitlab.freedesktop.org/drm/intel/issues/4998
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6934]: https://gitlab.freedesktop.org/drm/intel/issues/6934
[i915#6987]: https://gitlab.freedesktop.org/drm/intel/issues/6987
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12223 -> Patchwork_109464v1

CI-20190529: 20190529
CI_DRM_12223: c53a5e48e0405a63cda64682304cd8b391025be3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7002: 523844c74e7da6b39d856596c28a92f04172035f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109464v1: c53a5e48e0405a63cda64682304cd8b391025be3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109464v1/index.html

#4 lore raw
In reply to Jani Nikula

It should fix the issue. Meanwhile, the system will still crash if a new monitor is plugged while the machine is suspended. We might need to precache the EDID to prevent that.

Matthieu

Quoted 47 lines · Jani Nikula

We've used a temporary platform device for firmware EDID loading since it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as firmware to override broken monitor"), but there's no explanation why.

Do we need to?

Maybe this fixes the suspend/resume issue?

(Yes, I'll rewrite the commit message if this is the way to go ;)

References: https://lore.kernel.org/r/[email protected]

Cc Matthieu CHARETTE <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/drm_edid_load.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpu/drm/drm_edid_load.c +1 -10
index 37d8ba3ddb46..fbae12130234 100644
@@ -182,18 +182,9 @@ static void *edid_load(struct drm_connector 
 *connector, const char *name,
 		fwdata = generic_edid[builtin];
 		fwsize = sizeof(generic_edid[builtin]);
 	} else {
-		struct platform_device *pdev;
 		int err;
 
-		pdev = platform_device_register_simple(connector_name, -1, NULL, 
 0);
-		if (IS_ERR(pdev)) {
-			DRM_ERROR("Failed to register EDID firmware platform device "
-				  "for connector \"%s\"\n", connector_name);
-			return ERR_CAST(pdev);
-		}
-
-		err = request_firmware(&fw, name, &pdev->dev);
-		platform_device_unregister(pdev);
+		err = request_firmware(&fw, name, connector->dev->dev);
 		if (err) {
drivers/gpu/drm/drm_edid_load.c +0 -1
 			DRM_ERROR("Requesting EDID firmware \"%s\" failed (err=%d)\n",
 				  name, err);
--

2.34.1

#5 lore raw
Quoted 3 lines · Matthieu CHARETTE

It should fix the issue. Meanwhile, the system will still crash if a new monitor is plugged while the machine is suspended. We might need to precache the EDID to prevent that.

Please elaborate.

BR,
Jani.

Quoted 57 lines

Matthieu

Quoted 50 lines · Jani Nikula

We've used a temporary platform device for firmware EDID loading since it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as
firmware to override broken monitor"), but there's no explanation why.

Do we need to?

Maybe this fixes the suspend/resume issue?

(Yes, I'll rewrite the commit message if this is the way to go ;)

References:
https://lore.kernel.org/r/[email protected]

Cc Matthieu CHARETTE <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/drm_edid_load.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpu/drm/drm_edid_load.c +1 -10
index 37d8ba3ddb46..fbae12130234 100644
@@ -182,18 +182,9 @@ static void *edid_load(struct drm_connector 
 *connector, const char *name,
 		fwdata = generic_edid[builtin];
 		fwsize = sizeof(generic_edid[builtin]);
 	} else {
-		struct platform_device *pdev;
 		int err;
 
-		pdev = platform_device_register_simple(connector_name, -1, NULL, 
 0);
-		if (IS_ERR(pdev)) {
-			DRM_ERROR("Failed to register EDID firmware platform device "
-				  "for connector \"%s\"\n", connector_name);
-			return ERR_CAST(pdev);
-		}
-
-		err = request_firmware(&fw, name, &pdev->dev);
-		platform_device_unregister(pdev);
+		err = request_firmware(&fw, name, connector->dev->dev);
 		if (err) {
drivers/gpu/drm/drm_edid_load.c +0 -1
 			DRM_ERROR("Requesting EDID firmware \"%s\" failed (err=%d)\n",
 				  name, err);
--

2.34.1

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#6 lore raw

Currently the EDID is requested during the resume. But since it's requested too early, this means before the filesystem is mounted, the firmware request fails. This make the DRM driver crash when resuming. This kind of issue should be prevented by the firmware caching process which cache every firmware requested for the next resume. But since we are using a temporary device, the firmware isn't cached on suspend since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware will be cached on suspend for the next resume. So requesting the firmware during resume will succeed.
But if the firmware has never been requested since the boot, this means that the monitor isn't plugged since the boot. The kernel will not be caching the EDID. So if we plug the monitor while the machine is suspended. The resume will fail to load the firmware. And the DRM driver will crash.
So basically, your fix should solve the issue except for the case where the monitor hasn't been plugged since boot and is plugged while the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at explaining.

Matthieu

Quoted 72 lines · Jani Nikula
Quoted 3 lines · Matthieu CHARETTE

It should fix the issue. Meanwhile, the system will still crash if a new monitor is plugged while the machine is suspended. We might need to precache the EDID to prevent that.

Please elaborate.

BR,
Jani.

Quoted 47 lines

Matthieu

Quoted 42 lines · Jani Nikula

We've used a temporary platform device for firmware EDID loading since it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as
firmware to override broken monitor"), but there's no explanation why.

Do we need to?

Maybe this fixes the suspend/resume issue?

(Yes, I'll rewrite the commit message if this is the way to go ;)

References:
https://lore.kernel.org/r/[email protected]

Cc Matthieu CHARETTE <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/drm_edid_load.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpu/drm/drm_edid_load.c +0 -9
index 37d8ba3ddb46..fbae12130234 100644
@@ -182,18 +182,9 @@ static void *edid_load(struct drm_connector
 *connector, const char *name,
 		fwdata = generic_edid[builtin];
 		fwsize = sizeof(generic_edid[builtin]);
 	} else {
-		struct platform_device *pdev;
 		int err;
 
-		pdev = platform_device_register_simple(connector_name, -1, NULL,
 0);
-		if (IS_ERR(pdev)) {
-			DRM_ERROR("Failed to register EDID firmware platform device "
-				  "for connector \"%s\"\n", connector_name);
-			return ERR_CAST(pdev);
-		}
-
-		err = request_firmware(&fw, name, &pdev->dev);
Quoted 10 lines
Quoted 8 lines
drivers/gpu/drm/drm_edid_load.c +1 -1
-		platform_device_unregister(pdev);
+		err = request_firmware(&fw, name, connector->dev->dev);
 		if (err) {
drivers/gpu/drm/drm_edid_load.c +0 -1
 			DRM_ERROR("Requesting EDID firmware \"%s\" failed (err=%d)\n",
 				  name, err);
--

2.34.1

--
Jani Nikula, Intel Open Source Graphics Center

#7 lore raw
Quoted 11 lines · Matthieu CHARETTE

Currently the EDID is requested during the resume. But since it's requested too early, this means before the filesystem is mounted, the firmware request fails. This make the DRM driver crash when resuming. This kind of issue should be prevented by the firmware caching process which cache every firmware requested for the next resume. But since we are using a temporary device, the firmware isn't cached on suspend since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware will be cached on suspend for the next resume. So requesting the firmware during resume will succeed.
But if the firmware has never been requested since the boot, this

Quoted 8 lines

means that the monitor isn't plugged since the boot. The kernel will not be caching the EDID. So if we plug the monitor while the machine is suspended. The resume will fail to load the firmware. And the DRM driver will crash.
So basically, your fix should solve the issue except for the case where the monitor hasn't been plugged since boot and is plugged while the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at explaining.

That was a pretty good explanation. The only thing I'm missing is what the failure mode is exactly when you claim the driver will crash. Why would request_firmware() "crash" if called for the first time on the resume path?

I'm not sure I care much about not being able to load the firmware EDID in the suspend-plug-resume case (as this can be remedied with a subsequent modeset), but obviously any errors need to be handled gracefully, without crashing.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#8 lore raw

By crash, I mean that an error is returned here: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/heads/master/drivers/gpu/drm/drm_edid_load.c#195
I don't really know what happens next, but on my machine the built-in screen and the external remains dark. Also the kernel seems to freeze. I suspect a kernel panic, but I'm not sure. Anyway, the error is definitely not well handled, and a fix would be great. Also, request_firmware() will crash if called for the first time on the resume path because the file system isn't reachable on the resume process. And no cache is available for this firmware. So I guess that in this case, request_firmware() returns an error. Suspend-plug-resume case is not my priority nether as long as it doesn't make the system crash (Which is currently the case).

Quoted 43 lines · Jani Nikula
Quoted 17 lines · Matthieu CHARETTE

Currently the EDID is requested during the resume. But since it's requested too early, this means before the filesystem is mounted,
the
firmware request fails. This make the DRM driver crash when
resuming.
This kind of issue should be prevented by the firmware caching
process
which cache every firmware requested for the next resume. But since
we
are using a temporary device, the firmware isn't cached on suspend since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware will be cached on suspend for the next resume. So requesting the firmware during resume will succeed.
But if the firmware has never been requested since the boot, this means that the monitor isn't plugged since the boot. The kernel will not be caching the EDID. So if we plug the monitor while the machine

Quoted 8 lines

is suspended. The resume will fail to load the firmware. And the DRM driver will crash.
So basically, your fix should solve the issue except for the case where the monitor hasn't been plugged since boot and is plugged
while
the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at
explaining.

That was a pretty good explanation. The only thing I'm missing is what the failure mode is exactly when you claim the driver will crash. Why would request_firmware() "crash" if called for the first time on the resume path?

I'm not sure I care much about not being able to load the firmware EDID in the suspend-plug-resume case (as this can be remedied with a subsequent modeset), but obviously any errors need to be handled gracefully, without crashing.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

#9 lore raw

Hi,

Can you tell me what are we waiting for? Maybe I can help.

Thanks.

Matthieu

Quoted 56 lines · Matthieu CHARETTE

By crash, I mean that an error is returned here: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/heads/master/drivers/gpu/drm/drm_edid_load.c#195
I don't really know what happens next, but on my machine the built-in screen and the external remains dark. Also the kernel seems to freeze. I suspect a kernel panic, but I'm not sure. Anyway, the error is definitely not well handled, and a fix would be great. Also, request_firmware() will crash if called for the first time on the resume path because the file system isn't reachable on the resume process. And no cache is available for this firmware. So I guess that in this case, request_firmware() returns an error. Suspend-plug-resume case is not my priority nether as long as it doesn't make the system crash (Which is currently the case).

Quoted 48 lines · Jani Nikula
Quoted 22 lines · On Tue, 11 Oct 2022, Matthieu CHARETTE <[email protected]> wrote:

Currently the EDID is requested during the resume. But since it's requested too early, this means before the filesystem is mounted,
the
firmware request fails. This make the DRM driver crash when
resuming.
This kind of issue should be prevented by the firmware caching
process
which cache every firmware requested for the next resume. But
since we
are using a temporary device, the firmware isn't cached on suspend since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware
will
be cached on suspend for the next resume. So requesting the
firmware
during resume will succeed.
But if the firmware has never been requested since the boot, this means that the monitor isn't plugged since the boot. The kernel
will
not be caching the EDID. So if we plug the monitor while the
machine
is suspended. The resume will fail to load the firmware. And the

Quoted 8 lines

DRM
driver will crash.
So basically, your fix should solve the issue except for the case where the monitor hasn't been plugged since boot and is plugged
while
the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at
explaining.

That was a pretty good explanation. The only thing I'm missing is what the failure mode is exactly when you claim the driver will crash. Why would request_firmware() "crash" if called for the first time on the resume path?

I'm not sure I care much about not being able to load the firmware EDID in the suspend-plug-resume case (as this can be remedied with a subsequent modeset), but obviously any errors need to be handled gracefully, without crashing.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

#10 lore raw
Quoted 3 lines · Matthieu CHARETTE

Hi,

Can you tell me what are we waiting for? Maybe I can help.

Have you tried the patch? Is it an improvement over the status quo?

The "crash" is still ambiguous to me. Do you observe it with the patch? Do you have logs? Etc.

BR,
Jani.

Quoted 77 lines

Thanks.

Matthieu

Quoted 68 lines · Matthieu CHARETTE

By crash, I mean that an error is returned here:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/heads/master/drivers/gpu/drm/drm_edid_load.c#195
I don't really know what happens next, but on my machine the built-in screen and the external remains dark. Also the kernel seems to freeze. I suspect a kernel panic, but I'm not sure. Anyway, the error is definitely not well handled, and a fix would be great. Also, request_firmware() will crash if called for the first time on the resume path because the file system isn't reachable on the resume process. And no cache is available for this firmware. So I guess that in this case, request_firmware() returns an error. Suspend-plug-resume case is not my priority nether as long as it doesn't make the system crash (Which is currently the case).

Quoted 51 lines · Jani Nikula
Quoted 22 lines · On Tue, 11 Oct 2022, Matthieu CHARETTE <[email protected]> wrote:

Currently the EDID is requested during the resume. But since it's requested too early, this means before the filesystem is mounted,
the
firmware request fails. This make the DRM driver crash when
resuming.
This kind of issue should be prevented by the firmware caching
process
which cache every firmware requested for the next resume. But
since we
are using a temporary device, the firmware isn't cached on suspend since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware
will
be cached on suspend for the next resume. So requesting the
firmware
during resume will succeed.
But if the firmware has never been requested since the boot, this means that the monitor isn't plugged since the boot. The kernel
will
not be caching the EDID. So if we plug the monitor while the
machine
is suspended. The resume will fail to load the firmware. And the

Quoted 8 lines

DRM
driver will crash.
So basically, your fix should solve the issue except for the case where the monitor hasn't been plugged since boot and is plugged
while
the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at
explaining.

That was a pretty good explanation. The only thing I'm missing is what
the failure mode is exactly when you claim the driver will crash. Why would request_firmware() "crash" if called for the first time on the resume path?

I'm not sure I care much about not being able to load the firmware EDID
in the suspend-plug-resume case (as this can be remedied with a subsequent modeset), but obviously any errors need to be handled gracefully, without crashing.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#11 lore raw

I didn't test the patch yet. I will do. But even without testing I can tell you that it will work (It will not crash).
Currently when the crash occurs, all screens remain black after resume. I'm not able to login with ssh neither. And logs end before the suspend. So the crash seems to be some kind of kernel panic.

Matthieu

Quoted 107 lines · Jani Nikula
Quoted 3 lines · Matthieu CHARETTE

Hi,

Can you tell me what are we waiting for? Maybe I can help.

Have you tried the patch? Is it an improvement over the status quo?

The "crash" is still ambiguous to me. Do you observe it with the patch? Do you have logs? Etc.

BR,
Jani.

Quoted 90 lines

Thanks.

Matthieu

Quoted 81 lines · Matthieu CHARETTE

By crash, I mean that an error is returned here:

https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/heads/master/drivers/gpu/drm/drm_edid_load.c#195
I don't really know what happens next, but on my machine the
built-in
screen and the external remains dark. Also the kernel seems to freeze. I suspect a kernel panic, but I'm not sure. Anyway, the
error
is definitely not well handled, and a fix would be great. Also, request_firmware() will crash if called for the first time on the resume path because the file system isn't reachable on the
resume
process. And no cache is available for this firmware. So I guess
that
in this case, request_firmware() returns an error. Suspend-plug-resume case is not my priority nether as long as it doesn't make the system crash (Which is currently the case).

Quoted 59 lines · Jani Nikula
Quoted 27 lines · On Tue, 11 Oct 2022, Matthieu CHARETTE <[email protected]> wrote:

Currently the EDID is requested during the resume. But since
it's
requested too early, this means before the filesystem is
mounted,
the
firmware request fails. This make the DRM driver crash when
resuming.
This kind of issue should be prevented by the firmware caching
process
which cache every firmware requested for the next resume. But
since we
are using a temporary device, the firmware isn't cached on
suspend
since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware
will
be cached on suspend for the next resume. So requesting the
firmware
during resume will succeed.
But if the firmware has never been requested since the boot,
this
means that the monitor isn't plugged since the boot. The kernel
will
not be caching the EDID. So if we plug the monitor while the
machine
is suspended. The resume will fail to load the firmware. And the
DRM

Quoted 8 lines

driver will crash.
So basically, your fix should solve the issue except for the
case
where the monitor hasn't been plugged since boot and is plugged
while
the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at
explaining.

That was a pretty good explanation. The only thing I'm missing is what
the failure mode is exactly when you claim the driver will crash.
Why
would request_firmware() "crash" if called for the first time on
the
resume path?

I'm not sure I care much about not being able to load the firmware EDID
in the suspend-plug-resume case (as this can be remedied with a subsequent modeset), but obviously any errors need to be handled gracefully, without crashing.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

--
Jani Nikula, Intel Open Source Graphics Center

#12 lore raw

Hi,

I've tested the patch and I can confirm that it fixed the issue. Tested on Fedora 36 with kernel 6.0.8.

Thanks,
Matthieu

Quoted 118 lines · Matthieu CHARETTE

I didn't test the patch yet. I will do. But even without testing I can tell you that it will work (It will not crash).
Currently when the crash occurs, all screens remain black after resume. I'm not able to login with ssh neither. And logs end before the suspend. So the crash seems to be some kind of kernel panic.

Matthieu

Quoted 110 lines · Jani Nikula
Quoted 3 lines · On Sun, 06 Nov 2022, Matthieu CHARETTE <[email protected]> wrote:

Hi,

Can you tell me what are we waiting for? Maybe I can help.

Have you tried the patch? Is it an improvement over the status quo?

The "crash" is still ambiguous to me. Do you observe it with the patch? Do you have logs? Etc.

BR,
Jani.

Quoted 93 lines

Thanks.

Matthieu

Quoted 84 lines · Matthieu CHARETTE

By crash, I mean that an error is returned here:

https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/heads/master/drivers/gpu/drm/drm_edid_load.c#195
I don't really know what happens next, but on my machine the
built-in
screen and the external remains dark. Also the kernel seems to
freeze. I suspect a kernel panic, but I'm not sure. Anyway, the
error
is definitely not well handled, and a fix would be great.
Also, request_firmware() will crash if called for the first time
on
the resume path because the file system isn't reachable on the
resume
process. And no cache is available for this firmware. So I guess
that
in this case, request_firmware() returns an error.
Suspend-plug-resume case is not my priority nether as long as it
doesn't make the system crash (Which is currently the case).

Quoted 61 lines · Jani Nikula
Quoted 28 lines · On Tue, 11 Oct 2022, Matthieu CHARETTE <[email protected]> wrote:

Currently the EDID is requested during the resume. But since
it's
requested too early, this means before the filesystem is
mounted,
the
firmware request fails. This make the DRM driver crash when
resuming.
This kind of issue should be prevented by the firmware caching
process
which cache every firmware requested for the next resume. But
since we
are using a temporary device, the firmware isn't cached on
suspend
since the device doesn't work anymore.
When using a non temporary device to get the EDID, the firmware
will
be cached on suspend for the next resume. So requesting the
firmware
during resume will succeed.
But if the firmware has never been requested since the boot,
this
means that the monitor isn't plugged since the boot. The kernel
will
not be caching the EDID. So if we plug the monitor while the
machine
is suspended. The resume will fail to load the firmware. And
the
DRM

Quoted 8 lines

driver will crash.
So basically, your fix should solve the issue except for the
case
where the monitor hasn't been plugged since boot and is plugged
while
the machine is suspended.
I hope I was clear. Tell me if I wasn't. I'm not really good at
explaining.

That was a pretty good explanation. The only thing I'm missing is what
the failure mode is exactly when you claim the driver will
crash. Why
would request_firmware() "crash" if called for the first time on
the
resume path?

I'm not sure I care much about not being able to load the
firmware
EDID
in the suspend-plug-resume case (as this can be remedied with a subsequent modeset), but obviously any errors need to be handled gracefully, without crashing.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

--
Jani Nikula, Intel Open Source Graphics Center