perf annotate: Add missing condition flags for arm64
Subsystems (2)
Namhyung Kim
maintainerPATCH 1/1 perf annotate: Add missing condition flags for arm64
According to the document [1], it can also have 'hs', 'lo', 'vc', 'vs' as a condition code. Let's add them too.
Reported-by Kevin Nomura <[email protected]>
Signed-off-by Namhyung Kim <[email protected]>
--- tools/perf/arch/arm64/annotate/instructions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/arch/arm64/annotate/instructions.c +1 -1
@@ -102,7 +102,7 @@ static int arm64__annotate_init(struct arch *arch, char *cpuid __maybe_unused)if (err) goto out_free_arm;/* b, b.cond, br, cbz/cbnz, tbz/tbnz */ - err =regcomp (&arm->jump_insn,"^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|le|ls|lt|mi|ne|pl)?n?z?$" , + err =regcomp (&arm->jump_insn,"^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|hs|le|lo|ls|lt|mi|ne|pl|vc|vs)?n?z?$" ,REG_EXTENDED );if (err) goto out_free_call;
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
Em Thu, Oct 06, 2022 at 03:22:32PM -0700, Namhyung Kim escreveu:
Quoted 4 lines
According to the document [1], it can also have 'hs', 'lo', 'vc', 'vs' as a condition code. Let's add them too.
Thanks, applied.
- Arnaldo
Quoted 21 lines
Reported-by Kevin Nomura <[email protected]>Signed-off-by Namhyung Kim <[email protected]>--- tools/perf/arch/arm64/annotate/instructions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/arch/arm64/annotate/instructions.c +1
-1@@ -102,7 +102,7 @@ static int arm64__annotate_init(struct arch *arch, char *cpuid __maybe_unused)if (err) goto out_free_arm;/* b, b.cond, br, cbz/cbnz, tbz/tbnz */ - err =regcomp (&arm->jump_insn,"^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|le|ls|lt|mi|ne|pl)?n?z?$" , + err =regcomp (&arm->jump_insn,"^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|hs|le|lo|ls|lt|mi|ne|pl|vc|vs)?n?z?$" ,REG_EXTENDED );if (err) goto out_free_call;Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
Signature · 1 line
- Arnaldo