greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
Subsystems (3)
PATCH v3 1/1 greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
Add linux device tree entry related to
greatlakes specific devices connected to BMC SoC.
---
--- v3 - Add documentation of board compatible (bindings)
--- - Add board compatible --- - Remove the bootargs --- - Revise the DTS node name
---
--- v2 - Add binding document
---
--- v1 - Initial draft
---
--- arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++ 2 files changed, 242 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -1586,6 +1586,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-elbert.dtb \ aspeed-bmc-facebook-fuji.dtb \ aspeed-bmc-facebook-galaxy100.dtb \ + aspeed-bmc-facebook-greatlakes.dtb \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ aspeed-bmc-facebook-wedge40.dtb \
arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts new file +241 -0
241 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoted 5 lines · Delphine CC Chiu
Add linux device tree entry related to
greatlakes specific devices connected to BMC SoC.---
--- v3 - Add documentation of board compatible (bindings)
Quoted 7 lines
--- - Add board compatible --- - Remove the bootargs --- - Revise the DTS node name---
--- v2 - Add binding document
---
--- v1 - Initial draft
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
Quoted 6 lines
---
Signed-off-by Bonnie Lo <[email protected]>--- arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++
You need to document the binding. I think you already did, but then submitted without it. Read the process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst
Best regards,
Krzysztof
v4 cover ARM: dts: Facebook Greatlakes platform
In reply to Delphine CC ChiuAdd linux device tree entry related to
greatlakes specific devices connected to BMC SoC.
v4 - Resend as series
v3 - Add documentation of board compatible (bindings)
- Add board compatible
- Remove the bootargs
- Revise the DTS node name
v2 - Add binding document
v1 - Initial draft
Delphine CC Chiu (2):
dt-bindings: arm: aspeed: add Facebook Greatlakes board
ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC
.../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++ 3 files changed, 243 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
Signature · 1 line
2.17.1
PATCH v4 1/2 dt-bindings: arm: aspeed: add Facebook Greatlakes board
In reply to Delphine CC ChiuDocument the new compatibles used on Facebook Greatlakes
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
@@ -77,6 +77,7 @@ properties: - facebook,cloudripper-bmc - facebook,elbert-bmc - facebook,fuji-bmc + - facebook,greatlakes-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmc
Signature · 1 line
2.17.1
Re: [PATCH v4 1/2] dt-bindings: arm: aspeed: add Facebook Greatlakes board
Quoted 5 lines · Delphine CC Chiu
Document the new compatibles used on Facebook Greatlakes
Signed-off-by Delphine CC Chiu <[email protected]>--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
Best regards,
Krzysztof
PATCH v4 2/2 ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC
In reply to Delphine CC ChiuAdd linux device tree entry related to
greatlakes specific devices connected to BMC SoC.
--- arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++ 2 files changed, 242 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -1594,6 +1594,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-elbert.dtb \ aspeed-bmc-facebook-fuji.dtb \ aspeed-bmc-facebook-galaxy100.dtb \ + aspeed-bmc-facebook-greatlakes.dtb \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ aspeed-bmc-facebook-wedge40.dtb \
arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts new file +241 -0
241 lines not on this page · raw message
Signature · 1 line
2.17.1