fanotify_mark.2: Document FAN_MARK_IGNORE
PATCH v2 1/1 fanotify_mark.2: Document FAN_MARK_IGNORE
A new flavor of FAN_MARK_IGNORED_MASK that helps to resolve the ambiguity around the combination of event flags and ignore mask.
It is also more strict in the events and flags allowed to be set in a non-directory inode mark mask and it mandates the use of FAN_MARK_IGNORED_SURV_MODIFY flag on filesystem, mount and directory inode marks.
---
Hi Alex,
This is the fanotify man page update for the 6.0 release.
Thanks,
Amir.
Changes since [v1]:
- Address review comments by Jan and Matthew
[v1] https://lore.kernel.org/linux-man/[email protected]/
man2/fanotify_mark.2 | 177 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 175 insertions(+), 2 deletions(-)
man2/fanotify_mark.2 +175 -2
@@ -146,12 +146,130 @@ capability. The events in .I mask shall be added to or removed from the ignore mask. +Note that the flags +.B FAN_ONDIR , +and +.B FAN_EVENT_ON_CHILD +have no effect when provided with this flag. +The effect of setting the flags +.B FAN_ONDIR , +and +.B FAN_EVENT_ON_CHILD +in the mark mask +on the events that are set in the ignore mask +is undefined and depends on the Linux kernel version. +Specifically, prior to Linux 5.9, +.\" commit 497b0c5a7c0688c1b100a9c2e267337f677c198e +setting a mark mask on a file +and a mark with ignore mask on its parent directory +would not result in ignoring events on the file, +regardless of the +.B FAN_EVENT_ON_CHILD +flag in the parent directory's mark mask. +When the ignore mask is updated with the +.B FAN_MARK_IGNORED_MASK +flag +on a mark that was previously updated with the +.B FAN_MARK_IGNORE +flag, +the update fails with +.B EEXIST +error. +.TP +.BR FAN_MARK_IGNORE " (since Linux 6.0)" +.\" commit e252f2ed1c8c6c3884ab5dd34e003ed21f1fe6e0 +This flag has a similar effect as setting the +.B FAN_MARK_IGNORED_MASK +flag. +The events in +.I mask +shall be added to or removed from the ignore mask. +Unlike the +.B FAN_MARK_IGNORED_MASK +flag, +this flag also has the effect that the +.B FAN_ONDIR , +and +.B FAN_EVENT_ON_CHILD +flags take effect on the ignore mask. +Specifically, unless the +.B FAN_ONDIR +flag is set with +.BR FAN_MARK_IGNORE , +events on directories will not be ignored. +If the flag +.B FAN_EVENT_ON_CHILD +is set with +.BR FAN_MARK_IGNORE , +events on children will be ignored. +For example, +a mark on a directory with combination of +a mask with +.B FAN_CREATE +event +and +.B FAN_ONDIR +flag +and an ignore mask with +.B FAN_CREATE +event +and without +.B FAN_ONDIR +flag, +will result in getting only +the events for creation of sub-directories. +When using the +.B FAN_MARK_IGNORE +flag to add to an ignore mask +of a mount, +filesystem, +or directory inode mark, +the +.B FAN_MARK_IGNORED_SURV_MODIFY +flag must be specified. +Failure to do so will results with +.B EINVAL +or +.B EISDIR +error. .TP .B FAN_MARK_IGNORED_SURV_MODIFY The ignore mask shall survive modify events. If this flag is not set, the ignore mask is cleared when a modify event occurs -for the ignored file or directory. +on the marked object. +Omitting this flag is typically used to suppress events +(e.g., +.BR FAN_OPEN ) +for a specific file, +until that specific file's content has been modified. +It is far less useful to suppress events +on an entire filesystem, +or mount, +or on all files inside a directory, +until some file's content has been modified. +For this reason, +the +.B FAN_MARK_IGNORE +flag requires the +.B FAN_MARK_IGNORED_SURV_MODIFY +flag on a mount, +filesystem, +or directory inode mark. +This flag cannot be removed from a mark once set. +When the ignore mask is updated without this flag +on a mark that was previously updated with the +.B FAN_MARK_IGNORE +and +.B FAN_MARK_IGNORED_SURV_MODIFY +flags, +the update fails with +.B EEXIST +error. +.TP +.B FAN_MARK_IGNORE_SURV +This is a synonym for +.RB ( FAN_MARK_IGNORE | FAN_MARK_IGNORED_SURV_MODIFY ). .TP .BR FAN_MARK_EVICTABLE " (since Linux 5.19)" .\" commit 5f9d3bd520261fd7a850818c71809fd580e0f30c
@@ -462,6 +580,32 @@ and the user attempted to update the mark with .B FAN_MARK_EVICTABLE flag. .TP +.B EEXIST +The filesystem object indicated by +.I dirfd +and +.I pathname +has a mark that was updated with the +.B FAN_MARK_IGNORE +flag, +and the user attempted to update the mark with +.B FAN_MARK_IGNORED_MASK +flag. +.TP +.B EEXIST +The filesystem object indicated by +.I dirfd +and +.I pathname +has a mark that was updated with the +.B FAN_MARK_IGNORE +and +.B FAN_MARK_IGNORED_SURV_MODIFY +flags, +and the user attempted to update the mark only with +.B FAN_MARK_IGNORE +flag. +.TP .B EINVAL An invalid value was passed in .I flags
@@ -487,8 +631,33 @@ but one or more event types specified in the .I mask require it. .TP +.B EINVAL +.I flags +contains +.BR FAN_MARK_IGNORE , +and either +.B FAN_MARK_MOUNT +or +.BR FAN_MARK_FILESYSTEM , +but does not contain +.BR FAN_MARK_IGNORED_SURV_MODIFY . +.TP +.B EISDIR +.I flags +contains +.BR FAN_MARK_IGNORE , +but does not contain +.BR FAN_MARK_IGNORED_SURV_MODIFY , +and +.I dirfd +and +.I pathname +specify a directory. +.TP .B ENODEV The filesystem object indicated by +.I dirfd +and .I pathname is not associated with a filesystem that supports .I fsid
@@ -550,8 +719,12 @@ and do not specify a directory. .TP .B ENOTDIR -The fanotify group was initialized with flag +.I flags +contains +.BR FAN_MARK_IGNORE , +or the fanotify group was initialized with flag .BR FAN_REPORT_TARGET_FID , +and .I mask contains directory entry modification events (e.g.,
Signature · 1 line
2.25.1
Hi Amir!
Quoted 17 lines · Amir Goldstein
A new flavor of
FAN_MARK_IGNORED_MASKthat helps to resolve the ambiguity around the combination of event flags and ignore mask.It is also more strict in the events and flags allowed to be set in a non-directory inode mark mask and it mandates the use of
FAN_MARK_IGNORED_SURV_MODIFYflag on filesystem, mount and directory inode marks.Reviewed-by Jan Kara <[email protected]>Reviewed-by Matthew Bobrowski <[email protected]>Signed-off-by Amir Goldstein <[email protected]>---
Hi Alex,
This is the fanotify man page update for the 6.0 release.
Quoted 7 lines
Thanks,
Amir.Changes since [v1]:
- Address review comments by Jan and Matthew
Thanks! The semantic newline usage is very good! ;) See some small formatting comments below.
Cheers,
Alex
Quoted 9 lines
man2/fanotify_mark.2 | 177 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 175 insertions(+), 2 deletions(-)man2/fanotify_mark.2 +0
-0
man2/fanotify_mark.2 capability. · line 155
Quoted 10 lines
man2/fanotify_mark.2 +7
-0@@ -146,12 +146,130 @@ capability. The events in .I mask shall be added to or removed from the ignore mask. +Note that the flags +.B FAN_ONDIR , +and +.B FAN_EVENT_ON_CHILD +have no effect when provided with this flag. +The effect of setting the flags +.B FAN_ONDIR ,
s/B/BR/
bold roman (alternating)
Quoted 26 lines
man2/fanotify_mark.2 +26
-0+and +.B FAN_EVENT_ON_CHILD +in the mark mask +on the events that are set in the ignore mask +is undefined and depends on the Linux kernel version. +Specifically, prior to Linux 5.9, +.\" commit 497b0c5a7c0688c1b100a9c2e267337f677c198e +setting a mark mask on a file +and a mark with ignore mask on its parent directory +would not result in ignoring events on the file, +regardless of the +.B FAN_EVENT_ON_CHILD +flag in the parent directory's mark mask. +When the ignore mask is updated with the +.B FAN_MARK_IGNORED_MASK +flag +on a mark that was previously updated with the +.B FAN_MARK_IGNORE +flag, +the update fails with +.B EEXIST +error. +.TP +.BR FAN_MARK_IGNORE " (since Linux 6.0)" +.\" commit e252f2ed1c8c6c3884ab5dd34e003ed21f1fe6e0 +This flag has a similar effect as setting the
man2/fanotify_mark.2 capability. · line 191
Quoted 10 lines
man2/fanotify_mark.2 +10
-0+.B FAN_MARK_IGNORED_MASK +flag. +The events in +.I mask +shall be added to or removed from the ignore mask. +Unlike the +.B FAN_MARK_IGNORED_MASK +flag, +this flag also has the effect that the +.B FAN_ONDIR ,
bold roman
Quoted 72 lines
man2/fanotify_mark.2 +66
-1+and +.B FAN_EVENT_ON_CHILD +flags take effect on the ignore mask. +Specifically, unless the +.B FAN_ONDIR +flag is set with +.BR FAN_MARK_IGNORE , +events on directories will not be ignored. +If the flag +.B FAN_EVENT_ON_CHILD +is set with +.BR FAN_MARK_IGNORE , +events on children will be ignored. +For example, +a mark on a directory with combination of +a mask with +.B FAN_CREATE +event +and +.B FAN_ONDIR +flag +and an ignore mask with +.B FAN_CREATE +event +and without +.B FAN_ONDIR +flag, +will result in getting only +the events for creation of sub-directories. +When using the +.B FAN_MARK_IGNORE +flag to add to an ignore mask +of a mount, +filesystem, +or directory inode mark, +the +.B FAN_MARK_IGNORED_SURV_MODIFY +flag must be specified. +Failure to do so will results with +.B EINVAL +or +.B EISDIR +error. .TP .B FAN_MARK_IGNORED_SURV_MODIFY The ignore mask shall survive modify events. If this flag is not set, the ignore mask is cleared when a modify event occurs -for the ignored file or directory. +on the marked object. +Omitting this flag is typically used to suppress events +(e.g., +.BR FAN_OPEN ) +for a specific file, +until that specific file's content has been modified. +It is far less useful to suppress events +on an entire filesystem, +or mount, +or on all files inside a directory, +until some file's content has been modified. +For this reason, +the +.B FAN_MARK_IGNORE +flag requires the +.B FAN_MARK_IGNORED_SURV_MODIFY +flag on a mount, +filesystem, +or directory inode mark. +This flag cannot be removed from a mark once set. +When the ignore mask is updated without this flag +on a mark that was previously updated with the +.B FAN_MARK_IGNORE
man2/fanotify_mark.2 capability. · line 272
Quoted 10 lines
man2/fanotify_mark.2 +10
-0+and +.B FAN_MARK_IGNORED_SURV_MODIFY +flags, +the update fails with +.B EEXIST +error. +.TP +.B FAN_MARK_IGNORE_SURV +This is a synonym for +.RB ( FAN_MARK_IGNORE | FAN_MARK_IGNORED_SURV_MODIFY ).
I'm not sure if I'd format this as code (italics) right?, rather than separate constant names.
Please check the below paragraphs from man-pages(7), and I'll leave the decission up to you.
See man-pages(7):
Complete commands should, if long, be written as an in‐ dented line on their own, with a blank line before and after the command, for example
man 7 man-pages
If the command is short, then it can be included inline in the text, in italic format, for example, man 7 man‐ pages. In this case, it may be worth using nonbreaking spaces (\~) at suitable places in the command. Command options should be written in italics (e.g., -l).
Expressions, if not written on a separate indented line, should be specified in italics. Again, the use of non‐ breaking spaces may be appropriate if the expression is inlined with normal text.
[The original text shows some formatting; see the manual page]
Quoted 84 lines
man2/fanotify_mark.2 +56
-1.TP .BR FAN_MARK_EVICTABLE " (since Linux 5.19)" .\" commit 5f9d3bd520261fd7a850818c71809fd580e0f30c@@ -462,6 +580,32 @@ and the user attempted to update the mark with .B FAN_MARK_EVICTABLE flag. .TP +.B EEXIST +The filesystem object indicated by +.I dirfd +and +.I pathname +has a mark that was updated with the +.B FAN_MARK_IGNORE +flag, +and the user attempted to update the mark with +.B FAN_MARK_IGNORED_MASK +flag. +.TP +.B EEXIST +The filesystem object indicated by +.I dirfd +and +.I pathname +has a mark that was updated with the +.B FAN_MARK_IGNORE +and +.B FAN_MARK_IGNORED_SURV_MODIFY +flags, +and the user attempted to update the mark only with +.B FAN_MARK_IGNORE +flag. +.TP .B EINVAL An invalid value was passed in .I flags@@ -487,8 +631,33 @@ but one or more event types specified in the .I mask require it. .TP +.B EINVAL +.I flags +contains +.BR FAN_MARK_IGNORE , +and either +.B FAN_MARK_MOUNT +or +.BR FAN_MARK_FILESYSTEM , +but does not contain +.BR FAN_MARK_IGNORED_SURV_MODIFY . +.TP +.B EISDIR +.I flags +contains +.BR FAN_MARK_IGNORE , +but does not contain +.BR FAN_MARK_IGNORED_SURV_MODIFY , +and +.I dirfd +and +.I pathname +specify a directory. +.TP .B ENODEV The filesystem object indicated by +.I dirfd +and .I pathname is not associated with a filesystem that supports .I fsid@@ -550,8 +719,12 @@ and do not specify a directory. .TP .B ENOTDIR -The fanotify group was initialized with flag +.I flags +contains +.BR FAN_MARK_IGNORE , +or the fanotify group was initialized with flag .BR FAN_REPORT_TARGET_FID , +and .I mask contains directory entry modification events (e.g.,
Signature · 1 line
<http://www.alejandro-colomar.es/>
Quoted 185 lines · Alejandro Colomar
Hi Amir!
Quoted 17 lines · Amir Goldstein
A new flavor of
FAN_MARK_IGNORED_MASKthat helps to resolve the ambiguity around the combination of event flags and ignore mask.It is also more strict in the events and flags allowed to be set in a non-directory inode mark mask and it mandates the use of
FAN_MARK_IGNORED_SURV_MODIFYflag on filesystem, mount and directory inode marks.Reviewed-by Jan Kara <[email protected]>Reviewed-by Matthew Bobrowski <[email protected]>Signed-off-by Amir Goldstein <[email protected]>---
Hi Alex,
This is the fanotify man page update for the 6.0 release.
Quoted 7 lines
Thanks,
Amir.Changes since [v1]:
- Address review comments by Jan and MatthewThanks! The semantic newline usage is very good! ;) See some small formatting comments below.
Cheers,
Alex
Quoted 9 lines
man2/fanotify_mark.2 | 177 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 175 insertions(+), 2 deletions(-)man2/fanotify_mark.2 +0
-0man2/fanotify_mark.2 capability. · line 155
Quoted 10 lines
man2/fanotify_mark.2 +7
-0@@ -146,12 +146,130 @@ capability. The events in .I mask shall be added to or removed from the ignore mask. +Note that the flags +.B FAN_ONDIR , +and +.B FAN_EVENT_ON_CHILD +have no effect when provided with this flag. +The effect of setting the flags +.B FAN_ONDIR ,s/B/BR/
bold roman (alternating)
Quoted 26 lines
man2/fanotify_mark.2 +26
-0+and +.B FAN_EVENT_ON_CHILD +in the mark mask +on the events that are set in the ignore mask +is undefined and depends on the Linux kernel version. +Specifically, prior to Linux 5.9, +.\" commit 497b0c5a7c0688c1b100a9c2e267337f677c198e +setting a mark mask on a file +and a mark with ignore mask on its parent directory +would not result in ignoring events on the file, +regardless of the +.B FAN_EVENT_ON_CHILD +flag in the parent directory's mark mask. +When the ignore mask is updated with the +.B FAN_MARK_IGNORED_MASK +flag +on a mark that was previously updated with the +.B FAN_MARK_IGNORE +flag, +the update fails with +.B EEXIST +error. +.TP +.BR FAN_MARK_IGNORE " (since Linux 6.0)" +.\" commit e252f2ed1c8c6c3884ab5dd34e003ed21f1fe6e0 +This flag has a similar effect as setting theman2/fanotify_mark.2 capability. · line 191
Quoted 10 lines
man2/fanotify_mark.2 +10
-0+.B FAN_MARK_IGNORED_MASK +flag. +The events in +.I mask +shall be added to or removed from the ignore mask. +Unlike the +.B FAN_MARK_IGNORED_MASK +flag, +this flag also has the effect that the +.B FAN_ONDIR ,bold roman
Quoted 72 lines
man2/fanotify_mark.2 +66
-1+and +.B FAN_EVENT_ON_CHILD +flags take effect on the ignore mask. +Specifically, unless the +.B FAN_ONDIR +flag is set with +.BR FAN_MARK_IGNORE , +events on directories will not be ignored. +If the flag +.B FAN_EVENT_ON_CHILD +is set with +.BR FAN_MARK_IGNORE , +events on children will be ignored. +For example, +a mark on a directory with combination of +a mask with +.B FAN_CREATE +event +and +.B FAN_ONDIR +flag +and an ignore mask with +.B FAN_CREATE +event +and without +.B FAN_ONDIR +flag, +will result in getting only +the events for creation of sub-directories. +When using the +.B FAN_MARK_IGNORE +flag to add to an ignore mask +of a mount, +filesystem, +or directory inode mark, +the +.B FAN_MARK_IGNORED_SURV_MODIFY +flag must be specified. +Failure to do so will results with +.B EINVAL +or +.B EISDIR +error. .TP .B FAN_MARK_IGNORED_SURV_MODIFY The ignore mask shall survive modify events. If this flag is not set, the ignore mask is cleared when a modify event occurs -for the ignored file or directory. +on the marked object. +Omitting this flag is typically used to suppress events +(e.g., +.BR FAN_OPEN ) +for a specific file, +until that specific file's content has been modified. +It is far less useful to suppress events +on an entire filesystem, +or mount, +or on all files inside a directory, +until some file's content has been modified. +For this reason, +the +.B FAN_MARK_IGNORE +flag requires the +.B FAN_MARK_IGNORED_SURV_MODIFY +flag on a mount, +filesystem, +or directory inode mark. +This flag cannot be removed from a mark once set. +When the ignore mask is updated without this flag +on a mark that was previously updated with the +.B FAN_MARK_IGNOREman2/fanotify_mark.2 capability. · line 272
Quoted 10 lines
man2/fanotify_mark.2 +10
-0+and +.B FAN_MARK_IGNORED_SURV_MODIFY +flags, +the update fails with +.B EEXIST +error. +.TP +.B FAN_MARK_IGNORE_SURV +This is a synonym for +.RB ( FAN_MARK_IGNORE | FAN_MARK_IGNORED_SURV_MODIFY ).I'm not sure if I'd format this as code (italics) right?, rather than separate constant names.
Quoted 3 lines
Please check the below paragraphs from man-pages(7), and I'll leave the decission up to you.
I kind of like it the way it is, which is also consistent with similar constructs in fanotify_init.2.
Would you like me to post v3 for the 2 minor formatting fixes? Or will you make them on commit?
Thanks,
Amir.
Hi Amir,
Quoted 9 lines · Amir Goldstein
Quoted 8 lines
Quoted 1 line
+.RB (
FAN_MARK_IGNORE|FAN_MARK_IGNORED_SURV_MODIFY).I'm not sure if I'd format this as code (italics) right?, rather than separate constant names.
Please check the below paragraphs from man-pages(7), and I'll leave the decission up to you.
Quoted 5 lines
I kind of like it the way it is, which is also consistent with similar constructs in fanotify_init.2.
Would you like me to post v3 for the 2 minor formatting fixes? Or will you make them on commit?
I can amend it; don't worry. Let me prepare the repo after the release, and I'll apply this patch. If I don't in a few days, please ping me.
Cheers,
Alex
Quoted 3 lines
Thanks,
Amir.
Signature · 1 line
<http://www.alejandro-colomar.es/>
Hi Amir,
Quoted 13 lines · Alejandro Colomar
Hi Amir,
Quoted 9 lines · Amir Goldstein
Quoted 8 lines
Quoted 1 line
+.RB (
FAN_MARK_IGNORE|FAN_MARK_IGNORED_SURV_MODIFY).I'm not sure if I'd format this as code (italics) right?, rather than separate constant names.
Please check the below paragraphs from man-pages(7), and I'll leave the decission up to you.
Quoted 7 lines
Quoted 5 lines
I kind of like it the way it is, which is also consistent with similar constructs in fanotify_init.2.
Would you like me to post v3 for the 2 minor formatting fixes? Or will you make them on commit?
I can amend it; don't worry. Let me prepare the repo after the release, and I'll apply this patch. If I don't in a few days, please ping me.
Patch applied.
Cheers,
Alex
Signature · 1 line
<http://www.alejandro-colomar.es/>