macvlan: enforce a consistent minimal mtu
Subsystems (2)
PATCH 1/1 macvlan: enforce a consistent minimal mtu
From: Eric Dumazet <[email protected]>
macvlan should enforce a minimal mtu of 68, even at link creation.
This patch avoids the current behavior (which could lead to crashes in ipv6 stack if the link is brought up)
$ ip link add macvlan1 link eno1 mtu 8 type macvlan # This should fail !
$ ip link sh dev macvlan1
5: macvlan1@eno1: <BROADCAST,MULTICAST> mtu 8 qdisc noop
state DOWN mode DEFAULT group default qlen 1000
link/ether 02:47:6c:24:74:82 brd ff:ff:ff:ff:ff:ff
$ ip link set macvlan1 mtu 67
Error: mtu less than device minimum.
$ ip link set macvlan1 mtu 68
$ ip link set macvlan1 mtu 8
Error: mtu less than device minimum.Fixes 91572088e3fd ("net: use core MTU range checking in core net infra")
Reported-by syzbot <[email protected]>
Signed-off-by Eric Dumazet <[email protected]>
--- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/macvlan.c +1 -1
@@ -1192,7 +1192,7 @@ void macvlan_common_setup(struct net_device *dev) {ether_setup (dev); - dev->min_mtu =0 ; +/* ether_setup() has set dev->min_mtu to ETH_MIN_MTU. */ dev->max_mtu =ETH_MAX_MTU ; dev->priv_flags &= ~IFF_TX_SKB_SHARING ;netif_keep_dst (dev);
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Fri, 7 Oct 2022 15:57:43 -0700 you wrote:
From: Eric Dumazet <[email protected]>
macvlan should enforce a minimal mtu of 68, even at link creation.
This patch avoids the current behavior (which could lead to crashes in ipv6 stack if the link is brought up)
[...]
Here is the summary with links:
- [net] macvlan: enforce a consistent minimal mtu
https://git.kernel.org/netdev/net/c/b64085b00044
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html