[PATCH 0/1]
Subsystems (2)
cover [PATCH 0/1]
Pinebook uses RTL8723CS for WiFi and bluetooth. Enable it in the device tree. This was part of a patch series adding RTL8723CS Bluetooth support to btrtl.
Vasily Khoruzhick (1):
arm64: allwinner: a64: enable Bluetooth on Pinebook
.../boot/dts/allwinner/sun50i-a64-pinebook.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Signature · 7 lines
2.37.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 arm64: allwinner: a64: enable Bluetooth on Pinebook
From: Vasily Khoruzhick <[email protected]>
Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1 and uses PL5 as device wake GPIO and PL6 as host wake GPIO. The I2C controlling signals are connected to R_I2C bus.
Enable it in the device tree.
--- .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +13 -0
@@ -406,6 +406,19 @@ &uart0 { status = "okay"; }; +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "okay"; + + bluetooth { + compatible = "realtek,rtl8723cs-bt"; + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */ + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ + }; +}; + &usb_otg { dr_mode = "host"; };
Signature · 7 lines
2.37.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
Quoted 5 lines · On 08.10.22 at 01:45 Bastian Germann wrote:
Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1 and uses PL5 as device wake GPIO and PL6 as host wake GPIO. The I2C controlling signals are connected to
R_I2Cbus.Enable it in the device tree.
Hey,
Any chance you have a look at this patch? It has been a month and it was the third time the patch hit the list. If there is something wrong with it I would appreciate a comment.
Thanks,
Bastian
Samuel Holland
maintainerRe: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
In reply to Bastian GermannHi Bastian,
Please make sure you include the sunxi platform maintainers (as reported by get_maintainers.pl) when sending your patch, so it gets in our inboxes.
Subject prefix should be "arm64: dts: allwinner: a64:" (with "dts:").
Quoted 5 lines · Bastian Germann
From: Vasily Khoruzhick <[email protected]>
Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1 and uses PL5 as device wake GPIO and PL6 as host wake GPIO. The I2C controlling signals are connected to
R_I2Cbus.
Please remove this sentence; it doesn't make sense. The RTL8723CS does not have any I2C connection.
Quoted 15 lines
Enable it in the device tree.
Signed-off-by Vasily Khoruzhick <[email protected]>Signed-off-by Bastian Germann <[email protected]>--- .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +0
-0@@ -406,6 +406,19 @@ &uart0 { status = "okay"; };
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts &uart0 { · line 417
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +9
-0+&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + uart-has-rtscts; + status = "okay"; + + bluetooth { + compatible = "realtek,rtl8723cs-bt"; + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
You also need:
enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
(this is BT-RST-N in the schematic).
The rest looks good to me.
Regards,
Samuel
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts +4
-0+ host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ + }; +}; + &usb_otg { dr_mode = "host"; };