linux-user: mprotect() should returns 0 when len is 0.
PATCH v3 1/1 linux-user: mprotect() should returns 0 when len is 0.
Quoted 1 line · Soichiro Isshiki
A validation for wrap-around was added, I think it is neccesory.
I noticed the validation for wrap-around is *not* necessary, because it is done by guest_range_valid_untagged().
Signed-off-by Soichiro Isshiki <[email protected]>
--- linux-user/mmap.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
linux-user/mmap.c +6 -6
@@ -124,17 +124,17 @@ int target_mprotect(abi_ulong start, abi_ulong len, int target_prot)if ((start & ~TARGET_PAGE_MASK ) !=0 ) {return -TARGET_EINVAL ; } - page_flags =validate_prot_to_pageflags (&host_prot, target_prot); -if (!page_flags) { -return -TARGET_EINVAL ; +if (len ==0 ) { +return 0 ; } len =TARGET_PAGE_ALIGN (len); - end = start + len;if (!guest_range_valid_untagged (start, len)) {return -TARGET_ENOMEM ; } -if (len ==0 ) { -return 0 ; + end = start + len; + page_flags =validate_prot_to_pageflags (&host_prot, target_prot); +if (!page_flags) { +return -TARGET_EINVAL ; }mmap_lock ();
Signature · 1 line
2.25.1