Convert Unisoc GPIO bindings to yaml and add support for UMS512
Subsystems (3)
Chunyan Zhang
reviewerv3 cover Convert Unisoc GPIO bindings to yaml and add support for UMS512
From: Chunyan Zhang <[email protected]>
V3:
- Removed a example from sprd,gpio-eic.yaml;
- Added '|' at the beginning of description blocks;
- Added Reviewed-by tags from Krzysztof Kozlowski and Linus Walleij.
Changes on V2:
* Addressed review comments:
- Fixed typo;
- Added description for 'reg' property and modified its maxItems;
- Removed redundant examples;
- Rephrased commit message.
Chunyan Zhang (3):
dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml
dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
dt-bindings: gpio: Add compatible string for Unisoc UMS512
.../bindings/gpio/gpio-eic-sprd.txt | 97 -------------- .../devicetree/bindings/gpio/gpio-sprd.txt | 28 ---- .../bindings/gpio/sprd,gpio-eic.yaml | 124 ++++++++++++++++++ .../devicetree/bindings/gpio/sprd,gpio.yaml | 75 +++++++++++ 4 files changed, 199 insertions(+), 125 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-sprd.txt create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
Signature · 1 line
2.25.1
Chunyan Zhang
reviewerPATCH v3 1/3 dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml
From: Chunyan Zhang <[email protected]>
Convert the Unisoc gpio controller binding to DT schema format.
--- .../devicetree/bindings/gpio/gpio-sprd.txt | 28 -------- .../devicetree/bindings/gpio/sprd,gpio.yaml | 70 +++++++++++++++++++ 2 files changed, 70 insertions(+), 28 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-sprd.txt create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
Documentation/devicetree/bindings/gpio/gpio-sprd.txt deleted +0 -28
@@ -1,28 +0,0 @@ -Spreadtrum GPIO controller bindings - -The controller's registers are organized as sets of sixteen 16-bit -registers with each set controlling a bank of up to 16 pins. A single -interrupt is shared for all of the banks handled by the controller. - -Required properties: -- compatible: Should be "sprd,sc9860-gpio". -- reg: Define the base and range of the I/O address space containing -the GPIO controller registers. -- gpio-controller: Marks the device node as a GPIO controller. -- #gpio-cells: Should be <2>. The first cell is the gpio number and -the second cell is used to specify optional parameters. -- interrupt-controller: Marks the device node as an interrupt controller. -- #interrupt-cells: Should be <2>. Specifies the number of cells needed -to encode interrupt source. -- interrupts: Should be the port interrupt shared by all the gpios. - -Example: - ap_gpio: gpio@40280000 { - compatible = "sprd,sc9860-gpio"; - reg = <0 0x40280000 0 0x1000>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; - };
Documentation/devicetree/bindings/gpio/sprd,gpio.yaml new file +70 -0
70 lines not on this page · raw message
Signature · 1 line
2.25.1
Chunyan Zhang
reviewerPATCH v3 2/3 dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
In reply to Chunyan ZhangFrom: Chunyan Zhang <[email protected]>
Convert the Unisoc EIC controller binding to DT schema format. Update the maxItems of 'reg' property, since the current gpio-eic-sprd driver supports 3 reg items. Also removed a few similar examples.
--- .../bindings/gpio/gpio-eic-sprd.txt | 97 ----------------- .../bindings/gpio/sprd,gpio-eic.yaml | 103 ++++++++++++++++++ 2 files changed, 103 insertions(+), 97 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt deleted +0 -97
@@ -1,97 +0,0 @@ -Spreadtrum EIC controller bindings - -The EIC is the abbreviation of external interrupt controller, which can -be used only in input mode. The Spreadtrum platform has 2 EIC controllers, -one is in digital chip, and another one is in PMIC. The digital chip EIC -controller contains 4 sub-modules: EIC-debounce, EIC-latch, EIC-async and -EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub- -module. - -The EIC-debounce sub-module provides up to 8 source input signal -connections. A debounce mechanism is used to capture the input signals' -stable status (millisecond resolution) and a single-trigger mechanism -is introduced into this sub-module to enhance the input event detection -reliability. In addition, this sub-module's clock can be shut off -automatically to reduce power dissipation. Moreover the debounce range -is from 1ms to 4s with a step size of 1ms. The input signal will be -ignored if it is asserted for less than 1 ms. - -The EIC-latch sub-module is used to latch some special power down signals -and generate interrupts, since the EIC-latch does not depend on the APB -clock to capture signals. - -The EIC-async sub-module uses a 32kHz clock to capture the short signals -(microsecond resolution) to generate interrupts by level or edge trigger. - -The EIC-sync is similar with GPIO's input function, which is a synchronized -signal input register. It can generate interrupts by level or edge trigger -when detecting input signals. - -Required properties: -- compatible: Should be one of the following: - "sprd,sc9860-eic-debounce", - "sprd,sc9860-eic-latch", - "sprd,sc9860-eic-async", - "sprd,sc9860-eic-sync", - "sprd,sc2731-eic". -- reg: Define the base and range of the I/O address space containing - the GPIO controller registers. -- gpio-controller: Marks the device node as a GPIO controller. -- #gpio-cells: Should be <2>. The first cell is the gpio number and - the second cell is used to specify optional parameters. -- interrupt-controller: Marks the device node as an interrupt controller. -- #interrupt-cells: Should be <2>. Specifies the number of cells needed - to encode interrupt source. -- interrupts: Should be the port interrupt shared by all the gpios. - -Example: - eic_debounce: gpio@40210000 { - compatible = "sprd,sc9860-eic-debounce"; - reg = <0 0x40210000 0 0x80>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; - }; - - eic_latch: gpio@40210080 { - compatible = "sprd,sc9860-eic-latch"; - reg = <0 0x40210080 0 0x20>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; - }; - - eic_async: gpio@402100a0 { - compatible = "sprd,sc9860-eic-async"; - reg = <0 0x402100a0 0 0x20>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; - }; - - eic_sync: gpio@402100c0 { - compatible = "sprd,sc9860-eic-sync"; - reg = <0 0x402100c0 0 0x20>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; - }; - - pmic_eic: gpio@300 { - compatible = "sprd,sc2731-eic"; - reg = <0x300>; - interrupt-parent = <&sc2731_pmic>; - interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - };
Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml new file +103 -0
103 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH V3 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
Quoted 6 lines · Chunyan Zhang
From: Chunyan Zhang <[email protected]>
Convert the Unisoc EIC controller binding to DT schema format. Update the maxItems of 'reg' property, since the current gpio-eic-sprd driver supports 3 reg items. Also removed a few similar examples.
Quoted 8 lines
Signed-off-by Chunyan Zhang <[email protected]>--- .../bindings/gpio/gpio-eic-sprd.txt | 97 ----------------- .../bindings/gpio/sprd,gpio-eic.yaml | 103 ++++++++++++++++++ 2 files changed, 103 insertions(+), 97 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
Chunyan Zhang
reviewerPATCH v3 3/3 dt-bindings: gpio: Add compatible string for Unisoc UMS512
In reply to Chunyan ZhangFrom: Chunyan Zhang <[email protected]>
UMS512 use the same GPIO and EIC controller with SC9860.
--- .../bindings/gpio/sprd,gpio-eic.yaml | 33 +++++++++++++++---- .../devicetree/bindings/gpio/sprd,gpio.yaml | 7 +++- 2 files changed, 33 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml +27 -6
@@ -42,12 +42,33 @@ description: | properties: compatible: - enum: - - sprd,sc9860-eic-debounce - - sprd,sc9860-eic-latch - - sprd,sc9860-eic-async - - sprd,sc9860-eic-sync - - sprd,sc2731-eic + oneOf: + - enum: + - sprd,sc9860-eic-debounce + - sprd,sc9860-eic-latch + - sprd,sc9860-eic-async + - sprd,sc9860-eic-sync + - sprd,sc2731-eic + - items: + - enum: + - sprd,ums512-eic-debounce + - const: sprd,sc9860-eic-debounce + - items: + - enum: + - sprd,ums512-eic-latch + - const: sprd,sc9860-eic-latch + - items: + - enum: + - sprd,ums512-eic-async + - const: sprd,sc9860-eic-async + - items: + - enum: + - sprd,ums512-eic-sync + - const: sprd,sc9860-eic-sync + - items: + - enum: + - sprd,sc2730-eic + - const: sprd,sc2731-eic reg: minItems: 1
Documentation/devicetree/bindings/gpio/sprd,gpio.yaml +6 -1
@@ -19,7 +19,12 @@ description: | properties: compatible: - const: sprd,sc9860-gpio + oneOf: + - const: sprd,sc9860-gpio + - items: + - enum: + - sprd,ums512-gpio + - const: sprd,sc9860-gpio reg: maxItems: 1
Signature · 1 line
2.25.1