Enable LKGS instruction
Subsystems (3)
v2 cover Enable LKGS instruction
LKGS instruction is introduced with Intel FRED (flexible return and event delivery) specification https://cdrdv2.intel.com/v1/dl/getContent/678938.
LKGS is independent of FRED, so we enable it as a standalone CPU feature.
LKGS behaves like the MOV to GS instruction except that it loads the base address into the IA32_KERNEL_GS_BASE MSR instead of the GS segment’s descriptor cache, which is exactly what Linux kernel does to load user level GS base. Thus, with LKGS, there is no need to SWAPGS away from the kernel GS base.
Changes since V1:
* place fixup code into code section "__ex_table" instead of the obsoleted "fixup" section.
* add a comment that states the LKGS_DI macro will be repalced with "lkgs %di" once the binutils support LKGS instruction.
H. Peter Anvin (Intel) (6):
x86/cpufeature: add cpu feature bit for LKGS
x86/opcode: add LKGS instruction to x86-opcode-map x86/gsseg: make asm_load_gs_index() take an u16 x86/gsseg: move local_irq_save/restore() into asm_load_gs_index() x86/gsseg: move load_gs_index() to its own header file x86/gsseg: use the LKGS instruction if available for load_gs_index()
arch/x86/entry/entry_64.S | 28 +++++++++--- arch/x86/ia32/ia32_signal.c | 1 + arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/gsseg.h | 57 ++++++++++++++++++++++++ arch/x86/include/asm/mmu_context.h | 1 + arch/x86/include/asm/special_insns.h | 21 --------- arch/x86/kernel/paravirt.c | 1 + arch/x86/kernel/tls.c | 1 + arch/x86/lib/x86-opcode-map.txt | 1 + tools/arch/x86/include/asm/cpufeatures.h | 1 + tools/arch/x86/lib/x86-opcode-map.txt | 1 + 11 files changed, 87 insertions(+), 27 deletions(-) create mode 100644 arch/x86/include/asm/gsseg.h
Signature · 1 line
2.34.1
PATCH v2 1/6 x86/cpufeature: add cpu feature bit for LKGS
From: "H. Peter Anvin (Intel)" <[email protected]>
Add the CPU feature bit for LKGS (Load "Kernel" GS).
LKGS instruction is introduced with Intel FRED (flexible return and event delivery) specificaton
https://cdrdv2.intel.com/v1/dl/getContent/678938.
LKGS behaves like the MOV to GS instruction except that it loads the base address into the IA32_KERNEL_GS_BASE MSR instead of the GS segment’s descriptor cache, which is exactly what Linux kernel does to load a user level GS base. Thus, with LKGS, there is no need to SWAPGS away from the kernel GS base.
--- arch/x86/include/asm/cpufeatures.h | 1 + tools/arch/x86/include/asm/cpufeatures.h | 1 + 2 files changed, 2 insertions(+)
arch/x86/include/asm/cpufeatures.h +1 -0
@@ -308,6 +308,7 @@/* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4)/* AVX VNNI instructions */ #define X86_FEATURE_AVX512_BF16 (12*32+ 5)/* AVX512 BFLOAT16 instructions */ +#define X86_FEATURE_LKGS (12*32+ 18)/* Load "kernel" (userspace) gs */ /* AMD-defined CPU features, CPUID level 0x80000008 (EBX), word 13 */ #define X86_FEATURE_CLZERO (13*32+ 0)/* CLZERO instruction */
tools/arch/x86/include/asm/cpufeatures.h +1 -0
@@ -308,6 +308,7 @@/* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4)/* AVX VNNI instructions */ #define X86_FEATURE_AVX512_BF16 (12*32+ 5)/* AVX512 BFLOAT16 instructions */ +#define X86_FEATURE_LKGS (12*32+ 18)/* Load "kernel" (userspace) gs */ /* AMD-defined CPU features, CPUID level 0x80000008 (EBX), word 13 */ #define X86_FEATURE_CLZERO (13*32+ 0)/* CLZERO instruction */
Signature · 1 line
2.34.1
Re: [PATCH v2 1/6] x86/cpufeature: add cpu feature bit for LKGS
arch/x86/include/asm/cpufeatures.h line 311
Quoted 10 lines · Xin Li
arch/x86/include/asm/cpufeatures.h +1
-0@@ -308,6 +308,7 @@/* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4)/* AVX VNNI instructions */ #define X86_FEATURE_AVX512_BF16 (12*32+ 5)/* AVX512 BFLOAT16 instructions */ +#define X86_FEATURE_LKGS (12*32+ 18)/* Load "kernel" (userspace) gs */
The spec says [1]:
"Execution of LKGS causes an invalid-opcode exception (#UD) if CPL >
0."
Perhaps userspace has no interest in this. Then, we can add "" not to show "lkgs" in /proc/cpuinfo:
+#define X86_FEATURE_LKGS (12*32+ 18) /* "" Load "kernel"
(userspace) gs */
Thanks,
Chang
RE: [PATCH v2 1/6] x86/cpufeature: add cpu feature bit for LKGS
Quoted 15 lines
arch/x86/include/asm/cpufeatures.h line 309
Quoted 9 lines
arch/x86/include/asm/cpufeatures.h +0
-0@@ -308,6 +308,7 @@/* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4)/* AVX VNNI instructions */
arch/x86/include/asm/cpufeatures.h line 310
Quoted 1 line
arch/x86/include/asm/cpufeatures.h +0
-0#define X86_FEATURE_AVX512_BF16 (12*32+ 5)/* AVX512 BFLOAT16 instructions */
arch/x86/include/asm/cpufeatures.h line 311
Quoted 1 line
arch/x86/include/asm/cpufeatures.h +1
-0+#define X86_FEATURE_LKGS (12*32+ 18)/* Load "kernel" (userspace) gs */
Quoted 8 lines
The spec says [1]:
"Execution of LKGS causes an invalid-opcode exception (#UD) if CPL >
0."Perhaps userspace has no interest in this. Then, we can add "" not to show "lkgs" in
/proc/cpuinfo:+#define X86_FEATURE_LKGS (12*32+ 18) /* "" Load "kernel"(userspace) gs */
Good point!
Quoted 5 lines
Thanks,
Chang
H. Peter Anvin
reviewerRE: [PATCH v2 1/6] x86/cpufeature: add cpu feature bit for LKGS
Quoted 19 lines · On October 13, 2022 12:35:23 PM PDT, "Li, Xin3" <[email protected]> wrote:
Quoted 19 lines
arch/x86/include/asm/cpufeatures.h line 309
Quoted 9 lines
arch/x86/include/asm/cpufeatures.h +0
-0@@ -308,6 +308,7 @@/* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */ #define X86_FEATURE_AVX_VNNI (12*32+ 4)/* AVX VNNI instructions */
arch/x86/include/asm/cpufeatures.h line 310
Quoted 1 line
arch/x86/include/asm/cpufeatures.h +0
-0#define X86_FEATURE_AVX512_BF16 (12*32+ 5)/* AVX512 BFLOAT16 instructions */
arch/x86/include/asm/cpufeatures.h line 311
Quoted 1 line
arch/x86/include/asm/cpufeatures.h +1
-0+#define X86_FEATURE_LKGS (12*32+ 18)/* Load "kernel" (userspace) gs */
The spec says [1]:
"Execution of LKGS causes an invalid-opcode exception (#UD) if CPL >
0."
Quoted 13 lines
Quoted 4 lines
Perhaps userspace has no interest in this. Then, we can add "" not to show "lkgs" in
/proc/cpuinfo:+#define X86_FEATURE_LKGS (12*32+ 18) /* "" Load "kernel"(userspace) gs */
Good point!
Quoted 5 lines
Thanks,
Chang
It would be useful for reviewers to mention that this is was a policy change on the maintainers' part. This is totally valid, of course, but making it explicit would perhaps help reduce potential confusion.
PATCH v2 2/6 x86/opcode: add LKGS instruction to x86-opcode-map
In reply to Xin LiFrom: "H. Peter Anvin (Intel)" <[email protected]>
Add the instruction opcode used by LKGS.
Opcode number is per public FRED draft spec v3.0
https://cdrdv2.intel.com/v1/dl/getContent/678938.
--- arch/x86/lib/x86-opcode-map.txt | 1 + tools/arch/x86/lib/x86-opcode-map.txt | 1 + 2 files changed, 2 insertions(+)
arch/x86/lib/x86-opcode-map.txt +1 -0
@@ -1047,6 +1047,7 @@ GrpTable: Grp6 3: LTR Ew 4: VERR Ew 5: VERW Ew +6: LKGS Ew (F2) EndTable GrpTable: Grp7
tools/arch/x86/lib/x86-opcode-map.txt +1 -0
@@ -1047,6 +1047,7 @@ GrpTable: Grp6 3: LTR Ew 4: VERR Ew 5: VERW Ew +6: LKGS Ew (F2) EndTable GrpTable: Grp7
Signature · 1 line
2.34.1
PATCH v2 3/6 x86/gsseg: make asm_load_gs_index() take an u16
In reply to Xin LiFrom: "H. Peter Anvin (Intel)" <[email protected]>
Let gcc know that only the low 16 bits of load_gs_index() argument actually matter. It might allow it to create slightly better code. However, do not propagate this into the prototypes of functions that end up being paravirtualized, to avoid unnecessary changes.
--- arch/x86/entry/entry_64.S | 2 +- arch/x86/include/asm/special_insns.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/entry/entry_64.S +1 -1
@@ -779,7 +779,7 @@ _ASM_NOKPROBE(common_interrupt_return) /* * Reload gs selector with exception handling - * edi: new selector + * di: new selector * * Is in entry.text as it shouldn't be instrumented. */
arch/x86/include/asm/special_insns.h +1 -1
@@ -120,7 +120,7 @@ static inline void native_wbinvd(void) asmvolatile ("wbinvd" : : :"memory" ); } -extern asmlinkage void asm_load_gs_index(unsigned int selector); +extern asmlinkage void asm_load_gs_index(u16 selector);static inline void native_load_gs_index (unsigned int selector) {
Signature · 1 line
2.34.1
PATCH v2 4/6 x86/gsseg: move local_irq_save/restore() into asm_load_gs_index()
In reply to Xin LiFrom: "H. Peter Anvin (Intel)" <[email protected]>
The need to disable/enable interrupts around asm_load_gs_index() is a consequence of the implementation. Prepare for using the LKGS instruction, which is locally atomic and therefore doesn't need interrupts disabled.
--- arch/x86/entry/entry_64.S | 26 +++++++++++++++++++++----- arch/x86/include/asm/special_insns.h | 4 ---- 2 files changed, 21 insertions(+), 9 deletions(-)
arch/x86/entry/entry_64.S +21 -5
@@ -778,19 +778,35 @@ SYM_CODE_END(common_interrupt_return) _ASM_NOKPROBE(common_interrupt_return) /* - * Reload gs selector with exception handling + * Reload gs selector with exception handling. This is used only on + * native, so using swapgs, pushf, popf, cli, sti, ... directly is fine. + * * di: new selector + * rax: scratch register * * Is in entry.text as it shouldn't be instrumented. + * + * Note: popf is slow, so use pushf to read IF and then execute cli/sti + * if necessary. */ SYM_FUNC_START(asm_load_gs_index) FRAME_BEGIN + pushf + pop %rax + andl $X86_EFLAGS_IF, %eax /* Interrupts enabled? */ + jz 1f + cli +1: swapgs .Lgs_change: ANNOTATE_NOENDBR // error_entry movl %edi, %gs 2: ALTERNATIVE "", "mfence", X86_BUG_SWAPGS_FENCE swapgs + testl %eax, %eax + jz 3f + sti +3: FRAME_END RET
@@ -799,12 +815,12 @@ SYM_FUNC_START(asm_load_gs_index) swapgs /* switch back to user gs */ .macro ZAP_GS /* This can't be a string because the preprocessor needs to see it. */ - movl $__USER_DS, %eax - movl %eax, %gs + movl $__USER_DS, %edi + movl %edi, %gs .endm ALTERNATIVE "", "ZAP_GS", X86_BUG_NULL_SEG - xorl %eax, %eax - movl %eax, %gs + xorl %edi, %edi + movl %edi, %gs jmp 2b _ASM_EXTABLE(.Lgs_change, .Lbad_gs)
arch/x86/include/asm/special_insns.h +0 -4
@@ -124,11 +124,7 @@ extern asmlinkage void asm_load_gs_index(u16 selector);static inline void native_load_gs_index (unsigned int selector) { -unsigned long flags; - -local_irq_save (flags);asm_load_gs_index (selector); -local_irq_restore (flags); }static inline unsigned long __read_cr4 (void )
Signature · 1 line
2.34.1
PATCH v2 5/6 x86/gsseg: move load_gs_index() to its own header file
In reply to Xin LiFrom: "H. Peter Anvin (Intel)" <[email protected]>
<asm/cpufeature.h> depends on <asm/special_insns.h>, so in order to be able to use alternatives in native_load_gs_index(), factor it out into a separate header file.
--- arch/x86/ia32/ia32_signal.c | 1 + arch/x86/include/asm/gsseg.h | 32 ++++++++++++++++++++++++++++ arch/x86/include/asm/mmu_context.h | 1 + arch/x86/include/asm/special_insns.h | 17 --------------- arch/x86/kernel/paravirt.c | 1 + arch/x86/kernel/tls.c | 1 + 6 files changed, 36 insertions(+), 17 deletions(-) create mode 100644 arch/x86/include/asm/gsseg.h
arch/x86/ia32/ia32_signal.c +1 -0
@@ -34,6 +34,7 @@#include <asm/sigframe.h> #include <asm/sighandling.h> #include <asm/smap.h> +#include <asm/gsseg.h> static inline void reload_segments (struct sigcontext_32 *sc) {
arch/x86/include/asm/gsseg.h new file +32 -0
@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef _ASM_X86_GSSEG_H +#define _ASM_X86_GSSEG_H + +#include <linux/types.h> +#include <asm/processor.h> + +#ifdef CONFIG_X86_64 + +extern asmlinkage void asm_load_gs_index(u16 selector); + +static inline void native_load_gs_index (unsigned int selector) +{ +asm_load_gs_index (selector); +} + +#endif /* CONFIG_X86_64 */ + +#ifndef CONFIG_PARAVIRT_XXL + +static inline void load_gs_index (unsigned int selector) +{ +#ifdef CONFIG_X86_64 +native_load_gs_index (selector); +#else +loadsegment (gs, selector); +#endif +} + +#endif /* CONFIG_PARAVIRT_XXL */ + +#endif /* _ASM_X86_GSSEG_H */
arch/x86/include/asm/mmu_context.h +1 -0
@@ -12,6 +12,7 @@#include <asm/tlbflush.h> #include <asm/paravirt.h> #include <asm/debugreg.h> +#include <asm/gsseg.h> extern atomic64_t last_mm_ctx_id;
arch/x86/include/asm/special_insns.h +0 -17
@@ -120,13 +120,6 @@ static inline void native_wbinvd(void) asmvolatile ("wbinvd" : : :"memory" ); } -extern asmlinkage void asm_load_gs_index(u16 selector); - -static inline void native_load_gs_index (unsigned int selector) -{ -asm_load_gs_index (selector); -} -static inline unsigned long __read_cr4 (void ) {return native_read_cr4 ();
@@ -180,16 +173,6 @@ static inline void wbinvd(void) native_wbinvd(); } - -static inline void load_gs_index (unsigned int selector) -{ -#ifdef CONFIG_X86_64 -native_load_gs_index (selector); -#else -loadsegment (gs, selector); -#endif -} -#endif /* CONFIG_PARAVIRT_XXL */ static inline void clflush (volatile void *__p)
arch/x86/kernel/paravirt.c +1 -0
@@ -32,6 +32,7 @@#include <asm/special_insns.h> #include <asm/tlb.h> #include <asm/io_bitmap.h> +#include <asm/gsseg.h> /* * nop stub, which must not clobber anything *including the stack* to
arch/x86/kernel/tls.c +1 -0
@@ -12,6 +12,7 @@#include <asm/ldt.h> #include <asm/processor.h> #include <asm/proto.h> +#include <asm/gsseg.h> #include "tls.h"
Signature · 1 line
2.34.1
PATCH v2 6/6 x86/gsseg: use the LKGS instruction if available for load_gs_index()
In reply to Xin LiFrom: "H. Peter Anvin (Intel)" <[email protected]>
The LKGS instruction atomically loads a segment descriptor into the %gs descriptor registers, *except* that %gs.base is unchanged, and the base is instead loaded into MSR_IA32_KERNEL_GS_BASE, which is exactly what we want this function to do.
--- arch/x86/include/asm/gsseg.h | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)
arch/x86/include/asm/gsseg.h +26 -1
@@ -3,15 +3,40 @@#define _ASM_X86_GSSEG_H#include <linux/types.h> + +#include <asm/asm.h> +#include <asm/cpufeature.h> +#include <asm/alternative.h> #include <asm/processor.h> +#include <asm/nops.h> #ifdef CONFIG_X86_64 extern asmlinkage void asm_load_gs_index(u16 selector); +/* Replace with "lkgs %di" once binutils support LKGS instruction */ +#define LKGS_DI _ASM_BYTES(0xf2,0x0f,0x00,0xf7) + static inline void native_load_gs_index(unsigned int selector) { -asm_load_gs_index (selector); + u16 sel = selector; + + /* + * Note: the fixup is used for the LKGS instruction, but + * it needs to be attached to the primary instruction sequence + * as it isn't something that gets patched. + * + * %rax is provided to the assembly routine as a scratch + * register. + */ + asm_inline volatile("1:\n" + ALTERNATIVE("call asm_load_gs_index\n", + _ASM_BYTES(0x3e) LKGS_DI, + X86_FEATURE_LKGS) + _ASM_EXTABLE_TYPE_REG(1b, 1b, EX_TYPE_ZERO_REG, %k[sel]) + : ASM_CALL_CONSTRAINT + : [sel] "D" (sel) + : "memory", _ASM_AX); } #endif /* CONFIG_X86_64 */
Signature · 1 line
2.34.1
Re: [PATCH v2 6/6] x86/gsseg: use the LKGS instruction if available for load_gs_index()
Quoted 49 lines · Xin Li
From: "H. Peter Anvin (Intel)" <[email protected]>
The LKGS instruction atomically loads a segment descriptor into the %gs descriptor registers, *except* that %gs.base is unchanged, and the base is instead loaded into
MSR_IA32_KERNEL_GS_BASE, which is exactly what we want this function to do.Signed-off-by H. Peter Anvin (Intel) <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>Signed-off-by Xin Li <[email protected]>--- arch/x86/include/asm/gsseg.h | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)arch/x86/include/asm/gsseg.h +15
-1@@ -3,15 +3,40 @@#define _ASM_X86_GSSEG_H#include <linux/types.h> + +#include <asm/asm.h> +#include <asm/cpufeature.h> +#include <asm/alternative.h> #include <asm/processor.h> +#include <asm/nops.h> #ifdef CONFIG_X86_64 extern asmlinkage void asm_load_gs_index(u16 selector); +/* Replace with "lkgs %di" once binutils support LKGS instruction */ +#define LKGS_DI _ASM_BYTES(0xf2,0x0f,0x00,0xf7) +static inline void native_load_gs_index (unsigned int selector) { -asm_load_gs_index (selector); +u16 sel = selector; + +/* +* Note: the fixup is used for the LKGS instruction, but +* it needs to be attached to the primary instruction sequence +* as it isn't something that gets patched. +*
arch/x86/include/asm/gsseg.h line 38
Quoted 10 lines
arch/x86/include/asm/gsseg.h +10
-0+* %rax is provided to the assembly routine as a scratch +* register. +*/ + asm_inline volatile("1:\n" + ALTERNATIVE("call asm_load_gs_index\n", + _ASM_BYTES(0x3e) LKGS_DI, + X86_FEATURE_LKGS) + _ASM_EXTABLE_TYPE_REG(1b, 1b, EX_TYPE_ZERO_REG, %k[sel]) + : ASM_CALL_CONSTRAINT + : [sel] "D" (sel)
DI needs to be marked as input and output (+D), since the exception handler modifies it.
arch/x86/include/asm/gsseg.h line 39
Quoted 1 line
arch/x86/include/asm/gsseg.h +1
-0+ : "memory", _ASM_AX);
_ASM_AX is only needed for code that is used by both 32 and 64-bit. Since this is 64-bit only, "rax" would be appropriate.
--
Brian Gerst
H. Peter Anvin
reviewerRe: [PATCH v2 6/6] x86/gsseg: use the LKGS instruction if available for load_gs_index()
Quoted 64 lines · Brian Gerst
Quoted 49 lines · Xin Li
From: "H. Peter Anvin (Intel)" <[email protected]>
The LKGS instruction atomically loads a segment descriptor into the %gs descriptor registers, *except* that %gs.base is unchanged, and the base is instead loaded into
MSR_IA32_KERNEL_GS_BASE, which is exactly what we want this function to do.Signed-off-by H. Peter Anvin (Intel) <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>Signed-off-by Xin Li <[email protected]>--- arch/x86/include/asm/gsseg.h | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)arch/x86/include/asm/gsseg.h +15
-1@@ -3,15 +3,40 @@#define _ASM_X86_GSSEG_H#include <linux/types.h> + +#include <asm/asm.h> +#include <asm/cpufeature.h> +#include <asm/alternative.h> #include <asm/processor.h> +#include <asm/nops.h> #ifdef CONFIG_X86_64 extern asmlinkage void asm_load_gs_index(u16 selector); +/* Replace with "lkgs %di" once binutils support LKGS instruction */ +#define LKGS_DI _ASM_BYTES(0xf2,0x0f,0x00,0xf7) +static inline void native_load_gs_index (unsigned int selector) { -asm_load_gs_index (selector); +u16 sel = selector; + +/* +* Note: the fixup is used for the LKGS instruction, but +* it needs to be attached to the primary instruction sequence +* as it isn't something that gets patched. +* arch/x86/include/asm/gsseg.h line 38
Quoted 10 lines
arch/x86/include/asm/gsseg.h +10
-0+* %rax is provided to the assembly routine as a scratch +* register. +*/ + asm_inline volatile("1:\n" + ALTERNATIVE("call asm_load_gs_index\n", + _ASM_BYTES(0x3e) LKGS_DI, + X86_FEATURE_LKGS) + _ASM_EXTABLE_TYPE_REG(1b, 1b, EX_TYPE_ZERO_REG, %k[sel]) + : ASM_CALL_CONSTRAINT + : [sel] "D" (sel)DI needs to be marked as input and output (+D), since the exception handler modifies it.
Quoted 7 lines
arch/x86/include/asm/gsseg.h line 39
Quoted 1 line
arch/x86/include/asm/gsseg.h +1
-0+ : "memory", _ASM_AX);
_ASM_AXis only needed for code that is used by both 32 and 64-bit. Since this is 64-bit only, "rax" would be appropriate.--
Brian Gerst
The practice seems to have been to prefer the macros for consistency.
RE: [PATCH v2 6/6] x86/gsseg: use the LKGS instruction if available for load_gs_index()
In reply to Brian GerstQuoted 11 lines
arch/x86/include/asm/gsseg.h
Quoted 5 lines
arch/x86/include/asm/gsseg.h +5
-0+ asm_inline volatile("1:\n" + ALTERNATIVE("call asm_load_gs_index\n", + _ASM_BYTES(0x3e) LKGS_DI, + X86_FEATURE_LKGS) + _ASM_EXTABLE_TYPE_REG(1b, 1b, EX_TYPE_ZERO_REG,%k[sel])
arch/x86/include/asm/gsseg.h line 38
Quoted 2 lines
arch/x86/include/asm/gsseg.h +2
-0+ : ASM_CALL_CONSTRAINT + : [sel] "D" (sel)DI needs to be marked as input and output (+D), since the exception handler modifies it.
Good catch, I accidently removed it from the first version, will add it back. Xin
H. Peter Anvin
reviewerQuoted 11 lines · Xin Li
LKGS instruction is introduced with Intel FRED (flexible return and event delivery) specification https://cdrdv2.intel.com/v1/dl/getContent/678938.
LKGS is independent of FRED, so we enable it as a standalone CPU feature.
LKGS behaves like the MOV to GS instruction except that it loads the base address into the
IA32_KERNEL_GS_BASEMSR instead of the GS segment’s descriptor cache, which is exactly what Linux kernel does to load user level GS base. Thus, with LKGS, there is no need to SWAPGS away from the kernel GS base.
Quoted 4 lines
Changes since V1:
* place fixup code into code section "__ex_table" instead of the obsoleted "fixup" section.
Correction: __ex_table is NOT a code section (scared me there for a second...). With the new fixup handling code EX_TYPE_ZERO_REG takes care of all the work, and there simply is no need for any fixup code at all (the exception fixup is fully data-driven.)
So I would say "use EX_TYPE_ZERO_REG instead of fixup code in the obsolete .fixup code section."
-hpa
Quoted 5 lines
Quoted 3 lines
* place fixup code into code section "
__ex_table" instead of the obsoleted "fixup" section.Correction:
__ex_tableis NOT a code section (scared me there for a second...).
Right, my bad.
Quoted 8 lines
With the new fixup handling code
EX_TYPE_ZERO_REGtakes care of all the work, and there simply is no need for any fixup code at all (the exception fixup is fully data-driven.)So I would say "use
EX_TYPE_ZERO_REGinstead of fixup code in the obsolete .fixup code section."-hpa