drm/amdgpu: remove unnecessary condition check
Subsystems (2)
PATCH 1/1 drm/amdgpu: remove unnecessary condition check
version_minor>=0 is always true.
Signed-off-by Hawking Zhang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c +5 -6
@@ -526,13 +526,12 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,if (version_major ==2 && version_minor ==1 ) adev->gfx.rlc.is_rlc_v2_1 = true; -if (version_minor >=0 ) { - err =amdgpu_gfx_rlc_init_microcode_v2_0 (adev); -if (err) { -dev_err (adev->dev,"fail to init rlc v2_0 microcode\n" ); -return err; - } + err =amdgpu_gfx_rlc_init_microcode_v2_0 (adev); +if (err) { +dev_err (adev->dev,"fail to init rlc v2_0 microcode\n" ); +return err; } +if (version_minor >=1 )amdgpu_gfx_rlc_init_microcode_v2_1 (adev);if (version_minor >=2 )
Signature · 1 line
2.17.1
[AMD Official Use Only - General]
Reviewed-by Likun Gao <[email protected]>.
Regards,
Likun
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Hawking Zhang
Sent: Tuesday, October 11, 2022 11:46 AM
To: [email protected]; Gao, Likun <[email protected]>; Deucher, Alexander <[email protected]>
Cc: Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: remove unnecessary condition check
version_minor>=0 is always true.
Signed-off-by Hawking Zhang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c +5 -6
@@ -526,13 +526,12 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,if (version_major ==2 && version_minor ==1 ) adev->gfx.rlc.is_rlc_v2_1 = true; -if (version_minor >=0 ) { - err =amdgpu_gfx_rlc_init_microcode_v2_0 (adev); -if (err) { -dev_err (adev->dev,"fail to init rlc v2_0 microcode\n" ); -return err; - } + err =amdgpu_gfx_rlc_init_microcode_v2_0 (adev); +if (err) { +dev_err (adev->dev,"fail to init rlc v2_0 microcode\n" ); +return err; } +if (version_minor >=1 )amdgpu_gfx_rlc_init_microcode_v2_1 (adev);if (version_minor >=2 )
--
2.17.1