Skip to contentSkip to conversation

drm/amdgpu: remove unnecessary condition check

PATCH In review Hawking Zhang 2 participants 2 messages Oct 11, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: remove unnecessary condition check

version_minor>=0 is always true.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c +5 -6
index 012b72d00e04..128b65f500fe 100644
@@ -526,13 +526,12 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,
 	if (version_major == 2 && version_minor == 1)
 		adev->gfx.rlc.is_rlc_v2_1 = true;
 
-	if (version_minor >= 0) {
-		err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
-		if (err) {
-			dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
-			return err;
-		}
+	err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
+	if (err) {
+		dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
+		return err;
 	}
+
 	if (version_minor >= 1)
 		amdgpu_gfx_rlc_init_microcode_v2_1(adev);
 	if (version_minor >= 2)
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

Regards,
Likun

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Hawking Zhang
Sent: Tuesday, October 11, 2022 11:46 AM
To: [email protected]; Gao, Likun <[email protected]>; Deucher, Alexander <[email protected]>
Cc: Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: remove unnecessary condition check

version_minor>=0 is always true.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c +5 -6
index 012b72d00e04..128b65f500fe 100644
@@ -526,13 +526,12 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,
        if (version_major == 2 && version_minor == 1)
                adev->gfx.rlc.is_rlc_v2_1 = true;
 
-       if (version_minor >= 0) {
-               err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
-               if (err) {
-                       dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
-                       return err;
-               }
+       err = amdgpu_gfx_rlc_init_microcode_v2_0(adev);
+       if (err) {
+               dev_err(adev->dev, "fail to init rlc v2_0 microcode\n");
+               return err;
        }
+
        if (version_minor >= 1)
                amdgpu_gfx_rlc_init_microcode_v2_1(adev);
        if (version_minor >= 2)

--
2.17.1