Skip to contentSkip to conversation

net/mlx5: fix thread termination check on Windows

PATCH In review Tal Shnaiderman 3 participants 3 messages Oct 12, 2022 – Oct 18, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix thread termination check on Windows

The mlx5_is_thread_alive function always returns false (terminated) regardless to the actual thread state.

Fixed to return the correct thread state.

Bugzilla ID: 1089

Fixes 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
---
 drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/windows/mlx5_flow_os.c +1 -1
index 48d7da41b1..5013e9f012 100644
@@ -262,7 +262,7 @@ mlx5_is_thread_alive(HANDLE thread_handle)
 
 	if (result == WAIT_OBJECT_0)
 		return false;
-	return false;
+	return true;
 }
 
 static int
Signature · 1 line
2.16.1.windows.4
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines

-----Original Message-----
From: Tal Shnaiderman <[email protected]>
Sent: Wednesday, October 12, 2022 9:50
To: [email protected]
Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Raslan Darawsheh <[email protected]>; [email protected]; Idan Hackmon <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix thread termination check on Windows

The mlx5_is_thread_alive function always returns false (terminated) regardless to the actual thread state.

Quoted 7 lines

Fixed to return the correct thread state.

Bugzilla ID: 1089

Fixes 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
#2 lore raw
In reply to Tal Shnaiderman

Hi,

Quoted 14 lines

-----Original Message-----
From: Tal Shnaiderman <[email protected]>
Sent: Wednesday, October 12, 2022 9:50 AM
To: [email protected]
Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Raslan Darawsheh <[email protected]>; [email protected]; Idan Hackmon <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix thread termination check on Windows

The mlx5_is_thread_alive function always returns false (terminated) regardless to the actual thread state.

Quoted 7 lines

Fixed to return the correct thread state.

Bugzilla ID: 1089

Fixes 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh