app/testpmd: fix slave port reset action
PATCH 1/1 app/testpmd: fix slave port reset action
As stop action has been forbidden in secondary process, so the reset action should also not be allowed.
Fixes a550baf24af9 ("app/testpmd: support multi-process")
Signed-off-by Qiming Yang <[email protected]>
--- app/test-pmd/testpmd.c | 18 ++++++++++-------- doc/guides/testpmd_app_ug/run_app.rst | 1 + 2 files changed, 11 insertions(+), 8 deletions(-)
app/test-pmd/testpmd.c +10 -8
@@ -3333,14 +3333,16 @@ reset_port(portid_t pid)continue ; } - diag =rte_eth_dev_reset (pi); -if (diag ==0 ) { - port = &ports[pi]; - port->need_reconfig =1 ; - port->need_reconfig_queues =1 ; - }else { -fprintf (stderr,"Failed to reset port %d. diag=%d\n" , - pi, diag); +if (is_proc_primary ()) { + diag =rte_eth_dev_reset (pi); +if (diag ==0 ) { + port = &ports[pi]; + port->need_reconfig =1 ; + port->need_reconfig_queues =1 ; + }else { +fprintf (stderr,"Failed to reset port %d. diag=%d\n" , + pi, diag); + } } }
doc/guides/testpmd_app_ug/run_app.rst +1 -0
@@ -600,6 +600,7 @@ as follows: - ``dev_configure`` - ``dev_start`` - ``dev_stop`` +- ``dev_reset`` - ``rx_queue_setup`` - ``tx_queue_setup`` - ``rx_queue_release``
Signature · 1 line
2.25.1
Quoted 7 lines · Qiming Yang
As stop action has been forbidden in secondary process, so the reset action should also not be allowed.
Fixes a550baf24af9 ("app/testpmd: support multi-process")Signed-off-by Qiming Yang <[email protected]>
Acked-by Aman Singh<[email protected]>
Quoted 5 lines
--- app/test-pmd/testpmd.c | 18 ++++++++++-------- doc/guides/testpmd_app_ug/run_app.rst | 1 + 2 files changed, 11 insertions(+), 8 deletions(-)
Andrew Rybchenko
AppliedQuoted 10 lines · Aman Deep
Quoted 7 lines · Qiming Yang
As stop action has been forbidden in secondary process, so the reset action should also not be allowed.
Fixes a550baf24af9 ("app/testpmd: support multi-process")Signed-off-by Qiming Yang <[email protected]>Acked-by Aman Singh<[email protected]>
Applied to dpdk-next-net/main, thanks.