add device Samsung Galaxy S9 phone (codename starqltechn) and board binding
v3 cover add device Samsung Galaxy S9 phone (codename starqltechn) and board binding
Add initial support for Samsung Galaxy S9 phone (codename starqltechn) and board binding
Dzmitry Sankouski (2):
dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
arm64: dts: qcom: starqltechn: add initial device tree for starqltechn
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sdm845-samsung-starqltechn.dts | 460 ++++++++++++++++++ 3 files changed, 462 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
Signature · 1 line
2.30.2
PATCH v3 1/2 dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Add samsung,starqltechn board (Samsung Galaxy S9) binding.
---
Changes for v2,v3: none
Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -661,6 +661,7 @@ properties: - oneplus,fajita - qcom,sdm845-mtp - shift,axolotl + - samsung,starqltechn - samsung,w737 - sony,akari-row - sony,akatsuki-row
Signature · 1 line
2.30.2
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Quoted 5 lines · Dzmitry Sankouski
Add samsung,starqltechn board (Samsung Galaxy S9) binding.
Signed-off-by Dzmitry Sankouski <[email protected]>---
Changes for v2,v3: none
Where is v2 and v3 of this?
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
чт, 13 окт. 2022 г. в 16:43, Krzysztof Kozlowski
<[email protected]>:
Quoted 9 lines · Dzmitry Sankouski
Quoted 5 lines
Add samsung,starqltechn board (Samsung Galaxy S9) binding.
Signed-off-by Dzmitry Sankouski <[email protected]>---
Changes for v2,v3: noneWhere is v2 and v3 of this?
I've been told it's easier for maintainers to resend all patch series, even if only 1 patch from the series requires change. So I decided to keep versions equal in all patches, to clearly indicate those patches are from the same series. Please, correct me if I'm wrong.
Quoted 4 lines
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Quoted 10 lines · Dzmitry Sankouski
чт, 13 окт. 2022 г. в 16:43, Krzysztof Kozlowski
<[email protected]>:Quoted 8 lines · Dzmitry Sankouski
Quoted 5 lines
Add samsung,starqltechn board (Samsung Galaxy S9) binding.
Signed-off-by Dzmitry Sankouski <[email protected]>---
Changes for v2,v3: none
Quoted 5 lines
Quoted 1 line
Where is v2 and v3 of this?
I've been told it's easier for maintainers to resend all patch series, even if only 1 patch from the series requires change. So I decided to keep versions equal in all patches, to clearly indicate those patches are from the same series. Please, correct me if I'm wrong.
This is okay, but you wrote here there was a v1 and v2, and you changed nothing against it. If there was v1 and v2, we would ack it, I think.
Or this changelog is for some other patch? Not for this one?
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
пт, 14 окт. 2022 г. в 19:13, Krzysztof Kozlowski
<[email protected]>:
Quoted 18 lines · Dzmitry Sankouski
Quoted 10 lines
чт, 13 окт. 2022 г. в 16:43, Krzysztof Kozlowski
<[email protected]>:Quoted 8 lines · Dzmitry Sankouski
Quoted 5 lines
Add samsung,starqltechn board (Samsung Galaxy S9) binding.
Signed-off-by Dzmitry Sankouski <[email protected]>---
Changes for v2,v3: noneQuoted 5 lines
Quoted 1 line
Where is v2 and v3 of this?
I've been told it's easier for maintainers to resend all patch series, even if only 1 patch from the series requires change. So I decided to keep versions equal in all patches, to clearly indicate those patches are from the same series. Please, correct me if I'm wrong.
Quoted 4 lines
This is okay, but you wrote here there was a v1 and v2, and you changed nothing against it. If there was v1 and v2, we would ack it, I think.
Or this changelog is for some other patch? Not for this one?
There's no previous versions of this patch, since it was born in the v3 patch series. The empty changelog for this patch indicates that there's no point to look for previous versions. I think I'll do it differently next time to avoid confusion - just a sentence that vN is the start version for patch.
Quoted 4 lines
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Quoted 8 lines · Dzmitry Sankouski
Quoted 8 lines
Quoted 4 lines
I've been told it's easier for maintainers to resend all patch series, even if only 1 patch from the series requires change. So I decided to keep versions equal in all patches, to clearly indicate those patches are from the same series. Please, correct me if I'm wrong.
This is okay, but you wrote here there was a v1 and v2, and you changed nothing against it. If there was v1 and v2, we would ack it, I think.
Quoted 6 lines
Quoted 1 line
Or this changelog is for some other patch? Not for this one?
There's no previous versions of this patch, since it was born in the v3 patch series. The empty changelog for this patch indicates that there's no point to look for previous versions. I think I'll do it differently next time to avoid confusion - just a sentence that vN is the start version for patch.
Yes, please. Something like:
Changes for v3: New patch.
Best regards,
Krzysztof
PATCH v3 2/2 arm64: dts: qcom: starqltechn: add initial device tree for starqltechn
In reply to Dzmitry SankouskiNew device support - Samsung S9 (SM-G9600) phone
What works:
- simple framebuffer
- storage (both main and sdcard)
- ramoops
---
Changes for v2:
- rebase on Linus's master branch
Changes for v3:
- rebase on 6.0.0 version
- use correct device trade name 'Samung Galaxy S9'
- remove bootargs from dts
- move status to the last position, remove some blank lines
- merge starqltechn dtsi and dts
- lowercase hex addresses
- rename reserved memory nodes to compy 'memory@.*'
- add state suffix to pinctrl nodes
- remove pinconf{}, put the properties in the root of the node.
arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sdm845-samsung-starqltechn.dts | 460 ++++++++++++++++++ 2 files changed, 461 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -125,6 +125,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-enchilada.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb +dtb-$(CONFIG_ARCH_QCOM) += sdm845-samsung-starqltechn.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akari.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akatsuki.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-apollo.dtb
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts new file +460 -0
460 lines not on this page · raw message
Signature · 1 line
2.30.2
Quoted 6 lines · Dzmitry Sankouski
Add initial support for Samsung Galaxy S9 phone (codename starqltechn) and board binding
Dzmitry Sankouski (2):
dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
arm64: dts: qcom: starqltechn: add initial device tree for starqltechn
Quoted 7 lines
.../devicetree/bindings/arm/qcom.yaml| 1 +arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sdm845-samsung-starqltechn.dts | 460 ++++++++++++++++++ 3 files changed, 462 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts[...]
Applied, thanks!
[1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
commit: 20e88ca2960ee63450cc4b9383e387f18cc08fa8
[2/2] arm64: dts: qcom: starqltechn: add initial device tree for starqltechn
commit: d711b22eee55ced0e32645706f20329be249e207Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>