Skip to contentSkip to conversation

tests/kms_universal_plane: turn off pipe when primary plane is off

PATCH Superseded Alex Hung 3 participants 9 messages Oct 12, 2022 – Oct 14, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Alex Hung

author
#0 lore raw

PATCH 1/2 tests/kms_universal_plane: turn off pipe when primary plane is off

GPU drivers can reject when crtc is on and primary plane is off, so turn crtc off with primary plane and turn it on afterwards.

---
 tests/kms_universal_plane.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
tests/kms_universal_plane.c +13 -0
index 64416afd..468f7a4e 100644
@@ -62,6 +62,13 @@ typedef struct {
 	struct igt_fb biggreen_fb, smallred_fb, smallblue_fb;
 } gen9_test_t;
 
+static void
+set_pipe_on_off(igt_display_t *display, igt_output_t *output, enum pipe pipe)
+{
+	igt_output_set_pipe(output, pipe);
+	igt_display_commit2(display, COMMIT_LEGACY);
+}
+
 static void
 functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pipe)
 {
@@ -228,12 +235,14 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_7);
 
 	/* Step 11: Disable primary plane */
+	set_pipe_on_off(&data->display, output, PIPE_NONE);
 	igt_plane_set_fb(primary, NULL);
 	igt_display_commit2(display, COMMIT_UNIVERSAL);
 
 	/* Step 12: Legacy modeset to yellow FB (CRC 8) */
 	igt_plane_set_fb(primary, &test.yellow_fb);
 	igt_display_commit2(display, COMMIT_LEGACY);
+	set_pipe_on_off(&data->display, output, pipe);
 	igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_8);
 
 	/* Step 13: Legacy API', blue primary, red sprite */
@@ -497,8 +506,10 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_display_commit2(&data->display, COMMIT_LEGACY);
 
 	/* Disable the primary plane */
+	set_pipe_on_off(&data->display, output, PIPE_NONE);
 	igt_plane_set_fb(primary, NULL);
 	igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
+	set_pipe_on_off(&data->display, output, pipe);
 
 	/*
 	 * Issue a pageflip to red FB
@@ -520,9 +531,11 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	 * completes, which we don't have a good way to specifically test for,
 	 * but at least we can make sure that nothing blows up.
 	 */
+	set_pipe_on_off(&data->display, output, pipe);
 	igt_assert(drmModePageFlip(data->drm_fd, output->config.crtc->crtc_id,
 				   test.red_fb.fb_id, DRM_MODE_PAGE_FLIP_EVENT,
 				   &test) == 0);
+	set_pipe_on_off(&data->display, output, PIPE_NONE);
 	igt_plane_set_fb(primary, NULL);
 	igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
 
Signature · 1 line
2.38.0
author
#1 lore raw

PATCH 2/2 tests/kms_universal_plane: skip when pipe and primary plane cannot be off

amdgpu rejects when crtc is on + primary plane is off. As a result, skipping these scenario when they cannot be turned off together, i.e. crtc cannot be off when reading crc values.

---
 tests/kms_universal_plane.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)
tests/kms_universal_plane.c +13 -9
index 468f7a4e..8d51f288 100644
@@ -197,9 +197,11 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_4);
 
 	/* Step 5: Universal API's, disable primary plane (CRC 5) */
-	igt_plane_set_fb(primary, NULL);
-	igt_display_commit2(display, COMMIT_UNIVERSAL);
-	igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_5);
+	if (!is_amdgpu_device(data->drm_fd)) {
+		igt_plane_set_fb(primary, NULL);
+		igt_display_commit2(display, COMMIT_UNIVERSAL);
+		igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_5);
+	}
 
 	/* Step 6: Universal API's, re-enable primary with blue (CRC 6) */
 	igt_plane_set_fb(primary, &test.blue_fb);
@@ -271,9 +273,11 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	 * Step 15: Explicitly disable primary after it's already been
 	 * implicitly disabled (CRC 10).
 	 */
-	igt_plane_set_fb(primary, NULL);
-	igt_display_commit2(display, COMMIT_UNIVERSAL);
-	igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_10);
+	if (!is_amdgpu_device(data->drm_fd)) {
+		igt_plane_set_fb(primary, NULL);
+		igt_display_commit2(display, COMMIT_UNIVERSAL);
+		igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_10);
+	}
 
 	/* Step 16: Legacy API's, blue primary, red sprite */
 	igt_plane_set_fb(primary, &test.blue_fb);
@@ -284,7 +288,8 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_assert_crc_equal(&test.crc_2, &test.crc_4);
 
 	/* Disabling primary plane should be same as black primary */
-	igt_assert_crc_equal(&test.crc_1, &test.crc_5);
+	if (!is_amdgpu_device(data->drm_fd))
+		igt_assert_crc_equal(&test.crc_1, &test.crc_5);
 
 	/* Re-enabling primary should return to blue properly */
 	igt_assert_crc_equal(&test.crc_2, &test.crc_6);
@@ -306,8 +311,7 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	 * and have it disable successfully. Skip on amdgpu since crc_9 was
 	 * skipped with offscreen planes previously.
 	 */
-	if (!is_amdgpu_device(data->drm_fd))
-		igt_assert_crc_equal(&test.crc_5, &test.crc_9);
+	igt_assert_crc_equal(&test.crc_5, &test.crc_9);
 
 	/*
 	 * We should be able to explicitly disable an already
Signature · 1 line
2.38.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [igt-dev] [PATCH 2/2] tests/kms_universal_plane: skip when pipe and primary plane cannot be off

Quoted 6 lines · Alex Hung

amdgpu rejects when crtc is on + primary plane is off. As a result, skipping these scenario when they cannot be turned off together, i.e. crtc cannot be off when reading crc values.

Quoted 61 lines
---
 tests/kms_universal_plane.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)
tests/kms_universal_plane.c +13 -10
index 468f7a4e..8d51f288 100644
@@ -197,9 +197,11 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
        igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_4);
 
        /* Step 5: Universal API's, disable primary plane (CRC 5) */
-       igt_plane_set_fb(primary, NULL);
-       igt_display_commit2(display, COMMIT_UNIVERSAL);
-       igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_5);
+       if (!is_amdgpu_device(data->drm_fd)) {
+               igt_plane_set_fb(primary, NULL);
+               igt_display_commit2(display, COMMIT_UNIVERSAL);
+               igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_5);
+       }
 
        /* Step 6: Universal API's, re-enable primary with blue (CRC 6) */
        igt_plane_set_fb(primary, &test.blue_fb);
@@ -271,9 +273,11 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         * Step 15: Explicitly disable primary after it's already been
         * implicitly disabled (CRC 10).
         */
-       igt_plane_set_fb(primary, NULL);
-       igt_display_commit2(display, COMMIT_UNIVERSAL);
-       igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_10);
+       if (!is_amdgpu_device(data->drm_fd)) {
+               igt_plane_set_fb(primary, NULL);
+               igt_display_commit2(display, COMMIT_UNIVERSAL);
+               igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_10);
+       }
 
        /* Step 16: Legacy API's, blue primary, red sprite */
        igt_plane_set_fb(primary, &test.blue_fb);
@@ -284,7 +288,8 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
        igt_assert_crc_equal(&test.crc_2, &test.crc_4);
 
        /* Disabling primary plane should be same as black primary */
-       igt_assert_crc_equal(&test.crc_1, &test.crc_5);
+       if (!is_amdgpu_device(data->drm_fd))
+               igt_assert_crc_equal(&test.crc_1, &test.crc_5);
 
        /* Re-enabling primary should return to blue properly */
        igt_assert_crc_equal(&test.crc_2, &test.crc_6);
@@ -306,8 +311,7 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         * and have it disable successfully. Skip on amdgpu since crc_9 was
         * skipped with offscreen planes previously.
         */
-       if (!is_amdgpu_device(data->drm_fd))
-               igt_assert_crc_equal(&test.crc_5, &test.crc_9);
+       igt_assert_crc_equal(&test.crc_5, &test.crc_9);
 
        /*
         * We should be able to explicitly disable an already
--

2.38.0

#3 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] tests/kms_universal_plane: turn off pipe when primary plane is off

In reply to Alex Hung
== Series Details ==

== Series Details ==

Series: series starting with [1/2] tests/kms_universal_plane: turn off pipe when primary plane is off
URL : https://patchwork.freedesktop.org/series/109641/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12239 -> IGTPW_7955
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/index.html

Participating hosts (43 -> 44)
------------------------------

Additional (2): fi-icl-u2 fi-tgl-dsi
Missing (1): fi-ctg-p8600

Known issues
------------

Here are the changes found in IGTPW_7955 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][3] -> [DMESG-FAIL][4] ([i915#62])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-cfl-8109u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-cfl-8109u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][5] -> [INCOMPLETE][6] ([i915#4785])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-hsw-4770/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([i915#4103])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [PASS][10] -> [DMESG-WARN][11] ([i915#62]) +14 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-cfl-8109u/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-cfl-8109u/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#3555])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([fdo#109295] / [i915#3301])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][14] ([i915#5334]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
- fi-bxt-dsi: [DMESG-FAIL][16] ([i915#5334]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][18] ([i915#4983] / [i915#5828]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/bat-rpls-2/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3:
- {bat-dg2-11}: [FAIL][20] ([i915#6818]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
[i915#6856]: https://gitlab.freedesktop.org/drm/intel/issues/6856
[i915#7125]: https://gitlab.freedesktop.org/drm/intel/issues/7125

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7012 -> IGTPW_7955

CI-20190529: 20190529
CI_DRM_12239: c8ba40d43d6d1c9e457ebe91543a04a9e85b29f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7955: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/index.html
IGT_7012: ca6f5bdd537d26692c4b1ca011b8c4f227d95703 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/index.html

#4 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/2] tests/kms_universal_plane: turn off pipe when primary plane is off

In reply to Alex Hung
== Series Details ==

== Series Details ==

Series: series starting with [1/2] tests/kms_universal_plane: turn off pipe when primary plane is off
URL : https://patchwork.freedesktop.org/series/109641/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12239_full -> IGTPW_7955_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/index.html

Participating hosts (9 -> 6)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Known issues
------------

Here are the changes found in IGTPW_7955_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-snb2/igt@[email protected]

* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][2] ([i915#280])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][3] -> [FAIL][4] ([i915#4409])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-snb6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-snb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#4525])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb8/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-tglb5/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk5/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-random:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk9/igt@[email protected]

* igt@gem_lmem_swapping@parallel-multi:
- shard-tglb: NOTRUN -> [SKIP][12] ([i915#4613]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb3/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#4613]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb1/igt@[email protected]

* igt@gem_lmem_swapping@verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl8/igt@[email protected]

* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][15] ([i915#4270]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][16] ([i915#4270]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@[email protected]

* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][17] ([i915#768])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb1/igt@[email protected]

* igt@gem_softpin@evict-single-offset:
- shard-apl: NOTRUN -> [FAIL][18] ([i915#4171])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl2/igt@[email protected]

* igt@gem_softpin@evict-snoop-interruptible:
- shard-tglb: NOTRUN -> [SKIP][19] ([fdo#109312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][20] ([fdo#109312])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb7/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3323])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl2/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#3297])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#3297])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1:
- shard-glk: [PASS][24] -> [FAIL][25] ([i915#2521])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk9/igt@kms_async_flips@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk8/igt@kms_async_flips@[email protected]

* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#5286]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#5286]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#110725] / [fdo#111614]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#111614]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-glk: [PASS][30] -> [DMESG-FAIL][31] ([i915#118])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk3/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#111615]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb2/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#110723])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk1/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109278] / [i915#3886])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][37] ([fdo#109271]) +87 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-snb6/igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs.html
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111615] / [i915#3689]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#6095])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-glk: NOTRUN -> [SKIP][40] ([fdo#109271]) +74 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk8/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#3689]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278]) +5 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_ccs.html

* igt@kms_chamelium@dp-hpd:
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk7/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl2/igt@[email protected]

* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109284] / [fdo#111827]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb8/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-snb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb3/igt@[email protected]

* igt@kms_content_protection@lic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][48] ([i915#7121])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl2/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@uevent:
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#7118])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#6944] / [i915#7118])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@[email protected]

* igt@kms_content_protection@uevent@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][51] ([i915#1339] / [i915#7144])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl3/igt@kms_content_protection@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#109274] / [fdo#111825])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@[email protected]

* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109274] / [fdo#111825] / [i915#3637]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb2/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109274]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#2587] / [i915#2672]) +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#2587] / [i915#2672])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#2672] / [i915#3555]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][58] ([i915#3555])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][59] ([i915#2672]) +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode.html

* igt@kms_force_connector_basic@force-load-detect:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109285])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109285])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#6497]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109280]) +10 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-fullscreen:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109280] / [fdo#111825]) +10 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-fullscreen.html

* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-c:
- shard-iclb: NOTRUN -> [SKIP][65] ([i915#6403]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb7/igt@kms_invalid_mode@[email protected]

* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#6403]) +3 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb7/igt@kms_invalid_mode@[email protected]

* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#109289])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109289])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb6/igt@[email protected]

* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-b-hdmi-a-2:
- shard-glk: NOTRUN -> [FAIL][69] ([i915#4573]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk3/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-a-dp-1:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271]) +97 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl8/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-c-edp-1:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#5176]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#5176]) +3 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][73] -> [SKIP][74] ([i915#5235]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb6/igt@kms_plane_scaling@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@kms_plane_scaling@[email protected]

* igt@kms_prime@basic-modeset-hybrid:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#6524])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#6524])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb1/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#2920])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb5/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb1/igt@[email protected]

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl1/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][81] -> [SKIP][82] ([fdo#109441]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html

#### Possible fixes ####

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][83] ([i915#4525]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][85] ([i915#2842]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl3/igt@gem_exec_fair@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][87] ([i915#2842]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk6/igt@gem_exec_fair@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][89] ([i915#180] / [i915#1982]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl2/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][91] ([i915#5566] / [i915#716]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk7/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk8/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-apl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl1/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl8/igt@[email protected]

* igt@kms_addfb_basic@legacy-format:
- shard-tglb: [INCOMPLETE][95] ([i915#6987]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-tglb2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-tglb3/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][97] ([i915#2346]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk5/igt@kms_cursor_legacy@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk8/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][99] ([i915#2122]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk2/igt@kms_flip@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][101] ([i915#3555]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-valid-mode:
- shard-glk: [FAIL][103] -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk8/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-valid-mode.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-glk1/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-valid-mode.html

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][105] ([i915#5235]) -> [PASS][106] +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@kms_plane_scaling@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb5/igt@kms_plane_scaling@[email protected]

* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][107] ([fdo#109441]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@kms_psr@psr2_primary_blt.html

#### Warnings ####

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][109] ([fdo#109271]) -> [FAIL][110] ([i915#4275])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl8/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][111] ([i915#2920]) -> [SKIP][112] ([i915#658])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb8/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][113] ([fdo#111068] / [i915#658]) -> [SKIP][114] ([i915#2920])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb3/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-iclb2/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119]) ([fdo#109271] / [i915#180] / [i915#3002]) -> ([FAIL][120], [FAIL][121]) ([i915#3002])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl1/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl2/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl6/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/shard-apl3/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4275]: https://gitlab.freedesktop.org/drm/intel/issues/4275
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6987]: https://gitlab.freedesktop.org/drm/intel/issues/6987
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#7144]: https://gitlab.freedesktop.org/drm/intel/issues/7144
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7012 -> IGTPW_7955
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_12239: c8ba40d43d6d1c9e457ebe91543a04a9e85b29f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7955: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/index.html
IGT_7012: ca6f5bdd537d26692c4b1ca011b8c4f227d95703 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7955/index.html

#5 lore raw
In reply to Alex Hung
Quoted 14 lines · Alex Hung

GPU drivers can reject when crtc is on and primary plane is off, so turn crtc off with primary plane and turn it on afterwards.

---
 tests/kms_universal_plane.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
tests/kms_universal_plane.c +0 -0
index 64416afd..468f7a4e 100644

tests/kms_universal_plane.c typedef struct { · line 69

Quoted 8 lines
tests/kms_universal_plane.c +5 -0
@@ -62,6 +62,13 @@ typedef struct {
        struct igt_fb biggreen_fb, smallred_fb, smallblue_fb;
 } gen9_test_t;
 
+static void
+set_pipe_on_off(igt_display_t *display, igt_output_t *output, enum pipe pipe)
+{
+       igt_output_set_pipe(output, pipe);
+       igt_display_commit2(display, COMMIT_LEGACY);

Why did you choose legacy commit?

Quoted 46 lines
tests/kms_universal_plane.c +8 -1
+}
+
 static void
 functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pipe)
 {
@@ -228,12 +235,14 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
        igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_7);
 
        /* Step 11: Disable primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
        igt_plane_set_fb(primary, NULL);
        igt_display_commit2(display, COMMIT_UNIVERSAL);
 
        /* Step 12: Legacy modeset to yellow FB (CRC 8) */
        igt_plane_set_fb(primary, &test.yellow_fb);
        igt_display_commit2(display, COMMIT_LEGACY);
+       set_pipe_on_off(&data->display, output, pipe);
        igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_8);
 
        /* Step 13: Legacy API', blue primary, red sprite */
@@ -497,8 +506,10 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
        igt_display_commit2(&data->display, COMMIT_LEGACY);
 
        /* Disable the primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
        igt_plane_set_fb(primary, NULL);
        igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
+       set_pipe_on_off(&data->display, output, pipe);
 
        /*
         * Issue a pageflip to red FB
@@ -520,9 +531,11 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         * completes, which we don't have a good way to specifically test for,
         * but at least we can make sure that nothing blows up.
         */
+       set_pipe_on_off(&data->display, output, pipe);
        igt_assert(drmModePageFlip(data->drm_fd, output->config.crtc->crtc_id,
                                   test.red_fb.fb_id, DRM_MODE_PAGE_FLIP_EVENT,
                                   &test) == 0);
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
        igt_plane_set_fb(primary, NULL);
        igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
 
--

2.38.0

author
#6 lore raw
Quoted 18 lines · Mark Yacoub
Quoted 17 lines · Alex Hung

GPU drivers can reject when crtc is on and primary plane is off, so turn crtc off with primary plane and turn it on afterwards.

---
  tests/kms_universal_plane.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)
tests/kms_universal_plane.c +0 -0
index 64416afd..468f7a4e 100644
@@ -62,6 +62,13 @@ typedef struct {
         struct igt_fb biggreen_fb, smallred_fb, smallblue_fb;
  } gen9_test_t;
 
Quoted 6 lines

tests/kms_universal_plane.c typedef struct { · line 69

Quoted 5 lines
tests/kms_universal_plane.c +5 -0
+static void
+set_pipe_on_off(igt_display_t *display, igt_output_t *output, enum pipe pipe)
+{
+       igt_output_set_pipe(output, pipe);
+       igt_display_commit2(display, COMMIT_LEGACY);

Why did you choose legacy commit?

This seems to be most stable. I observed failures / regressions if using atomic and universal on both intel and amd devices, but not with legacy.

Quoted 46 lines
Quoted 46 lines
tests/kms_universal_plane.c +8 -1
+}
+
  static void
  functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pipe)
  {
@@ -228,12 +235,14 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_7);
 
         /* Step 11: Disable primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
         igt_plane_set_fb(primary, NULL);
         igt_display_commit2(display, COMMIT_UNIVERSAL);
 
         /* Step 12: Legacy modeset to yellow FB (CRC 8) */
         igt_plane_set_fb(primary, &test.yellow_fb);
         igt_display_commit2(display, COMMIT_LEGACY);
+       set_pipe_on_off(&data->display, output, pipe);
         igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_8);
 
         /* Step 13: Legacy API', blue primary, red sprite */
@@ -497,8 +506,10 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         igt_display_commit2(&data->display, COMMIT_LEGACY);
 
         /* Disable the primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
         igt_plane_set_fb(primary, NULL);
         igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
+       set_pipe_on_off(&data->display, output, pipe);
 
         /*
          * Issue a pageflip to red FB
@@ -520,9 +531,11 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
          * completes, which we don't have a good way to specifically test for,
          * but at least we can make sure that nothing blows up.
          */
+       set_pipe_on_off(&data->display, output, pipe);
         igt_assert(drmModePageFlip(data->drm_fd, output->config.crtc->crtc_id,
                                    test.red_fb.fb_id, DRM_MODE_PAGE_FLIP_EVENT,
                                    &test) == 0);
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
         igt_plane_set_fb(primary, NULL);
         igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
 
--

2.38.0

#7 lore raw
Quoted 29 lines · Alex Hung
Quoted 18 lines · Mark Yacoub
Quoted 17 lines · Alex Hung

GPU drivers can reject when crtc is on and primary plane is off, so turn crtc off with primary plane and turn it on afterwards.

---
  tests/kms_universal_plane.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)
tests/kms_universal_plane.c +0 -0
index 64416afd..468f7a4e 100644
@@ -62,6 +62,13 @@ typedef struct {
         struct igt_fb biggreen_fb, smallred_fb, smallblue_fb;
  } gen9_test_t;
 
Quoted 6 lines

tests/kms_universal_plane.c typedef struct { · line 69

Quoted 5 lines
tests/kms_universal_plane.c +5 -0
+static void
+set_pipe_on_off(igt_display_t *display, igt_output_t *output, enum pipe pipe)
+{
+       igt_output_set_pipe(output, pipe);
+       igt_display_commit2(display, COMMIT_LEGACY);

Why did you choose legacy commit?

Quoted 2 lines

This seems to be most stable. I observed failures / regressions if using atomic and universal on both intel and amd devices, but not with legacy.

I'm not an expert but this doesn't sit too well with me. Do you know it's failing on AMD?

Quoted 47 lines
Quoted 47 lines
Quoted 47 lines
tests/kms_universal_plane.c +8 -1
+}
+
  static void
  functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pipe)
  {
@@ -228,12 +235,14 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_7);
 
         /* Step 11: Disable primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
         igt_plane_set_fb(primary, NULL);
         igt_display_commit2(display, COMMIT_UNIVERSAL);
 
         /* Step 12: Legacy modeset to yellow FB (CRC 8) */
         igt_plane_set_fb(primary, &test.yellow_fb);
         igt_display_commit2(display, COMMIT_LEGACY);
+       set_pipe_on_off(&data->display, output, pipe);
         igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_8);
 
         /* Step 13: Legacy API', blue primary, red sprite */
@@ -497,8 +506,10 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
         igt_display_commit2(&data->display, COMMIT_LEGACY);
 
         /* Disable the primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
         igt_plane_set_fb(primary, NULL);
         igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
+       set_pipe_on_off(&data->display, output, pipe);
 
         /*
          * Issue a pageflip to red FB
@@ -520,9 +531,11 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
          * completes, which we don't have a good way to specifically test for,
          * but at least we can make sure that nothing blows up.
          */
+       set_pipe_on_off(&data->display, output, pipe);
         igt_assert(drmModePageFlip(data->drm_fd, output->config.crtc->crtc_id,
                                    test.red_fb.fb_id, DRM_MODE_PAGE_FLIP_EVENT,
                                    &test) == 0);
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
         igt_plane_set_fb(primary, NULL);
         igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
 
--

2.38.0

author
#8 lore raw
Quoted 30 lines · Mark Yacoub
Quoted 29 lines · Alex Hung
Quoted 24 lines · Mark Yacoub
Quoted 14 lines · Alex Hung

GPU drivers can reject when crtc is on and primary plane is off, so turn crtc off with primary plane and turn it on afterwards.

---
   tests/kms_universal_plane.c | 13 +++++++++++++
   1 file changed, 13 insertions(+)
tests/kms_universal_plane.c +0 -0
index 64416afd..468f7a4e 100644

tests/kms_universal_plane.c typedef struct { · line 69

Quoted 8 lines
tests/kms_universal_plane.c +5 -0
@@ -62,6 +62,13 @@ typedef struct {
          struct igt_fb biggreen_fb, smallred_fb, smallblue_fb;
   } gen9_test_t;
 
+static void
+set_pipe_on_off(igt_display_t *display, igt_output_t *output, enum pipe pipe)
+{
+       igt_output_set_pipe(output, pipe);
+       igt_display_commit2(display, COMMIT_LEGACY);

Why did you choose legacy commit?

Quoted 4 lines
Quoted 2 lines

This seems to be most stable. I observed failures / regressions if using atomic and universal on both intel and amd devices, but not with legacy.

I'm not an expert but this doesn't sit too well with me. Do you know it's failing on AMD?

Using atomic in fact can work. atomic could cause some failures when combining with other commits (ex. some already using legacy). I removed the function set_pipe_on_off() and the following changes with COMMIT_ATOMIC pass on both of my amd & intel systems.

If that look better I can send a V2 patch.

        /* Step 11: Disable primary plane */
+       igt_output_set_pipe(output, PIPE_NONE);
+       igt_display_commit2(display, COMMIT_ATOMIC);
        igt_plane_set_fb(primary, NULL);
        igt_display_commit2(display, COMMIT_UNIVERSAL);

        /* Step 12: Legacy modeset to yellow FB (CRC 8) */
        igt_plane_set_fb(primary, &test.yellow_fb);
+       igt_output_set_pipe(output, pipe);
        igt_display_commit2(display, COMMIT_LEGACY);
        igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_8);

@@ -497,6 +500,8 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)

        igt_display_commit2(&data->display, COMMIT_LEGACY);

        /* Disable the primary plane */
+       igt_output_set_pipe(output, PIPE_NONE);
+       igt_display_commit2(&data->display, COMMIT_ATOMIC);
        igt_plane_set_fb(primary, NULL);
        igt_display_commit2(&data->display, COMMIT_UNIVERSAL);

@@ -506,6 +511,7 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
* Note that crtc->primary->fb = NULL causes flip to return
EBUSY for
* historical reasons...
*/

+       igt_output_set_pipe(output, pipe);
        igt_assert(drmModePageFlip(data->drm_fd, 
output->config.crtc->crtc_id,
                                   test.red_fb.fb_id, 0, NULL) == -EBUSY);

@@ -520,9 +526,13 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
* completes, which we don't have a good way to specifically
test for,
* but at least we can make sure that nothing blows up.
*/
+ igt_output_set_pipe(output, pipe);

+       igt_display_commit2(&data->display, COMMIT_ATOMIC);
        igt_assert(drmModePageFlip(data->drm_fd, 
output->config.crtc->crtc_id,
                                   test.red_fb.fb_id, 
DRM_MODE_PAGE_FLIP_EVENT,
                                   &test) == 0);
+       igt_output_set_pipe(output, PIPE_NONE);
+       igt_display_commit2(&data->display, COMMIT_ATOMIC);
        igt_plane_set_fb(primary, NULL);
        igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
Quoted 47 lines
Quoted 47 lines
Quoted 47 lines
Quoted 47 lines
tests/kms_universal_plane.c +8 -1
+}
+
   static void
   functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pipe)
   {
@@ -228,12 +235,14 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
          igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_7);
 
          /* Step 11: Disable primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
          igt_plane_set_fb(primary, NULL);
          igt_display_commit2(display, COMMIT_UNIVERSAL);
 
          /* Step 12: Legacy modeset to yellow FB (CRC 8) */
          igt_plane_set_fb(primary, &test.yellow_fb);
          igt_display_commit2(display, COMMIT_LEGACY);
+       set_pipe_on_off(&data->display, output, pipe);
          igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_8);
 
          /* Step 13: Legacy API', blue primary, red sprite */
@@ -497,8 +506,10 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
          igt_display_commit2(&data->display, COMMIT_LEGACY);
 
          /* Disable the primary plane */
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
          igt_plane_set_fb(primary, NULL);
          igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
+       set_pipe_on_off(&data->display, output, pipe);
 
          /*
           * Issue a pageflip to red FB
@@ -520,9 +531,11 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
           * completes, which we don't have a good way to specifically test for,
           * but at least we can make sure that nothing blows up.
           */
+       set_pipe_on_off(&data->display, output, pipe);
          igt_assert(drmModePageFlip(data->drm_fd, output->config.crtc->crtc_id,
                                     test.red_fb.fb_id, DRM_MODE_PAGE_FLIP_EVENT,
                                     &test) == 0);
+       set_pipe_on_off(&data->display, output, PIPE_NONE);
          igt_plane_set_fb(primary, NULL);
          igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
 
--

2.38.0