Skip to contentSkip to conversation

drivers: watchdog: exar_wdt.c fix use after free

PATCH In review Manank Patel 2 participants 2 messages Oct 13, 2022 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: watchdog: exar_wdt.c fix use after free

fix use after free by storing the result of PTR_ERR(n->pdev) to a local variable before returning.

---
 drivers/watchdog/exar_wdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/watchdog/exar_wdt.c +3 -1
index 35058d8b21bc..7c61ff343271 100644
@@ -355,8 +355,10 @@ static int __init exar_wdt_register(struct wdt_priv *priv, const int idx)
 						    &priv->wdt_res, 1,
 						    priv, sizeof(*priv));
 	if (IS_ERR(n->pdev)) {
+		int err = PTR_ERR(n->pdev);
+
 		kfree(n);
-		return PTR_ERR(n->pdev);
+		return err;
 	}
 
 	list_add_tail(&n->list, &pdev_list);
Signature · 1 line
2.38.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Manank Patel

fix use after free by storing the result of PTR_ERR(n->pdev) to a local variable before returning.

Quoted 20 lines
---
  drivers/watchdog/exar_wdt.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/watchdog/exar_wdt.c +3 -1
index 35058d8b21bc..7c61ff343271 100644
@@ -355,8 +355,10 @@ static int __init exar_wdt_register(struct wdt_priv *priv, const int idx)
  						    &priv->wdt_res, 1,
  						    priv, sizeof(*priv));
  	if (IS_ERR(n->pdev)) {
+		int err = PTR_ERR(n->pdev);
+
  		kfree(n);
-		return PTR_ERR(n->pdev);
+		return err;
  	}
 
  	list_add_tail(&n->list, &pdev_list);