Skip to contentSkip to conversation

common/cnxk: set MTU size on SDP based on SoC type

PATCH Superseded Nithin Dabilpuram 2 participants 41 messages Oct 11, 2022 – Oct 18, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/13 common/cnxk: set MTU size on SDP based on SoC type

From: Sathesh Edara <[email protected]>

Set maximum frame size on SDP NIX side to 16KB for T93 A0-B0, F95N A0 and F95O A0 SOC type. Rest of the SoCs SDP NIX to 64KB.

---
 drivers/common/cnxk/hw/nix.h     |  1 +
 drivers/common/cnxk/roc_errata.h |  8 ++++++++
 drivers/common/cnxk/roc_model.h  | 12 ++++++++++++
 drivers/common/cnxk/roc_nix.c    |  5 ++++-
 4 files changed, 25 insertions(+), 1 deletion(-)
drivers/common/cnxk/hw/nix.h +1 -0
index a5352644ca..425c335bf3 100644
@@ -2118,6 +2118,7 @@ struct nix_lso_format {
 #define NIX_CN9K_MAX_HW_FRS 9212UL
 #define NIX_LBK_MAX_HW_FRS  65535UL
 #define NIX_SDP_MAX_HW_FRS  65535UL
+#define NIX_SDP_16K_HW_FRS  16380UL
 #define NIX_RPM_MAX_HW_FRS  16380UL
 #define NIX_MIN_HW_FRS	    60UL
 
drivers/common/cnxk/roc_errata.h +8 -0
index d3b32f1786..a39796e894 100644
@@ -90,4 +90,12 @@ roc_errata_nix_no_meta_aura(void)
 	return roc_model_is_cn10ka_a0();
 }
 
+/* Errata IPBUNIXTX-35039 */
+static inline bool
+roc_errata_nix_sdp_send_has_mtu_size_16k(void)
+{
+	return (roc_model_is_cnf95xxn_a0() || roc_model_is_cnf95xxo_a0() ||
+		roc_model_is_cn96_a0() || roc_model_is_cn96_b0());
+}
+
 #endif /* _ROC_ERRATA_H_ */
drivers/common/cnxk/roc_model.h +12 -0
index 57a8af06fc..1985dd771d 100644
@@ -140,6 +140,12 @@ roc_model_is_cn96_ax(void)
 	return (roc_model->flag & ROC_MODEL_CN96xx_Ax);
 }
 
+static inline uint64_t
+roc_model_is_cn96_b0(void)
+{
+	return (roc_model->flag & ROC_MODEL_CN96xx_B0);
+}
+
 static inline uint64_t
 roc_model_is_cn96_cx(void)
 {
@@ -170,6 +176,12 @@ roc_model_is_cnf95xxn_b0(void)
 	return roc_model->flag & ROC_MODEL_CNF95xxN_B0;
 }
 
+static inline uint64_t
+roc_model_is_cnf95xxo_a0(void)
+{
+	return roc_model->flag & ROC_MODEL_CNF95xxO_A0;
+}
+
 static inline uint16_t
 roc_model_is_cn95xxn_a0(void)
 {
drivers/common/cnxk/roc_nix.c +4 -1
index 4bb306b60e..8fd8ec8461 100644
@@ -127,8 +127,11 @@ roc_nix_max_pkt_len(struct roc_nix *roc_nix)
 {
 	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
 
-	if (roc_nix_is_sdp(roc_nix))
+	if (roc_nix_is_sdp(roc_nix)) {
+		if (roc_errata_nix_sdp_send_has_mtu_size_16k())
+			return NIX_SDP_16K_HW_FRS;
 		return NIX_SDP_MAX_HW_FRS;
+	}
 
 	if (roc_model_is_cn9k())
 		return NIX_CN9K_MAX_HW_FRS;
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/13 common/cnxk: add devargs for soft expiry poll frequency

Add support to override soft expiry poll frequency via devargs. Also provide helper API to indicate reassembly support on a chip and documentation for devargs that are already present.

---
 doc/guides/nics/cnxk.rst              | 39 +++++++++++++++++++++++++++
 drivers/common/cnxk/roc_nix_inl.c     |  7 +++++
 drivers/common/cnxk/roc_nix_inl.h     |  3 ++-
 drivers/common/cnxk/roc_nix_inl_dev.c |  4 +--
 drivers/common/cnxk/version.map       |  1 +
 drivers/net/cnxk/cnxk_ethdev_sec.c    | 17 +++++++++---
 6 files changed, 65 insertions(+), 6 deletions(-)
doc/guides/nics/cnxk.rst +39 -0
index a1e3a4a965..7da6cb3967 100644
@@ -494,6 +494,45 @@ Runtime Config Options for inline device
    With the above configuration, application can enable inline IPsec processing
    for inbound SA with max SPI of 128 for traffic aggregated on inline device.
 
+- ``Count of meta buffers for inline inbound IPsec second pass``
+
+   Number of meta buffers allocated for inline inbound IPsec second pass can
+   be specified by ``nb_meta_bufs`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use. Number of meta
+   buffers should be at least equal to aggregated number of packet buffers of all
+   packet mbuf pools in use by Inline IPsec enabled ethernet devices.
+
+   For example::
+
+      -a 0002:1d:00.0,nb_meta_bufs=1024
+
+   With the above configuration, PMD would enable inline IPsec processing
+   for inbound with 1024 meta buffers available for second pass.
+
+- ``Meta buffer size for inline inbound IPsec second pass``
+
+   Size of meta buffer allocated for inline inbound IPsec second pass can
+   be specified by ``meta_buf_sz`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use.
+
+   For example::
+
+      -a 0002:1d:00.0,meta_buf_sz=512
+
+   With the above configuration, PMD would allocate meta buffers of size 512 for
+   inline inbound IPsec processing second pass.
+
+- ``Inline Outbound soft expiry poll frequency in usec`` (default ``100``)
+
+   Soft expiry poll frequency for Inline Outbound sessions can be specified by
+   ``soft_exp_poll_freq`` ``devargs`` parameter.
+
+   For example::
+
+      -a 0002:1d:00.0,soft_exp_poll_freq=1000
+
+   With the above configuration, driver would poll for soft expiry events every
+   1000 usec.
 
 Debugging Options
 -----------------
drivers/common/cnxk/roc_nix_inl.c +7 -0
index cdf31b1f0c..213d71e684 100644
@@ -480,6 +480,13 @@ nix_inl_rq_mask_cfg(struct roc_nix *roc_nix, bool enable)
 	return mbox_process(mbox);
 }
 
+bool
+roc_nix_has_reass_support(struct roc_nix *nix)
+{
+	PLT_SET_USED(nix);
+	return !!roc_model_is_cn10ka();
+}
+
 int
 roc_nix_inl_inb_init(struct roc_nix *roc_nix)
 {
drivers/common/cnxk/roc_nix_inl.h +2 -1
index 019cf6d28b..c537262819 100644
@@ -183,7 +183,7 @@ struct roc_nix_inl_dev {
 	uint16_t wqe_skip;
 	uint8_t spb_drop_pc;
 	uint8_t lpb_drop_pc;
-	bool set_soft_exp_poll;
+	uint32_t soft_exp_poll_freq; /* Polling disabled if 0 */
 	uint32_t nb_meta_bufs;
 	uint32_t meta_buf_sz;
 	/* End of input parameters */
@@ -229,6 +229,7 @@ int __roc_api roc_nix_inl_ts_pkind_set(struct roc_nix *roc_nix, bool ts_ena,
 				       bool inb_inl_dev);
 int __roc_api roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool ena);
 int __roc_api roc_nix_inl_meta_aura_check(struct roc_nix_rq *rq);
+bool __roc_api roc_nix_has_reass_support(struct roc_nix *nix);
 
 /* NIX Inline Outbound API */
 int __roc_api roc_nix_inl_outb_init(struct roc_nix *roc_nix);
drivers/common/cnxk/roc_nix_inl_dev.c +2 -2
index 4fe7b5180b..c3d94dd0da 100644
@@ -789,7 +789,6 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *inl_dev)
 
 	soft_exp_consumer_cnt = 0;
 	soft_exp_poll_thread_exit = false;
-	inl_dev->soft_exp_poll_freq = 100;
 	rc = plt_ctrl_thread_create(&inl_dev->soft_exp_poll_thread,
 				    "OUTB_SOFT_EXP_POLL_THREAD", NULL,
 				    nix_inl_outb_poll_thread, inl_dev);
@@ -839,10 +838,11 @@ roc_nix_inl_dev_init(struct roc_nix_inl_dev *roc_inl_dev)
 	inl_dev->wqe_skip = roc_inl_dev->wqe_skip;
 	inl_dev->spb_drop_pc = NIX_AURA_DROP_PC_DFLT;
 	inl_dev->lpb_drop_pc = NIX_AURA_DROP_PC_DFLT;
-	inl_dev->set_soft_exp_poll = roc_inl_dev->set_soft_exp_poll;
+	inl_dev->set_soft_exp_poll = !!roc_inl_dev->soft_exp_poll_freq;
 	inl_dev->nb_rqs = inl_dev->is_multi_channel ? 1 : PLT_MAX_ETHPORTS;
 	inl_dev->nb_meta_bufs = roc_inl_dev->nb_meta_bufs;
 	inl_dev->meta_buf_sz = roc_inl_dev->meta_buf_sz;
+	inl_dev->soft_exp_poll_freq = roc_inl_dev->soft_exp_poll_freq;
 
 	if (roc_inl_dev->spb_drop_pc)
 		inl_dev->spb_drop_pc = roc_inl_dev->spb_drop_pc;
drivers/common/cnxk/version.map +1 -0
index 276fec3660..f08b6076e4 100644
@@ -135,6 +135,7 @@ INTERNAL {
 	roc_nix_get_pf_func;
 	roc_nix_get_vf;
 	roc_nix_get_vwqe_interval;
+	roc_nix_has_reass_support;
 	roc_nix_inl_cb_register;
 	roc_nix_inl_cb_unregister;
 	roc_nix_inl_ctx_write;
drivers/net/cnxk/cnxk_ethdev_sec.c +14 -3
index 9304b1465d..8bec9acb54 100644
@@ -12,6 +12,10 @@
 #define CNXK_INL_CPT_CHANNEL	      "inl_cpt_channel"
 #define CNXK_NIX_INL_NB_META_BUFS     "nb_meta_bufs"
 #define CNXK_NIX_INL_META_BUF_SZ      "meta_buf_sz"
+#define CNXK_NIX_SOFT_EXP_POLL_FREQ   "soft_exp_poll_freq"
+
+/* Default soft expiry poll freq in usec */
+#define CNXK_NIX_SOFT_EXP_POLL_FREQ_DFLT 100
 
 struct inl_cpt_channel {
 	bool is_multi_channel;
@@ -263,6 +267,7 @@ static int
 nix_inl_parse_devargs(struct rte_devargs *devargs,
 		      struct roc_nix_inl_dev *inl_dev)
 {
+	uint32_t soft_exp_poll_freq = CNXK_NIX_SOFT_EXP_POLL_FREQ_DFLT;
 	uint32_t ipsec_in_max_spi = BIT(8) - 1;
 	uint32_t ipsec_in_min_spi = 0;
 	struct inl_cpt_channel cpt_channel;
@@ -292,6 +297,8 @@ nix_inl_parse_devargs(struct rte_devargs *devargs,
 			   &nb_meta_bufs);
 	rte_kvargs_process(kvlist, CNXK_NIX_INL_META_BUF_SZ, &parse_val_u32,
 			   &meta_buf_sz);
+	rte_kvargs_process(kvlist, CNXK_NIX_SOFT_EXP_POLL_FREQ,
+			   &parse_val_u32, &soft_exp_poll_freq);
 	rte_kvargs_free(kvlist);
 
 null_devargs:
@@ -303,6 +310,7 @@ nix_inl_parse_devargs(struct rte_devargs *devargs,
 	inl_dev->is_multi_channel = cpt_channel.is_multi_channel;
 	inl_dev->nb_meta_bufs = nb_meta_bufs;
 	inl_dev->meta_buf_sz = meta_buf_sz;
+	inl_dev->soft_exp_poll_freq = soft_exp_poll_freq;
 	return 0;
 exit:
 	return -EINVAL;
@@ -390,7 +398,6 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv,
 	wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ);
 	wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ;
 	inl_dev->wqe_skip = wqe_skip;
-	inl_dev->set_soft_exp_poll = true;
 	rc = roc_nix_inl_dev_init(inl_dev);
 	if (rc) {
 		plt_err("Failed to init nix inl device, rc=%d(%s)", rc,
@@ -425,5 +432,9 @@ RTE_PMD_REGISTER_KMOD_DEP(cnxk_nix_inl, "vfio-pci");
 
 RTE_PMD_REGISTER_PARAM_STRING(cnxk_nix_inl,
 			      CNXK_NIX_INL_SELFTEST "=1"
-			      CNXK_NIX_INL_IPSEC_IN_MAX_SPI "=<1-65535>"
-			      CNXK_INL_CPT_CHANNEL "=<1-4095>/<1-4095>");
+			      CNXK_NIX_INL_IPSEC_IN_MIN_SPI "=<1-U32_MAX>"
+			      CNXK_NIX_INL_IPSEC_IN_MAX_SPI "=<1-U32_MAX>"
+			      CNXK_INL_CPT_CHANNEL "=<1-4095>/<1-4095>"
+			      CNXK_NIX_INL_NB_META_BUFS "=<1-U32_MAX>"
+			      CNXK_NIX_INL_META_BUF_SZ "=<1-U32_MAX>"
+			      CNXK_NIX_SOFT_EXP_POLL_FREQ "=<0-U32_MAX>");
Signature · 1 line
2.25.1
#2 lore raw

PATCH 3/13 net/cnxk: fix later skip to include mbuf priv

In reply to Nithin Dabilpuram

Fix later skip to include mbuf priv data as mbuf->buf_addr is populated based on calculation including per-mbuf priv area.

Fixes 706eeae60757 ("net/cnxk: add multi-segment Rx for CN10K")
---
 drivers/net/cnxk/cn10k_rx.h    | 4 +++-
 drivers/net/cnxk/cnxk_ethdev.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/cnxk/cn10k_rx.h +3 -1
index 46488d442e..cf390a0361 100644
@@ -682,6 +682,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,
 		    uint64_t rearm, const uint16_t flags)
 {
 	const rte_iova_t *iova_list;
+	uint16_t later_skip = 0;
 	struct rte_mbuf *head;
 	const rte_iova_t *eol;
 	uint8_t nb_segs;
@@ -720,10 +721,11 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,
 	nb_segs--;
 
 	rearm = rearm & ~0xFFFF;
+	later_skip = (uintptr_t)mbuf->buf_addr - (uintptr_t)mbuf;
 
 	head = mbuf;
 	while (nb_segs) {
-		mbuf->next = ((struct rte_mbuf *)*iova_list) - 1;
+		mbuf->next = (struct rte_mbuf *)(*iova_list - later_skip);
 		mbuf = mbuf->next;
 
 		RTE_MEMPOOL_CHECK_COOKIES(mbuf->pool, (void **)&mbuf, 1, 1);
drivers/net/cnxk/cnxk_ethdev.c +1 -1
index 2cb48ba152..8fe996b2d9 100644
@@ -620,7 +620,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid,
 	first_skip += RTE_PKTMBUF_HEADROOM;
 	first_skip += rte_pktmbuf_priv_size(mp);
 	rq->first_skip = first_skip;
-	rq->later_skip = sizeof(struct rte_mbuf);
+	rq->later_skip = sizeof(struct rte_mbuf) + rte_pktmbuf_priv_size(mp);
 	rq->lpb_size = mp->elt_size;
 	if (roc_errata_nix_no_meta_aura())
 		rq->lpb_drop_ena = !(dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY);
Signature · 1 line
2.25.1
#3 lore raw

PATCH 4/13 net/cnxk: add use nixtx offset for cn10kb

In reply to Nithin Dabilpuram

In outbound inline case, use NIX Tx offset instead of NIX Tx address for CN103XX as per new instruction format.

---
 drivers/common/cnxk/roc_constants.h | 1 +
 drivers/event/cnxk/cn10k_worker.h   | 3 +++
 drivers/net/cnxk/cn10k_ethdev.c     | 6 ++++++
 drivers/net/cnxk/cn10k_ethdev.h     | 3 ++-
 drivers/net/cnxk/cn10k_ethdev_sec.c | 2 ++
 drivers/net/cnxk/cn10k_tx.h         | 4 ++--
 6 files changed, 16 insertions(+), 3 deletions(-)
drivers/common/cnxk/roc_constants.h +1 -0
index c693dde62e..0495965daa 100644
@@ -12,6 +12,7 @@
 /* [CN10K, .) */
 #define ROC_LMT_LINE_SZ		    128
 #define ROC_NUM_LMT_LINES	    2048
+#define ROC_LMT_LINES_PER_STR_LOG2  4
 #define ROC_LMT_LINES_PER_CORE_LOG2 5
 #define ROC_LMT_LINE_SIZE_LOG2	    7
 #define ROC_LMT_BASE_PER_CORE_LOG2                                             \
drivers/event/cnxk/cn10k_worker.h +3 -0
index 7a82dd352a..75a2ff244a 100644
@@ -595,6 +595,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf *m, uint64_t *cmd,
 		ws->gw_rdata = roc_sso_hws_head_wait(ws->base);
 
 	cn10k_sso_txq_fc_wait(txq);
+	if (flags & NIX_TX_OFFLOAD_SECURITY_F && sec)
+		cn10k_nix_sec_fc_wait_one(txq);
+
 	roc_lmt_submit_steorl(lmt_id, pa);
 
 	if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
drivers/net/cnxk/cn10k_ethdev.c +6 -0
index e8faeebe1f..cf1d9b164d 100644
@@ -538,6 +538,9 @@ cn10k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
 	int rc = -ENOTSUP;
 	RTE_SET_USED(eth_dev);
 
+	if (!roc_nix_has_reass_support(&dev->nix))
+		return -ENOTSUP;
+
 	if (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY) {
 		reassembly_capa->timeout_ms = 60 * 1000;
 		reassembly_capa->max_frags = 4;
@@ -565,6 +568,9 @@ cn10k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
 	struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);
 	int rc = 0;
 
+	if (!roc_nix_has_reass_support(&dev->nix))
+		return -ENOTSUP;
+
 	if (!conf->flags) {
 		/* Clear offload flags on disable */
 		dev->rx_offload_flags &= ~NIX_RX_REAS_F;
drivers/net/cnxk/cn10k_ethdev.h +2 -1
index d0a5b136e3..948c8348ad 100644
@@ -75,7 +75,8 @@ struct cn10k_sec_sess_priv {
 			uint16_t partial_len : 10;
 			uint16_t chksum : 2;
 			uint16_t dec_ttl : 1;
-			uint16_t rsvd : 3;
+			uint16_t nixtx_off : 1;
+			uint16_t rsvd : 2;
 		};
 
 		uint64_t u64;
drivers/net/cnxk/cn10k_ethdev_sec.c +2 -0
index 6de4a284da..3ca707f038 100644
@@ -798,6 +798,8 @@ cn10k_eth_sec_session_create(void *device,
 		sess_priv.chksum = (!ipsec->options.ip_csum_enable << 1 |
 				    !ipsec->options.l4_csum_enable);
 		sess_priv.dec_ttl = ipsec->options.dec_ttl;
+		if (roc_model_is_cn10kb_a0())
+			sess_priv.nixtx_off = 1;
 
 		/* Pointer from eth_sec -> outb_sa */
 		eth_sec->sa = outb_sa;
drivers/net/cnxk/cn10k_tx.h +2 -2
index 492942de15..527b65022f 100644
@@ -397,7 +397,7 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,
 		/* DLEN passed is excluding L2 HDR */
 		pkt_len -= l2_len;
 	}
-	w0 |= nixtx;
+	w0 |= sess_priv.nixtx_off ? ((((int64_t)nixtx - (int64_t)dptr) & 0xFFFFF) << 32) : nixtx;
 	/* CPT word 0 and 1 */
 	cmd01 = vdupq_n_u64(0);
 	cmd01 = vsetq_lane_u64(w0, cmd01, 0);
@@ -539,7 +539,7 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,
 		sg->seg1_size = pkt_len + dlen_adj;
 		pkt_len -= l2_len;
 	}
-	w0 |= nixtx;
+	w0 |= sess_priv.nixtx_off ? ((((int64_t)nixtx - (int64_t)dptr) & 0xFFFFF) << 32) : nixtx;
 	/* CPT word 0 and 1 */
 	cmd01 = vdupq_n_u64(0);
 	cmd01 = vsetq_lane_u64(w0, cmd01, 0);
Signature · 1 line
2.25.1
#4 lore raw

PATCH 5/13 common/cnxk: fix RQ mask config for cn10kb chip

In reply to Nithin Dabilpuram

RQ mask config needs to enable SPB_ENA in order for Zero for being able to override it with Meta aura.

Also fix flow control config to catch invalid rxchan config errors.

Fixes ddf955d3917e ("common/cnxk: support CPT second pass")
Fixes da57d4589a6f ("common/cnxk: support NIX flow control")
---
 drivers/common/cnxk/roc_nix_fc.c  |  4 ++-
 drivers/common/cnxk/roc_nix_inl.c | 43 +++++++++++++++++--------------
 2 files changed, 26 insertions(+), 21 deletions(-)
drivers/common/cnxk/roc_nix_fc.c +3 -1
index f4cfa11c0f..033e17a4bf 100644
@@ -52,8 +52,10 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable)
 		req->bpid_per_chan = true;
 
 		rc = mbox_process_msg(mbox, (void *)&rsp);
-		if (rc || (req->chan_cnt != rsp->chan_cnt))
+		if (rc || (req->chan_cnt != rsp->chan_cnt)) {
+			rc = -EIO;
 			goto exit;
+		}
 
 		nix->chan_cnt = rsp->chan_cnt;
 		for (i = 0; i < rsp->chan_cnt; i++)
drivers/common/cnxk/roc_nix_inl.c +23 -20

69 lines not on this page · raw message

Signature · 1 line
2.25.1
#5 lore raw

PATCH 6/13 common/cnxk: fix schedule weight update

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Each TX schedule config mail box supports maximum 20 register updates. This patch will send node weight updates in multiple mailbox when TM created with more than 20 scheduler nodes.

Fixes 464c9f919321 ("common/cnxk: support NIX TM dynamic update")
---
 drivers/common/cnxk/roc_nix_queue.c  |  2 +-
 drivers/common/cnxk/roc_nix_tm_ops.c | 60 ++++++++++++++++++----------
 2 files changed, 41 insertions(+), 21 deletions(-)
drivers/common/cnxk/roc_nix_queue.c +1 -1
index 405d9a8274..7f001efbb0 100644
@@ -810,7 +810,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
 	nb_sqb_bufs += NIX_SQB_LIST_SPACE;
 	/* Clamp up the SQB count */
 	nb_sqb_bufs = PLT_MIN(roc_nix->max_sqb_count,
-			      PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
+			      (uint16_t)PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
 
 	sq->nb_sqb_bufs = nb_sqb_bufs;
 	sq->sqes_per_sqb_log2 = (uint16_t)plt_log2_u32(sqes_per_sqb);
drivers/common/cnxk/roc_nix_tm_ops.c +40 -20

78 lines not on this page · raw message

Signature · 1 line
2.25.1
#6 lore raw

PATCH 7/13 common/cnxk: sync NIX HW info mbox structure with kernel

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Sync nix_hw_info structure with kernel.

Maintain default RR_QUANTUM for VF TL2 same as kernel to make equal distribution among all VFs.

---
 drivers/common/cnxk/roc_mbox.h         |  8 +++++-
 drivers/common/cnxk/roc_nix.c          |  9 ++++++-
 drivers/common/cnxk/roc_nix.h          |  1 +
 drivers/common/cnxk/roc_nix_tm.c       | 10 ++++----
 drivers/common/cnxk/roc_nix_tm_utils.c | 34 +++++++++++++++++++++-----
 5 files changed, 49 insertions(+), 13 deletions(-)
drivers/common/cnxk/roc_mbox.h +7 -1
index a47e6a8f3b..e8d4ae283d 100644
@@ -1215,7 +1215,13 @@ struct nix_inline_ipsec_lf_cfg {
 struct nix_hw_info {
 	struct mbox_msghdr hdr;
 	uint16_t __io vwqe_delay;
-	uint16_t __io rsvd[15];
+	uint16_t __io max_mtu;
+	uint16_t __io min_mtu;
+	uint32_t __io rpm_dwrr_mtu;
+	uint32_t __io sdp_dwrr_mtu;
+	uint32_t __io lbk_dwrr_mtu;
+	uint32_t __io rsvd32[1];
+	uint64_t __io rsvd[15]; /* Add reserved fields for future expansion */
 };
 
 struct nix_bandprof_alloc_req {
drivers/common/cnxk/roc_nix.c +8 -1
index 8fd8ec8461..2a320cc291 100644
@@ -303,8 +303,15 @@ roc_nix_get_hw_info(struct roc_nix *roc_nix)
 
 	mbox_alloc_msg_nix_get_hw_info(mbox);
 	rc = mbox_process_msg(mbox, (void *)&hw_info);
-	if (rc == 0)
+	if (rc == 0) {
 		nix->vwqe_interval = hw_info->vwqe_delay;
+		if (nix->lbk_link)
+			roc_nix->dwrr_mtu = hw_info->lbk_dwrr_mtu;
+		else if (nix->sdp_link)
+			roc_nix->dwrr_mtu = hw_info->sdp_dwrr_mtu;
+		else
+			roc_nix->dwrr_mtu = hw_info->rpm_dwrr_mtu;
+	}
 
 	return rc;
 }
drivers/common/cnxk/roc_nix.h +1 -0
index 5c2a869eba..1eb1c9af55 100644
@@ -422,6 +422,7 @@ struct roc_nix {
 	uint32_t ipsec_in_min_spi;
 	uint32_t ipsec_in_max_spi;
 	uint32_t ipsec_out_max_sa;
+	uint32_t dwrr_mtu;
 	bool ipsec_out_sso_pffunc;
 	bool custom_sa_action;
 	/* End of input parameters */
drivers/common/cnxk/roc_nix_tm.c +5 -5
index 81fa6b1d93..86918990a2 100644
@@ -256,10 +256,6 @@ nix_tm_node_add(struct roc_nix *roc_nix, struct nix_tm_node *node)
 	if (node->weight > roc_nix_tm_max_sched_wt_get())
 		return NIX_ERR_TM_WEIGHT_EXCEED;
 
-	/* Maintain minimum weight */
-	if (!node->weight)
-		node->weight = 1;
-
 	node->hw_lvl = nix_tm_lvl2nix(nix, lvl);
 	node->rr_prio = 0xF;
 	node->max_prio = UINT32_MAX;
@@ -1358,7 +1354,11 @@ nix_tm_prepare_default_tree(struct roc_nix *roc_nix)
 		node->id = nonleaf_id;
 		node->parent_id = parent;
 		node->priority = 0;
-		node->weight = NIX_TM_DFLT_RR_WT;
+		/* Default VF root RR_QUANTUM is in sync with kernel */
+		if (lvl == ROC_TM_LVL_ROOT && !nix_tm_have_tl1_access(nix))
+			node->weight = 0;
+		else
+			node->weight = NIX_TM_DFLT_RR_WT;
 		node->shaper_profile_id = ROC_NIX_TM_SHAPER_PROFILE_NONE;
 		node->lvl = lvl;
 		node->tree = ROC_NIX_TM_DEFAULT;
drivers/common/cnxk/roc_nix_tm_utils.c +28 -6
index 193f9df5ff..d33e793664 100644
@@ -644,9 +644,25 @@ nix_tm_topology_reg_prep(struct nix *nix, struct nix_tm_node *node,
 	return k;
 }
 
+static inline int
+nix_tm_default_rr_weight(struct nix *nix)
+{
+	struct roc_nix *roc_nix = nix_priv_to_roc_nix(nix);
+	uint32_t max_pktlen = roc_nix_max_pkt_len(roc_nix);
+	uint32_t weight;
+
+	/* Reduce TX VTAG Insertions */
+	max_pktlen -= 8;
+	weight = max_pktlen / roc_nix->dwrr_mtu;
+	if (max_pktlen % roc_nix->dwrr_mtu)
+		weight += 1;
+
+	return weight;
+}
+
 uint8_t
-nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
-		      volatile uint64_t *reg, volatile uint64_t *regval)
+nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node, volatile uint64_t *reg,
+		      volatile uint64_t *regval)
 {
 	uint64_t strict_prio = node->priority;
 	uint32_t hw_lvl = node->hw_lvl;
@@ -654,8 +670,14 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
 	uint64_t rr_quantum;
 	uint8_t k = 0;
 
-	/* For CN9K, weight needs to be converted to quantum */
-	rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
+	/* If minimum weight not provided, then by default RR_QUANTUM
+	 * should be in sync with kernel, i.e., single MTU value
+	 */
+	if (!node->weight)
+		rr_quantum = nix_tm_default_rr_weight(nix);
+	else
+		/* For CN9K, weight needs to be converted to quantum */
+		rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
 
 	/* For children to root, strict prio is default if either
 	 * device root is TL2 or TL1 Static Priority is disabled.
@@ -666,8 +688,8 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
 
 	plt_tm_dbg("Schedule config node %s(%u) lvl %u id %u, "
 		   "prio 0x%" PRIx64 ", rr_quantum/rr_wt 0x%" PRIx64 " (%p)",
-		   nix_tm_hwlvl2str(node->hw_lvl), schq, node->lvl, node->id,
-		   strict_prio, rr_quantum, node);
+		   nix_tm_hwlvl2str(node->hw_lvl), schq, node->lvl, node->id, strict_prio,
+		   rr_quantum, node);
 
 	switch (hw_lvl) {
 	case NIX_TXSCH_LVL_SMQ:
Signature · 1 line
2.25.1
#7 lore raw

PATCH 8/13 common/cnxk: revert VF root weight

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

With kernel RR_QUANTUM some of the DPDK perf test (ipsec reassembly) was failing, so reverting this change.

---
 drivers/common/cnxk/roc_nix_tm.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/common/cnxk/roc_nix_tm.c +1 -5
index 86918990a2..be8da714cd 100644
@@ -1354,11 +1354,7 @@ nix_tm_prepare_default_tree(struct roc_nix *roc_nix)
 		node->id = nonleaf_id;
 		node->parent_id = parent;
 		node->priority = 0;
-		/* Default VF root RR_QUANTUM is in sync with kernel */
-		if (lvl == ROC_TM_LVL_ROOT && !nix_tm_have_tl1_access(nix))
-			node->weight = 0;
-		else
-			node->weight = NIX_TM_DFLT_RR_WT;
+		node->weight = NIX_TM_DFLT_RR_WT;
 		node->shaper_profile_id = ROC_NIX_TM_SHAPER_PROFILE_NONE;
 		node->lvl = lvl;
 		node->tree = ROC_NIX_TM_DEFAULT;
Signature · 1 line
2.25.1
#8 lore raw

PATCH 9/13 common/cnxk: set hysteresis bit to one

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Setting non zero FC_HYST_BITS to reduce mesh traffic on HW.

---
 drivers/common/cnxk/roc_nix_queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/cnxk/roc_nix_queue.c +1 -1
index 7f001efbb0..040b9cc45b 100644
@@ -834,7 +834,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
 	else
 		aura.fc_stype = 0x3; /* STSTP */
 	aura.fc_addr = (uint64_t)sq->fc;
-	aura.fc_hyst_bits = 0; /* Store count on all updates */
+	aura.fc_hyst_bits = 1; /* Store count on all updates */
 	rc = roc_npa_pool_create(&sq->aura_handle, blk_sz, nb_sqb_bufs, &aura,
 				 &pool, 0);
 	if (rc)
Signature · 1 line
2.25.1
#9 lore raw

PATCH 10/13 net/cnxk: handle SA soft packet and byte expiry events

In reply to Nithin Dabilpuram

From: Vamsi Attunuru <[email protected]>

Handle SA soft packet and byte expiry event for Inline outbound SA.

---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/cnxk/cn10k_ethdev_sec.c +6 -1
index 3ca707f038..ce1b10d885 100644
@@ -428,7 +428,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, uint32_t soft_exp_event)
 			sa = (struct roc_ot_ipsec_outb_sa *)args;
 			priv = roc_nix_inl_ot_ipsec_outb_sa_sw_rsvd(sa);
 			desc.metadata = (uint64_t)priv->userdata;
-			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY;
+			if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+				desc.subtype =
+					RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY;
+			else
+				desc.subtype =
+					RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY;
 			eth_dev = &rte_eth_devices[soft_exp_event >> 8];
 			rte_eth_dev_callback_process(eth_dev,
 				RTE_ETH_EVENT_IPSEC, &desc);
Signature · 1 line
2.25.1
#10 lore raw

PATCH 11/13 common/cnxk: sync mailbox for channel and bpid map

In reply to Nithin Dabilpuram

From: Sunil Kumar Kori <[email protected]>

As per recent change in Linux-5.4.x, mailbox is updated to configure mapping between channel and BPID. Due to mbox mismatch, PFC was broken. Patch syncs mailbox definition for the same. Also fixes the PFC configuration issues.

---
 drivers/common/cnxk/roc_mbox.h | 6 +++---
 drivers/common/cnxk/roc_nix.h  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/common/cnxk/roc_mbox.h +3 -3
index e8d4ae283d..d47808e5ef 100644
@@ -1164,10 +1164,10 @@ struct nix_bp_cfg_req {
 	/* bpid_per_chan = 1 assigns separate bp id for each channel */
 };
 
-/* PF can be mapped to either CGX or LBK interface,
- * so maximum 64 channels are possible.
+/* PF can be mapped to either CGX or LBK or SDP interface,
+ * so maximum 256 channels are possible.
  */
-#define NIX_MAX_CHAN	 64
+#define NIX_MAX_CHAN	 256
 #define NIX_CGX_MAX_CHAN 16
 #define NIX_LBK_MAX_CHAN 1
 struct nix_bp_cfg_rsp {
drivers/common/cnxk/roc_nix.h +1 -1
index 1eb1c9af55..c50efefa80 100644
@@ -432,7 +432,7 @@ struct roc_nix {
 	bool rx_ptp_ena;
 	uint16_t cints;
 
-#define ROC_NIX_MEM_SZ (6 * 1024)
+#define ROC_NIX_MEM_SZ (6 * 1056)
 	uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned;
 } __plt_cache_aligned;
 
Signature · 1 line
2.25.1
#11 lore raw

PATCH 12/13 net/cnxk: remove unnecessary dptr update

In reply to Nithin Dabilpuram

Also remove ESN update from ucode command word 0 based on latest ucode.

---
 drivers/event/cnxk/cn9k_worker.h | 1 -
 drivers/net/cnxk/cn10k_tx.h      | 4 ----
 2 files changed, 5 deletions(-)
drivers/event/cnxk/cn9k_worker.h +0 -1
index 881861f348..4c3932da47 100644
@@ -718,7 +718,6 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
 	esn = outb_priv->esn;
 	outb_priv->esn = esn + 1;
 
-	ucode_cmd[0] |= (esn >> 32) << 16;
 	esn_lo = rte_cpu_to_be_32(esn & (BIT_ULL(32) - 1));
 	esn_hi = rte_cpu_to_be_32(esn >> 32);
 
drivers/net/cnxk/cn10k_tx.h +0 -4
index 527b65022f..5b13f02095 100644
@@ -422,8 +422,6 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,
 				CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
 	cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-	dptr += l2_len;
-
 	/* Move to our line */
 	laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
@@ -564,8 +562,6 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,
 				CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
 	cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-	dptr += l2_len;
-
 	/* Move to our line */
 	laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
Signature · 1 line
2.25.1
#12 lore raw

PATCH 13/13 net/cnxk: remove duplicate mempool debug checks

In reply to Nithin Dabilpuram

Remove duplicate mempool debug checks for mbufs received.

Fixes 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model")
---
 drivers/net/cnxk/cn10k_rx.h | 6 ------
 1 file changed, 6 deletions(-)
drivers/net/cnxk/cn10k_rx.h +0 -6
index cf390a0361..4e22ceda02 100644
@@ -1307,12 +1307,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,
 			ol_flags3 |= nix_rx_olflags_get(lookup_mem, cq3_w1);
 		}
 
-		/* Mark mempool obj as "get" as it is alloc'ed by NIX */
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf2->pool, (void **)&mbuf2, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf3->pool, (void **)&mbuf3, 1, 1);
-
 		/* Translate meta to mbuf */
 		if (flags & NIX_RX_OFFLOAD_SECURITY_F) {
 			uint64_t cq0_w5 = *CQE_PTR_OFF(cq0, 0, 40, flags);
Signature · 1 line
2.25.1
#13 lore raw

Re: [PATCH 13/13] net/cnxk: remove duplicate mempool debug checks

Quoted 5 lines · Nithin Dabilpuram

Remove duplicate mempool debug checks for mbufs received.

Fixes 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model")

# Please fix the following
# Also, update git comments and add fixes for the relevant patches(for example the revert patch)

[for-next-net]dell[dpdk-next-net-mrvl] $ git pw series apply 25145 Failed to apply patch:
Applying: common/cnxk: set MTU size on SDP based on SoC type
Applying: common/cnxk: add devargs for soft expiry poll frequency
Applying: net/cnxk: fix later skip to include mbuf priv Using index info to reconstruct a base tree...
M drivers/net/cnxk/cnxk_ethdev.c
Falling back to patching base and 3-way merge... Auto-merging drivers/net/cnxk/cnxk_ethdev.c
CONFLICT (content): Merge conflict in drivers/net/cnxk/cnxk_ethdev.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0003 net/cnxk: fix later skip to include mbuf priv When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort"

Quoted 24 lines
---
 drivers/net/cnxk/cn10k_rx.h | 6 ------
 1 file changed, 6 deletions(-)
drivers/net/cnxk/cn10k_rx.h +0 -7
index cf390a0361..4e22ceda02 100644
@@ -1307,12 +1307,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,
                        ol_flags3 |= nix_rx_olflags_get(lookup_mem, cq3_w1);
                }
 
-               /* Mark mempool obj as "get" as it is alloc'ed by NIX */
-               RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1);
-               RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1);
-               RTE_MEMPOOL_CHECK_COOKIES(mbuf2->pool, (void **)&mbuf2, 1, 1);
-               RTE_MEMPOOL_CHECK_COOKIES(mbuf3->pool, (void **)&mbuf3, 1, 1);
-
                /* Translate meta to mbuf */
                if (flags & NIX_RX_OFFLOAD_SECURITY_F) {
                        uint64_t cq0_w5 = *CQE_PTR_OFF(cq0, 0, 40, flags);
--

2.25.1

#14 lore raw

PATCH v2 1/13 common/cnxk: set MTU size on SDP based on SoC type

In reply to Nithin Dabilpuram

From: Sathesh Edara <[email protected]>

Set maximum frame size on SDP NIX side to 16KB for T93 A0-B0, F95N A0 and F95O A0 SOC type. Rest of the SoCs SDP NIX to 64KB.

---
v2:
- Add fixes line in patch 1/13
- Squash patch 8/13 to 7/13 as 7/13 is the patch that introduced the bug
- Add another patch to handle HARD SA expiry event for outbound inline.

 drivers/common/cnxk/hw/nix.h     |  1 +
 drivers/common/cnxk/roc_errata.h |  8 ++++++++
 drivers/common/cnxk/roc_model.h  | 12 ++++++++++++
 drivers/common/cnxk/roc_nix.c    |  5 ++++-
 4 files changed, 25 insertions(+), 1 deletion(-)
drivers/common/cnxk/hw/nix.h +1 -0
index a5352644ca..425c335bf3 100644
@@ -2118,6 +2118,7 @@ struct nix_lso_format {
 #define NIX_CN9K_MAX_HW_FRS 9212UL
 #define NIX_LBK_MAX_HW_FRS  65535UL
 #define NIX_SDP_MAX_HW_FRS  65535UL
+#define NIX_SDP_16K_HW_FRS  16380UL
 #define NIX_RPM_MAX_HW_FRS  16380UL
 #define NIX_MIN_HW_FRS	    60UL
 
drivers/common/cnxk/roc_errata.h +8 -0
index d3b32f1786..a39796e894 100644
@@ -90,4 +90,12 @@ roc_errata_nix_no_meta_aura(void)
 	return roc_model_is_cn10ka_a0();
 }
 
+/* Errata IPBUNIXTX-35039 */
+static inline bool
+roc_errata_nix_sdp_send_has_mtu_size_16k(void)
+{
+	return (roc_model_is_cnf95xxn_a0() || roc_model_is_cnf95xxo_a0() ||
+		roc_model_is_cn96_a0() || roc_model_is_cn96_b0());
+}
+
 #endif /* _ROC_ERRATA_H_ */
drivers/common/cnxk/roc_model.h +12 -0
index 57a8af06fc..1985dd771d 100644
@@ -140,6 +140,12 @@ roc_model_is_cn96_ax(void)
 	return (roc_model->flag & ROC_MODEL_CN96xx_Ax);
 }
 
+static inline uint64_t
+roc_model_is_cn96_b0(void)
+{
+	return (roc_model->flag & ROC_MODEL_CN96xx_B0);
+}
+
 static inline uint64_t
 roc_model_is_cn96_cx(void)
 {
@@ -170,6 +176,12 @@ roc_model_is_cnf95xxn_b0(void)
 	return roc_model->flag & ROC_MODEL_CNF95xxN_B0;
 }
 
+static inline uint64_t
+roc_model_is_cnf95xxo_a0(void)
+{
+	return roc_model->flag & ROC_MODEL_CNF95xxO_A0;
+}
+
 static inline uint16_t
 roc_model_is_cn95xxn_a0(void)
 {
drivers/common/cnxk/roc_nix.c +4 -1
index 4bb306b60e..8fd8ec8461 100644
@@ -127,8 +127,11 @@ roc_nix_max_pkt_len(struct roc_nix *roc_nix)
 {
 	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
 
-	if (roc_nix_is_sdp(roc_nix))
+	if (roc_nix_is_sdp(roc_nix)) {
+		if (roc_errata_nix_sdp_send_has_mtu_size_16k())
+			return NIX_SDP_16K_HW_FRS;
 		return NIX_SDP_MAX_HW_FRS;
+	}
 
 	if (roc_model_is_cn9k())
 		return NIX_CN9K_MAX_HW_FRS;
Signature · 1 line
2.25.1
#15 lore raw

PATCH v2 2/13 common/cnxk: add devargs for soft expiry poll frequency

Add support to override soft expiry poll frequency via devargs. Also provide helper API to indicate reassembly support on a chip and documentation for devargs that are already present.

Fixes 780b9c89241b ("net/cnxk: support zero AURA for inline meta")
---
 doc/guides/nics/cnxk.rst              | 39 +++++++++++++++++++++++++++
 drivers/common/cnxk/roc_nix_inl.c     |  7 +++++
 drivers/common/cnxk/roc_nix_inl.h     |  3 ++-
 drivers/common/cnxk/roc_nix_inl_dev.c |  4 +--
 drivers/common/cnxk/version.map       |  1 +
 drivers/net/cnxk/cnxk_ethdev_sec.c    | 17 +++++++++---
 6 files changed, 65 insertions(+), 6 deletions(-)
doc/guides/nics/cnxk.rst +39 -0
index a1e3a4a965..7da6cb3967 100644
@@ -494,6 +494,45 @@ Runtime Config Options for inline device
    With the above configuration, application can enable inline IPsec processing
    for inbound SA with max SPI of 128 for traffic aggregated on inline device.
 
+- ``Count of meta buffers for inline inbound IPsec second pass``
+
+   Number of meta buffers allocated for inline inbound IPsec second pass can
+   be specified by ``nb_meta_bufs`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use. Number of meta
+   buffers should be at least equal to aggregated number of packet buffers of all
+   packet mbuf pools in use by Inline IPsec enabled ethernet devices.
+
+   For example::
+
+      -a 0002:1d:00.0,nb_meta_bufs=1024
+
+   With the above configuration, PMD would enable inline IPsec processing
+   for inbound with 1024 meta buffers available for second pass.
+
+- ``Meta buffer size for inline inbound IPsec second pass``
+
+   Size of meta buffer allocated for inline inbound IPsec second pass can
+   be specified by ``meta_buf_sz`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use.
+
+   For example::
+
+      -a 0002:1d:00.0,meta_buf_sz=512
+
+   With the above configuration, PMD would allocate meta buffers of size 512 for
+   inline inbound IPsec processing second pass.
+
+- ``Inline Outbound soft expiry poll frequency in usec`` (default ``100``)
+
+   Soft expiry poll frequency for Inline Outbound sessions can be specified by
+   ``soft_exp_poll_freq`` ``devargs`` parameter.
+
+   For example::
+
+      -a 0002:1d:00.0,soft_exp_poll_freq=1000
+
+   With the above configuration, driver would poll for soft expiry events every
+   1000 usec.
 
 Debugging Options
 -----------------
drivers/common/cnxk/roc_nix_inl.c +7 -0
index cdf31b1f0c..213d71e684 100644
@@ -480,6 +480,13 @@ nix_inl_rq_mask_cfg(struct roc_nix *roc_nix, bool enable)
 	return mbox_process(mbox);
 }
 
+bool
+roc_nix_has_reass_support(struct roc_nix *nix)
+{
+	PLT_SET_USED(nix);
+	return !!roc_model_is_cn10ka();
+}
+
 int
 roc_nix_inl_inb_init(struct roc_nix *roc_nix)
 {
drivers/common/cnxk/roc_nix_inl.h +2 -1
index 019cf6d28b..c537262819 100644
@@ -183,7 +183,7 @@ struct roc_nix_inl_dev {
 	uint16_t wqe_skip;
 	uint8_t spb_drop_pc;
 	uint8_t lpb_drop_pc;
-	bool set_soft_exp_poll;
+	uint32_t soft_exp_poll_freq; /* Polling disabled if 0 */
 	uint32_t nb_meta_bufs;
 	uint32_t meta_buf_sz;
 	/* End of input parameters */
@@ -229,6 +229,7 @@ int __roc_api roc_nix_inl_ts_pkind_set(struct roc_nix *roc_nix, bool ts_ena,
 				       bool inb_inl_dev);
 int __roc_api roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool ena);
 int __roc_api roc_nix_inl_meta_aura_check(struct roc_nix_rq *rq);
+bool __roc_api roc_nix_has_reass_support(struct roc_nix *nix);
 
 /* NIX Inline Outbound API */
 int __roc_api roc_nix_inl_outb_init(struct roc_nix *roc_nix);
drivers/common/cnxk/roc_nix_inl_dev.c +2 -2
index 4fe7b5180b..c3d94dd0da 100644
@@ -789,7 +789,6 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *inl_dev)
 
 	soft_exp_consumer_cnt = 0;
 	soft_exp_poll_thread_exit = false;
-	inl_dev->soft_exp_poll_freq = 100;
 	rc = plt_ctrl_thread_create(&inl_dev->soft_exp_poll_thread,
 				    "OUTB_SOFT_EXP_POLL_THREAD", NULL,
 				    nix_inl_outb_poll_thread, inl_dev);
@@ -839,10 +838,11 @@ roc_nix_inl_dev_init(struct roc_nix_inl_dev *roc_inl_dev)
 	inl_dev->wqe_skip = roc_inl_dev->wqe_skip;
 	inl_dev->spb_drop_pc = NIX_AURA_DROP_PC_DFLT;
 	inl_dev->lpb_drop_pc = NIX_AURA_DROP_PC_DFLT;
-	inl_dev->set_soft_exp_poll = roc_inl_dev->set_soft_exp_poll;
+	inl_dev->set_soft_exp_poll = !!roc_inl_dev->soft_exp_poll_freq;
 	inl_dev->nb_rqs = inl_dev->is_multi_channel ? 1 : PLT_MAX_ETHPORTS;
 	inl_dev->nb_meta_bufs = roc_inl_dev->nb_meta_bufs;
 	inl_dev->meta_buf_sz = roc_inl_dev->meta_buf_sz;
+	inl_dev->soft_exp_poll_freq = roc_inl_dev->soft_exp_poll_freq;
 
 	if (roc_inl_dev->spb_drop_pc)
 		inl_dev->spb_drop_pc = roc_inl_dev->spb_drop_pc;
drivers/common/cnxk/version.map +1 -0
index e935f17c28..e2c6a223ea 100644
@@ -135,6 +135,7 @@ INTERNAL {
 	roc_nix_get_pf_func;
 	roc_nix_get_vf;
 	roc_nix_get_vwqe_interval;
+	roc_nix_has_reass_support;
 	roc_nix_inl_cb_register;
 	roc_nix_inl_cb_unregister;
 	roc_nix_inl_ctx_write;
drivers/net/cnxk/cnxk_ethdev_sec.c +14 -3
index 9304b1465d..8bec9acb54 100644
@@ -12,6 +12,10 @@
 #define CNXK_INL_CPT_CHANNEL	      "inl_cpt_channel"
 #define CNXK_NIX_INL_NB_META_BUFS     "nb_meta_bufs"
 #define CNXK_NIX_INL_META_BUF_SZ      "meta_buf_sz"
+#define CNXK_NIX_SOFT_EXP_POLL_FREQ   "soft_exp_poll_freq"
+
+/* Default soft expiry poll freq in usec */
+#define CNXK_NIX_SOFT_EXP_POLL_FREQ_DFLT 100
 
 struct inl_cpt_channel {
 	bool is_multi_channel;
@@ -263,6 +267,7 @@ static int
 nix_inl_parse_devargs(struct rte_devargs *devargs,
 		      struct roc_nix_inl_dev *inl_dev)
 {
+	uint32_t soft_exp_poll_freq = CNXK_NIX_SOFT_EXP_POLL_FREQ_DFLT;
 	uint32_t ipsec_in_max_spi = BIT(8) - 1;
 	uint32_t ipsec_in_min_spi = 0;
 	struct inl_cpt_channel cpt_channel;
@@ -292,6 +297,8 @@ nix_inl_parse_devargs(struct rte_devargs *devargs,
 			   &nb_meta_bufs);
 	rte_kvargs_process(kvlist, CNXK_NIX_INL_META_BUF_SZ, &parse_val_u32,
 			   &meta_buf_sz);
+	rte_kvargs_process(kvlist, CNXK_NIX_SOFT_EXP_POLL_FREQ,
+			   &parse_val_u32, &soft_exp_poll_freq);
 	rte_kvargs_free(kvlist);
 
 null_devargs:
@@ -303,6 +310,7 @@ nix_inl_parse_devargs(struct rte_devargs *devargs,
 	inl_dev->is_multi_channel = cpt_channel.is_multi_channel;
 	inl_dev->nb_meta_bufs = nb_meta_bufs;
 	inl_dev->meta_buf_sz = meta_buf_sz;
+	inl_dev->soft_exp_poll_freq = soft_exp_poll_freq;
 	return 0;
 exit:
 	return -EINVAL;
@@ -390,7 +398,6 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv,
 	wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ);
 	wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ;
 	inl_dev->wqe_skip = wqe_skip;
-	inl_dev->set_soft_exp_poll = true;
 	rc = roc_nix_inl_dev_init(inl_dev);
 	if (rc) {
 		plt_err("Failed to init nix inl device, rc=%d(%s)", rc,
@@ -425,5 +432,9 @@ RTE_PMD_REGISTER_KMOD_DEP(cnxk_nix_inl, "vfio-pci");
 
 RTE_PMD_REGISTER_PARAM_STRING(cnxk_nix_inl,
 			      CNXK_NIX_INL_SELFTEST "=1"
-			      CNXK_NIX_INL_IPSEC_IN_MAX_SPI "=<1-65535>"
-			      CNXK_INL_CPT_CHANNEL "=<1-4095>/<1-4095>");
+			      CNXK_NIX_INL_IPSEC_IN_MIN_SPI "=<1-U32_MAX>"
+			      CNXK_NIX_INL_IPSEC_IN_MAX_SPI "=<1-U32_MAX>"
+			      CNXK_INL_CPT_CHANNEL "=<1-4095>/<1-4095>"
+			      CNXK_NIX_INL_NB_META_BUFS "=<1-U32_MAX>"
+			      CNXK_NIX_INL_META_BUF_SZ "=<1-U32_MAX>"
+			      CNXK_NIX_SOFT_EXP_POLL_FREQ "=<0-U32_MAX>");
Signature · 1 line
2.25.1
#16 lore raw

PATCH v2 3/13 net/cnxk: fix later skip to include mbuf priv

In reply to Nithin Dabilpuram

Fix later skip to include mbuf priv data as mbuf->buf_addr is populated based on calculation including per-mbuf priv area.

Fixes 706eeae60757 ("net/cnxk: add multi-segment Rx for CN10K")
---
 drivers/net/cnxk/cn10k_rx.h    | 4 +++-
 drivers/net/cnxk/cnxk_ethdev.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/cnxk/cn10k_rx.h +3 -1
index 46488d442e..cf390a0361 100644
@@ -682,6 +682,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,
 		    uint64_t rearm, const uint16_t flags)
 {
 	const rte_iova_t *iova_list;
+	uint16_t later_skip = 0;
 	struct rte_mbuf *head;
 	const rte_iova_t *eol;
 	uint8_t nb_segs;
@@ -720,10 +721,11 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,
 	nb_segs--;
 
 	rearm = rearm & ~0xFFFF;
+	later_skip = (uintptr_t)mbuf->buf_addr - (uintptr_t)mbuf;
 
 	head = mbuf;
 	while (nb_segs) {
-		mbuf->next = ((struct rte_mbuf *)*iova_list) - 1;
+		mbuf->next = (struct rte_mbuf *)(*iova_list - later_skip);
 		mbuf = mbuf->next;
 
 		RTE_MEMPOOL_CHECK_COOKIES(mbuf->pool, (void **)&mbuf, 1, 1);
drivers/net/cnxk/cnxk_ethdev.c +1 -1
index 71c3f1666b..bf1585fe67 100644
@@ -680,7 +680,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid,
 	first_skip += RTE_PKTMBUF_HEADROOM;
 	first_skip += rte_pktmbuf_priv_size(lpb_pool);
 	rq->first_skip = first_skip;
-	rq->later_skip = sizeof(struct rte_mbuf);
+	rq->later_skip = sizeof(struct rte_mbuf) + rte_pktmbuf_priv_size(mp);
 	rq->lpb_size = lpb_pool->elt_size;
 	if (roc_errata_nix_no_meta_aura())
 		rq->lpb_drop_ena = !(dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY);
Signature · 1 line
2.25.1
#17 lore raw

PATCH v2 4/13 net/cnxk: use NIX Tx offset for cn10kb

In reply to Nithin Dabilpuram

In outbound inline case, use NIX Tx offset instead of NIX Tx address for CN103XX as per new instruction format.

---
 drivers/common/cnxk/roc_constants.h | 1 +
 drivers/event/cnxk/cn10k_worker.h   | 3 +++
 drivers/net/cnxk/cn10k_ethdev.c     | 6 ++++++
 drivers/net/cnxk/cn10k_ethdev.h     | 3 ++-
 drivers/net/cnxk/cn10k_ethdev_sec.c | 2 ++
 drivers/net/cnxk/cn10k_tx.h         | 4 ++--
 6 files changed, 16 insertions(+), 3 deletions(-)
drivers/common/cnxk/roc_constants.h +1 -0
index c693dde62e..0495965daa 100644
@@ -12,6 +12,7 @@
 /* [CN10K, .) */
 #define ROC_LMT_LINE_SZ		    128
 #define ROC_NUM_LMT_LINES	    2048
+#define ROC_LMT_LINES_PER_STR_LOG2  4
 #define ROC_LMT_LINES_PER_CORE_LOG2 5
 #define ROC_LMT_LINE_SIZE_LOG2	    7
 #define ROC_LMT_BASE_PER_CORE_LOG2                                             \
drivers/event/cnxk/cn10k_worker.h +3 -0
index 7a82dd352a..75a2ff244a 100644
@@ -595,6 +595,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf *m, uint64_t *cmd,
 		ws->gw_rdata = roc_sso_hws_head_wait(ws->base);
 
 	cn10k_sso_txq_fc_wait(txq);
+	if (flags & NIX_TX_OFFLOAD_SECURITY_F && sec)
+		cn10k_nix_sec_fc_wait_one(txq);
+
 	roc_lmt_submit_steorl(lmt_id, pa);
 
 	if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
drivers/net/cnxk/cn10k_ethdev.c +6 -0
index 0b33b3a496..4658713591 100644
@@ -538,6 +538,9 @@ cn10k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
 	int rc = -ENOTSUP;
 	RTE_SET_USED(eth_dev);
 
+	if (!roc_nix_has_reass_support(&dev->nix))
+		return -ENOTSUP;
+
 	if (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY) {
 		reassembly_capa->timeout_ms = 60 * 1000;
 		reassembly_capa->max_frags = 4;
@@ -565,6 +568,9 @@ cn10k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
 	struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);
 	int rc = 0;
 
+	if (!roc_nix_has_reass_support(&dev->nix))
+		return -ENOTSUP;
+
 	if (!conf->flags) {
 		/* Clear offload flags on disable */
 		dev->rx_offload_flags &= ~NIX_RX_REAS_F;
drivers/net/cnxk/cn10k_ethdev.h +2 -1
index d0a5b136e3..948c8348ad 100644
@@ -75,7 +75,8 @@ struct cn10k_sec_sess_priv {
 			uint16_t partial_len : 10;
 			uint16_t chksum : 2;
 			uint16_t dec_ttl : 1;
-			uint16_t rsvd : 3;
+			uint16_t nixtx_off : 1;
+			uint16_t rsvd : 2;
 		};
 
 		uint64_t u64;
drivers/net/cnxk/cn10k_ethdev_sec.c +2 -0
index 6de4a284da..3ca707f038 100644
@@ -798,6 +798,8 @@ cn10k_eth_sec_session_create(void *device,
 		sess_priv.chksum = (!ipsec->options.ip_csum_enable << 1 |
 				    !ipsec->options.l4_csum_enable);
 		sess_priv.dec_ttl = ipsec->options.dec_ttl;
+		if (roc_model_is_cn10kb_a0())
+			sess_priv.nixtx_off = 1;
 
 		/* Pointer from eth_sec -> outb_sa */
 		eth_sec->sa = outb_sa;
drivers/net/cnxk/cn10k_tx.h +2 -2
index 36fa96f83f..d375183f90 100644
@@ -397,7 +397,7 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,
 		/* DLEN passed is excluding L2 HDR */
 		pkt_len -= l2_len;
 	}
-	w0 |= nixtx;
+	w0 |= sess_priv.nixtx_off ? ((((int64_t)nixtx - (int64_t)dptr) & 0xFFFFF) << 32) : nixtx;
 	/* CPT word 0 and 1 */
 	cmd01 = vdupq_n_u64(0);
 	cmd01 = vsetq_lane_u64(w0, cmd01, 0);
@@ -539,7 +539,7 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,
 		sg->seg1_size = pkt_len + dlen_adj;
 		pkt_len -= l2_len;
 	}
-	w0 |= nixtx;
+	w0 |= sess_priv.nixtx_off ? ((((int64_t)nixtx - (int64_t)dptr) & 0xFFFFF) << 32) : nixtx;
 	/* CPT word 0 and 1 */
 	cmd01 = vdupq_n_u64(0);
 	cmd01 = vsetq_lane_u64(w0, cmd01, 0);
Signature · 1 line
2.25.1
#18 lore raw

PATCH v2 5/13 common/cnxk: fix RQ mask config for cn10kb chip

In reply to Nithin Dabilpuram

RQ mask config needs to enable SPB_ENA in order for Zero for being able to override it with Meta aura.

Also fix flow control config to catch invalid rxchan config errors.

Fixes ddf955d3917e ("common/cnxk: support CPT second pass")
Fixes da57d4589a6f ("common/cnxk: support NIX flow control")
---
 drivers/common/cnxk/roc_nix_fc.c  |  4 ++-
 drivers/common/cnxk/roc_nix_inl.c | 43 +++++++++++++++++--------------
 2 files changed, 26 insertions(+), 21 deletions(-)
drivers/common/cnxk/roc_nix_fc.c +3 -1
index f4cfa11c0f..033e17a4bf 100644
@@ -52,8 +52,10 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable)
 		req->bpid_per_chan = true;
 
 		rc = mbox_process_msg(mbox, (void *)&rsp);
-		if (rc || (req->chan_cnt != rsp->chan_cnt))
+		if (rc || (req->chan_cnt != rsp->chan_cnt)) {
+			rc = -EIO;
 			goto exit;
+		}
 
 		nix->chan_cnt = rsp->chan_cnt;
 		for (i = 0; i < rsp->chan_cnt; i++)
drivers/common/cnxk/roc_nix_inl.c +23 -20

69 lines not on this page · raw message

Signature · 1 line
2.25.1
#19 lore raw

PATCH v2 6/13 common/cnxk: fix schedule weight update

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Each TX schedule config mail box supports maximum 20 register updates. This patch will send node weight updates in multiple mailbox when TM created with more than 20 scheduler nodes.

Fixes 464c9f919321 ("common/cnxk: support NIX TM dynamic update")
---
 drivers/common/cnxk/roc_nix_queue.c  |  2 +-
 drivers/common/cnxk/roc_nix_tm_ops.c | 60 ++++++++++++++++++----------
 2 files changed, 41 insertions(+), 21 deletions(-)
drivers/common/cnxk/roc_nix_queue.c +1 -1
index 368f1a52f7..7318f26b57 100644
@@ -916,7 +916,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
 	nb_sqb_bufs += NIX_SQB_LIST_SPACE;
 	/* Clamp up the SQB count */
 	nb_sqb_bufs = PLT_MIN(roc_nix->max_sqb_count,
-			      PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
+			      (uint16_t)PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
 
 	sq->nb_sqb_bufs = nb_sqb_bufs;
 	sq->sqes_per_sqb_log2 = (uint16_t)plt_log2_u32(sqes_per_sqb);
drivers/common/cnxk/roc_nix_tm_ops.c +40 -20

78 lines not on this page · raw message

Signature · 1 line
2.25.1
#20 lore raw

PATCH v2 7/13 common/cnxk: sync NIX HW info mbox structure with kernel

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Sync nix_hw_info structure with kernel.

Maintain default RR_QUANTUM for VF TL2 same as kernel to make equal distribution among all VFs.

---
 drivers/common/cnxk/roc_mbox.h         |  8 +++++-
 drivers/common/cnxk/roc_nix.c          |  9 ++++++-
 drivers/common/cnxk/roc_nix.h          |  1 +
 drivers/common/cnxk/roc_nix_tm.c       |  4 ---
 drivers/common/cnxk/roc_nix_tm_utils.c | 34 +++++++++++++++++++++-----
 5 files changed, 44 insertions(+), 12 deletions(-)
drivers/common/cnxk/roc_mbox.h +7 -1
index a47e6a8f3b..e8d4ae283d 100644
@@ -1215,7 +1215,13 @@ struct nix_inline_ipsec_lf_cfg {
 struct nix_hw_info {
 	struct mbox_msghdr hdr;
 	uint16_t __io vwqe_delay;
-	uint16_t __io rsvd[15];
+	uint16_t __io max_mtu;
+	uint16_t __io min_mtu;
+	uint32_t __io rpm_dwrr_mtu;
+	uint32_t __io sdp_dwrr_mtu;
+	uint32_t __io lbk_dwrr_mtu;
+	uint32_t __io rsvd32[1];
+	uint64_t __io rsvd[15]; /* Add reserved fields for future expansion */
 };
 
 struct nix_bandprof_alloc_req {
drivers/common/cnxk/roc_nix.c +8 -1
index 8fd8ec8461..2a320cc291 100644
@@ -303,8 +303,15 @@ roc_nix_get_hw_info(struct roc_nix *roc_nix)
 
 	mbox_alloc_msg_nix_get_hw_info(mbox);
 	rc = mbox_process_msg(mbox, (void *)&hw_info);
-	if (rc == 0)
+	if (rc == 0) {
 		nix->vwqe_interval = hw_info->vwqe_delay;
+		if (nix->lbk_link)
+			roc_nix->dwrr_mtu = hw_info->lbk_dwrr_mtu;
+		else if (nix->sdp_link)
+			roc_nix->dwrr_mtu = hw_info->sdp_dwrr_mtu;
+		else
+			roc_nix->dwrr_mtu = hw_info->rpm_dwrr_mtu;
+	}
 
 	return rc;
 }
drivers/common/cnxk/roc_nix.h +1 -0
index 34cb2c717c..6636ee52c1 100644
@@ -426,6 +426,7 @@ struct roc_nix {
 	uint32_t ipsec_in_min_spi;
 	uint32_t ipsec_in_max_spi;
 	uint32_t ipsec_out_max_sa;
+	uint32_t dwrr_mtu;
 	bool ipsec_out_sso_pffunc;
 	bool custom_sa_action;
 	/* End of input parameters */
drivers/common/cnxk/roc_nix_tm.c +0 -4
index 81fa6b1d93..be8da714cd 100644
@@ -256,10 +256,6 @@ nix_tm_node_add(struct roc_nix *roc_nix, struct nix_tm_node *node)
 	if (node->weight > roc_nix_tm_max_sched_wt_get())
 		return NIX_ERR_TM_WEIGHT_EXCEED;
 
-	/* Maintain minimum weight */
-	if (!node->weight)
-		node->weight = 1;
-
 	node->hw_lvl = nix_tm_lvl2nix(nix, lvl);
 	node->rr_prio = 0xF;
 	node->max_prio = UINT32_MAX;
drivers/common/cnxk/roc_nix_tm_utils.c +28 -6
index 193f9df5ff..d33e793664 100644
@@ -644,9 +644,25 @@ nix_tm_topology_reg_prep(struct nix *nix, struct nix_tm_node *node,
 	return k;
 }
 
+static inline int
+nix_tm_default_rr_weight(struct nix *nix)
+{
+	struct roc_nix *roc_nix = nix_priv_to_roc_nix(nix);
+	uint32_t max_pktlen = roc_nix_max_pkt_len(roc_nix);
+	uint32_t weight;
+
+	/* Reduce TX VTAG Insertions */
+	max_pktlen -= 8;
+	weight = max_pktlen / roc_nix->dwrr_mtu;
+	if (max_pktlen % roc_nix->dwrr_mtu)
+		weight += 1;
+
+	return weight;
+}
+
 uint8_t
-nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
-		      volatile uint64_t *reg, volatile uint64_t *regval)
+nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node, volatile uint64_t *reg,
+		      volatile uint64_t *regval)
 {
 	uint64_t strict_prio = node->priority;
 	uint32_t hw_lvl = node->hw_lvl;
@@ -654,8 +670,14 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
 	uint64_t rr_quantum;
 	uint8_t k = 0;
 
-	/* For CN9K, weight needs to be converted to quantum */
-	rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
+	/* If minimum weight not provided, then by default RR_QUANTUM
+	 * should be in sync with kernel, i.e., single MTU value
+	 */
+	if (!node->weight)
+		rr_quantum = nix_tm_default_rr_weight(nix);
+	else
+		/* For CN9K, weight needs to be converted to quantum */
+		rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
 
 	/* For children to root, strict prio is default if either
 	 * device root is TL2 or TL1 Static Priority is disabled.
@@ -666,8 +688,8 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
 
 	plt_tm_dbg("Schedule config node %s(%u) lvl %u id %u, "
 		   "prio 0x%" PRIx64 ", rr_quantum/rr_wt 0x%" PRIx64 " (%p)",
-		   nix_tm_hwlvl2str(node->hw_lvl), schq, node->lvl, node->id,
-		   strict_prio, rr_quantum, node);
+		   nix_tm_hwlvl2str(node->hw_lvl), schq, node->lvl, node->id, strict_prio,
+		   rr_quantum, node);
 
 	switch (hw_lvl) {
 	case NIX_TXSCH_LVL_SMQ:
Signature · 1 line
2.25.1
#21 lore raw

PATCH v2 8/13 common/cnxk: set hysteresis bit to one

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Setting non zero FC_HYST_BITS to reduce mesh traffic on HW.

---
 drivers/common/cnxk/roc_nix_queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/cnxk/roc_nix_queue.c +1 -1
index 7318f26b57..1cb1fd2101 100644
@@ -940,7 +940,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
 	else
 		aura.fc_stype = 0x3; /* STSTP */
 	aura.fc_addr = (uint64_t)sq->fc;
-	aura.fc_hyst_bits = 0; /* Store count on all updates */
+	aura.fc_hyst_bits = 1; /* Store count on all updates */
 	rc = roc_npa_pool_create(&sq->aura_handle, blk_sz, nb_sqb_bufs, &aura,
 				 &pool, 0);
 	if (rc)
Signature · 1 line
2.25.1
#22 lore raw

PATCH v2 9/13 net/cnxk: handle SA soft packet and byte expiry events

In reply to Nithin Dabilpuram

From: Vamsi Attunuru <[email protected]>

Handle SA soft packet and byte expiry event for Inline outbound SA.

---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/cnxk/cn10k_ethdev_sec.c +6 -1
index 3ca707f038..ce1b10d885 100644
@@ -428,7 +428,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, uint32_t soft_exp_event)
 			sa = (struct roc_ot_ipsec_outb_sa *)args;
 			priv = roc_nix_inl_ot_ipsec_outb_sa_sw_rsvd(sa);
 			desc.metadata = (uint64_t)priv->userdata;
-			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY;
+			if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+				desc.subtype =
+					RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY;
+			else
+				desc.subtype =
+					RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY;
 			eth_dev = &rte_eth_devices[soft_exp_event >> 8];
 			rte_eth_dev_callback_process(eth_dev,
 				RTE_ETH_EVENT_IPSEC, &desc);
Signature · 1 line
2.25.1
#23 lore raw

PATCH v2 10/13 common/cnxk: sync mailbox for channel and bpid map

In reply to Nithin Dabilpuram

From: Sunil Kumar Kori <[email protected]>

As per recent change in Linux-5.4.x, mailbox is updated to configure mapping between channel and BPID. Due to mbox mismatch, PFC was broken. Patch syncs mailbox definition for the same. Also fixes the PFC configuration issues.

---
 drivers/common/cnxk/roc_mbox.h | 6 +++---
 drivers/common/cnxk/roc_nix.h  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/common/cnxk/roc_mbox.h +3 -3
index e8d4ae283d..d47808e5ef 100644
@@ -1164,10 +1164,10 @@ struct nix_bp_cfg_req {
 	/* bpid_per_chan = 1 assigns separate bp id for each channel */
 };
 
-/* PF can be mapped to either CGX or LBK interface,
- * so maximum 64 channels are possible.
+/* PF can be mapped to either CGX or LBK or SDP interface,
+ * so maximum 256 channels are possible.
  */
-#define NIX_MAX_CHAN	 64
+#define NIX_MAX_CHAN	 256
 #define NIX_CGX_MAX_CHAN 16
 #define NIX_LBK_MAX_CHAN 1
 struct nix_bp_cfg_rsp {
drivers/common/cnxk/roc_nix.h +1 -1
index 6636ee52c1..6654a2df78 100644
@@ -436,7 +436,7 @@ struct roc_nix {
 	bool rx_ptp_ena;
 	uint16_t cints;
 
-#define ROC_NIX_MEM_SZ (6 * 1024)
+#define ROC_NIX_MEM_SZ (6 * 1056)
 	uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned;
 } __plt_cache_aligned;
 
Signature · 1 line
2.25.1
#24 lore raw

PATCH v2 11/13 net/cnxk: remove unnecessary dptr update

In reply to Nithin Dabilpuram

Also remove ESN update from ucode command word 0 based on latest ucode.

---
 drivers/event/cnxk/cn9k_worker.h | 1 -
 drivers/net/cnxk/cn10k_tx.h      | 4 ----
 2 files changed, 5 deletions(-)
drivers/event/cnxk/cn9k_worker.h +0 -1
index 881861f348..4c3932da47 100644
@@ -718,7 +718,6 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
 	esn = outb_priv->esn;
 	outb_priv->esn = esn + 1;
 
-	ucode_cmd[0] |= (esn >> 32) << 16;
 	esn_lo = rte_cpu_to_be_32(esn & (BIT_ULL(32) - 1));
 	esn_hi = rte_cpu_to_be_32(esn >> 32);
 
drivers/net/cnxk/cn10k_tx.h +0 -4
index d375183f90..815cd2ff1f 100644
@@ -422,8 +422,6 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,
 				CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
 	cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-	dptr += l2_len;
-
 	/* Move to our line */
 	laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
@@ -564,8 +562,6 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,
 				CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
 	cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-	dptr += l2_len;
-
 	/* Move to our line */
 	laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
Signature · 1 line
2.25.1
#25 lore raw

PATCH v2 12/13 net/cnxk: remove duplicate mempool debug checks

In reply to Nithin Dabilpuram

Remove duplicate mempool debug checks for mbufs received.

Fixes 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model")
---
 drivers/net/cnxk/cn10k_rx.h | 6 ------
 1 file changed, 6 deletions(-)
drivers/net/cnxk/cn10k_rx.h +0 -6
index cf390a0361..4e22ceda02 100644
@@ -1307,12 +1307,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,
 			ol_flags3 |= nix_rx_olflags_get(lookup_mem, cq3_w1);
 		}
 
-		/* Mark mempool obj as "get" as it is alloc'ed by NIX */
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf2->pool, (void **)&mbuf2, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf3->pool, (void **)&mbuf3, 1, 1);
-
 		/* Translate meta to mbuf */
 		if (flags & NIX_RX_OFFLOAD_SECURITY_F) {
 			uint64_t cq0_w5 = *CQE_PTR_OFF(cq0, 0, 40, flags);
Signature · 1 line
2.25.1
#26 lore raw

PATCH v2 13/13 net/cnxk: handle hard expiry events

In reply to Nithin Dabilpuram

From: Vamsi Attunuru <[email protected]>

Based on the hard limits configured in the SA context, PMD passes corresponding event subtype to the application to notify hard expiry event

---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/cnxk/cn10k_ethdev_sec.c +6 -0
index ce1b10d885..ed5c335787 100644
@@ -479,6 +479,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, uint32_t soft_exp_event)
 	case ROC_IE_OT_UCC_ERR_SA_OVERFLOW:
 		desc.subtype = RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW;
 		break;
+	case ROC_IE_OT_UCC_ERR_SA_EXPIRED:
+		if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY;
+		else
+			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY;
+		break;
 	case ROC_IE_OT_UCC_ERR_PKT_IP:
 		warn_cnt++;
 		if (warn_cnt % 10000 == 0)
Signature · 1 line
2.25.1
#27 lore raw

PATCH v3 1/13 common/cnxk: set MTU size on SDP based on SoC type

In reply to Nithin Dabilpuram

From: Sathesh Edara <[email protected]>

Set maximum frame size on SDP NIX side to 16KB for T93 A0-B0, F95N A0 and F95O A0 SOC type. Rest of the SoCs SDP NIX to 64KB.

---
v3:
- Fix commit message in patch 9/13
v2:
- Add fixes line in patch 1/13
- Squash patch 8/13 to 7/13 as 7/13 is the patch that introduced the bug
- Add another patch to handle HARD SA expiry event for outbound inline.

drivers/common/cnxk/hw/nix.h | 1 +

 drivers/common/cnxk/roc_errata.h |  8 ++++++++
 drivers/common/cnxk/roc_model.h  | 12 ++++++++++++
 drivers/common/cnxk/roc_nix.c    |  5 ++++-
 4 files changed, 25 insertions(+), 1 deletion(-)
drivers/common/cnxk/hw/nix.h +1 -0
index a5352644ca..425c335bf3 100644
@@ -2118,6 +2118,7 @@ struct nix_lso_format {
 #define NIX_CN9K_MAX_HW_FRS 9212UL
 #define NIX_LBK_MAX_HW_FRS  65535UL
 #define NIX_SDP_MAX_HW_FRS  65535UL
+#define NIX_SDP_16K_HW_FRS  16380UL
 #define NIX_RPM_MAX_HW_FRS  16380UL
 #define NIX_MIN_HW_FRS	    60UL
 
drivers/common/cnxk/roc_errata.h +8 -0
index d3b32f1786..a39796e894 100644
@@ -90,4 +90,12 @@ roc_errata_nix_no_meta_aura(void)
 	return roc_model_is_cn10ka_a0();
 }
 
+/* Errata IPBUNIXTX-35039 */
+static inline bool
+roc_errata_nix_sdp_send_has_mtu_size_16k(void)
+{
+	return (roc_model_is_cnf95xxn_a0() || roc_model_is_cnf95xxo_a0() ||
+		roc_model_is_cn96_a0() || roc_model_is_cn96_b0());
+}
+
 #endif /* _ROC_ERRATA_H_ */
drivers/common/cnxk/roc_model.h +12 -0
index 57a8af06fc..1985dd771d 100644
@@ -140,6 +140,12 @@ roc_model_is_cn96_ax(void)
 	return (roc_model->flag & ROC_MODEL_CN96xx_Ax);
 }
 
+static inline uint64_t
+roc_model_is_cn96_b0(void)
+{
+	return (roc_model->flag & ROC_MODEL_CN96xx_B0);
+}
+
 static inline uint64_t
 roc_model_is_cn96_cx(void)
 {
@@ -170,6 +176,12 @@ roc_model_is_cnf95xxn_b0(void)
 	return roc_model->flag & ROC_MODEL_CNF95xxN_B0;
 }
 
+static inline uint64_t
+roc_model_is_cnf95xxo_a0(void)
+{
+	return roc_model->flag & ROC_MODEL_CNF95xxO_A0;
+}
+
 static inline uint16_t
 roc_model_is_cn95xxn_a0(void)
 {
drivers/common/cnxk/roc_nix.c +4 -1
index 4bb306b60e..8fd8ec8461 100644
@@ -127,8 +127,11 @@ roc_nix_max_pkt_len(struct roc_nix *roc_nix)
 {
 	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
 
-	if (roc_nix_is_sdp(roc_nix))
+	if (roc_nix_is_sdp(roc_nix)) {
+		if (roc_errata_nix_sdp_send_has_mtu_size_16k())
+			return NIX_SDP_16K_HW_FRS;
 		return NIX_SDP_MAX_HW_FRS;
+	}
 
 	if (roc_model_is_cn9k())
 		return NIX_CN9K_MAX_HW_FRS;
Signature · 1 line
2.25.1
#28 lore raw

PATCH v3 2/13 common/cnxk: add devargs for soft expiry poll frequency

Add support to override soft expiry poll frequency via devargs. Also provide helper API to indicate reassembly support on a chip and documentation for devargs that are already present.

Fixes 780b9c89241b ("net/cnxk: support zero AURA for inline meta")
---
 doc/guides/nics/cnxk.rst              | 39 +++++++++++++++++++++++++++
 drivers/common/cnxk/roc_nix_inl.c     |  7 +++++
 drivers/common/cnxk/roc_nix_inl.h     |  3 ++-
 drivers/common/cnxk/roc_nix_inl_dev.c |  4 +--
 drivers/common/cnxk/version.map       |  1 +
 drivers/net/cnxk/cnxk_ethdev_sec.c    | 17 +++++++++---
 6 files changed, 65 insertions(+), 6 deletions(-)
doc/guides/nics/cnxk.rst +39 -0
index a1e3a4a965..7da6cb3967 100644
@@ -494,6 +494,45 @@ Runtime Config Options for inline device
    With the above configuration, application can enable inline IPsec processing
    for inbound SA with max SPI of 128 for traffic aggregated on inline device.
 
+- ``Count of meta buffers for inline inbound IPsec second pass``
+
+   Number of meta buffers allocated for inline inbound IPsec second pass can
+   be specified by ``nb_meta_bufs`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use. Number of meta
+   buffers should be at least equal to aggregated number of packet buffers of all
+   packet mbuf pools in use by Inline IPsec enabled ethernet devices.
+
+   For example::
+
+      -a 0002:1d:00.0,nb_meta_bufs=1024
+
+   With the above configuration, PMD would enable inline IPsec processing
+   for inbound with 1024 meta buffers available for second pass.
+
+- ``Meta buffer size for inline inbound IPsec second pass``
+
+   Size of meta buffer allocated for inline inbound IPsec second pass can
+   be specified by ``meta_buf_sz`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use.
+
+   For example::
+
+      -a 0002:1d:00.0,meta_buf_sz=512
+
+   With the above configuration, PMD would allocate meta buffers of size 512 for
+   inline inbound IPsec processing second pass.
+
+- ``Inline Outbound soft expiry poll frequency in usec`` (default ``100``)
+
+   Soft expiry poll frequency for Inline Outbound sessions can be specified by
+   ``soft_exp_poll_freq`` ``devargs`` parameter.
+
+   For example::
+
+      -a 0002:1d:00.0,soft_exp_poll_freq=1000
+
+   With the above configuration, driver would poll for soft expiry events every
+   1000 usec.
 
 Debugging Options
 -----------------
drivers/common/cnxk/roc_nix_inl.c +7 -0
index cdf31b1f0c..213d71e684 100644
@@ -480,6 +480,13 @@ nix_inl_rq_mask_cfg(struct roc_nix *roc_nix, bool enable)
 	return mbox_process(mbox);
 }
 
+bool
+roc_nix_has_reass_support(struct roc_nix *nix)
+{
+	PLT_SET_USED(nix);
+	return !!roc_model_is_cn10ka();
+}
+
 int
 roc_nix_inl_inb_init(struct roc_nix *roc_nix)
 {
drivers/common/cnxk/roc_nix_inl.h +2 -1
index 019cf6d28b..c537262819 100644
@@ -183,7 +183,7 @@ struct roc_nix_inl_dev {
 	uint16_t wqe_skip;
 	uint8_t spb_drop_pc;
 	uint8_t lpb_drop_pc;
-	bool set_soft_exp_poll;
+	uint32_t soft_exp_poll_freq; /* Polling disabled if 0 */
 	uint32_t nb_meta_bufs;
 	uint32_t meta_buf_sz;
 	/* End of input parameters */
@@ -229,6 +229,7 @@ int __roc_api roc_nix_inl_ts_pkind_set(struct roc_nix *roc_nix, bool ts_ena,
 				       bool inb_inl_dev);
 int __roc_api roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool ena);
 int __roc_api roc_nix_inl_meta_aura_check(struct roc_nix_rq *rq);
+bool __roc_api roc_nix_has_reass_support(struct roc_nix *nix);
 
 /* NIX Inline Outbound API */
 int __roc_api roc_nix_inl_outb_init(struct roc_nix *roc_nix);
drivers/common/cnxk/roc_nix_inl_dev.c +2 -2
index 4fe7b5180b..c3d94dd0da 100644
@@ -789,7 +789,6 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *inl_dev)
 
 	soft_exp_consumer_cnt = 0;
 	soft_exp_poll_thread_exit = false;
-	inl_dev->soft_exp_poll_freq = 100;
 	rc = plt_ctrl_thread_create(&inl_dev->soft_exp_poll_thread,
 				    "OUTB_SOFT_EXP_POLL_THREAD", NULL,
 				    nix_inl_outb_poll_thread, inl_dev);
@@ -839,10 +838,11 @@ roc_nix_inl_dev_init(struct roc_nix_inl_dev *roc_inl_dev)
 	inl_dev->wqe_skip = roc_inl_dev->wqe_skip;
 	inl_dev->spb_drop_pc = NIX_AURA_DROP_PC_DFLT;
 	inl_dev->lpb_drop_pc = NIX_AURA_DROP_PC_DFLT;
-	inl_dev->set_soft_exp_poll = roc_inl_dev->set_soft_exp_poll;
+	inl_dev->set_soft_exp_poll = !!roc_inl_dev->soft_exp_poll_freq;
 	inl_dev->nb_rqs = inl_dev->is_multi_channel ? 1 : PLT_MAX_ETHPORTS;
 	inl_dev->nb_meta_bufs = roc_inl_dev->nb_meta_bufs;
 	inl_dev->meta_buf_sz = roc_inl_dev->meta_buf_sz;
+	inl_dev->soft_exp_poll_freq = roc_inl_dev->soft_exp_poll_freq;
 
 	if (roc_inl_dev->spb_drop_pc)
 		inl_dev->spb_drop_pc = roc_inl_dev->spb_drop_pc;
drivers/common/cnxk/version.map +1 -0
index e935f17c28..e2c6a223ea 100644
@@ -135,6 +135,7 @@ INTERNAL {
 	roc_nix_get_pf_func;
 	roc_nix_get_vf;
 	roc_nix_get_vwqe_interval;
+	roc_nix_has_reass_support;
 	roc_nix_inl_cb_register;
 	roc_nix_inl_cb_unregister;
 	roc_nix_inl_ctx_write;
drivers/net/cnxk/cnxk_ethdev_sec.c +14 -3
index 9304b1465d..8bec9acb54 100644
@@ -12,6 +12,10 @@
 #define CNXK_INL_CPT_CHANNEL	      "inl_cpt_channel"
 #define CNXK_NIX_INL_NB_META_BUFS     "nb_meta_bufs"
 #define CNXK_NIX_INL_META_BUF_SZ      "meta_buf_sz"
+#define CNXK_NIX_SOFT_EXP_POLL_FREQ   "soft_exp_poll_freq"
+
+/* Default soft expiry poll freq in usec */
+#define CNXK_NIX_SOFT_EXP_POLL_FREQ_DFLT 100
 
 struct inl_cpt_channel {
 	bool is_multi_channel;
@@ -263,6 +267,7 @@ static int
 nix_inl_parse_devargs(struct rte_devargs *devargs,
 		      struct roc_nix_inl_dev *inl_dev)
 {
+	uint32_t soft_exp_poll_freq = CNXK_NIX_SOFT_EXP_POLL_FREQ_DFLT;
 	uint32_t ipsec_in_max_spi = BIT(8) - 1;
 	uint32_t ipsec_in_min_spi = 0;
 	struct inl_cpt_channel cpt_channel;
@@ -292,6 +297,8 @@ nix_inl_parse_devargs(struct rte_devargs *devargs,
 			   &nb_meta_bufs);
 	rte_kvargs_process(kvlist, CNXK_NIX_INL_META_BUF_SZ, &parse_val_u32,
 			   &meta_buf_sz);
+	rte_kvargs_process(kvlist, CNXK_NIX_SOFT_EXP_POLL_FREQ,
+			   &parse_val_u32, &soft_exp_poll_freq);
 	rte_kvargs_free(kvlist);
 
 null_devargs:
@@ -303,6 +310,7 @@ nix_inl_parse_devargs(struct rte_devargs *devargs,
 	inl_dev->is_multi_channel = cpt_channel.is_multi_channel;
 	inl_dev->nb_meta_bufs = nb_meta_bufs;
 	inl_dev->meta_buf_sz = meta_buf_sz;
+	inl_dev->soft_exp_poll_freq = soft_exp_poll_freq;
 	return 0;
 exit:
 	return -EINVAL;
@@ -390,7 +398,6 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv,
 	wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ);
 	wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ;
 	inl_dev->wqe_skip = wqe_skip;
-	inl_dev->set_soft_exp_poll = true;
 	rc = roc_nix_inl_dev_init(inl_dev);
 	if (rc) {
 		plt_err("Failed to init nix inl device, rc=%d(%s)", rc,
@@ -425,5 +432,9 @@ RTE_PMD_REGISTER_KMOD_DEP(cnxk_nix_inl, "vfio-pci");
 
 RTE_PMD_REGISTER_PARAM_STRING(cnxk_nix_inl,
 			      CNXK_NIX_INL_SELFTEST "=1"
-			      CNXK_NIX_INL_IPSEC_IN_MAX_SPI "=<1-65535>"
-			      CNXK_INL_CPT_CHANNEL "=<1-4095>/<1-4095>");
+			      CNXK_NIX_INL_IPSEC_IN_MIN_SPI "=<1-U32_MAX>"
+			      CNXK_NIX_INL_IPSEC_IN_MAX_SPI "=<1-U32_MAX>"
+			      CNXK_INL_CPT_CHANNEL "=<1-4095>/<1-4095>"
+			      CNXK_NIX_INL_NB_META_BUFS "=<1-U32_MAX>"
+			      CNXK_NIX_INL_META_BUF_SZ "=<1-U32_MAX>"
+			      CNXK_NIX_SOFT_EXP_POLL_FREQ "=<0-U32_MAX>");
Signature · 1 line
2.25.1
#29 lore raw

PATCH v3 3/13 net/cnxk: fix later skip to include mbuf priv

In reply to Nithin Dabilpuram

Fix later skip to include mbuf priv data as mbuf->buf_addr is populated based on calculation including per-mbuf priv area.

Fixes 706eeae60757 ("net/cnxk: add multi-segment Rx for CN10K")
---
 drivers/net/cnxk/cn10k_rx.h    | 4 +++-
 drivers/net/cnxk/cnxk_ethdev.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/cnxk/cn10k_rx.h +3 -1
index 46488d442e..cf390a0361 100644
@@ -682,6 +682,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,
 		    uint64_t rearm, const uint16_t flags)
 {
 	const rte_iova_t *iova_list;
+	uint16_t later_skip = 0;
 	struct rte_mbuf *head;
 	const rte_iova_t *eol;
 	uint8_t nb_segs;
@@ -720,10 +721,11 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,
 	nb_segs--;
 
 	rearm = rearm & ~0xFFFF;
+	later_skip = (uintptr_t)mbuf->buf_addr - (uintptr_t)mbuf;
 
 	head = mbuf;
 	while (nb_segs) {
-		mbuf->next = ((struct rte_mbuf *)*iova_list) - 1;
+		mbuf->next = (struct rte_mbuf *)(*iova_list - later_skip);
 		mbuf = mbuf->next;
 
 		RTE_MEMPOOL_CHECK_COOKIES(mbuf->pool, (void **)&mbuf, 1, 1);
drivers/net/cnxk/cnxk_ethdev.c +1 -1
index 71c3f1666b..bf1585fe67 100644
@@ -680,7 +680,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid,
 	first_skip += RTE_PKTMBUF_HEADROOM;
 	first_skip += rte_pktmbuf_priv_size(lpb_pool);
 	rq->first_skip = first_skip;
-	rq->later_skip = sizeof(struct rte_mbuf);
+	rq->later_skip = sizeof(struct rte_mbuf) + rte_pktmbuf_priv_size(mp);
 	rq->lpb_size = lpb_pool->elt_size;
 	if (roc_errata_nix_no_meta_aura())
 		rq->lpb_drop_ena = !(dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY);
Signature · 1 line
2.25.1
#30 lore raw

PATCH v3 4/13 net/cnxk: use NIX Tx offset for cn10kb

In reply to Nithin Dabilpuram

In outbound inline case, use NIX Tx offset instead of NIX Tx address for CN103XX as per new instruction format.

---
 drivers/common/cnxk/roc_constants.h | 1 +
 drivers/event/cnxk/cn10k_worker.h   | 3 +++
 drivers/net/cnxk/cn10k_ethdev.c     | 6 ++++++
 drivers/net/cnxk/cn10k_ethdev.h     | 3 ++-
 drivers/net/cnxk/cn10k_ethdev_sec.c | 2 ++
 drivers/net/cnxk/cn10k_tx.h         | 4 ++--
 6 files changed, 16 insertions(+), 3 deletions(-)
drivers/common/cnxk/roc_constants.h +1 -0
index c693dde62e..0495965daa 100644
@@ -12,6 +12,7 @@
 /* [CN10K, .) */
 #define ROC_LMT_LINE_SZ		    128
 #define ROC_NUM_LMT_LINES	    2048
+#define ROC_LMT_LINES_PER_STR_LOG2  4
 #define ROC_LMT_LINES_PER_CORE_LOG2 5
 #define ROC_LMT_LINE_SIZE_LOG2	    7
 #define ROC_LMT_BASE_PER_CORE_LOG2                                             \
drivers/event/cnxk/cn10k_worker.h +3 -0
index 7a82dd352a..75a2ff244a 100644
@@ -595,6 +595,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf *m, uint64_t *cmd,
 		ws->gw_rdata = roc_sso_hws_head_wait(ws->base);
 
 	cn10k_sso_txq_fc_wait(txq);
+	if (flags & NIX_TX_OFFLOAD_SECURITY_F && sec)
+		cn10k_nix_sec_fc_wait_one(txq);
+
 	roc_lmt_submit_steorl(lmt_id, pa);
 
 	if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
drivers/net/cnxk/cn10k_ethdev.c +6 -0
index 0b33b3a496..4658713591 100644
@@ -538,6 +538,9 @@ cn10k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
 	int rc = -ENOTSUP;
 	RTE_SET_USED(eth_dev);
 
+	if (!roc_nix_has_reass_support(&dev->nix))
+		return -ENOTSUP;
+
 	if (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY) {
 		reassembly_capa->timeout_ms = 60 * 1000;
 		reassembly_capa->max_frags = 4;
@@ -565,6 +568,9 @@ cn10k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
 	struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);
 	int rc = 0;
 
+	if (!roc_nix_has_reass_support(&dev->nix))
+		return -ENOTSUP;
+
 	if (!conf->flags) {
 		/* Clear offload flags on disable */
 		dev->rx_offload_flags &= ~NIX_RX_REAS_F;
drivers/net/cnxk/cn10k_ethdev.h +2 -1
index d0a5b136e3..948c8348ad 100644
@@ -75,7 +75,8 @@ struct cn10k_sec_sess_priv {
 			uint16_t partial_len : 10;
 			uint16_t chksum : 2;
 			uint16_t dec_ttl : 1;
-			uint16_t rsvd : 3;
+			uint16_t nixtx_off : 1;
+			uint16_t rsvd : 2;
 		};
 
 		uint64_t u64;
drivers/net/cnxk/cn10k_ethdev_sec.c +2 -0
index 6de4a284da..3ca707f038 100644
@@ -798,6 +798,8 @@ cn10k_eth_sec_session_create(void *device,
 		sess_priv.chksum = (!ipsec->options.ip_csum_enable << 1 |
 				    !ipsec->options.l4_csum_enable);
 		sess_priv.dec_ttl = ipsec->options.dec_ttl;
+		if (roc_model_is_cn10kb_a0())
+			sess_priv.nixtx_off = 1;
 
 		/* Pointer from eth_sec -> outb_sa */
 		eth_sec->sa = outb_sa;
drivers/net/cnxk/cn10k_tx.h +2 -2
index 36fa96f83f..d375183f90 100644
@@ -397,7 +397,7 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,
 		/* DLEN passed is excluding L2 HDR */
 		pkt_len -= l2_len;
 	}
-	w0 |= nixtx;
+	w0 |= sess_priv.nixtx_off ? ((((int64_t)nixtx - (int64_t)dptr) & 0xFFFFF) << 32) : nixtx;
 	/* CPT word 0 and 1 */
 	cmd01 = vdupq_n_u64(0);
 	cmd01 = vsetq_lane_u64(w0, cmd01, 0);
@@ -539,7 +539,7 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,
 		sg->seg1_size = pkt_len + dlen_adj;
 		pkt_len -= l2_len;
 	}
-	w0 |= nixtx;
+	w0 |= sess_priv.nixtx_off ? ((((int64_t)nixtx - (int64_t)dptr) & 0xFFFFF) << 32) : nixtx;
 	/* CPT word 0 and 1 */
 	cmd01 = vdupq_n_u64(0);
 	cmd01 = vsetq_lane_u64(w0, cmd01, 0);
Signature · 1 line
2.25.1
#31 lore raw

PATCH v3 5/13 common/cnxk: fix RQ mask config for cn10kb chip

In reply to Nithin Dabilpuram

RQ mask config needs to enable SPB_ENA in order for Zero for being able to override it with Meta aura.

Also fix flow control config to catch invalid rxchan config errors.

Fixes ddf955d3917e ("common/cnxk: support CPT second pass")
Fixes da57d4589a6f ("common/cnxk: support NIX flow control")
---
 drivers/common/cnxk/roc_nix_fc.c  |  4 ++-
 drivers/common/cnxk/roc_nix_inl.c | 43 +++++++++++++++++--------------
 2 files changed, 26 insertions(+), 21 deletions(-)
drivers/common/cnxk/roc_nix_fc.c +3 -1
index f4cfa11c0f..033e17a4bf 100644
@@ -52,8 +52,10 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable)
 		req->bpid_per_chan = true;
 
 		rc = mbox_process_msg(mbox, (void *)&rsp);
-		if (rc || (req->chan_cnt != rsp->chan_cnt))
+		if (rc || (req->chan_cnt != rsp->chan_cnt)) {
+			rc = -EIO;
 			goto exit;
+		}
 
 		nix->chan_cnt = rsp->chan_cnt;
 		for (i = 0; i < rsp->chan_cnt; i++)
drivers/common/cnxk/roc_nix_inl.c +23 -20

69 lines not on this page · raw message

Signature · 1 line
2.25.1
#32 lore raw

PATCH v3 6/13 common/cnxk: fix schedule weight update

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Each TX schedule config mail box supports maximum 20 register updates. This patch will send node weight updates in multiple mailbox when TM created with more than 20 scheduler nodes.

Fixes 464c9f919321 ("common/cnxk: support NIX TM dynamic update")
---
 drivers/common/cnxk/roc_nix_queue.c  |  2 +-
 drivers/common/cnxk/roc_nix_tm_ops.c | 60 ++++++++++++++++++----------
 2 files changed, 41 insertions(+), 21 deletions(-)
drivers/common/cnxk/roc_nix_queue.c +1 -1
index 368f1a52f7..7318f26b57 100644
@@ -916,7 +916,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
 	nb_sqb_bufs += NIX_SQB_LIST_SPACE;
 	/* Clamp up the SQB count */
 	nb_sqb_bufs = PLT_MIN(roc_nix->max_sqb_count,
-			      PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
+			      (uint16_t)PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
 
 	sq->nb_sqb_bufs = nb_sqb_bufs;
 	sq->sqes_per_sqb_log2 = (uint16_t)plt_log2_u32(sqes_per_sqb);
drivers/common/cnxk/roc_nix_tm_ops.c +40 -20

78 lines not on this page · raw message

Signature · 1 line
2.25.1
#33 lore raw

PATCH v3 7/13 common/cnxk: sync NIX HW info mbox structure with kernel

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Sync nix_hw_info structure with kernel.

Maintain default RR_QUANTUM for VF TL2 same as kernel to make equal distribution among all VFs.

---
 drivers/common/cnxk/roc_mbox.h         |  8 +++++-
 drivers/common/cnxk/roc_nix.c          |  9 ++++++-
 drivers/common/cnxk/roc_nix.h          |  1 +
 drivers/common/cnxk/roc_nix_tm.c       |  4 ---
 drivers/common/cnxk/roc_nix_tm_utils.c | 34 +++++++++++++++++++++-----
 5 files changed, 44 insertions(+), 12 deletions(-)
drivers/common/cnxk/roc_mbox.h +7 -1
index a47e6a8f3b..e8d4ae283d 100644
@@ -1215,7 +1215,13 @@ struct nix_inline_ipsec_lf_cfg {
 struct nix_hw_info {
 	struct mbox_msghdr hdr;
 	uint16_t __io vwqe_delay;
-	uint16_t __io rsvd[15];
+	uint16_t __io max_mtu;
+	uint16_t __io min_mtu;
+	uint32_t __io rpm_dwrr_mtu;
+	uint32_t __io sdp_dwrr_mtu;
+	uint32_t __io lbk_dwrr_mtu;
+	uint32_t __io rsvd32[1];
+	uint64_t __io rsvd[15]; /* Add reserved fields for future expansion */
 };
 
 struct nix_bandprof_alloc_req {
drivers/common/cnxk/roc_nix.c +8 -1
index 8fd8ec8461..2a320cc291 100644
@@ -303,8 +303,15 @@ roc_nix_get_hw_info(struct roc_nix *roc_nix)
 
 	mbox_alloc_msg_nix_get_hw_info(mbox);
 	rc = mbox_process_msg(mbox, (void *)&hw_info);
-	if (rc == 0)
+	if (rc == 0) {
 		nix->vwqe_interval = hw_info->vwqe_delay;
+		if (nix->lbk_link)
+			roc_nix->dwrr_mtu = hw_info->lbk_dwrr_mtu;
+		else if (nix->sdp_link)
+			roc_nix->dwrr_mtu = hw_info->sdp_dwrr_mtu;
+		else
+			roc_nix->dwrr_mtu = hw_info->rpm_dwrr_mtu;
+	}
 
 	return rc;
 }
drivers/common/cnxk/roc_nix.h +1 -0
index 34cb2c717c..6636ee52c1 100644
@@ -426,6 +426,7 @@ struct roc_nix {
 	uint32_t ipsec_in_min_spi;
 	uint32_t ipsec_in_max_spi;
 	uint32_t ipsec_out_max_sa;
+	uint32_t dwrr_mtu;
 	bool ipsec_out_sso_pffunc;
 	bool custom_sa_action;
 	/* End of input parameters */
drivers/common/cnxk/roc_nix_tm.c +0 -4
index 81fa6b1d93..be8da714cd 100644
@@ -256,10 +256,6 @@ nix_tm_node_add(struct roc_nix *roc_nix, struct nix_tm_node *node)
 	if (node->weight > roc_nix_tm_max_sched_wt_get())
 		return NIX_ERR_TM_WEIGHT_EXCEED;
 
-	/* Maintain minimum weight */
-	if (!node->weight)
-		node->weight = 1;
-
 	node->hw_lvl = nix_tm_lvl2nix(nix, lvl);
 	node->rr_prio = 0xF;
 	node->max_prio = UINT32_MAX;
drivers/common/cnxk/roc_nix_tm_utils.c +28 -6
index 193f9df5ff..d33e793664 100644
@@ -644,9 +644,25 @@ nix_tm_topology_reg_prep(struct nix *nix, struct nix_tm_node *node,
 	return k;
 }
 
+static inline int
+nix_tm_default_rr_weight(struct nix *nix)
+{
+	struct roc_nix *roc_nix = nix_priv_to_roc_nix(nix);
+	uint32_t max_pktlen = roc_nix_max_pkt_len(roc_nix);
+	uint32_t weight;
+
+	/* Reduce TX VTAG Insertions */
+	max_pktlen -= 8;
+	weight = max_pktlen / roc_nix->dwrr_mtu;
+	if (max_pktlen % roc_nix->dwrr_mtu)
+		weight += 1;
+
+	return weight;
+}
+
 uint8_t
-nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
-		      volatile uint64_t *reg, volatile uint64_t *regval)
+nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node, volatile uint64_t *reg,
+		      volatile uint64_t *regval)
 {
 	uint64_t strict_prio = node->priority;
 	uint32_t hw_lvl = node->hw_lvl;
@@ -654,8 +670,14 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
 	uint64_t rr_quantum;
 	uint8_t k = 0;
 
-	/* For CN9K, weight needs to be converted to quantum */
-	rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
+	/* If minimum weight not provided, then by default RR_QUANTUM
+	 * should be in sync with kernel, i.e., single MTU value
+	 */
+	if (!node->weight)
+		rr_quantum = nix_tm_default_rr_weight(nix);
+	else
+		/* For CN9K, weight needs to be converted to quantum */
+		rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
 
 	/* For children to root, strict prio is default if either
 	 * device root is TL2 or TL1 Static Priority is disabled.
@@ -666,8 +688,8 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
 
 	plt_tm_dbg("Schedule config node %s(%u) lvl %u id %u, "
 		   "prio 0x%" PRIx64 ", rr_quantum/rr_wt 0x%" PRIx64 " (%p)",
-		   nix_tm_hwlvl2str(node->hw_lvl), schq, node->lvl, node->id,
-		   strict_prio, rr_quantum, node);
+		   nix_tm_hwlvl2str(node->hw_lvl), schq, node->lvl, node->id, strict_prio,
+		   rr_quantum, node);
 
 	switch (hw_lvl) {
 	case NIX_TXSCH_LVL_SMQ:
Signature · 1 line
2.25.1
#34 lore raw

PATCH v3 8/13 common/cnxk: set hysteresis bit to one

In reply to Nithin Dabilpuram

From: Satha Rao <[email protected]>

Setting non zero FC_HYST_BITS to reduce mesh traffic on HW.

---
 drivers/common/cnxk/roc_nix_queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/cnxk/roc_nix_queue.c +1 -1
index 7318f26b57..1cb1fd2101 100644
@@ -940,7 +940,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
 	else
 		aura.fc_stype = 0x3; /* STSTP */
 	aura.fc_addr = (uint64_t)sq->fc;
-	aura.fc_hyst_bits = 0; /* Store count on all updates */
+	aura.fc_hyst_bits = 1; /* Store count on all updates */
 	rc = roc_npa_pool_create(&sq->aura_handle, blk_sz, nb_sqb_bufs, &aura,
 				 &pool, 0);
 	if (rc)
Signature · 1 line
2.25.1
#35 lore raw

PATCH v3 9/13 net/cnxk: handle SA soft packet and byte expiry events

In reply to Nithin Dabilpuram

From: Vamsi Attunuru <[email protected]>

Handle SA soft packet and byte expiry event for Inline outbound SA.

---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/cnxk/cn10k_ethdev_sec.c +6 -1
index 3ca707f038..ce1b10d885 100644
@@ -428,7 +428,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, uint32_t soft_exp_event)
 			sa = (struct roc_ot_ipsec_outb_sa *)args;
 			priv = roc_nix_inl_ot_ipsec_outb_sa_sw_rsvd(sa);
 			desc.metadata = (uint64_t)priv->userdata;
-			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY;
+			if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+				desc.subtype =
+					RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY;
+			else
+				desc.subtype =
+					RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY;
 			eth_dev = &rte_eth_devices[soft_exp_event >> 8];
 			rte_eth_dev_callback_process(eth_dev,
 				RTE_ETH_EVENT_IPSEC, &desc);
Signature · 1 line
2.25.1
#36 lore raw

PATCH v3 10/13 common/cnxk: sync mailbox for channel and bpid map

In reply to Nithin Dabilpuram

From: Sunil Kumar Kori <[email protected]>

As per recent change in Linux-5.4.x, mailbox is updated to configure mapping between channel and BPID. Due to mbox mismatch, PFC was broken. Patch syncs mailbox definition for the same. Also fixes the PFC configuration issues.

---
 drivers/common/cnxk/roc_mbox.h | 6 +++---
 drivers/common/cnxk/roc_nix.h  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/common/cnxk/roc_mbox.h +3 -3
index e8d4ae283d..d47808e5ef 100644
@@ -1164,10 +1164,10 @@ struct nix_bp_cfg_req {
 	/* bpid_per_chan = 1 assigns separate bp id for each channel */
 };
 
-/* PF can be mapped to either CGX or LBK interface,
- * so maximum 64 channels are possible.
+/* PF can be mapped to either CGX or LBK or SDP interface,
+ * so maximum 256 channels are possible.
  */
-#define NIX_MAX_CHAN	 64
+#define NIX_MAX_CHAN	 256
 #define NIX_CGX_MAX_CHAN 16
 #define NIX_LBK_MAX_CHAN 1
 struct nix_bp_cfg_rsp {
drivers/common/cnxk/roc_nix.h +1 -1
index 6636ee52c1..6654a2df78 100644
@@ -436,7 +436,7 @@ struct roc_nix {
 	bool rx_ptp_ena;
 	uint16_t cints;
 
-#define ROC_NIX_MEM_SZ (6 * 1024)
+#define ROC_NIX_MEM_SZ (6 * 1056)
 	uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned;
 } __plt_cache_aligned;
 
Signature · 1 line
2.25.1
#37 lore raw

PATCH v3 11/13 net/cnxk: remove unnecessary dptr update

In reply to Nithin Dabilpuram

Also remove ESN update from ucode command word 0 based on latest ucode.

---
 drivers/event/cnxk/cn9k_worker.h | 1 -
 drivers/net/cnxk/cn10k_tx.h      | 4 ----
 2 files changed, 5 deletions(-)
drivers/event/cnxk/cn9k_worker.h +0 -1
index 881861f348..4c3932da47 100644
@@ -718,7 +718,6 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
 	esn = outb_priv->esn;
 	outb_priv->esn = esn + 1;
 
-	ucode_cmd[0] |= (esn >> 32) << 16;
 	esn_lo = rte_cpu_to_be_32(esn & (BIT_ULL(32) - 1));
 	esn_hi = rte_cpu_to_be_32(esn >> 32);
 
drivers/net/cnxk/cn10k_tx.h +0 -4
index d375183f90..815cd2ff1f 100644
@@ -422,8 +422,6 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,
 				CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
 	cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-	dptr += l2_len;
-
 	/* Move to our line */
 	laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
@@ -564,8 +562,6 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,
 				CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
 	cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-	dptr += l2_len;
-
 	/* Move to our line */
 	laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
Signature · 1 line
2.25.1
#38 lore raw

PATCH v3 12/13 net/cnxk: remove duplicate mempool debug checks

In reply to Nithin Dabilpuram

Remove duplicate mempool debug checks for mbufs received.

Fixes 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model")
---
 drivers/net/cnxk/cn10k_rx.h | 6 ------
 1 file changed, 6 deletions(-)
drivers/net/cnxk/cn10k_rx.h +0 -6
index cf390a0361..4e22ceda02 100644
@@ -1307,12 +1307,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,
 			ol_flags3 |= nix_rx_olflags_get(lookup_mem, cq3_w1);
 		}
 
-		/* Mark mempool obj as "get" as it is alloc'ed by NIX */
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf2->pool, (void **)&mbuf2, 1, 1);
-		RTE_MEMPOOL_CHECK_COOKIES(mbuf3->pool, (void **)&mbuf3, 1, 1);
-
 		/* Translate meta to mbuf */
 		if (flags & NIX_RX_OFFLOAD_SECURITY_F) {
 			uint64_t cq0_w5 = *CQE_PTR_OFF(cq0, 0, 40, flags);
Signature · 1 line
2.25.1
#39 lore raw

PATCH v3 13/13 net/cnxk: handle hard expiry events

In reply to Nithin Dabilpuram

From: Vamsi Attunuru <[email protected]>

Based on the hard limits configured in the SA context, PMD passes corresponding event subtype to the application to notify hard expiry event

---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/cnxk/cn10k_ethdev_sec.c +6 -0
index ce1b10d885..ed5c335787 100644
@@ -479,6 +479,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, uint32_t soft_exp_event)
 	case ROC_IE_OT_UCC_ERR_SA_OVERFLOW:
 		desc.subtype = RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW;
 		break;
+	case ROC_IE_OT_UCC_ERR_SA_EXPIRED:
+		if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY;
+		else
+			desc.subtype = RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY;
+		break;
 	case ROC_IE_OT_UCC_ERR_PKT_IP:
 		warn_cnt++;
 		if (warn_cnt % 10000 == 0)
Signature · 1 line
2.25.1
#40 lore raw

Re: [PATCH v3 13/13] net/cnxk: handle hard expiry events

Quoted 8 lines · Nithin Dabilpuram

From: Vamsi Attunuru <[email protected]>

Based on the hard limits configured in the SA context, PMD passes corresponding event subtype to the application to notify hard expiry event

Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

commit b05f3b8dd70254ff40f02a9783d6a3c419f3fa2c

Author: Vamsi Attunuru <[email protected]>
Date:   Fri Oct 14 11:13:17 2022 +0530

net/cnxk: handle hard expiry events

Based on the hard limits configured in the SA context, PMD passes corresponding event subtype to the application to notify hard expiry event

commit 39d00803ac14c5c82f066bac26becd22d98c8a25

Author: Nithin Dabilpuram <[email protected]>
Date:   Fri Oct 14 11:13:16 2022 +0530

net/cnxk: remove duplicate mempool debug checks

Remove duplicate mempool debug checks for mbufs received.

Fixes 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model")

commit 800400d9125b093990155bc0b127ad2ec3df1018

Author: Nithin Dabilpuram <[email protected]>
Date:   Fri Oct 14 11:13:15 2022 +0530

net/cnxk: remove unnecessary DPTR update

Removed unnecessary datapointer(DPTR) update and remove ESN update from microcode command word 0 based on the latest microcode.

commit d5718d9c467090505864f843a2838511ea48167d

Author: Sunil Kumar Kori <[email protected]>
Date:   Fri Oct 14 11:13:14 2022 +0530

common/cnxk: fix channel to BPID mapping

As per recent change in Linux-5.4.x AF driver, mailbox is updated to configure mapping between channel and BPID.
Due to mbox mismatch, PFC was broken. Patch syncs mailbox definition for the same. Also fixes the PFC configuration issues.

Fixes ff1400aa9d34 ("net/cnxk: add receive channel backpressure for SDP")

commit 3adb75fe4d5018ee556850af49aaebb19a99ba5c

Author: Vamsi Attunuru <[email protected]>
Date:   Fri Oct 14 11:13:13 2022 +0530

net/cnxk: handle SA soft packet and byte expiry events

Handle SA soft packet and byte expiry event for Inline outbound SA.

commit 0ec8b45ea8742f468e10e04603a426a27d1c5a41

Author: Satha Rao <[email protected]>
Date:   Fri Oct 14 11:13:12 2022 +0530

common/cnxk: set hysteresis bit to one

Setting non zero FC_HYST_BITS to reduce mesh traffic to reduce system resources.

commit 78f832e5ef5b694ac0b4148ec1ed1e69e73932a2

Author: Satha Rao <[email protected]>
Date:   Fri Oct 14 11:13:11 2022 +0530

common/cnxk: sync NIX HW info mbox structure with kernel

Sync nix_hw_info structure with kernel.

Maintain default RR_QUANTUM for VF TL2 same as kernel to make equal distribution among all VFs.

commit a5fc439a0bcc66c1f501a70f5439bbfe413d02b7

Author: Satha Rao <[email protected]>
Date:   Fri Oct 14 11:13:10 2022 +0530

common/cnxk: fix schedule weight update

Each TX schedule config mail box supports a maximum 20 register updates. This patch will send node weight updates in multiple mailboxes when TM is created with more than 20 scheduler nodes.

Fixes 464c9f919321 ("common/cnxk: support NIX TM dynamic update")

commit 0aa3a8bf816d76a8a219cdc2c7733072b92ecbec

Author: Nithin Dabilpuram <[email protected]>
Date:   Fri Oct 14 11:13:09 2022 +0530

common/cnxk: fix RQ mask config for cn10kb chip

RQ mask config needs to enable SPB_ENA in order for zero for being able to override it with meta AURA.

Also fix flow control config to catch invalid rxchan config errors.

Fixes ddf955d3917e ("common/cnxk: support CPT second pass")
Fixes da57d4589a6f ("common/cnxk: support NIX flow control")

commit 87d6f8ce329212bb33a7e26b6f021cc11b900865

Author: Nithin Dabilpuram <[email protected]>
Date:   Fri Oct 14 11:13:08 2022 +0530

net/cnxk: use NIX Tx offset for cn10kb

In outbound inline case, use NIX Tx offset instead of NIX Tx address for cn10kb as per new instruction format.

commit 48b95a4b46207172645d8892265e79accfd2c6a3

Author: Nithin Dabilpuram <[email protected]>
Date:   Fri Oct 14 11:13:07 2022 +0530

net/cnxk: fix later skip to include mbuf priv

Fix later skip to include mbuf priv data as mbuf->buf_addr is populated based on calculation including per-mbuf priv area.

Fixes 706eeae60757 ("net/cnxk: add multi-segment Rx for CN10K")

commit 2d394491f7a3492b87f590c4e789c17d41d89230

Author: Nithin Dabilpuram <[email protected]>
Date:   Fri Oct 14 11:13:06 2022 +0530

common/cnxk: add devargs for soft expiry poll frequency

Add support to override soft expiry poll frequency via devargs. Also provide helper API to indicate reassembly support on a chip and documentation for devargs that are already present.

Fixes 780b9c89241b ("net/cnxk: support zero AURA for inline meta")

commit 8614ba649706fadefa55a111c1d1bb4882ca0c91

Author: Sathesh Edara <[email protected]>
Date:   Fri Oct 14 11:13:05 2022 +0530

common/cnxk: set MTU size on SDP based on SoC type

Set maximum frame size on SDP NIX side to 16KB for CN93 A0 and B0, CNF95N A0 and CNF95O A0 SOC type. Rest of the SoCs SDP NIX to 64KB.

Quoted 24 lines
---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/cnxk/cn10k_ethdev_sec.c +6 -1
index ce1b10d885..ed5c335787 100644
@@ -479,6 +479,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, uint32_t soft_exp_event)
        case ROC_IE_OT_UCC_ERR_SA_OVERFLOW:
                desc.subtype = RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW;
                break;
+       case ROC_IE_OT_UCC_ERR_SA_EXPIRED:
+               if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+                       desc.subtype = RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY;
+               else
+                       desc.subtype = RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY;
+               break;
        case ROC_IE_OT_UCC_ERR_PKT_IP:
                warn_cnt++;
                if (warn_cnt % 10000 == 0)
--

2.25.1