Skip to contentSkip to conversation

tests/tcg: include CONFIG_PLUGIN in config-host.mak

PATCH In review Paolo Bonzini 2 participants 4 messages Oct 13, 2022 – Oct 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/tcg: include CONFIG_PLUGIN in config-host.mak

---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +3 -0
index f4ff1cf305..a5af9c524f 100755
@@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
 if test -n "$gdb_bin"; then
     echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
 fi
+if test "$plugins" = "yes" ; then
+    echo "CONFIG_PLUGIN=y" >> $config_host_mak
+fi
 
 tcg_tests_targets=
 for target in $target_list; do
Signature · 1 line
2.37.3
#1 lore raw
Quoted 10 lines · Paolo Bonzini
---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +0 -0
index f4ff1cf305..a5af9c524f 100755

configure echo "HOST_CC=$host_cc" >> $config_host_mak · line 2479

Quoted 6 lines
configure +3 -0
@@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
 if test -n "$gdb_bin"; then
     echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
 fi
+if test "$plugins" = "yes" ; then
+    echo "CONFIG_PLUGIN=y" >> $config_host_mak
+fi

Don't we already do that anyway?

Quoted 3 lines
configure +0 -0
 tcg_tests_targets=
 for target in $target_list; do
Signature · 1 line
Alex Bennée
#2 lore raw
Quoted 9 lines · Alex Bennée
Quoted 5 lines · Paolo Bonzini
---
 configure | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

configure echo "HOST_CC=$host_cc" >> $config_host_mak · line 2479

Quoted 11 lines
configure +3 -0
index f4ff1cf305..a5af9c524f 100755
@@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
 if test -n "$gdb_bin"; then
     echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
 fi
+if test "$plugins" = "yes" ; then
+    echo "CONFIG_PLUGIN=y" >> $config_host_mak
+fi

Don't we already do that anyway?

No, we don't. CONFIG_PLUGIN enables "make test-plugins" and "make plugins" but not the plugin tests in tests/tcg.

Paolo

#3 lore raw
Quoted 24 lines · Paolo Bonzini
Quoted 9 lines · Alex Bennée
Quoted 5 lines · Paolo Bonzini
---
 configure | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

configure echo "HOST_CC=$host_cc" >> $config_host_mak · line 2479

Quoted 11 lines
configure +3 -0
index f4ff1cf305..a5af9c524f 100755
@@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
 if test -n "$gdb_bin"; then
     echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
 fi
+if test "$plugins" = "yes" ; then
+    echo "CONFIG_PLUGIN=y" >> $config_host_mak
+fi

Don't we already do that anyway?

Quoted 2 lines

No, we don't. CONFIG_PLUGIN enables "make test-plugins" and "make plugins" but not the plugin tests in tests/tcg.

Ahh I see. Queued to testing/next, thanks.

Signature · 1 line
Alex Bennée