Skip to contentSkip to conversation

u-boot: Change depends from lzop to lzo

PATCH In review Ryan Eatmon 3 participants 5 messages Oct 13, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 u-boot: Change depends from lzop to lzo

lzop has disappeared from upstream master, but lzo is there.

---
v2: Fixed typo lzpo -> lzop

 meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc +1 -1
index d29c80cf..88018541 100644
@@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
 PV:append = "+git${SRCPV}"
 
 # u-boot needs devtree compiler to parse dts files
-DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
+DEPENDS += "dtc-native bc-native lzo-native flex-native bison-native python3-setuptools-native"
 
 DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Ryan Eatmon via lists.yoctoproject.org

lzop has disappeared from upstream master, but lzo is there.

lzop is actually a compression tool, while lzo is just a library. so, I don't believe this change is correct/complete.

Quoted 22 lines

---
v2: Fixed typo lzpo -> lzop

 meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc +1 -1
index d29c80cf..88018541 100644
@@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
 PV:append = "+git${SRCPV}"
 
 # u-boot needs devtree compiler to parse dts files
-DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
+DEPENDS += "dtc-native bc-native lzo-native flex-native bison-native python3-setuptools-native"
 
 DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
 
Signature · 1 line
2.17.1
#2 lore raw
Quoted 6 lines · Denys Dmytriyenko
Quoted 1 line · Ryan Eatmon via lists.yoctoproject.org

lzop has disappeared from upstream master, but lzo is there.

lzop is actually a compression tool, while lzo is just a library. so, I don't believe this change is correct/complete.

Do we use this? Might be better to just drop the DEPENDS.

Andrew

Quoted 33 lines
Quoted 33 lines

---
v2: Fixed typo lzpo -> lzop

  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc +1 -1
index d29c80cf..88018541 100644
@@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
  PV:append = "+git${SRCPV}"
 
  # u-boot needs devtree compiler to parse dts files
-DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
+DEPENDS += "dtc-native bc-native lzo-native flex-native bison-native python3-setuptools-native"
 
  DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
 
Signature · 10 lines
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15164): https://lists.yoctoproject.org/g/meta-ti/message/15164
Mute This Topic: https://lists.yoctoproject.org/mt/94310494/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
#3 lore raw
Quoted 9 lines · Andrew Davis
Quoted 6 lines · Denys Dmytriyenko
Quoted 1 line · Ryan Eatmon via lists.yoctoproject.org

lzop has disappeared from upstream master, but lzo is there.

lzop is actually a compression tool, while lzo is just a library. so, I don't believe this change is correct/complete.

Do we use this? Might be better to just drop the DEPENDS.

I was wondering the same thing. lzop is clearly gone from master upstream. So we either need to find a replacement, or we need to remove it.

Here is the commit that removed it:

commit dea5e8863792dc7bb3324b543e04da4c94a060aa

Author: Ross Burton <[email protected]>
Date:   Tue May 24 16:23:58 2022 +0100

lzop: remove recipe from oe-core

There are no users of lzop in oe-core, and there hasn't been a
release of
lzop since 2017.

Denys, as the person who added the lzop-native requirement in u-boot in the first place, can you think of anything?

Quoted 35 lines

Andrew

Quoted 33 lines
Quoted 33 lines

---
v2: Fixed typo lzpo -> lzop

  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc +0 -0
index d29c80cf..88018541 100644
@@ -23,7 +23,7 @@ SRC_URI = 

"${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}" PV:append = "+git${SRCPV}"

  # u-boot needs devtree compiler to parse dts files
-DEPENDS += "dtc-native bc-native lzop-native flex-native 
bison-native python3-setuptools-native"
+DEPENDS += "dtc-native bc-native lzo-native flex-native bison-native 
python3-setuptools-native"
  DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
Signature · 10 lines
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15164): https://lists.yoctoproject.org/g/meta-ti/message/15164
Mute This Topic: https://lists.yoctoproject.org/mt/94310494/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#4 lore raw
Quoted 31 lines · Ryan Eatmon
Quoted 10 lines · Andrew Davis
Quoted 7 lines · Denys Dmytriyenko
Quoted 1 line · Ryan Eatmon via lists.yoctoproject.org

lzop has disappeared from upstream master, but lzo is there.

lzop is actually a compression tool, while lzo is just a library. so, I don't believe this change is correct/complete.

Do we use this? Might be better to just drop the DEPENDS.

I was wondering the same thing. lzop is clearly gone from master upstream. So we either need to find a replacement, or we need to remove it.

Here is the commit that removed it:

commit dea5e8863792dc7bb3324b543e04da4c94a060aa

Author: Ross Burton <[email protected]>
Date:   Tue May 24 16:23:58 2022 +0100

lzop: remove recipe from oe-core

There are no users of lzop in oe-core, and there hasn't been a
release of
lzop since 2017.

Quoted 6 lines

Denys, as the person who added the lzop-native requirement in u-boot in the first place, can you think of anything?

lzop has been moved from oe-core to meta-oe, so it's not completely gone:

https://git.openembedded.org/meta-openembedded/commit/?id=90ff53b8df1e3259cbc201c658a4f3f4dddf3aa8

Even oe-core still has some conditional dependencies on lzop-native, assuming you use meta-oe layer. But normally it is not enabled by default.

When FIT image gets generated, it can compress the kernel image using either the default gzip compression algorithm, or lzo one. It is selected by FIT_KERNEL_COMP_ALG variable:

https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/kernel-uboot.bbclass

So, unless you specifically change that variable to "lzo" for FIT image based HS platforms, you don't need a dependency on lzop-native. Otherwise, you need meta-oe layer in your stack.

Quoted 26 lines
Quoted 26 lines

Andrew

Quoted 24 lines
Quoted 24 lines

---
v2: Fixed typo lzpo -> lzop

  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc +0 -0
index d29c80cf..88018541 100644
@@ -23,7 +23,7 @@ SRC_URI =

"${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}" PV:append = "+git${SRCPV}"

  # u-boot needs devtree compiler to parse dts files
-DEPENDS += "dtc-native bc-native lzop-native flex-native
bison-native python3-setuptools-native"
+DEPENDS += "dtc-native bc-native lzo-native flex-native
bison-native python3-setuptools-native"
  DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
Signature · 1 line
2.17.1